From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by sourceware.org (Postfix) with ESMTPS id B3EF7385842C for ; Wed, 7 Feb 2024 16:59:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B3EF7385842C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B3EF7385842C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707325148; cv=none; b=sIm8WS0r2HlalYssdLHg59Xh57keiyqZm+t4t/4RPxWFx2Voy3iLtb2PnAFAOuCH2RwN1EPHqY13bLZQY16wJMwYOjA8PS2H1Z6wGSbl9aT1bAyyTNbuBLmFi03aQr6EMynBSVJ2iECWipGzVp1sVwKeckAmAuboAOVrlR1DTqk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707325148; c=relaxed/simple; bh=HsjhHU5SHz6DIb2uPEyUbw+J7M46WPzO3vJy1dFm03Q=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=oEd7558+cBK3YvhLNZS+uxTivYvZAt3P1/1un8akwrvK3jxurXpEXmSxyhBtuBssRtYOP332i+acSixiguD/lh3JkUuTtDiyWc/hxITdfPUZRTA1v9Z3Owf2ZQe2I2Eted7jOJMNl/RBWDTTmKkz2twThUTFSLUZeHcvj9ooAcY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-40fb3b5893eso7118745e9.0 for ; Wed, 07 Feb 2024 08:59:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1707325144; x=1707929944; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rtBeyztS4QxaWVfNZ0XuTwZcB/orhSJMok+OMjAG3HE=; b=ZtMmTgOHtjGccH/oGvw/WVD8iJI8+5aIY1LUR4hH7P5L+zhVQD69zEe5YGUVf11WFo GX2LPLHkw/4+P02mggHrhJ9AUT1KP67+6G3lrLzfNHrWt/+x1mk41aAHwM7ToxYmyHnr FAId22VA84nvAEBaWzhhXQl5JLGPbsfTI96tpa2bbKTF0DGTxzGN2Q7zTxO1QKaz+5hN MbIcnM7Y/afaWy/X2g5B948497sO1ZBVU+xq5n2neGfhjYhe5cwKK/cKLrdmFotpH8PS idIhIUVUfU9JHgd8M2WNUN40u2bH6LjYV5jhkjFrVZzROAM3An8pzhBFmpzrr059Ht5l lUpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707325144; x=1707929944; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rtBeyztS4QxaWVfNZ0XuTwZcB/orhSJMok+OMjAG3HE=; b=cLXfteIaN9OuG4cCPBEBqxyAcyd0mLdhsdyxZ8FRoAhxSVJflih6mWd+gnNZdfc2cX z9HxjddB0SlLN/gpIFhpbYuPjmOxsgsJ9BD+IMDXnB8ucD2vTCCCW2ir1PrJ5GEbm/jA 1JFpvXpZcU4JAxWM4uqjSupXyo235d4hySzhg02LyKXHm1eooPAoxTTphLqNMw6vuVBo BJQtN1aN0JtgoiWg2BKhgqRzgTYMfM3TtiWB9arMbFeYXsSEGNnaflJbXRVioEgXBKNs NIXJQ4wn5jW2Y6xFnQEw/RfKF6QU3Aw72orVVnFNOur0t1LdMutc/Sp3Xg2BPqhIMYry by3g== X-Gm-Message-State: AOJu0YxPvqeFwkRHQLd+7oBP4uRXyCtYen6dEX+Lrz4BmisFMnt4ZI1Y +FvQqrelGEVNHylGt7kY2vZUmUa3dA+ty2NfIKyfOdmFfReuM5g2zP+INtVjKQ== X-Google-Smtp-Source: AGHT+IH/2D9sCa9EnKTR/f0KwFkPfqtjxUN8Apbbgn6TiqHB1jmQoBEOgcjJqKIXgKZJrPVvFxTsdA== X-Received: by 2002:a05:600c:4307:b0:40f:b166:7687 with SMTP id p7-20020a05600c430700b0040fb1667687mr5194227wme.15.1707325144487; Wed, 07 Feb 2024 08:59:04 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVIYnn5RdtA1cu1m01i9+79HCyt1dNNg7/HuNLw5D+dn3Wsc84F48lxan7damWmhF1HWQfL+Qt7ffKqF9M= Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id u14-20020a05600c19ce00b0040fdf2832desm2618404wmq.12.2024.02.07.08.59.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Feb 2024 08:59:04 -0800 (PST) Message-ID: Date: Wed, 7 Feb 2024 17:59:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86: Warn .insn instruction with length > 15 bytes Content-Language: en-US To: "H.J. Lu" Cc: binutils@sourceware.org, Michael Matz References: <20240205200028.219844-1-hjl.tools@gmail.com> <4b1c3da8-d218-460b-89e6-6844096ed393@suse.com> <533a896f-8eec-b73b-cb18-26240ad822fc@suse.de> <8059bdee-392a-b9cd-41d5-8dea538c957c@suse.de> <2721d4bc-e29f-4ed1-8fac-064fe0711029@suse.com> <93ef6fde-42aa-485a-8b22-f2c1f1d52efa@suse.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3025.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 07.02.2024 17:53, H.J. Lu wrote: > On Wed, Feb 7, 2024 at 7:32 AM Jan Beulich wrote: >> >> On 07.02.2024 16:24, H.J. Lu wrote: >>> On Tue, Feb 6, 2024 at 11:51 PM Jan Beulich wrote: >>>> >>>> On 06.02.2024 19:06, H.J. Lu wrote: >>>>> On Tue, Feb 6, 2024 at 9:05 AM Jan Beulich wrote: >>>>>> >>>>>> On 06.02.2024 17:28, H.J. Lu wrote: >>>>>>> With as_bad, assembler will continue to assemble, just not generate >>>>>>> an object file. We ran into this with APX. Not everyone checks >>>>>>> assembler warnings closely. It led to mysterious crashes. I am >>>>>>> not against it if someone else implements an assembler option to >>>>>>> turn this error into a warning. >>>>>> >>>>>> But it should be the other way around: The compiler could pass an >>>>>> option to promote the (default) warning to an error. And if you >>>>>> don#t pay attention to warning for assembly files, you could pass >>>>>> the same option as well. Without harming anyone else with anything >>>>> >>>>> People who use/need instructions > 15 bytes belong to a very small >>>>> minority. If they want to do it, they can use .insn or use binutlls 2.41 >>>>> or older. The default assembler isn't for them. >>>> >>>> No, staying on an old assembler isn't viable. And minority or not, you >>>> have to face it: In the present discussion it is you who represents a >>>> minority. As such I'm even inclined to suggest that your earlier patch >>>> wants reverting, on the basis that it was put in despite there being >>>> disagreement. Unless you soon come forward with an incremental change >>>> undoing at least the worst of its effects ... >>> >>> Please tell me exactly which projects are negatively impacted by >>> disallowing > 15 byte instructions. >> >> I already told you: I'm using such in testing of my personal disassembler >> library. > > So, it is only you. You can either use .insn or add a switch to turn > this error to warning. I has been a warning until 2.42, which you've regressed for my use case. This is why I expect you to at least soften the regression, in allowing people like me to simply add a command line option to the gas invocations. Plus, as you have learnt from Michael's responses, I'm not the only one to think that this diagnostic ought to continue to be a warning by default. Jan