From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by sourceware.org (Postfix) with ESMTPS id A9A933858D39 for ; Thu, 13 Jan 2022 07:58:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A9A933858D39 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2050.outbound.protection.outlook.com [104.47.13.50]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-32-iItLj-XAOdWYxIMgATlhYw-1; Thu, 13 Jan 2022 08:58:29 +0100 X-MC-Unique: iItLj-XAOdWYxIMgATlhYw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TGaYPgP5IXrFCWq+6IdkYEBi1FnG+yx1eQ+QSxJA9oICYiEOcll/DICv/Z4NXizf0aTuUsZt3o1kJsIMevD/GUjGGqh9dNmzFT4jn4yA7Q5VhysTEr8IUzKmtkS9/fc8AMnjXaB6WCk6coswalKzJYfRzMx51ndDvwpBhUfZWN/Owsxy7AH/2vmuLJ4feu2Ku8LNe1PNJY5mn8J4oyiYbOCBTDC/gb3tcm6hBXBx66+z82qMC2Wx6cwunRe+i9xUnyKBUKeqAzlamHtJ1AAh/wGCVnOD3UTYdA5goT7DZDy3QGR19pcISof+cxEdu/9c6okiBwdXesS0p7Gh0U87Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NOB06n6u+ysajowPhS7A08hOAR4SSrdylOI0sGjY1BA=; b=Iv7OuuMtvWfOvvhN3QZOFTX8zo23eNYg6XWkUGLdtQ22fPbxW6AepcyVSLNcwdBRc1v6YfRyGWv3IM4UcE7NLps6OTUWnPEMQ+yGYHW61NLM4fK5H5+bUGqyXDKGfWfPos9xLjziAPuNiZcGB1IntmSqbT933vkzeUiNacrxnbjjocdRdfd48GIQs6mgoClTtuZdZdXu8Z0VP2YQoYEVmoFkCk5lFpFtY8dJyygstFA6TlIXUELG9vH3qUPgP2X0KaiSNphPClG3JnylfKbt3zi/siDvwgRAnpW8n3QC4Ncv50H5cc1dbLlVu4bmGCIgvoi+tYdFFogcn4PVmXW3GA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2333.eurprd04.prod.outlook.com (2603:10a6:800:28::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.11; Thu, 13 Jan 2022 07:58:27 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4867.012; Thu, 13 Jan 2022 07:58:27 +0000 Message-ID: Date: Thu, 13 Jan 2022 08:58:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: Don't use C++ comments in assembly Content-Language: en-US To: Alan Modra References: Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR0301CA0055.eurprd03.prod.outlook.com (2603:10a6:20b:469::25) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 96f90b4e-98c9-430f-b387-08d9d66a7b2a X-MS-TrafficTypeDiagnostic: VI1PR0401MB2333:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2803; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dNyiIEdjgZIyELDEd3V99kBSQnOVAPa+SPL6tPS9yHMn6ecRuB1UJe3xtoPHTw32+WAYgdylh4eBCw15IWQJCyQDcz2K5lPxz+f3dQ/j0vIIDWCNJJBSrjwN/jcuReoYpT4zUgNYrTpuRjxHO4hC60fsCEYSThXTBFkRggPLwy+BCaz5DzgBfz1qp7nA8hyAw5qUWEcB7BODNkqTlELmfq38FGQEvyzg+VJacyWp7RSODI1UM9rxHdonfzkRsSjj1F/kvw9EPwhpwrLvOPjAR6669cDM9WF4CS6s/OYYjGx12p049FPl1F79PQkj5ephhBtMLKr8ikRgz0ViwhOzpBbX2G7M7ZGDfnH1TJJDFU5S7XNETHnn1FbjLGAirCcvHMnl9/sdo8qyhcJvn32Pp6CcS1Z9JvNT2dK+M1Zz39b/nny49NqNNIHPEuekc64AOq3O4MqVt6NrpGHdgLa4ngNYETMeIkXeXbXowb0/ITq07Q9bS85XT2IKp7XwYmQAeIW4Q62ax7SNQdDqNQmF9weULRVfozLfmTWPT7u2WfWSK7oPSBoKuBevG+my2lS10YoTzp5d4QZpwIbJ/uLicuWuKRARu2f5LI/+GfGE1Bung3j/cvyhnx8BceRfbFRaMq5uVgjv0+1dO2eeOlKq8pw2JZnQDUjFbhu94dwyGu999Tc+Gv8bN6rjM1CHRVXVro3ZDq1novdMFXs2C+hmJ/Rti5e32Dv1/reNeF3P7E4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5600.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(8936002)(6916009)(31686004)(316002)(6486002)(4744005)(4326008)(31696002)(8676002)(36756003)(6506007)(5660300002)(53546011)(66946007)(66476007)(6512007)(186003)(26005)(2906002)(38100700002)(86362001)(66556008)(2616005)(508600001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UXZOK0tFeVRJdjliajlkVkwzd1YzVDB0anRkQkhIY1RuSDJyVTdUT3hKczMv?= =?utf-8?B?ZGFGNFRINitCaUVqUjBTQmZhei9WTFJMTllqQmV0cWlrOXo3ZE9Wc04xbXo5?= =?utf-8?B?bzRMcGMwdzdTTnd6RE5hT254R2dWUisvekUwUVlvUm9MZmx0MVRTUzYwTzRl?= =?utf-8?B?ekxtV1lDRGFzcEIzcmpuNWN5Z2VPTThRa3ZKcEQxMFFIWlFTM25jK0NER01y?= =?utf-8?B?Q1BMYzlIYzNLdm5IL1dLR2RSQkF3R2JabzhvWXFJVjdtdCtaQi9ubHc3WUdq?= =?utf-8?B?NmFmRDMySkpQMHZmYmp1cURJbXQreGtiSEFQS1Rxb2MvNUZ5dk04L1g2ODNv?= =?utf-8?B?eEMvbFYwL3hGMTRsa0xRUXY1QXVvNlNFU1RoM01NM1pSV0hLSFMzSVM2b3p6?= =?utf-8?B?OHZ5M2p1SE1kbENvZjZmTGc5RUc0d1JWSFYvVGkvN2lLSzB1Q3I4aVRnZmp1?= =?utf-8?B?RGhucVhaVUljWGx1VGpKbGFrVHBIRDEycFBZVkI5VlFlVExKUXQwdHdxc2c2?= =?utf-8?B?aTFoQkFFS091U1F4cGZqcllRWHA0b1FrRmp4dU9CajFIVkhhUitLMWlZNDk5?= =?utf-8?B?dkFHbEllckY2TWhaN0FjaWVoYUlWamErT21BTkttMFYvTUpjbWUrYVh3Q0d2?= =?utf-8?B?QVlBNzNwWUhsMkJRVzJjbXlaeGhKeGRWTEcwWXZFK2x2SjBPenZ6Um92dkdm?= =?utf-8?B?VDZjSkJuQ3hNYUY5Z0toaDdYTm4rYzA4WHdPKzJ0ZzljYjAyaTJSVUZWM1dk?= =?utf-8?B?Zi9aWWdrRlJtaVg3OUhTMmM3RmI3TUp5YXBOWTZpY2RPclpwV01UK2x6K3U4?= =?utf-8?B?ZFREVzlUS0w4MW52K3pOTy9WaitoWDMwa0pNK3VFNVlRY0RhNEY3RXlBRDNq?= =?utf-8?B?amdYTHQ1UFE4UGhaQnJ5b01JbmxmcS9JQ3h4M2UveHpxbEx4a1hmQUhHeEVF?= =?utf-8?B?UzVVeE5lRkN1VzlkUm1ZQzRjQzY0OHpLbStqNDhKWFN5TVV4alQ5dUlUdzA5?= =?utf-8?B?OUNlRnVhdjBjMzRLTStJeG9IWC9CSmtoNW1tMlNaK250OE1PbjdoUWF2K0N6?= =?utf-8?B?WlVRU2I1Rm9XZFNVNXdabzJIazRZcWhQSGxpMms1ZHFKMTRwRlh1b0UwWTBP?= =?utf-8?B?ZGRURThKSllLazBxTnZaRy9PM2NaVjZSZEpVWHcvQWl6Qkd3WGZHMXVHU0I5?= =?utf-8?B?eEVWeFpJenRJL25XSXkycktZaW9vYURSSGxMQkFldVBLMUkxTmhQK3RPVUVu?= =?utf-8?B?NE51ZjVmWjh4MjNLRmRlMGplZndreVU2d3pBVytWc296Tno0bTNmcTMwYyt0?= =?utf-8?B?MVpQRnVXSVF5Qms1ZjdzYy9sRFVrdEZxejhlY3NRWmpvYjE4ZkY4b1RHeUFs?= =?utf-8?B?U280RFRjSktYcjV3dGtGTC9nNFVJMXlaR3RSTlZYeEFXa0ZOTDUrYnF3TTlJ?= =?utf-8?B?TzhLTVhiR0xOeWFYUVptZHJSWjBOYWs1ZXJ5c3NyNWl4djlobmprcktRcVYy?= =?utf-8?B?bVBkK2RMbkxXMzlkaWxTR3F2Vks0S040ZlBRdDFVaWNWWDdwMTJkRnZPKzNY?= =?utf-8?B?S3ZlUE1YQ096YTRqT3BxeHkyWUVwNnRNSXlCbHFpTm5DTXc5ZjhwMFhhNVUy?= =?utf-8?B?VU9ZWE5LK1N6YjM0VlVybkVKZ1E2QldrTGxnUW9TS1BDWmN5b3pyWEZVdXgr?= =?utf-8?B?ejBac1BYc1B5aVg4dXdORkdaVkZUOVZzdzRBalgyWkZGdStKeVVUK21Pc05C?= =?utf-8?B?YWxzWk1CL1NGR3UvTC9YaDVQNDNxeXBFbnFYVjhuU0Q0VnkyVDNWdWFIYXNv?= =?utf-8?B?cmtSVUNlVExCWWNqWFFHbm1xY255UndZUlZPaGc5VWVZek8wU0t4NFV0ZHNa?= =?utf-8?B?V1N6dFZvL0l4eW8xQ2JDei9CWm03RFd1aFNZSUZXUWtIRVR5R1FyYi81Wk5J?= =?utf-8?B?MTcyT2tJRTllRHB6U2YxNlAxUUtCNmpFSWNGMktvNmQzdjN1TTNxaWtmVTMz?= =?utf-8?B?N2l5aVhtcFh3TFVNOEpjbDVnbUx0WkJMMHdBOXJmeGoyYytlRnE4ZjFzU1Ra?= =?utf-8?B?WnVVZmwvTHVrRG1DU1Npbmt1eGVYeG51V05DUFYvbzlUcUJmWnNBRnhjcXl2?= =?utf-8?B?RWlnbmtJQ0dpZU8zaG9SYVF0TXpTMkVwY1BVeXluVDlSYnlWNWVRd2tlcFFt?= =?utf-8?Q?WIvMc4fTzvMyDRc8d2e9tT8=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 96f90b4e-98c9-430f-b387-08d9d66a7b2a X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2022 07:58:27.2268 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kAtczNX1QI1SMK8KvHixM/sakKEpfoHDUHBk0LcEWjCYDyoUo2UoGZPGOBp++zCO9ZjV9GGdBE1bHmLrc8zw4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2333 X-Spam-Status: No, score=-3038.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Jan 2022 07:58:33 -0000 On 13.01.2022 04:38, Alan Modra via Binutils wrote: > It might seem to work, but only if '/' is a start of comment char. > > * testsuite/ld-elf/dt-relr-1.s: Use # for comment. > * testsuite/ld-elf/dt-relr-2.s: Likewise. > * testsuite/ld-elf/dt-relr-3.s: Likewise. > > diff --git a/ld/testsuite/ld-elf/dt-relr-1.s b/ld/testsuite/ld-elf/dt-relr-1.s > index 1eb34588160..ce1a876b1e8 100644 > --- a/ld/testsuite/ld-elf/dt-relr-1.s > +++ b/ld/testsuite/ld-elf/dt-relr-1.s > @@ -9,5 +9,5 @@ _start: > .globl data > data: > .byte 0 > - // Offset is not a multiple of 2. Don't use DT_RELR. > +# Offset is not a multiple of 2. Don't use DT_RELR. Just for my own education, since I've been wondering how to write comments in tests suitable for all (or at least most) targets: # isn't a universal comment char either (having a different meaning e.g. on Arm). In gas/testsuite/gas/all/quoted-sym-names.s I did use /**/ which looks to have worked quite well ... Elsewhere I find ";#" in use. Jan