From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by sourceware.org (Postfix) with ESMTPS id 0AC623858D28 for ; Fri, 6 Jan 2023 17:48:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0AC623858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=harmstone.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-x32d.google.com with SMTP id fm16-20020a05600c0c1000b003d96fb976efso4075015wmb.3 for ; Fri, 06 Jan 2023 09:48:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=bKurbrTkt5g+0BDDxTJnYyEJ61xqrQCn07ofd38XEs0=; b=c9GFq7SJ8EJ8f6GAokN0m3RE2wU7QeSeHA225rBL2M3DPfpcmtlcxKLGeDYOjjk5P8 Krkm804O4R/X978s9L5rXAazRhA0QpZo8zhH7CPg0W0hWLKTjv1EKqo9V9sXYu0l5OFn 7/18moDnEQ16ny2VUE44rggsz1L4ErAsaoo5hTxuzPq6WwP0MuqMegJSTFloNXROwdFb SV2x1+S0C4OoGGsjYsocZyjReDgcauNVUCTrfLIQxIBeEgXtMsbKArMqbMburxNhpKGb WpEAQqbThLGn2L2QUq+R1k/vPjgnHfqGhTStmyy1aOD/YfZb/UkRqzzwZBuxAOdcrz2C SYTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bKurbrTkt5g+0BDDxTJnYyEJ61xqrQCn07ofd38XEs0=; b=qrWXUf8tm5x1LRP2wJ413ZQGiS0onJ3l1HX9yyoXgjxVXX+eM7mH53Xu3gW2ocydoe tlT9EiBrrAZK1uuv7igltuz4s89aZooj1ehhrbLTYtdAVMXqoh8UesEMyk5pmCs8UVw6 M0Upc5UBOwt2KZtKmhcm3KTs6pSZVOzM2Rle/1JfkUCrLfk8RfZcjp3TVVkOVR9syiiq 6ai6Rc6XTXv3DrJmvMQOdXtpLnSc7xpwskK3Jq2SQA5A7gBaRCfkFPP3sWbNECyJAT2m J31ZbCP97i0qtEbi3mlGOhRklGec7FpuFljznLhj9PbksXWQRV5AIFTQKwj3mUBgg0ay GBhg== X-Gm-Message-State: AFqh2kqu3s02cBoLQdoEGkgeb4cpu2JO3+fdxAcc4plCdWeHG6tRSiyX S+8xFvShBWKBFTKOflnIniHMNEE+WGqfqw== X-Google-Smtp-Source: AMrXdXvEOzdthQuNP6JybxJn2+s2lOmNZzGZZbwl7J0B5AwHOQYG6Meu6tXH3IbQBLwK8iP06VVO2Q== X-Received: by 2002:a05:600c:5114:b0:3d2:5e4e:6fa with SMTP id o20-20020a05600c511400b003d25e4e06famr42590621wms.34.1673027330831; Fri, 06 Jan 2023 09:48:50 -0800 (PST) Received: from ?IPV6:2a02:8010:64ea:0:8eb8:7eff:fe53:9d5f? ([2a02:8010:64ea:0:8eb8:7eff:fe53:9d5f]) by smtp.googlemail.com with ESMTPSA id z6-20020a05600c0a0600b003d96efd09b7sm8490425wmp.19.2023.01.06.09.48.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jan 2023 09:48:50 -0800 (PST) Sender: Mark Harmstone Message-ID: Date: Fri, 6 Jan 2023 17:48:48 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 2/7] Skip ELF-specific tests when targeting pe-aarch64 To: Jan Beulich Cc: binutils@sourceware.org, Tamar.Christina@arm.com, nickc@redhat.com, pinskia@gmail.com, Richard.Earnshaw@foss.arm.com, nightstrike@gmail.com, wej22007@outlook.com, zac.walker@linaro.org References: <20230106012509.7918-1-mark@harmstone.com> <20230106012509.7918-2-mark@harmstone.com> <4c1fda53-249e-1877-9bd0-dfef0cd6f108@suse.com> Content-Language: en-US From: Mark Harmstone In-Reply-To: <4c1fda53-249e-1877-9bd0-dfef0cd6f108@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/1/23 08:11, Jan Beulich wrote: > On 06.01.2023 02:25, Mark Harmstone wrote: >> --- a/binutils/testsuite/binutils-all/objcopy.exp >> +++ b/binutils/testsuite/binutils-all/objcopy.exp >> @@ -1411,6 +1411,7 @@ proc objcopy_test_without_global_symbol { } { >> # The AArch64 and ARM targets preserve mapping symbols >> # in object files, so they will fail this test. >> setup_xfail aarch64*-*-* arm*-*-* >> +clear_xfail aarch64*-*-pe* aarch64*-*-mingw* > This change clearly doesn't fit with the title, and hence would better be > a separate change. > >> --- a/gas/testsuite/gas/aarch64/adr_1.d >> +++ b/gas/testsuite/gas/aarch64/adr_1.d >> @@ -1,5 +1,6 @@ >> #as: -mabi=lp64 >> #objdump: -dr >> +#notarget: *-*-pe* *-*-mingw* > While it's up to the arch maintainers to judge, to me there's nothing ELF- > specific in this and similar tests; all you need to do is adjust the > expectations to also accept the COFF form of the respective relocations. > That's what we do on x86, for example. > >> --- a/gas/testsuite/gas/aarch64/advsimd-mov-bad.d >> +++ b/gas/testsuite/gas/aarch64/advsimd-mov-bad.d >> @@ -1,5 +1,6 @@ >> #source: advsimd-mov-bad.s >> #readelf: -s --wide >> +#notarget: *-*-pe* *-*-mingw* > Tests using readelf, otoh, are appropriate to exclude. I wonder though > whether that wouldn't better be done in a more generic manner. > > Jan Hi Jan, This patch series has already been approved by Nick. I'm resubmitting it because of a last-minute change that ARM insisted we make. As I think I said before, I'm indifferent towards the two test patches. I'm including them as a courtesy, because they helped reduce the noise when I was working on the rest of the patches. I'm happy to leave them out if they're at all contentious. Mark