From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2055.outbound.protection.outlook.com [40.107.20.55]) by sourceware.org (Postfix) with ESMTPS id 7408C389900F for ; Mon, 5 Dec 2022 11:25:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7408C389900F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Apu/tYnGAe5XecYxjlC0NRxuLeUi9rsXMbHsUSGPzYYFD4HAMOwt26R2pyVOkto3sUG+J9eRp2Bh5GZAtwpgP6wXaB/cAwort0nMdClX2AF+BJf82Eg8Re8kZ4q52bOain+UYQv0JAMxzhxvgy1DLtGeBZ6lF0SdOryFL54+e+fsZoeEtEc+8K8s1G7Kan56QzW2lZFnFyrtOp23uuvROMdq6xPFkgRVsKP6wyb/rXfFvnDEKiX6vL0TVQxq2fb2QhalgRxbBIuy0BAoRzExEiD9Zfkb6qGOG5OOAglunF1+buXnQl1aY+v+ToZtXqtsz9okar6foBkAFTsdbJUukw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+lMeSljJ2aIPpR7GgYyRzCwLqB8VIWg6qstGwro79fk=; b=PlZTyjYnQDnbeEtNCHaWPHXKbLBGO4DOOCp4tZNdtijGDUQfiA2fPMGbrSJRbXvs5acHujqAwOD7chRBBK6tRtfoDZbOTgbJocG08o1/B/iMQdQE6JEEOFVcTwBxQ/m1aSY+cBrQ1yKwbX0zGez1YDngp9b4jQEu8UxCx8s3Zac8d/h6ziyv7NiFJe2jglbvq81elByudQrOq5+NxecQ9WO/P2XD4enM/Asbmel4szRXEpBb2jmus7j+RBV43NCgMerliWbQ82n3bDVa2kUJTJv4wSV3LfHZxztS8AzEpASHaUwXEdVyfr7xXHMx5qVSQIJFj/gTj1eUJ6inE7k78g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+lMeSljJ2aIPpR7GgYyRzCwLqB8VIWg6qstGwro79fk=; b=ZH09RfzIWl1QmpBp6T2F7oKuj047HQ1BwXcP29IKPN+uWFQfrGE26TfF0RGGPlN3y+ZOfJINSldaXu422eNh53b11cafIRDOZb6ccQh1QjyxxpSUz9HDTh75AdHl9WZgmdq4xx//017GA8l4PJrDu9n1ZsqbbcGTE5v86Hr2LXYPQFBW7MsnG9ak9WwcrRv8C/DQpKlTW1oC676EZFDih2AOUVST8CJmVOZJChFZVxszxbSVsJ2i3F/8CNQ6a+CuPn/Ud0+ZZSsK7l1NHx3v0cPkEtqgo7uo212wsr0eGILBgADEQuoapJVMRrFkpz7Our6Or5USAwtSpKUdglT5Xg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB7099.eurprd04.prod.outlook.com (2603:10a6:10:12b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.10; Mon, 5 Dec 2022 11:25:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5880.014; Mon, 5 Dec 2022 11:25:06 +0000 Message-ID: Date: Mon, 5 Dec 2022 12:25:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v3] x86: Remove libopcodes dependency Content-Language: en-US To: "H.J. Lu" Cc: Binutils References: <20221122181927.251937-1-hjl.tools@gmail.com> <6a5d4918-919a-8b6b-822b-17ce38488629@suse.com> <63e51eee-e9f4-5332-d69e-feca3421553b@suse.com> <8bb7a0f0-5809-af64-7fc8-1aabe1047dc0@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0100.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB7099:EE_ X-MS-Office365-Filtering-Correlation-Id: 51e2c521-61d2-4f1c-7018-08dad6b35c0c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Nx3SB+yzHBTSju2M36yw8O4i+6tRiidesr/MFI99t+ccPXJQt1P/qAYhtj5cUXuaGdi8atPmGci0F9QH7zJ0uy+oJerNZ9pwS/kGcv+I3Vdpz3NQ/Ex4hdYQGsufdMRcucmrcSYWqDVH5PDa5CXsdQtr5pblMbnPkdjGAnbkvXfJbhPeRxtf8rs5KundfqbVgyUXTRZUIbPWAmQwfLMc+TNxcyVs/UyLUMKaxA5KDuhnNjCMtTfHuOxhXuK39KQKb2agtduo7MEzwFWHRTXx9cBjYmgymnMXiyj3SQ5YmL8NX/FjCUYODzNYWpx5iDGUWB0PzmQADc26gj0LU1H5FGHXe7beW40OwOFCcR57NiwvdOgNlYBjDNw9cnBzDP/Fk/5+aSuZUg4NMGve6AWX43FhmqT2jljPV+9RsFwACllywrPLe2qRBP13I9YrUw8iSGEMwt1xiQmfn5rKhW3MIhqy6ctC0q0juDFCR4cYvFJoOgtRHyUg9F4InLEI2nLrpJdiTT6zS9/RPBHSiprDz2wWA0qXa8Rky7nRoIw0RZxiP+eCgXLZE7HpoZNfRBdQR1DUKKOpwI68M6mIso8nIjy3XG73D4qi34lUefdP3M/cYHX4En159XnkwH//nDw4CvgX/eGnGJTaF6OdrVByj4RYGy277wAXgkRDBnTt6PBBf7J+ENeNlApBWDBHjaMZUWMc9AjzHF1c64Rhr6qQ0gXLioTwOLw/sqvIsfHlE6E= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(376002)(396003)(346002)(136003)(366004)(451199015)(31686004)(31696002)(86362001)(6506007)(53546011)(478600001)(6486002)(36756003)(38100700002)(6512007)(2616005)(186003)(83380400001)(8676002)(5660300002)(4326008)(41300700001)(26005)(66556008)(66476007)(66946007)(316002)(8936002)(2906002)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aElCcTRiWVZWNUM5YTNtTjB5aVNFekR1c3ZwbFh5TmpHV21kZDlQMnZwN0Zt?= =?utf-8?B?Y3NPY2I5UWJOWTJnNEw3Mk9CSkswdmpOSWFoY1EzTkVBS3dsZ2wzQ2dQR2lj?= =?utf-8?B?aklOZjVnNkJ0K096eG45bHpWcXYwaUFCTkYzRWNqajRJUmJoWjRCaW8yd3N0?= =?utf-8?B?eE12bmhpV0s2bnpDd2IvbTdMYm94OWE1cDZZdTdEUUZWQWoyeFhZS2dYa2xp?= =?utf-8?B?UzMxVmNmMDlRYTNPODJPTGhGQmkrV0NOdGpoM21qWkN4elNjeFcvSWJKbllx?= =?utf-8?B?dk9LeTNqQ3VxbjNnSVFYTG9KSExMaWs5T3RUaUhGbXdXb21yaU5NVFBNWmUx?= =?utf-8?B?UDdDZjhrL2Nsb1FDSE4vWkRINHhGcjFFVmxKNDc3QzJ0SEcySEZOVHJrQWJm?= =?utf-8?B?Y0JCR1JSWDZralBlZm9tZ3g5bUF6SE5NbXB2ZWRpa1BjdmFJOEZ5TFBCQlZ0?= =?utf-8?B?OHJJSkJaOU52OUZHaU5wV01oN2RhYmoxSERqVGFWblVoQUJ4a05Sb0pweDkw?= =?utf-8?B?ODBPZ3o1R21YQVRtNStKdnYvRk5YdVRISWJuaDdHWlpZSUZuNUpqLzVYOTFs?= =?utf-8?B?N2oxVUZESC85cTVVUVVFTDdud3VueTZHbTBVQTE5dzU3eGttYmxYaWRIdFkw?= =?utf-8?B?VHdLZVo5Y2FWdWw0Z3ROUGdOc25uRG9LY3JYbEFDM3hVL1VkWjZ5RHd4WWZz?= =?utf-8?B?bDA4cHRZRVRxTC9nY2lXcnNlUGc3bHlKWG4yMFRVWmI4ZUt5cTJoNmozM2gr?= =?utf-8?B?QWNadGc3S1lGZHUzY1ozV2c3emUwaXpYUjVRUjVEYjFUaUFmL3JrczJxdW5F?= =?utf-8?B?alZMclI1VG9nLzR0UUFPMjJxRno4RVlqYysrM0pscWZyNTljU0FBdUhGRXln?= =?utf-8?B?YVlIckd2WFN2TzZuU2JHbVhTTlUrdm5TcmxDVDlCOHNxVU5YTVdJYkhDZk5t?= =?utf-8?B?dVZJNEY5NFZwTE9OcjlDL0N1YlkyKzRDQVZMUC9TNFBZbEQrQmZ3RG1DT2No?= =?utf-8?B?OWEwWUV4a3BzMmpnUHN5K1dIWEE2YVBOM094ei9zRkdlRFJWcWUyZmE1TDZk?= =?utf-8?B?ZlhseTlEQ3Y2ZzFqeXdQRjIrbnZtMVlTWTRVNTNhcHBsR25EWFhTSkQvT3VI?= =?utf-8?B?VWVpVnZlTWtDaC9WVERYUW5hVXJwclROWnQ5NHAzMnBPbWlZNmJvU0x2aWJX?= =?utf-8?B?blhvYUF2WGl6V214YVp2L2ZPenE4WndvRGtkb0JWc0puZmhGNzR0Qm5seGh2?= =?utf-8?B?QVRYVVUrM1BRa1ZjWW1KNUNBZnJrTzc5aXdwZTh0VTdkMm1Bdzljam11VTgw?= =?utf-8?B?NVZ1TG1ITmM5QmN4NDVvYUM3TiszN3VML1BkMmxuSW1RcHRYRTFPbEZkbXg4?= =?utf-8?B?Wk9DV1J2eDlSVEcxb3lHdDhRUnVobjJQSjlSWDJUc0NGeEpQbDNHUGZ5VG5K?= =?utf-8?B?Tzltc0lEeTBWUjNpR20zZS9vdHd5YS92WWRGdkM0ajl2NktmajhGSzQ5byth?= =?utf-8?B?L05Oanh0cnFDeVM3djdSaHhGSk05TTRhUUU2cm1VRjNxMlhjcGxUV0R0WmNx?= =?utf-8?B?cmNISmJUUzRuMDkwWmcxYWlLVDR1L1NuSkMrZ2djYnViYkJzUmlWczU0TFBB?= =?utf-8?B?UjNTQzIrNUhQV3NuS2RFTDVhM1c1UzZWTVNXT29uYk44Smd1QjZBTkZDY2k2?= =?utf-8?B?Uy9JdEsvVDdvVGdHZ29mVnBxS21VQjJEdXM3QlpaMjMyanhpdDJFbUtYM0ZP?= =?utf-8?B?b241QytyRDBSWjhpK3I1eDhKY29TY21yNkNvaS9uZW9JS0YrM2ZwOS9qWFFu?= =?utf-8?B?aXg2SmNoRUVwQytUVHJwd3BWd0xzSXFaQmROT2l1OXF1MnJoakd4MXBrVzZu?= =?utf-8?B?M1BBeGI5QkpFa2xhQi93ek9PSE9PbmFLQkhUUzI3ZG1OZ2dmTjNzTytYQytU?= =?utf-8?B?SytKellkall2WHVRdm5lWXo0Y2Uzam9aN2E5bXVJZmcrUHQ4eGY3R2p6QThE?= =?utf-8?B?QmdWSUdjbldVcHJXTVQ3TjI3d2h2eFJ5NGg2MVNhUCtZNDlMMmxLeWlwLzF5?= =?utf-8?B?TlN0K24xQWF2UGxIU3grZFgrRUx6S0dacnUvZ0ZGUWxwK0ZLYVZEM1dnOTl4?= =?utf-8?Q?fCKuL0TnTJeoXJc2/ZZ4JsSQ9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51e2c521-61d2-4f1c-7018-08dad6b35c0c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2022 11:25:06.0811 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qM5lvaNP3un7vC4nmMfmQa9AkdIfIY+3eKy5YOoP7aqBML98pCidnan0M9sht67jBfCpQSM6qFrrEdIiy1S72w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7099 X-Spam-Status: No, score=-3029.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 02.12.2022 18:19, H.J. Lu wrote: > On Thu, Dec 1, 2022 at 11:16 PM Jan Beulich wrote: >> >> On 01.12.2022 19:26, H.J. Lu wrote: >>> On Thu, Dec 01, 2022 at 08:41:28AM +0100, Jan Beulich wrote: >>>> I understand you prefer it, but given you've found what's wrong >>>> yourself, I'm puzzled by "I don't see anything wrong with my >>>> approach". Or wait - looks like I misread what you pointed out >>>> above: That looks to be something from the top level Makefile. >>>> Yet then again I can't spot any such in my build trees. Where is >>>> that excerpt from? (I can spot somewhat similar patterns, but >>>> they're used strictly to recurse _down_, just like looks to be >>>> the case with what you've quoted.) >>>> >>>> In any event, a practical manifestation of the issue I've said >>>> I'm concerned of is this: If a 2nd party anywhere in the tree did >>>> the same you do, and if the two $(MAKE) invocations then raced >>>> with one another, then it's plain undefined what would happen to >>> >>> Fixed. >> >> In which way? You still ... >> >>> --- a/gas/Makefile.am >>> +++ b/gas/Makefile.am >>> @@ -448,6 +448,18 @@ development.exp: $(BFDDIR)/development.sh >>> $(EGREP) "(development|experimental)=" $(BFDDIR)/development.sh \ >>> | $(AWK) -F= '{ print "set " $$1 " " $$2 }' > $@ >>> >>> +config/tc-i386.@OBJEXT@: $(srcdir)/../opcodes/i386-init.h \ >>> + $(srcdir)/../opcodes/i386-tbl.h >>> + >>> +# i386-gen will generate both headers in one go. Use a pattern rule to >>> +# properly express this, with the inner dash ('-') arbitrarily chosen to >>> +# be the stem. >>> +$(srcdir)/../opcodes/i386%init.h $(srcdir)/../opcodes/i386%tbl.h: @MAINT@ $(srcdir)/../opcodes/i386-opc.tbl \ >>> + $(srcdir)/../opcodes/i386-reg.tbl \ >>> + $(srcdir)/../opcodes/i386-opc.h \ >>> + $(srcdir)/../opcodes/i386-gen.c >>> + $(MAKE) -C ../opcodes gen-i386-tbl >> >> ... wrongly recurse from gas/ into opcodes/. In fact I can't spot any >> change in regard to the cross-subdir operation that I continue to >> object to. I'm afraid I'm unaware of ways to address this other than >> by avoiding the recursive $(MAKE) invocation altogether. > > $(srcdir)/../opcodes/i386%init.h $(srcdir)/../opcodes/i386%tbl.h > will invoke $(MAKE) only once. But that was a separate problem I was complaining about. This does in no way address the issue of inappropriate make recursion. Unless I see a technically correct version from you by the end of this week, I will commit my variant (series) early next week. It is pretty unacceptable for you to block my (also further) work by insisting on the use of a broken alternative patch. I've clearly indicated that I'm okay with any solution that's better than mine, but such a solution has to be free of (pretty obvious) flaws. Jan