From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 98B5A3858D1E for ; Wed, 21 Dec 2022 18:19:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 98B5A3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BLHEEl6002594; Wed, 21 Dec 2022 18:19:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=MOXjP9ff+4MWwwFIE8oKtbf0hLvgKwdigs4sY2hSLes=; b=2saLcVUwhYk2nrBgWWePTF/rWLil4kPtPl9fzjmu1qGiqCrs4vvAD48ojHRS/IHsitIt kEDa5a0VZvFQi/Wp8Vnz+VVDOw5h9VZ4pMssrcYSld0PvxU8Bi4yMZzzbIqwaPSCItQz X7euc0Whq9ICwHTC2lQ2doSKkq6hdMQfeuCB5W+fluV8G1soqxk3jRF/wlMT9Noxm8FF aZIZzGx6dK0g2kwiy8luQyVUv4uJQxB2UU2GUe2WPTfxawGQmrxeHKFkBPgMaHZLompV MngiEnrEEeRi7Apq/kXZWLnaWIcFJbVGwF8iZoCn4OxRTZQafkojy4Bhdp4pZcQEdCMr FQ== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3mh6tpsr9w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 Dec 2022 18:19:28 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2BLHRg4c009703; Wed, 21 Dec 2022 18:19:27 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2175.outbound.protection.outlook.com [104.47.57.175]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3mh47dakwk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 Dec 2022 18:19:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WdzxPCXz0HVQop8sytzVDoCS4jX1HQAGwOA3wanMgUFUD+nFmd/FukOwBKJmUQ/Ev4f9+DJ3vXStm0AibDWycozwzQbn5/lPPyA1IQLstmoWijQV/uAjyLI3PiQGc8lIgqzem2ipCbI2zeksa/xflkpqMvDDpYgwsJoAMo+S6WnEq4zMDUJc1l2iKGusrIcFzME0iOt2gCuig7gMbXAU0IPES1rzWvGspuHXqjD6L9qvLFdh5MHxMEcG5DifrVBJ30pqh/CmVOH5ogkQATk4NXlbGyKOT10b9QasIP4hupzDe57L06q7qv9pOBSTPI22xNz0nCjq1xzbUYFXKJ/75g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MOXjP9ff+4MWwwFIE8oKtbf0hLvgKwdigs4sY2hSLes=; b=jBmFYllbLLU4tcHR6jv1G3PFR16R7v/XQ98WgprMLdGJio/+tHcjmh29XBbI1Wczew/hGf8s6sFxaGtyZcSH+9OP5PllYvVjvxXBDnSBHB0LPji5drNNLhA8cE2UFkRqdx11ZKtpPCJr2XJrJIBZ+6LnoC9pSJ0MYoBBpQeVzV5TjfyOdmpxjjD/wx7DyDDR3g/FWkas7TDVoMhyKGvhRLOFh3DtUOiYpzujcb3SDDOPE2w1s273w5WTAX90hpijqid9B+go+WpBEOJiABky3W0dqOYzQp70v63W0riBDHGB7M1CF6SR6Z88mzayjUnZcsbITTrnCXTNmRvhj23Qkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MOXjP9ff+4MWwwFIE8oKtbf0hLvgKwdigs4sY2hSLes=; b=K2zmBpKbsqX2gUpEQ+2PbzFyKyqapnD3HKLuXapsQrAucNKnMlfntrJlUs7JtOfeTJNE4+WYgMEsS4XJzj2zjWexNnqo7DI5M6LHx9BynO4aQrXTuq+TkUviuJ5WMTlXID6Lb4knRQEDml7EjF8EHfKOIYeXF3jguAXFux4YfzM= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by CH0PR10MB5226.namprd10.prod.outlook.com (2603:10b6:610:da::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Wed, 21 Dec 2022 18:19:25 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::ee70:1952:4416:1bdc]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::ee70:1952:4416:1bdc%5]) with mapi id 15.20.5924.016; Wed, 21 Dec 2022 18:19:24 +0000 Message-ID: Date: Wed, 21 Dec 2022 10:19:20 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH, V2 0/5] SFrame: add support for .cfi_b_key_frame Content-Language: en-US To: binutils@sourceware.org Cc: nickc@redhat.com References: <20221219211406.1443750-1-indu.bhagat@oracle.com> From: Indu Bhagat In-Reply-To: <20221219211406.1443750-1-indu.bhagat@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW2PR16CA0069.namprd16.prod.outlook.com (2603:10b6:907:1::46) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|CH0PR10MB5226:EE_ X-MS-Office365-Filtering-Correlation-Id: ce6c204a-e2f2-443a-3c12-08dae37fe322 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I+EvEacw8HDv3QOHEaD4fUEMF4MqBD3IgXfPY589xH8B8wOrAj25SmMttHurM9FqYDGxpyvZGYZmvCdwKDCXXDJvMqq1fdzkAIPYS9R/ythBbGlEvzDfMQdQsbeolZbfWtYvjXkPLnyI4Ts5Plza3B4BnXyv1LmbxIIAInK6XnJKnBxg2baz3hboANpDuU054YF/JCcN2nkRF1V4sWXC/NF52SRYTqnVoGvlxVb7OgvpEM7vJEq4E5MfDSA4+npeoPM6luJ+jCYyDuHUq5bQY+A3+etPRWp239ke6FiFM4fF7jXNYJyp84LMAIGDJZEh20PuzvLlN5XsixNgWiJj6FGG8Jvj8xJu57d0H8W/XjsJR7o97w0Tn6oZxNDARo04Q0R0nrrqB/fERlkM7EYE73AEgTCU6iJRbZn81A0yaGZPs5J2JO5+ATWid7E6GsDBAKyUIU3PsvrxE8FXl5q3NATNSCEMlA1Ch5401ml3kXdrQF4Rr6i29+1iy/IQ/TPXbI72xF1dFuJ282ZUXRuQVSE/sfxpMET0HkwMrJvNI5tjkKoZTICpAyBsclTp4SVJyq0eozec7Jw6SZaE16MVxhvGz0WpOD4UZ/H/M/21OiwvsRWQGIYf75Ru4e/qD2H+AEKsNuZUiJkSL4ujlawj/DHcLDECJtZYxi3mIvBxR0BJlyFNNtcusOZMuLH4zk1dqc65djfNB2Sghl04M2XZMZlJL/qx6z7+bBgp+a9zbFDPQVPwoVo2Woao6wq1gILV X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(366004)(39860400002)(346002)(136003)(451199015)(2616005)(8936002)(86362001)(83380400001)(38100700002)(31696002)(36756003)(316002)(2906002)(66556008)(5660300002)(6506007)(66476007)(6916009)(66946007)(4326008)(41300700001)(31686004)(44832011)(8676002)(6666004)(53546011)(26005)(186003)(6512007)(478600001)(6486002)(142923001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d3lQdDhHUUFBR3Bxay81ekFNdXVMSFJQTVFUVzlQeXozVFVTWTVpSW1wWXp0?= =?utf-8?B?dnRsNGxIVldOZm1Fc0JWSkhtZldDK3JnR1Nsdkl1dzBtT1p6YUlKNERQYnZo?= =?utf-8?B?VUdyTFBSN0tqU2tISlV1S21XTGtHd2FYSkdTcHl3ck9mdEpTbkNkclpnejJL?= =?utf-8?B?aXVUYXY3M3J2Y0k3NTRFOXFydnhPMjJCSU5jYUFZZUc1clNEMjN4RE5yVmFl?= =?utf-8?B?elI5MTFKL0NqVHQrYmczbXlZRXdycCtJN2RaLzl0S1lDcEVSQUtxc2tEandC?= =?utf-8?B?c1hUa2lBR3ZvbnBkd09NU3ZFTVFZRVZHMTkwT2FhMTJpZWZWcm9yZEdzaDNx?= =?utf-8?B?ZWl0b3U1eC9SbnhXNFVneWplcUNpTy9sQ1VKYy9wVVNBTkJiZ3ZWcE5uZmJ4?= =?utf-8?B?YmZSZm93RmhpWlA0MTZBYkl4WmZsSkk4eVU5TGgyaDZBQVVYbmhHUG1Teitp?= =?utf-8?B?WklvaTB0SEdoQTI1Z2ZwS3hTSGYvVXI2N3FNQ1pmMzlIVS9uUFhqZnBpd0Jt?= =?utf-8?B?SXVlR1paK1puczhCcTlRN3gwZWg1V01FYWdIMnNDR0hkRzlRTXNla0JRWTYz?= =?utf-8?B?VGtmT3ljNmhCUHNzeFZoQkJjUkRjcWxEUEh5bnJWRWtPZXM5aTdjVjJRdGxh?= =?utf-8?B?bk1kMDA5R014UXJVbWFkK0Nvd3BBa2FOZ29HSVpSY0xSTEtmcy9HTlkxQXEy?= =?utf-8?B?RCtIN3ZRTWNzb1NPQzY5YnpFUENkRUtWMXM5QnJLVU0vQVRyZ0NSamhpdEVq?= =?utf-8?B?U0ZoNDc2OU0ydXAxSVk3L2tPUDNpdlJvT0dxQ09CRnhvL1NkNXNoV2xmU2RF?= =?utf-8?B?bC9KeUVnT2VLM2dTWUFyd1c2a1h6dUdaem9pSitPZUlEOWxhM0NyVGZJMXVU?= =?utf-8?B?YTIwRmhHL1lFOWg4RkgzWFRsOUNYTVBraVJyMkFEaXdTTDdwVWNXNnAvZnk0?= =?utf-8?B?MTROTVpsa3F5M0x3N2lBNk80V21yeFhjK1paUkFOTmZBWkJOblAveU9tRXpY?= =?utf-8?B?YkYzWkREaXUyeHpMcXBNMFRkb1NUR0FpVW1LVmY1TUZtS0hzaEFveWhjdm5G?= =?utf-8?B?WDQrM2hncS9XOXNOaG1tZ1pIOGpjb1BBNlI2SGNZM3c1Q0lqU2orQ0lMRGdk?= =?utf-8?B?ZjI3M1hWaGJrWWdUdWxGNCs5QVVjTm9acDc0bjE0eGFyWUVxMHhoNWN5Q3hZ?= =?utf-8?B?WC9aUUs2ZFFJTGlRUXg1VmhFLzdHSE1wV3NYM25vV28xckdsYU5rb2tRUStG?= =?utf-8?B?dkJWdVkwT3Y0MUtUMG5TSVNzYUNXTXR2SE5Mb0xKN1VVd3Z1T25GOXFHNkw2?= =?utf-8?B?LzZQVkhZU2pyaGF0RWpzSEJoWHN2VVBlL1MvR2N1MEtOWnB1K3NCdE1lc0Rl?= =?utf-8?B?K3hPUFBtT2xGalpVcUdtUklWSFhUWXZHZ0NuZjBIdkRIVUV0WkRiNEVSbGp0?= =?utf-8?B?ZlJOUmR5ZkJRTlhiOGdZeVdYZ05sM1JzK2ZEU1JYNnlHdmJyVUdvSWVmbERI?= =?utf-8?B?VzNkTDZWWlgwcXdZRkQ2MjVlaU1tVjQwN1k2cXAvN015MC9BSVBHdjYwb1RS?= =?utf-8?B?M2ZIRENSeWVFa0dHQ0VNYTdoNU1xMTZ5ejdCOXBKZzVGem44NXIrb3d6Mmhz?= =?utf-8?B?V1pHLzk1SHJTeHJNZWlJYitTbjZrWlZxSjQzbkVyR3RTYmhOMzBWU0VDQnpS?= =?utf-8?B?Y003M1hFeUtkVlpudHlhV2VsUk1tckk5WDlESzJFYkl5YzZKTUpQSW0wU3hV?= =?utf-8?B?SmlwRmxBWFEyTndReVVJVVZoWmVwdmEyM3hMQnIvMjVoV3FNeDAzZ05jeVBt?= =?utf-8?B?NHpCd3BJZmVLdUFoK3VFb0JoQ0xJVUo1c2hRZ1A1dEtmd3NFV2NTNEZTajlK?= =?utf-8?B?bXU3M3VKbWFYY2FVL3VoQmltelRCNmc1bitUVnpHMFA4bmQ4cGZrOUtGNVYr?= =?utf-8?B?OHBzN0pBU2lYc3k3RHgydnYrVWNwTmk0NVZPb0xJWi9MTkE3NEczanoxZHVi?= =?utf-8?B?eVhxeVRHTFdhak5EbkRJN001TWwwTGRtWUdlc3lXaFAvaWZTS0N5b2RvWHIv?= =?utf-8?B?eE9vdllzN094L0Qxd21SakpoenRBWTFiYWc3d2E5aTNQMzgzdDFMcTlxN1d4?= =?utf-8?Q?gLj1ivOYyXp55Do4z/mSEzTyN?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: ce6c204a-e2f2-443a-3c12-08dae37fe322 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2022 18:19:24.0807 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5xRFeRPxsi383ObqblJ5PZjAkpnWiCqlRXrF+fdLi3RSqNOTvqWt8NWgNRmUonfFhdZ1HjMWbzVdV0Zu/VMmQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5226 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-21_10,2022-12-21_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 phishscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2212210155 X-Proofpoint-ORIG-GUID: COf16RnIWoqYdu7e9oLBaycx2HNwUPXl X-Proofpoint-GUID: COf16RnIWoqYdu7e9oLBaycx2HNwUPXl X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: PING. This patch series has not been committed. I earlier sent the series as "[COMMITTED, V2]" by mistake; so this needs an OK before I can commit it. Thanks On 12/19/22 13:14, Indu Bhagat wrote: > [Changes from V1] > - Rebased on latest trunk. > - Fixed the testcase as we now emit "[s]" marker for both mangled RA in > register and stack. > [End of changes in V1] > > Thanks > > ---------------------- > > Hello, > > This patchset adds support for handling the .cfi_b_key_frame assembler > directive to the SFrame format: SFrame format representation now allows to > encode which of the pauth A key / B key are used (for signing return > addresses on aarch64), and gas, readelf/objdump now allow for generation > and textual dump of this information. > > Testing notes: > > - Regression tested cross build of several targets on an x86_64 host and an > aarch64 host using a regression script that checks for failures in gas, ld, > binutils, libctf and libsframe. > - Regression tested native builds on x86_64 and aarch64. > - binutils/gdb try bot showed no new regressions. > > Thanks, > Indu Bhagat (5): > [1/5] sframe.h: add support for .cfi_b_key_frame > [2/5] gas: sframe: add support for .cfi_b_key_frame > [3/5] objdump/readelf: sframe: emit marker for SFrame FDE with B key > [4/5] gas: sframe: testsuite: add testcase for .cfi_b_key_frame > [5/5] sframe: doc: update documentation for pauth key in SFrame FDE > > gas/gen-sframe.c | 26 +++++++++++--- > gas/gen-sframe.h | 2 +- > gas/sframe-opt.c | 3 ++ > .../cfi-sframe-aarch64-pac-ab-key-1.d | 27 ++++++++++++++ > .../cfi-sframe-aarch64-pac-ab-key-1.s | 36 +++++++++++++++++++ > gas/testsuite/gas/cfi-sframe/cfi-sframe.exp | 1 + > include/sframe.h | 25 +++++++++---- > libsframe/doc/sframe-spec.texi | 8 ++++- > libsframe/sframe-dump.c | 19 ++++++++++ > 9 files changed, 135 insertions(+), 12 deletions(-) > create mode 100644 gas/testsuite/gas/cfi-sframe/cfi-sframe-aarch64-pac-ab-key-1.d > create mode 100644 gas/testsuite/gas/cfi-sframe/cfi-sframe-aarch64-pac-ab-key-1.s >