From: Jan Beulich <jbeulich@suse.com>
To: Andrew Goth <Andrew.Goth@caemilusa.com>,
"H.J. Lu" <hjl.tools@gmail.com>, Nick Clifton <nickc@redhat.com>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>
Subject: Re: @CPP_FOR_BUILD@ problem since binutils-2.38
Date: Fri, 7 Oct 2022 10:42:45 +0200 [thread overview]
Message-ID: <c8710738-94c8-ec95-357a-7a63cf50f50a@suse.com> (raw)
In-Reply-To: <PH1P110MB16505D9D39EC5B1DE22FE3D5EC5F9@PH1P110MB1650.NAMP110.PROD.OUTLOOK.COM>
On 07.10.2022 06:10, Andrew Goth via Binutils wrote:
> Hi, I'm having trouble with @CPP_FOR_BUILD@, @CPPFLAGS_FOR_BUILD@, etc. in binutils's Makefile.in not being replaced by the configure script.
>
> This problem was introduced with version 2.38 and persists into 2.39.
>
> Here is an excerpt from the diff from 2.37 to 2.38:
>
> diff -U0 -r binutils-2.37/Makefile.in binutils-2.38/Makefile.in
> --- binutils-2.37/Makefile.in 2021-07-18 11:47:23.000000000 -0500
> +++ binutils-2.38/Makefile.in 2022-02-09 06:04:43.000000000 -0600
> @@ -342,0 +367,2 @@
> +CPP_FOR_BUILD = @CPP_FOR_BUILD@
> +CPPFLAGS_FOR_BUILD = @CPPFLAGS_FOR_BUILD@
> @@ -345,0 +372 @@
> +DSYMUTIL_FOR_BUILD = @DSYMUTIL_FOR_BUILD@
> @@ -347,0 +375 @@
> +GDC_FOR_BUILD = @GDC_FOR_BUILD@
> @@ -394,0 +423 @@
> +DSYMUTIL = @DSYMUTIL@
> @@ -398,0 +428 @@
> +OTOOL = @OTOOL@
> @@ -404,0 +435 @@
> +GDC = @GDC@
>
> Every single one of these additions to Makefile.in yields a corresponding Makefile line that passes through unsubstituted.
>
> In configure, CPP_FOR_BUILD, etc. aren't in $ac_subst_vars. Similarly, they're not listed with AC_SUBST() in configure.ac, which I find most interesting.
Hmm, this looks to be due to 08ca783430ac syncing only Makefile.*
with gcc's, but not configure.ac. The CPPFLAGS_FOR_BUILD issue was
meanwhile addressed in isolation by commit e472ec9fad6d. Nick -
what is the general policy / approach of syncing top level files?
Jan
next prev parent reply other threads:[~2022-10-07 8:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 4:10 Andrew Goth
2022-10-07 8:42 ` Jan Beulich [this message]
2022-10-10 0:43 ` Alan Modra
2022-10-10 6:50 ` Tsukasa OI
2022-10-11 13:03 ` Alan Modra
2022-10-11 18:21 ` Tom Tromey
2022-10-11 23:40 ` Alan Modra
2022-10-13 4:32 ` Tom Tromey
2022-10-10 10:06 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8710738-94c8-ec95-357a-7a63cf50f50a@suse.com \
--to=jbeulich@suse.com \
--cc=Andrew.Goth@caemilusa.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).