From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id EA2373860758 for ; Fri, 30 Jun 2023 12:08:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EA2373860758 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688126925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kLKp1bNR7LaS40J0UNxEjV1iB+v+5G3LwMcNZB1PrdU=; b=N/1cYH7Sh8lrZWzn3tpuQB67fNkE7YMwpTcE2DJwN0DTmv6H0O1Z0ZxJ3ocyeIulyY3qjn yae1865ahvIPcavsf2MqU++XYN2yQYcXNZkdlahAFFfhnWWOKhfI1xk3yULI758vDN62rN FZVmwvABQAvERRpRWBJrs7pE7IcubYs= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-221-DLahEJSmNxiUxptTtRlk2w-1; Fri, 30 Jun 2023 08:08:44 -0400 X-MC-Unique: DLahEJSmNxiUxptTtRlk2w-1 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-3fda1a83608so20254611cf.3 for ; Fri, 30 Jun 2023 05:08:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688126923; x=1690718923; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kLKp1bNR7LaS40J0UNxEjV1iB+v+5G3LwMcNZB1PrdU=; b=SYY3J/kJGHv683k1BgzvnI75kXwhPO6dmrA5Qirh/Br4eULVRq4SMq2UbwhvOHC3CV haBYQU4OZujIAPIhZXK+3zsNx59Vluo//dPSFr9PY+BNXPEdo1zqkOrPVk4i/K/H4k9N HZWIitXZNHrApjE43iiN1QfrNxyei1zpvEugVoVWl5ttaYphGrWVrPqiK0xnH7ehmueb fDxM7TuCTjQSCIM8CKNSBTujlI2mhAWPtf2+tnx96LhiFrJS7UbdhfgnjiKud/xeawnd wzUpDqE7uoKSq75lykGt0eTYpN+JDg6AUwRetDu1ib4kYo6j9K4lNagg1SLUPlRskoFy xYfg== X-Gm-Message-State: AC+VfDweV2r94ik/MEEsRx/Bse0ouys27NR8m4A7vAnmcM85dkblFwlT HQtZ1bnIqMaBD3yzz1oOw/Z3GasR5ttyckx4M/9YfXcQr0eABWy1yxcEmQ4Lhx7ktKwEcsiJWTP ZbwXc8KolWOm7xnhzcA== X-Received: by 2002:a05:622a:354:b0:400:ab67:c8c with SMTP id r20-20020a05622a035400b00400ab670c8cmr3192396qtw.23.1688126923439; Fri, 30 Jun 2023 05:08:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6yxss+fEAzG+3LihUjWxtWITJLzQtFr0008BA3MgVrcUVF0n2Ea22s5rPawzVg4fEmn/oWJw== X-Received: by 2002:a05:622a:354:b0:400:ab67:c8c with SMTP id r20-20020a05622a035400b00400ab670c8cmr3192369qtw.23.1688126923105; Fri, 30 Jun 2023 05:08:43 -0700 (PDT) Received: from [192.168.1.7] (adsl-2-solo-172-78.claranet.co.uk. [80.168.172.78]) by smtp.gmail.com with ESMTPSA id o23-20020ac85557000000b003f6bbd7863csm8159610qtr.86.2023.06.30.05.08.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jun 2023 05:08:42 -0700 (PDT) Message-ID: Date: Fri, 30 Jun 2023 13:08:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH V3] optimize handle_COMDAT To: Oleg Tolmatcev , "binutils@sourceware.org" References: <648f4180.a70a0220.a7021.407c@mx.google.com> From: Nick Clifton In-Reply-To: <648f4180.a70a0220.a7021.407c@mx.google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Oleg, > I have improved my patch again. This time I read the MS COFF documentation, I kept all the checks, I successfully ran "make check" in WSL and I formatted the code with clang-format. I used the GNU style and tabs for indentation. I also simplified the patch. Thank you. Unfortunately there are still a couple of problems with the patch, Firstly, and most importantly, the patch triggers a new failure in the linker testsuite: Running ld/testsuite/ld-linkonce/linkonce.exp ... [...] FAIL: pr26103 Secondly - the patch cannot be applied from your email. Its formatting has been corrupted, forcing me to apply it by hand. Lastly the patch includes a lot of unnecessary formatting changes to unrelated code. This is annoying as it masks the true content of the patch. Please could you investigate the testsuite failure and submit a revised patch as an attachment, rather than inline in the email. Cheers Nick