From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 798E53858D33 for ; Fri, 10 Nov 2023 14:12:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 798E53858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 798E53858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699625563; cv=none; b=msFBHYuHcHurVbi30zuy5wfTRwl/OGgY/4oVpVZShX1AF4pthb//1NLvWGc43x4Nm9NXy543nigouL433yuo/s1nmNGH3Qaez9nHI/xUwL8T4fJV1atodCrLZBwbx3U9jsqEXn+xms1Hl8EvAjKI0TZARGjGUUAK5R3v2H/e0Ug= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699625563; c=relaxed/simple; bh=OOCuUYdy9DWBy96hxL8sFe7Z2ipSzGTGsXh7nXMFBVA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=NYzIZ8tKYZc2JfyWkFSEzdMQkwWVaKOPBjEp+FxbuOqTO9/GEvNa5FuYV5UxDHvue7No/sXCDTtYp0LlopWtHeIduTS5KeGrRc8J5W/H4j0Tdip2dV/P2oflMNIEv2t0BciJaT7h1n4mI91UiE8JV807Nc65JDHrVr5YfKMWRiQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699625561; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=es0WsZqoMEGtRQCzSvgfWE2NmOUhrCdjB7dHdpW4BX0=; b=ApDn4g913hvqCK7Cx9D/91pibk7VpwOMn6MB54tWxO88hjceftYmwAfeG7LSrRVQ7J3BED 5+AezEywB58QquRO+Kq9qZx7CtoRk1StxcawzhDeCwmIT8xVpTfg/N2BOIWBiyynCeD5Mt Wwd9aGF3cOvne/jDaCHz/WWYKuEI7fg= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-500-lg_v2Tt0N7yF-NP5uy6XXg-1; Fri, 10 Nov 2023 09:12:40 -0500 X-MC-Unique: lg_v2Tt0N7yF-NP5uy6XXg-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-779e001ffa5so221821485a.3 for ; Fri, 10 Nov 2023 06:12:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699625558; x=1700230358; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=es0WsZqoMEGtRQCzSvgfWE2NmOUhrCdjB7dHdpW4BX0=; b=HRkF39R+b11WSYVDU0jbkFP4mQOC7tmQGp3Pj2cGUHQnFLwOcyIudkaF4BrO1u87Iv 58rxBIahu8ubhVvBYjEwiQehVNDMNMdQMrbnEaP7EYEA4D1nT4ek3rYxqXHo1xhUOQoj h209YmBa5NIEn+mmiVv7kKrG1AWjuvH+BcN0dTIgomb7W3NyExyu/8Qa0+R1m+T/30SK lrk4RTFT9vuVb/cTaxoxF5T8gJLN2c+t2i0HKeAE/KwLmJRiU3GARDuNZf49kEsUGrJu CYdNOPC9gW1AJ+Gz3FWSNBcVUaN76VViSpOuV7QkHXP04zo0lC57cJ13PQZIWLrz9Lgn S7QQ== X-Gm-Message-State: AOJu0YxIWpR4pIqmIYRScSXd4n8p6IdifGUwzg1HJNMBSVbgg6Io2rF3 rU0JNLQ72ra9jU76Z2YvDDav1a2bNCHwHtFh4QS8SeqSgGH6e9cjTU0fTK2/VpRX8/hSg16Z8Uq oyL+ClHhs2P0tOc74ar3Qi287SA== X-Received: by 2002:a05:620a:198b:b0:775:c2a1:1f1e with SMTP id bm11-20020a05620a198b00b00775c2a11f1emr9156156qkb.50.1699625558543; Fri, 10 Nov 2023 06:12:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IHJBIiXurKkhO7BxANG7PD3myvMxhhRKIUy1G9Fw1lagtzGR6MyRcfmT8jPviHBxhYPiVM/sg== X-Received: by 2002:a05:620a:198b:b0:775:c2a1:1f1e with SMTP id bm11-20020a05620a198b00b00775c2a11f1emr9156137qkb.50.1699625558211; Fri, 10 Nov 2023 06:12:38 -0800 (PST) Received: from [192.168.1.11] ([80.168.197.243]) by smtp.gmail.com with ESMTPSA id g6-20020a05620a218600b0077891d2d12dsm715225qka.43.2023.11.10.06.12.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Nov 2023 06:12:37 -0800 (PST) Message-ID: Date: Fri, 10 Nov 2023 14:12:36 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] MIPS: Change all E_MIPS_* to EF_MIPS_* To: Ying Huang , binutils@sourceware.org Cc: yunqiang.su@oss.cipunited.com References: <20231010063635.2800937-1-ying.huang@oss.cipunited.com> From: Nick Clifton Autocrypt: addr=nickc@redhat.com; keydata= xsFNBFm/2cUBEADkvRqMWfAryJ52T4J/640Av5cam9ojdFih9MjcX7QWFxIzJfTFYq2z+nb4 omdfZosdCJL2zGcn6C0AxpHNvxR9HMDkEyFHKrjDh4xWU+pH4z9azQEqJh331X7UzbZldqQo 16VkuVavgsTJaHcXm+nGIBTcUbl2oiTtHhmuaYxx6JTMcFjC7vyO5mLBw78wt52HBYweJ0Nj HBvvH/JxbAAULSPRUC61K0exlO49VFbFETQNG1hZTKEji95fPbre7PpXQ0ewQShUgttEE/J3 UA4jYaF9lOcZgUzbA27xTV//KomP0D30yr4e4EJEJYYNKa3hofTEHDXeeNgM25tprhBUMdbV RZpf2Keuk2uDVwc+EiOVri48rb1NU+60sOXvoGO6Ks81+mhAGmrBrlgLhAp8K1HPHI4MG4gH nrMqX2rEGUGRPFjC3qqVVlPm8H05PnosNqDLQ1Pf7C0pVgsCx6hKQB7Y1qBui7aoj9zeFaQg pYef+CEERIKEcWwrjaOJwK3pi9HFdxS0NNWYZj8HPzz/AsgTTQdsbulPlVq2SsctmOnL42CZ OCTppGYwl53CG/EqVY+UQBzFzJBaY8TJRFFYVEy5/HH4H11rMoZwqIkk71EOGU3X6mWlANRi kR3M4GhVITRzuaV69Fed+OeXcCmP94ASLfuhBR2uynmcHpBKpwARAQABzTtOaWNrIENsaWZ0 b24gKENoaWVmIEJpbnV0aWxzIE1haW50YWluZXIpIDxuaWNrY0ByZWRoYXQuY29tPsLBeAQT AQIAIgUCWb/ZxQIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQE/zvid2ePE9cOxAA 3cX1bdDaTFttTqukdPXLCtD2aNwJos4vB4LYPSgugLkYaHIQH9d1NQPhS0TlUeovnFNESLaV soihv0YmBUCyL4jE52FRoTjE6fUhYkFNqIWN2HYwkVrSap2UUJFquRVoVbPkbSup8P+D8eyd BbdxsY6f+5E8Rtz5ibVnPZTib7CyqnFokJITWjzGdIP0Gn+JWVa6jtHTImWx1MtqiuVRDapU hrIoUIjf98HQn9/N5ylEFYQTw7tzaJNWeGUoGYS8+8n/0sNbuYQUU/zwMVY9wpJcrXaas6yZ XGpF/tua59t9LFCct+07YAUSWyaBXqBW3PKQz7QP+oE8yje91XrhOQam04eJhPIBLO88g6/U rdKaY7evBB8bJ76Zpn1yqsYOXwAxifD0gDcRTQcB2s5MYXYmizn2GoUm1MnCJeAfQCi/YMob R+c8xEEkRU83Tnnw3pmAbRU6OcPihEFuK/+SOMKIuV1QWmjkbAr4g9XeXvaN+TRJ9Hl/k1k/ sj+uOfyGIaFzM/fpaLmFk8vHeej4i2/C6cL4mnahwYBDHAfHO65ZUIBAssdA6AeJ+PGsYeYh qs6zkpaA2b0wT4f9s7BPSqi0Veky8bUYYY7WpjzDcHnj1gEeIU55EhOQ42dnEfv7WrIAXanO P8SjhgqAUkb3R88azZCpEMTHiCE4bFxzOmjOwU0EWb/ZxQEQALaJE/3u23rTvPLkitaTJFqK kwPVylzkwmKdvd2qeEFk1qys2J3tACTMyYVnYTSXy5EJH2zJyhUfLnhLp8jJZF4oU5QehOaJ PcMmzI/CZS1AmH+jnm6pukdZAowTzJyt4IKSapr+7mxcxX1YQ2XewMnFYpLkAA2dHaChLSU/ EHJXe3+O4DgEURTFMa3SRN/J4GNMBacKXnMSSYylI5DcIOZ/v0IGa5MAXHrP1Hwm1rBmloIc gmzexczBf+IcWgCLThyFPffv+2pfLK1XaS82OzBC7fS01pB/eDOkjQuKy16sKZX6Rt57vud4 0uE5a0lpyItC2P7u7QWL4yT5pMF+oS8bm3YWgEntV380RyZpqgJGZTZLNq2T4ZgfiaueEV4J zOnG2/QRGjOUrNQaYzKy5V127CTnRg4BYF/uLEmizLcI3O3U1+mEz6h48wkAojO1B6AZ8Lm+ JuxOW5ouGcrkTEuIG56GcDwMWS/Pw/vNsDyNmOCjy9eEKWJgmMmLaq59HpfTd8IOeaYyuAQH AsYt/zzKy0giMgjhCQtuc99E4nQE9KZ44DKsnqRabK9s3zYE3PIkCFIEZcUiJXSXWWOIdJ43 j+YyFHU5hqXfECM6rzKGBeBUGTzyWcOX6YwRM4LzQDVJwYG8cVfth+v4/ImcXR43D4WVxxBE AjKag02b+1yfABEBAAHCwV8EGAECAAkFAlm/2cUCGwwACgkQE/zvid2ePE/dqQ/6ApUwgsZz tps0MOdRddjPwz44pWXS5MG45irMQXELGQyxkrafc8lwHeABYstoK8dpopTcJGE3dZGL3JNz 1YWxQ5AV4uyqBn5N8RubcA8NzR6DQP+OGPIwzMketvVC/cbbKDZqf0uTDy3jP65OFhSkTEIy nYv1Mb4JJl3Sq+haUbfWLAV5nboSuHmiZE6Bz2+TjdoVkNwHBfpqxu6MlWka+P98SUcmY8iV hPy9QC1XFOGdFDFf1kYgHW27mFwds35NQhNARgftAVz9FZXruW6tFIIfisjr3rVjD9R8VgL7 l5vMr9ylOFpepnI6+wd2X1566HW7F1Zw1DIrY2NHL7kL5635bHrJY4n7o/n7Elk/Ca/MAqzd IZxz6orfXeImsqZ6ODn4Y47PToS3Tr3bMNN9N6tmOPQZkJGHDBExbhAi/Jp8fpWxMmpVCUl6 c85cOBCR4s8tZsvGYOjR3CvqKrX4bb8GElrhOvAJa6DdmZXc7AyoVMaTvhpq3gJYKmC64oqt 7zwIHwaCxTbP6C6oUp9ENRV7nHnXN3BlvIgCo4QEs6HkDzkmgYlCEOKBiDyVMSkPDZdsspa+ K4GlU2Swi/BDJMjtDxyo+K0M81LXXxOeRfEIfPtZ3ddxBKPva1uSsuz+pbN9d1JY8Ko5T/h1 6susi2ReUyNJEJaSnjO5z13TQ1U= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Ying Huang, > Ping, Sorry for the delay in reviewing your patch. >> Now MIPS has two macro definitions for ELF file header flags, >> respectively E_ and EF_. It is difficult to decide which style macro >> we should use when we want to add new ELF file header flags. >> >> We can refer to this message coming from the lost world: >> . >> Clearly IRIX and the Linux kernel used to use EF_* macros. >> So we should use EF_* to keep same style with the beginning. I agree that having inconsistent naming schemes for the macros is annoying. But I dislike the idea of a backwards incompatible change. It is not only the binutils, gdb and glibc that use these macros but other programs as well. To that end I have amended your patch so that the changes to include/elf/mips.h and elfcpp/mips.h also keep the old definitions of the constants. This means that other users of these files will not have to change their code unless they want to. >> And we also have submitted this change to glibc. You will also need to submit the changes to gdb/mips-tdep.c and sim/mips/interp.c to the gdb mailing list as these files are not maintained by the Binutils project. >> bfd/elf32-mips.c | 4 +- >> bfd/elfxx-mips.c | 224 +++++++++++++++++++++---------------------- >> binutils/readelf.c | 76 +++++++-------- >> elfcpp/mips.h | 74 +++++++------- >> gas/config.in | 6 +- >> gas/config/tc-mips.c | 10 +- >> gas/configure | 8 +- >> gas/configure.ac | 10 +- >> gold/mips.cc | 168 ++++++++++++++++---------------- >> include/elf/mips.h | 74 +++++++------- Approved and applied - with the change mentioned above. One other thing - your email program appears to have mangled the patch, removing lots of whitespace. This made the patch impossible to apply automatically and instead I had to apply it by hand. In the future, please could you supply the patch as an attachment, rather than inline ? Cheers Nick