From: Jan Beulich <jbeulich@suse.com>
To: "徐持恒 Xu Chiheng" <chiheng.xu@gmail.com>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>,
"H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: [PATCH] binutils: partially revert 17c6c3b99156fe82c1e637e1a5fd9f163ac788c8
Date: Fri, 18 Nov 2022 11:01:38 +0100 [thread overview]
Message-ID: <c955ec7e-f750-4c67-9eaa-a6c72abbf511@suse.com> (raw)
In-Reply-To: <CAPOVtOuN+g3vRAMrL4sdJkPecJ2ge-Er3eLQK6dLFhmh6BsMfg@mail.gmail.com>
On 18.11.2022 10:37, 徐持恒 Xu Chiheng via Binutils wrote:
> Sorry, but I really think this is a regression.
> 64 bit linker originally could do relocation on 32 bit object code. It
> worked perfectly.
And it still can, provided you pass in well-formed 32-bit object files.
> Setting src_mask to 0, ignores the addend value in the section content.
Which is precisely what the ELF spec says the behavior is for RELA type
relocations. _Not_ ignoring section contents was the bug here.
You are, btw, not the first one to notice this perceived regression. But
that still doesn't actually make it one. It is merely a change in
behavior to fix a long-standing bug.
Jan
next prev parent reply other threads:[~2022-11-18 10:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 17:44 徐持恒 Xu Chiheng
2022-11-17 18:06 ` H.J. Lu
[not found] ` <SY4P282MB40478D0B56A396B9DF249BBE8A069@SY4P282MB4047.AUSP282.PROD.OUTLOOK.COM>
2022-11-17 18:50 ` H.J. Lu
[not found] ` <SY4P282MB40470E7AC17968C86A8731488A069@SY4P282MB4047.AUSP282.PROD.OUTLOOK.COM>
2022-11-17 19:11 ` H.J. Lu
[not found] ` <SY4P282MB40478BD7C68830B7DC5705358A069@SY4P282MB4047.AUSP282.PROD.OUTLOOK.COM>
2022-11-17 19:51 ` H.J. Lu
[not found] ` <SY4P282MB404738CCE8DD452A63DA4B0B8A069@SY4P282MB4047.AUSP282.PROD.OUTLOOK.COM>
2022-11-18 9:37 ` 徐持恒 Xu Chiheng
2022-11-18 10:01 ` Jan Beulich [this message]
2022-11-18 10:24 ` 徐持恒 Xu Chiheng
2022-11-18 10:34 ` Jan Beulich
2022-11-18 10:45 ` 徐持恒 Xu Chiheng
2022-11-18 13:31 ` Jan Beulich
[not found] ` <CAPOVtOuQ3Xto+uoRVqfyWDuvqO=8XrL64+ujZHY+OsN81Q4E=A@mail.gmail.com>
2022-11-18 14:03 ` Jan Beulich
[not found] ` <da40ede4-5f91-a35e-dcae-ab222f0d0cdf@suse.com>
[not found] ` <CAPOVtOsHOzBxx=1bCMgRP-DfWzJu_eS-5UaEj-q_F8p86R-q9g@mail.gmail.com>
2022-11-18 14:09 ` Jan Beulich
2022-11-18 14:14 ` 徐持恒 Xu Chiheng
2022-11-18 14:35 ` 徐持恒 Xu Chiheng
2022-11-21 7:53 ` Jan Beulich
2022-11-21 8:30 ` 徐持恒 Xu Chiheng
2022-11-21 8:50 ` 徐持恒 Xu Chiheng
2022-11-21 9:02 ` Jan Beulich
2022-11-21 9:06 ` Jan Beulich
2022-11-21 9:21 ` 徐持恒 Xu Chiheng
2022-11-21 9:52 ` Jan Beulich
2022-11-21 10:59 ` 徐持恒 Xu Chiheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c955ec7e-f750-4c67-9eaa-a6c72abbf511@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=chiheng.xu@gmail.com \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).