From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by sourceware.org (Postfix) with ESMTPS id 4684E3856256 for ; Wed, 18 May 2022 12:36:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4684E3856256 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2055.outbound.protection.outlook.com [104.47.13.55]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-40-LlGMLcdwNwqbNqr5sPSBwA-1; Wed, 18 May 2022 14:36:49 +0200 X-MC-Unique: LlGMLcdwNwqbNqr5sPSBwA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FwLYgFIFOc0qRXgL/PijD9iIDglomhVYrRch6Dlp6dWi/SgS9KwKH2i96yCEPDQP/lU28Avj9Glzc4k05bYBmBYX7+ROZGE0V7HUUK1DoY7DVof1/kNgkjG/+zPf1eqL1a1lavaGmjsf5dTbAxDcNPBjmdJKIs9c30e/CX6n+ygX+HAbpsudiJKxGNxRWgCVkEE6GeXH/9PHGJmxZFvchVLvLuw10aO6XOdxtXSDEGmHue0Q+bfaXFA+8yBrHVgtazSRbA+zoRE10qNyS91zGq3oDGuxqcRp02+ncHWU+DLxtnMxPL6+MXaqfEaY415KT44Tah2iDYt+yzfZGtj9ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k7bwDGFi0EBlEFcIZjVbzKJS5wscp1mYC0rFCrStYxg=; b=T+XfM4AaSnqo7fRh54fIdfMdKD+K/pVZtIhLjiZTsQrUAi4swlspGzwHLTGN3xTteY2uFfzJ3hrzdNYv8r+TPH3T/INQ2wrLcGOQjYYanzq7DUMw5og0EwzIeCwKSGGPf4thotaxj5G+P/sVrQVDZOY9UQvmZB6NhPN6foa0PDFs5cokyYBFxLkKbfvPzT1yvlrPzx/VWbkDSQ311pc+eo7lJSS9Si1kw9bKneijBO3SpAtnd40vtJXjybsdnlRBzEynLEVhXekCUIWXKydBRyN3/XcAdCBXiKE7vxYK53UWxfanCSK0AKsm/MXe9ORvBrTYkm/rnz/9KRmBE1EGAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB7096.eurprd04.prod.outlook.com (2603:10a6:20b:113::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Wed, 18 May 2022 12:36:47 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.014; Wed, 18 May 2022 12:36:47 +0000 Message-ID: Date: Wed, 18 May 2022 14:36:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] bfd: Fix issues with files in debug_line table with dwarf5. Content-Language: en-US To: "Potharla, Rupesh" , "Potharla, Rupesh via Binutils" Cc: "George, Jini Susan" , "Parasuraman, Hariharan" , "Natarajan, Kavitha" References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR04CA0042.eurprd04.prod.outlook.com (2603:10a6:20b:46a::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 379c591f-30d8-4394-aefe-08da38cb12f9 X-MS-TrafficTypeDiagnostic: AM7PR04MB7096:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TiJeJjXUlx31Qokfl+VAgZVOQKYmYMjJgxBwdr9Lib67SI5FWuUMHwuQANt284GzDfsM6Cv8vZkHB7BMJvqZihafnrq2rBvoMVi/LrAwsbAq9xzW48grigkp28F1U2yZcFr85v5nCIuL/i0zfTIkyQxMgtOWmND3YZtSD4Y3RljgSl833kURzwG7n1JcHFbm6doJWPQXGhE1vE3p0eVrcyCJsTZUndWG1dgPFjZ9J0xAKtH27RIM7/MUeYheZYX80eWlCuqLJjioZ3UEoHeQWb9ZDjIMtu7i7gEMtclIh/sLvCpx4w5pEmtO1Yu1f+NPnng1pjg6DYs+w2g1Wq62qDs01tYQnnWeK39ZQv29j0LvOSKdo2KJoMvDhv8I5dLnUYYzC7PNyYHULFA8NQsl0u+U7z2Yu4QVyCCPzs5IpRg0Xk04dH4oCMPiBgfohu5eQJlbQbF/zXvwrWi1S6poazE+LQi7mVgk34cFnoF0SQ8sGzoisTNNiikNmyisOtO0DgVkepKXnCALU/Io5vzVPu9Jv02S9/LhEpY1ViwffGw07qNyz4tsrPgOhKcs/XxS/4Yj/QDDuGtpKs0n8cwyPKmHfd5/jskfYNxjFLh9xvIR1yFm0QMcro4w7zHgHbKQajiHtcN3YUUO0gv+QJ0N6REyG2E32PzecOw7XyPYgms7wsz1VNNgl+NIrLV/bZAaDk8cl8XCGWUTBo80X2TNJNTBnmhFBCf2vJf383bIJbXJOZeYK2Q7B2SljSkQqzRr X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(83380400001)(8676002)(4326008)(66556008)(66476007)(66946007)(6506007)(186003)(110136005)(54906003)(53546011)(508600001)(6512007)(26005)(6486002)(2906002)(2616005)(36756003)(316002)(86362001)(31686004)(31696002)(38100700002)(5660300002)(8936002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVlVbmloZG0yTVcyMDAwV0dLdEFQeW5temtEbGtVb1UrTXRacXBEMERCTGdY?= =?utf-8?B?aWlyd3JHaUdCc1NQRDFDaFRwdjdJQkU3MjBsdmdvekYyZ2IxRDZIVTU3MWRO?= =?utf-8?B?SjVQN0ZtRlFXSGxVb1RDb000OGdSbkdWaWpCWWJmZDVKcFo3TGFHc293QzA5?= =?utf-8?B?KzJLSkp3OHRBZGhZSTBlRHhFVDBMZDM5MGZRWFE3R1p1RDNpS2Vkc08zaG8v?= =?utf-8?B?bXdxTitMeDBldE9sTWZuVmZZbU5oZDh3RE94VFVQZnpHZ0I3V3A4NG5XRjlp?= =?utf-8?B?Z05vQndNdmYwTkhLTlNFckFzTUQvekpiY01KUWgyS0UyK1RFVUJTaXVmZlY0?= =?utf-8?B?WGRGQVdjSUpoTloweHVoOVRVb2NQK09sR0kySFhzWUhzZEhsM3dnaVVkZ3Mw?= =?utf-8?B?Tlk1c2JhUTArMjc2Snlzck1VeHBXdzZkay83NnpnTTdPcGhvbHVma0RINUZq?= =?utf-8?B?eTFjZm9FcG00NzJhTGIvUHo4NmIvNlV1YjhiSXFDSWxnOXhFL0lvai9rTU8x?= =?utf-8?B?ck0rRGJJYkdrNC84L1NvY2V1WXJvM3lOaWFWMzJxWmo5K1UzNHJRU2hHNlFN?= =?utf-8?B?dkUzYUZON0FiMUROME10cHJYTnJTS2dPWE1URHFoK2ZEWlUvRys1NnZycEdE?= =?utf-8?B?L25DVyt6SEpoWU9VZmswVzFyUjBjdzBqZ051aE5LVm1LdnlCWXhxUEdFVDZ2?= =?utf-8?B?V0F4Yng1ek1ZUkVpVS8vbS80eStvWmNVVVN5aENLZndwL0wybWtEU1ptTEhL?= =?utf-8?B?dzFML2RkOHUvSmNpUjJKbWIvMVcyajFFbTlGdHpSaE50VGVZZWVwQmJvR0hn?= =?utf-8?B?bUhWNjNlek04U2VDU2k4SFY5MUsrRENSZWdJcjdWYnZuUUQyQURLQjdUZ1Uv?= =?utf-8?B?NCtuVS85WkJWM3VoZFZUa2NpT2FTZk14a29IS0RNdU1LZTFVY3ZEUTRHS2FH?= =?utf-8?B?Q3o3d1craEpLcjBQeDE0a3BHaytXUGtmeW0vNGZKYmtodkNyK3VNVzVuOVVy?= =?utf-8?B?d2dsVXh4bzdXSjVUUUVzR0Z2ZmVkVjFveUk5RDlkeEZmR3V6QzBQbjNPQ2Yr?= =?utf-8?B?R0haRkJBWDhrYUdjWlFIZXowdUxKcmtodWdEMmJZT09DMGdJa1dvMkltZ3Yz?= =?utf-8?B?ZEsxY2FOeVM4R2k2Tno2Z3hSSk00WHhRaDJlWHJkc3hSY2I5WExhQjJKWHl5?= =?utf-8?B?bkxuL0pHc0M2ZXBSaUJUSmtwZE1oL0laVWdxdkxGR2cxU0JvaGN3NHY5U05q?= =?utf-8?B?VE41U3UxaWQvUVRqUk1RQS96N1g5R25mZnJTR1c2YlpjOFFYVi9mcnJpQk9Z?= =?utf-8?B?Yit4anBrOFk2NjU4eFgxSXArdmFNRVYrd2JueTJMRCtrMHlVTGpkaFhnRkZY?= =?utf-8?B?Ym9OSXdXZXlSMDBaa081RjM0eVFsOFZJbUZ0NWp1OW1NN3VYTnlGSGdtaGU5?= =?utf-8?B?RzBya1ZRR0IvdVpvaHNBTjBNR3c1WTVGU2tvc0NML2xyc3EvK3V1UXNPcjRK?= =?utf-8?B?MjZIdjVKSXd0ZDljQ2NycVg1WkdnMjdUc2VxcmQ4bU5IcjZPN2JjcXdzclpl?= =?utf-8?B?c3FWUFVCdWM1Q3VjWGgwZnhqLzQ5cmxURFhLSHo1MU95aWd1YjdaS3JvS1R5?= =?utf-8?B?Sm96KzhIMjRGS2FHYkpIdG5qdWd1aDRwS3BkL3pCbzhiRVFOMnVFa1ZOSzJo?= =?utf-8?B?bUh0cytOazBQekdZNXhpL2trUlAwSk5YUTJUazZNckQ2SXFBV2pUWFlrMlky?= =?utf-8?B?eUV4T3FXTVFmdzF0WWIvN0czM2dsYlZFY21zdzB4Vml3b2c1RDNiOEsrK25y?= =?utf-8?B?OXNjdERZVWNiYzNLY2Y5TDYwQ0VFTC9Ed3ZsTlRDMmZsUFpUVVN1VE1wKzUy?= =?utf-8?B?YjBjaExZYzloaUtScGNpT09aU0h3OGl6cXpmYVl3TEdCaTFNTTMzR3p4Kzkz?= =?utf-8?B?a3VIci9ZaSszNjRCa3d2cG9VMjJWMzQ1aDcwQTR3cFBHNVQxWEEzUmF2RmxO?= =?utf-8?B?Y1lNVEZVeEMyY3BwMzVZdDdUNUF2ZnVFaHlaNEFxVUpQSlVEY29MbDRVL0pB?= =?utf-8?B?WEhrK282ZW9IT1hjUmd1ZHJIcDNyb3Y0aHNOczk0ZGx3SFlVRHhjVVFockpz?= =?utf-8?B?eWVzTHJhR2d1TFhCYVgzOE1peSt1b0FrTEFUSjdEaHV1ZVZGcmh5VEsxdnNl?= =?utf-8?B?SENGTHFZZmNnQjZNN0ppNTZoMW4vc2hnN2JSN3gzeUJqcFFoNXpjd2hyMkdP?= =?utf-8?B?aHV4TTQrOVROYUkySkgyNlZWK3pZaEFudDBxcjlZeWNRcVp6d2xhSk5rMFg4?= =?utf-8?B?Q1RDcjRBK0xMRGFGUVlmUkNydmxXaDlxUlgySlQyNWUwVGRTdmhMQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 379c591f-30d8-4394-aefe-08da38cb12f9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 12:36:47.6403 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5EktS9s2s8HQIDQLFe9F+9gspsYoT7pi+qqAV0wqChBi9FdGqul5jcvUidbLDvVRFfy2w+diP2nZo7xNHR2Szw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7096 X-Spam-Status: No, score=-3032.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 May 2022 12:36:53 -0000 On 09.05.2022 09:03, Potharla, Rupesh via Binutils wrote: > [Public] > > > > While working on the implementation of DW_FORM_strx forms could not print file names even after the implementation of strx forms. I found an issue with adding the file names to the file table with dwarf5 and clang. > > With dwarf5 debug line version the file index is starting with zero, but the code is expecting it to be 1 which is the case with other dwarf versions. > > From the contents of .debug_line compiled with clang and dwarf5, the file names array index is starting with zero. > > standard_opcode_lengths[DW_LNS_set_isa] = 1 > include_directories[ 0] = "/home/rupesh/addr2line" > file_names[ 0]: > name: "prog1.c" > dir_index: 0 > md5_checksum: da4ea4c312af96d39b13557acdf23f05 > > Address Line Column File ISA Discriminator Flags > ------------------ ------ ------ ------ --- ------------- ------------- > > > The below line skipping zero entry was added as part of commit 19d80e5fec548e681c453d15b4ae5b49bc080acc is ignoring the file names in the zeroth index. I have no idea why this line was added. Removing the line is working for programs compiled with clang using dwarf5. With my fix, I am not seeing any issues with GCC and dwarf5 moreover currently GCC's debug_line version is 3 even when compiled with dwarf5. > > /* Skip the first "zero entry", which is the compilation dir/file. */ > if (datai != 0) > if (!callback (table, fe.name, fe.dir, fe.time, fe.size)) > return false; > > Made code changes to fix this issue. Can you review the code changes and send in your comments/suggestions? > > Regards, > Rupesh P Much of the above wants to go ... > From 28e92539dfe5319e7bdfea32c4ee46f55ff51053 Mon Sep 17 00:00:00 2001 > From: rupothar rupesh.potharla@amd.com > Date: Mon, 9 May 2022 12:10:48 +0530 > Subject: [PATCH] bfd: Fix issues with files in debug_line table with dwarf5. > > --- ... above this marker, to become the actual commit message. > @@ -2270,10 +2273,8 @@ read_formatted_entries (struct comp_unit *unit, bfd_byte **bufp, > } > } > > - /* Skip the first "zero entry", which is the compilation dir/file. */ > - if (datai != 0) > - if (!callback (table, fe.name, fe.dir, fe.time, fe.size)) > - return false; > + if (!callback (table, fe.name, fe.dir, fe.time, fe.size)) > + return false; > } How come this change doesn't add a version check? To help being certain this is the right way of changing things, can you please add up to two testcases (readelf and/or objdump), one for a version < 5 (unless one such already exists and hence it would be visible there that you don't unduly alter handling of those older versions) and one for version 5? Jan