From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 6A04C384640E for ; Thu, 25 Apr 2024 07:54:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6A04C384640E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6A04C384640E Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1714031692; cv=pass; b=Vzzpu9UMnLPOu5c4GOzLTzxZz0DD1iblqbokXr5JCTSMMcC7y5agawfH4+19xrrZOrWYpL7svxwXxigi5yYcEfHSMnOIj5AcUcLPmQOsC1DwegM3O1W+5UHRA51T4CV1xanRHH9iDOEXY0sjy7E0YHczM7aR8lSL8nEVFhQ8LgQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1714031692; c=relaxed/simple; bh=h5ohAtn8pW/mCWbrWy/ds065wW78agN/azByRInqJz4=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:From:To: MIME-Version; b=lymc2FmGoJ9wlg6d7GxNcR142KqBOUatm4CyqbfL3hq6keOnre7s1/aeVmgKNRmPQjhP3qKUALHgjL0LXSZhGbzpTpiFQZgrmBJpZ29b1lHdqBSZttEd4amslSMUQ5bmBUnCJkFy4ZXUwudcScqemGGzhPAMnolRI32qGaUM1GE= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43P0iTK9012825; Thu, 25 Apr 2024 07:54:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : from : to : cc : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=d74IzIDkuFN2rjqoRHWCGQ7g4cG+ZdIuzyTgXlfNZ2Q=; b=FSC32yDOIuSB9uO9RgXTCJxDm7UzPPXHhemTwWKE+9+9vW8qapYTsJ9L9icLICm9cpnH hxux8TRkuTNKU+TWMMlq2qJi3qpKuebDrTNnOJ9Ed7eUpPboHa4nTRCwdeZPN9lnfAbZ ybD65yi4TVligRHd13GsYwAwfqbIZ9kftBe1XAzYpgdlPdvPQCtdYwv7q2L06bzPjlvZ eMtphz0+VwC9jajhetwEOoP6QbSmVlOg9FnJHqvXaFZqn6kTXK45V8bj0ErYYW4fWi91 2BgkqnzwSeZnilb4sUpW2ArZv+Jd1KiPXOWtALvYycCgnkn5HORUs0PS7D5zasyFOW83 Cg== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xm4mdan6b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 25 Apr 2024 07:54:47 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 43P7B3VY019700; Thu, 25 Apr 2024 07:54:46 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2169.outbound.protection.outlook.com [104.47.55.169]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3xpbf60g79-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 25 Apr 2024 07:54:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MPqO9AncbQTYk7tZMAoGwIcdBfxbmVFy5esSYp1ZmO0EH3Wne5VfW9mEEr5JfaPf0itvBzJaIyjBrQttZmSa3sLxs4D8PkyFB0W5hevf8g2Eaxr5U/LI91J7DXchtqc7oWpsoXN6F9vp1LKsX9GO9REmsgAix32zwycB8sZcNYeGCi13fJP6tRqlnIjW3oNxHqu0/ZPEpI2pzGCZoK036cQQlOXXMrMigOlXp7kth3Orcf+/nstSTSAt/HYD1yCdz6lOxCFYsQB8OB0jZHB8DkQG9w+aM3VvppicT7TwaK4kh+ZaXmO9SLJw9ksE/tN10WIDgUhpXPxoCd5lFvfksw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d74IzIDkuFN2rjqoRHWCGQ7g4cG+ZdIuzyTgXlfNZ2Q=; b=PSFybxo9nW9Jw9M4wJYTRDR4BcgL1GjvrR+wuE6s91JhplbYX1B5brMsP3gmloVHcW88Vn2Ll7uPczctQv0peC5prrvK/xuNZTiplpOC9lJWhig1uJN+Y3OSdiHqJ6NhIDmvsb1bB6UwsPnoZ342A1dHdiVakV0Z240xrSmL8ClSejfyAqwa5J8cyCHKR918sPakIehqTggHBtlUZLuH5WoWWlpBwP7duT15dbjKCxiZXJ7FTPZqz9KFVGmF4UHT9+I0X/KOOPHo6NsZNFLzGLYwkJVxTezs/bPWeetFztuSeIhxoFulw3mKrFrzoZa4yPQThl8fbV7QxCN0IyRNIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d74IzIDkuFN2rjqoRHWCGQ7g4cG+ZdIuzyTgXlfNZ2Q=; b=ZiAwW8/WmnAa9OsQtTBpiL8eTLWA+Bo6QVxzdHcaDYxieS1BDG/+2Ljz++w2oTxR0beJB2Csi9mI+f7C0s2bQcPQhnTdK5kVg3u8XX0rcZ2gBIK/WvlXnSaF2cEp7IPgHSlaXwNbF807g1+5qZihu7ZivSoQsykPrMQ7CLMUvcQ= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by CH2PR10MB4181.namprd10.prod.outlook.com (2603:10b6:610:ac::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.44; Thu, 25 Apr 2024 07:54:42 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::6f0e:742a:270:889]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::6f0e:742a:270:889%5]) with mapi id 15.20.7519.023; Thu, 25 Apr 2024 07:54:42 +0000 Message-ID: Date: Thu, 25 Apr 2024 00:54:41 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v3 0/2] s390: Initial support to generate SFrame info from CFI directives in assembler Content-Language: en-US From: Indu Bhagat To: Jens Remus , binutils@sourceware.org Cc: Andreas Krebbel References: <20240412163625.965517-1-jremus@linux.ibm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MW4PR03CA0078.namprd03.prod.outlook.com (2603:10b6:303:b6::23) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|CH2PR10MB4181:EE_ X-MS-Office365-Filtering-Correlation-Id: ff0b3771-4fe8-450d-2e43-08dc64fcf790 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: =?utf-8?B?b1R0Wk04ZUtibnJkcFV1NU9RdklLMHZnMGZsRXNydk9ZaXBpcDMzZy8wbWdO?= =?utf-8?B?OWNLeUU4RGFrSk4zVDZDMzZEaURhbjByZmxUblNhcDQzR0Z2MlBvdUxrVXBj?= =?utf-8?B?RVE5UGZTRENicVVpUFhmVWk3cUpmVjE1Sm9iQ2EyZ09lWEhjMG5qYXhjVGZW?= =?utf-8?B?andEMFIvN2NnaFNXQThwUDhCZ2VRMVJ4S2lMaVUzN3JseElQWDlrODl3MkVp?= =?utf-8?B?STlIMDM5S1VrN0k3OHZ3R2dubGZ2TmFub0JkRGVON1ZxSldpa0V2eExEY25q?= =?utf-8?B?OEZLZzZrWCtta2J1TlllcmJTbDJId1NqQ1E3elJFUnFmdzNVOXBwZDh2Y3Vm?= =?utf-8?B?WnBQVHhXTng1UVNjajgyc1g3WGptaExXeU5SaDQwR0Y5YW1JbHBQSkxjME5r?= =?utf-8?B?UXFPb2gvdHoxTjNrN0dyNEx6QkNyTHRCVXBoV3FZc0U1RkJRU3R2OEo4ZjZp?= =?utf-8?B?L0ltQm1idkdoVVNDVkovTE9pdWttTXIzZ2hlemFkZDRpOG9ocndiaHRHT081?= =?utf-8?B?aFZ0OGlKd3NiTkdSOHdqQThyNWVydHZiM1dVeXZYTXZuY2lTOG5NM3FzSENq?= =?utf-8?B?RnB2MnJtWm01Q21PenNMUVZQVnFXZi9YbWI3QXlLdDgzR25Obk1LWXdST3RX?= =?utf-8?B?dlFnTmZLV3VoMGI4TDZhdGdhMWUrVkJhR1gyZWxNUld0bkluMUdjR1ZDc1pu?= =?utf-8?B?eDdFckRDaTF0a2tKZ2YwaDZIWVhUbndvWGtRSGFRRHFFOEhnNXVqeC8rSS9a?= =?utf-8?B?dTlhR1E2Q1g2Z1ROUXJoUTNSMVJFYmZxejIzbkVZSlg1S2g1bUpraStHYmRr?= =?utf-8?B?aTUvS3RNQTkxMncrUzN0cjZXT2ZLM3VZK2FZc0t2S000WWVqeFE2NlFBZkFQ?= =?utf-8?B?djBReGdVS1hpOUhha1Rtb1B5cDkwNzFzZU0xanNXRElCanVzUGdvQlBzSlFD?= =?utf-8?B?WWpVazF6eU1ZWkpGZjZpQVNCcnRzYW1xMXZQTTd3WStxS0FyNGR5anY5eUZI?= =?utf-8?B?bmw2OFdoWjVVNEJEQUVZeHZLUkQzMWlrTTRUTVRPQWt2QjJEbHdMdzB0SkhN?= =?utf-8?B?Z2VROTExTFJYOUtWWGd1NU1sOFljakxsZ1BHQjdwd09ZSXk0dW5ORHkvemFH?= =?utf-8?B?MSs1bDFXelgrais0SSs3ZEpCV0RGaUJ4bGFYcThnd3lhL2szZkRYNXVBZ1h0?= =?utf-8?B?aFBUei9KUG9CN3EzRlYxQ3pDeVRQSjJ1VEt2WUZyVVVSU2tXVGQ5K2JlbDhl?= =?utf-8?B?UDR1cXprQmlVaFkrMkp6bXk0UHBCbWtBeUNlQVM4SnlObGkvZWo2dEN6L3JH?= =?utf-8?B?VW1ncmNqeTJ4TmZPenEzVnh1ZjIzZ3F6L1lYaXVmR2hHb1lWR2pmWVhybWxF?= =?utf-8?B?TC9zNHVxQ05YVGU4dktOKzRzeU05aWZ4VmppTHgxMFoyR0hpMFdKSmlwRHRD?= =?utf-8?B?WVN1UDN5bFJJMTBwaXd4Nm1BNmtabXlpVE9IR2QrVHhVVHYvMEpSMFF1WU8v?= =?utf-8?B?SzR0cVUrQXJzQjRoQkl1OU81dGZ5M0tzU0xUVUV3eXJHVFRZQTRyMTcvU0dt?= =?utf-8?B?cHk3ck9oSlVIcFlubDZVeHJiN21NcHl5eUpBTnl2cElmOTFQTCtCTlgrVHYv?= =?utf-8?B?TEVtY0U4ZjFGWlVKK2tYc21HblRDajZlQmhrV2l4V2JiWXZUNjJ2OCtmeDNx?= =?utf-8?B?SDJRSWNrSTlQTERIL3ZIWWFVRTZjRUhxRmZkd29qNlZ6U05UUVFQZ2xRPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(1800799015)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a0RpeUdjcHFEQVQwMzRkM3pSUExLWlNkR1locDZuektlTU93WDNYMy9lOTEz?= =?utf-8?B?RjZxUnpqTURNYnJnYW1EakRNd3BENUVnY2R0Sk9VTUp5YURreDNFNldXVnl4?= =?utf-8?B?YmRSTXdkbk53SDFMMVJyT0RhRmFYME5Cc01nWVRJY3J5dGUrT1c5b0xOa0h0?= =?utf-8?B?MGswUlpTSFo3cFYrZ0YyK1NEbjZZcmlCdHZ2M3hrRDhnMFQxUkhCWkxTUUpO?= =?utf-8?B?UXU4Q29lSEIrdjhBOC9Xb1Z5ZWxRbksvTHF2U3BhSXhGdThXa0x2SGR1RU9w?= =?utf-8?B?TmJCSVdDdnRPaFVDYjN6RmJYT3dQWmw0disxQUpJd2ZmWjZNQ2xUb3B5RlBT?= =?utf-8?B?QkFaUTg0RHRXSXY5SzZVTi9wcGZ6cmU4d1lzdXo2N1RIT3ZKSUlLTjRTcmtn?= =?utf-8?B?RnBUaUdsYk9wN3lCOWs2MWJKOG5FUHJKQTllMlhRanJGZytqb2Z4VW1PUEkv?= =?utf-8?B?MVQ3TkVBV2dWZGhRT1RRNTltUEJtdmFXTzg2U1NaUVROaFoyYThwTmlyRS9V?= =?utf-8?B?aGJRT3RBMEFTMWM5QUpnMXp1U1AyK3BJaHlaSUNadkNSSWo2amc3VjFUSElq?= =?utf-8?B?QVdUZTlhNVJNNmZaamJYeEkyanBGczMvZE9WQXBEdWRRZXB1U1UwZXpnQzFH?= =?utf-8?B?WVBjV0YwSFdKOCtvNWJGUWpUUWg5ZnFkUm5YV3JaemQ0emg2VUgxZWpMN25E?= =?utf-8?B?UWNoRDJXQWFUTGJNL0VkSU01M3RhYTNkZFpoOGRkdGNPZlZ3bWR0ZW9ubWQv?= =?utf-8?B?M3VSekdwY1BIUVdESU1YNWJrdG1DQmVhc1RvSTZFMUdqTGFicThHbE5OODha?= =?utf-8?B?VElFZjNSTm90MElsQmE1TnRLZjZOdUVRTitYSHgxaFV1KzRIV3pySFFOR0N1?= =?utf-8?B?cnNNSXQ0RkNJcFZRT0RadWdKczVHZkZPWXUrTUlyR29FQ1RLcHRDbkhEVHRj?= =?utf-8?B?Sk0zODluNmtNK21HNFpKbEpJSEZYNGxKM1FVelVDVC9jd0Vlb2JpNXJ5bU9a?= =?utf-8?B?d0lOOU9OeEhBMSt4UG1McnBQVGpISmZXdmlJMnBtWmgzaE5MZmlIaHFqOVRL?= =?utf-8?B?U1QxK3cycTJ0UmtKL0dncmlYRmpPc0lUOGlwcGVBRTMwT0dlNVRObHh0dWxE?= =?utf-8?B?RTRWWU9ycVZ4NFZvT3MzQUs4TVZNdGhEcC9zTXRQNlBmbUt6eUd1M1kxVVA1?= =?utf-8?B?TnhiYUp6S0FkZTFodWwrZSt6THlpRTk4bWRLQTYxd1V6NzRsd3llaEdwM1V1?= =?utf-8?B?NlN6bVNXZmNYNkR6dm9pMkdxZnNwYVY4U210dDk0Kyt6RGZiSlNBQ0kzbGU0?= =?utf-8?B?VkVwcm1tTmRqcVFGSFdGWHVnNjRodTNjZUxDZ1FBWFlLaGpFdVFmc0NzeE51?= =?utf-8?B?R3hSWjlxSmw1SWduR0RSNy9hVmxqTlNNcmkzS292bGhBN0htSEh0SkJIS1FT?= =?utf-8?B?am9KMzNqYWliOUNKbmg3YnQybW5DWWN5UFJVTll4OThpWnExbzRpRnp1V3Er?= =?utf-8?B?eVdwVWhZWWJ2SzFUNlB2cjgzdXhMK2tBZ1J1dkpiUDhFcHdNSy9kRjBpQWxD?= =?utf-8?B?dWpCREhrSmxwRVFPT3AxRlQzUDA3Sy8zMFVjNkVDYmN3QlBZVFo5MGFidkZu?= =?utf-8?B?UmM0bE9qeStnQXBoMzM2QmhHT2RhZWdkV0V4bkFTdlRDdEl1Z3dvalUxYUM3?= =?utf-8?B?cG4zYXZBZU42cm9WS3pqa2dLVjQwT01SakFyUnB6TUtJVU14V2ZZVGN2czEz?= =?utf-8?B?R21GSHg2OCt5M0JBY3dQbWtCWGFnRjdMUXE1YzhCRXc5MkVpQlMyNkU1cm1l?= =?utf-8?B?L2pNN3piK3pFSVo3T2dIZXRUMkgwd3VkM2Y1cGxEVTdtYlhKTW9qMzd3TjJl?= =?utf-8?B?WCtCaWkzVnU4ZmJMd3BTN3dNQ2lWMWNWOEJMZGtCV2ZkS2d1cDdGQVZWOWJq?= =?utf-8?B?dEVpaFR6QnZubnlWUkt6M2FGaXVTOEhJRElSemFpOU85czhiMklDd3FjOGFq?= =?utf-8?B?SkpIcWFlTWJBRjkvbllIM0lqemgvaDlxTjY5T2tIK3dwSUsxYzhOUlA4ekNX?= =?utf-8?B?NUIwamRRZXFZSFBDeGRDZUx0MlNSeXY4OGIvMG9PcmNmUytXVDlhcm51S2kw?= =?utf-8?B?QnBOWFNHTkwwd1h3Z0I3T3NpWkRvNm5jN1NCcUR3U0d6R1kySU5ka2hwYWU2?= =?utf-8?Q?8usqZgN5za7U4aQW/WxbWsQ=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: yeOSwwHtPdWBCYUr44/fRX56vLU5tdMwGMnx9ZBI74+t2axmgVv5V416BE/rhKaqOC55Zph32YGfGKpbXVFelGnkWaoyhQRyNyirpSP6qhOATkroPJ0fFCevQUlW/WdMmokcyn0097ayA3McY15fKQd6SbBFRi+fKq7zQqsRgNoY9eW4ylgXhDZvEVpjotF3orX/9OpQ/w+U3gwTaICwaiphj96UJBuHwKJl4K6XfGrH1MzD0QFmntXpC4ks6Bdey3oDjU1ekvzaMQbKas+m72NojkvcQPzXPbQlyVwKpplnLCxnItMD6fwpF+2d5xPS2Vqc459V0h2FuSeyq7AfFp+jEMTQx7Wx9BbU3oi6V4QEJfcqX/hIXI3TEMrSc6dIsAAPtFpKFCAosk2lwMhPvmNjoMVovC7sNDIkerbQflHKjJ522JWdQxg87FOoIQxys0dbVfdIiTvChJUSm35c3UV+RYp3bdBPjgJjykcJ4hqFKxcsO6Qx5i5kyS0PfAPYYh6t4xgFogDWaIbKPqv1Ho96tVGeqNSpy7oT/6iEKz6Vf2LfEBqzOhPIhwBJvo0QLGO2x5/eRVWRVS5e5wLNumPoNlxpG28NVJfQCZ+Fmks= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: ff0b3771-4fe8-450d-2e43-08dc64fcf790 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2024 07:54:42.8584 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yX5BF1jgMsSawsPnlTOraKwRHJGqgae7+Kcjsco2J668NNR9T9bkGq+7ECj1iIlt1utCxHYbhj3xKQFQ1EsNwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4181 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-04-25_06,2024-04-25_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999 mlxscore=0 phishscore=0 spamscore=0 adultscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404250055 X-Proofpoint-ORIG-GUID: 1CLpD-is26McJzsK1CTek_SoQCWyYDfA X-Proofpoint-GUID: 1CLpD-is26McJzsK1CTek_SoQCWyYDfA X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/22/24 17:26, Indu Bhagat wrote: > On 4/12/24 09:36, Jens Remus wrote: >> As suggested by Indu I have split my RFC V2 patch series to add initial >> support to generate SFrame information on s390x into: >> >> 1. A separate series consisting of all the generic preparatory cleanups, >>     enhancements, and fixes to the generation of SFrame information >>     in the assembler: "[PATCH v3 00/15] sframe: Enhancements to SFrame >>     info generation". >> >> 2. This RFC series on top with the actual "s390: Initial support >>     to generate SFrame info from CFI directives in assembler" >> >> Since the original patch series was at V2 I am sending both as V3. >> >> >> This patch series adds initial support to the assembler on s390x to >> generate SFrame stack trace information from CFI directives. It is >> largely based on the respective AArch64 support. >> >> Please be aware that the SFrame support for s390x provided by patches >> 1 and 2 of this series still has some open issues, which need to be >> addressed. >> Any ideas or assistance to overcome the current SFrame limitations >> listed below and in the patch description are very welcome. >> >> Patch 1 adds initial support to the assembler on s390x to generate >> SFrame stack trace information from CFI directives. Due to differences >> in the s390x ELF ABI [1] compared to the AArch64 and x68 AMD64 ELF ABIs >> and the simplified assumptions of the current SFrame format V2 there >> are several unresolved issues (see also patch description): >> >> - GCC on s390x may save the frame pointer (FP; r11) and/or return >>    address (RA; r14) registers in other registers (e.g. floating-point >>    registers) instead of saving them on the stack. SFrame currently only >>    supports FP/RA tracking on the stack. >>    GCC only does so in leaf-functions. That are functions that do not >>    call any other functions. Therefore they are guaranteed to only ever >>    be the topmost function on the call stack. >>    This is addressed by patch 2, which extends SFrame with limited >>    support to represent FP/RA saved in another register on s390x. >> >> - The s390x ELF ABI does not designate a frame pointer register number. >>    Currently GCC and clang mostly use register r11. >>    This could be addressed by designating r11 as frame-pointer register >>    in the s390x ELF ABI in a SFrame compatibility section. >> >> - GCC GCC be observed to use r14 as frame-pointer register in the stack >>    clash protector in the function prologue. This guarantees that the >>    function is toplevel on the call stack during this non-default frame- >>    pointer use. >>    This could be addressed by changing GCC to use the "default" frame- >>    pointer register r11. Another option would be to extend SFrame >>    with limited support to track a non-SP/FP CFA base register number on >>    s390x. >> >> - Glibc uses non-default frame-pointer register r12 in two instances. >>    This most likely can be addressed by chaning glibc to use the default >>    frame-pointer register r11 instead. >> >> - Glibc mcount() / fentry() use non-default return-adress register r0. >>    This cannot be changed, but the use of Linux Kernel perf together >>    with profiling can be documented as incompatible on s390x. >> >> - GCC on s390x may copy the return address (RA) from register r14 to >>    another register and even use that to return to the caller. >>    Effectively this is just a specialization of the first bullet and >>    is addressed by patch 2. >> >> - GCC may produce code and CFI where the FP is saved on the stack >>    while the RA is not. SFrame currently cannot represent this. >>    See the respective patch in my separate preparatory patch series. >>    This can be addressed by enhancing SFrame to represent this case. >>    I will send two alternative options to achieve this as RFC soon. >> > > Hi Jens, > > For this issue I have taken a look at your two proposals: >   - #R1 [RFC PATCH 0/1] sframe: Represent FP without RA on stack (padding) >   - #R2 [RFC PATCH 0/1] sframe: Represent FP without RA on stack (bitmap) > > (Thanks a lot for working out those options in detail and providing the > patches, and stats where applicable). > > I think #R1 is good in the way it keeps the changes isolated to s390 > support but it is a bit wasteful to force an offset.  The latter > indicates limitation in SFrame representation (pointing to the need to > improve and not suffer by sacrificing space). As for #R2, IMO it makes > the format less future-proof: it will only allow upto 4 offsets. > > Now an option indeed is to: > > 1. Use your #R2 approach but keep it confined to s390. > > We can use additional bits in the SFrame auxiliary header to indicate > the fact that for s390, the 4-bits in sframe_fre_info are "flags for > offsets" and not "Number of offsets". Hence keeping this limitation > confined to the s390x incarnation of the format. > > Adding additional information in the the auxiliary header area: Using > sfh_auxhdr_len to define a 32-bit area (32-bit size so that FDEs > accesses do not cause unaligned memory accesses; not sure myself yet if > unaligned accesses are OK on s390 though). > > Although I dont like the additional complexity of "adding info in the > the aux hdr to allow a different interpretation of an existing field > differently"; but I don't have a strong opinion against this. > > 2. There is an unused bit in sframe_fre_info.  We could consider using > it (for s390x) to tag those FREs where RA has not been saved on stack, > but FP is. > > I dont think this information can be encoded in SFrame FDE.  There can > be a function that does not save r14 in prologue, but does so later, > right ? If not, we also have the following: > > There are unused bits in SFrame FDE (see sfde_func_info) that can be > used to indicate that an FDE does not save RA on stack, hence the second > offset, if present, will be FP.  Then we can use it in conjunction with > "RA-tracking-enabled". > > I was thinking of suggesting to use the bit [(((sfde_func_info) >> 5) & > 0x1)] (i.e. the one currently used for Pauth key on aarch64). > > We could instead also consider using one of the upper two bits > (sfde_func_info), which are currently unused, if this feature will be > useful for other arches. > And ... 3. Similar to the padding solution, using SFrame FRE offset to store some metadata is also an option. A rough sketch provided in the other thread. (I am already of two minds about the padding solution: I initially found it wasteful, but overall it does fit well with the SFrame philosophy in that we dont lose the flexibility.) > >> Patch 2 (new) extends SFrame with limited support to represent FP/RA >> saved in another register on s390x. Functions may use this only while >> they are the toplevel function on the call stack. That is for instance >> in leaf-functions and in the function prologue and epilogue. >> >> [1] ELF ABI s390x Supplement: >>      https://github.com/IBM/s390x-abi/releases >> >> >> Changes v3 -> v2: >> - New patch as noted above and in the patch notes. >> >> Changes v1 -> v2: >> - Resolved a regression reported by Linaro-TCWG-CI on AArch64 in one of >>    the generic ld SFrame test cases. The test case contained a >>    .cfi_def_cfa directive, specifying a CFA base register number that is >>    not necessarily a SFrame SP/FP register number on all architectures. >>    This caused the changes from patch 6 to skip SFrame FDE generation on >>    AArch64 (and s390x aswell) with a warning, causing the test case to >>    fail. >> >> Thanks and regards, >> Jens > >