From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2047.outbound.protection.outlook.com [40.107.22.47]) by sourceware.org (Postfix) with ESMTPS id BDF523858D35 for ; Mon, 22 May 2023 14:47:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BDF523858D35 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VOXt8tCzhF5RCvCV8qiqVHqJqAExkRQ6IkqatXPrNXc+PHvY8dgMHSrLQ6Km6BB6E3qjKUawWGMwPVBA2NVhpJ7m785kujf37/QR+6MGhr555CfrgQgVhxENnVNabdqpVxEw5p5HrVRnATRWJTO0XNAG2yb6xYA2U1gLxttT4l9Qg7nwAGcN/jkKkfNkE8kahi5Eonyfl33dYADSug9AALN79ZzBrV6u2BuWR6HLwZtjxH0/X3ZFrmpLb44nEq4rZ0DcXZseXRLoOla1oCBVP4sSzrXVGGO1c8/DRlFtiM5Byg3QdZRtZfMDB5VoSLnMOiDw6khtCzvxXCg4FDVohw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rHODdgIR5I/SOY9DdOiYeG1CvWbhuCfsyH94qiMV+g0=; b=mpxUOeNR0ZWqHPSvp08qeF4eneMiM8eyPbNttEHnFmogTHNFvihVd7aEqXni70fYMv2T9DhxUAVuRvTNb3r1D1iDdhSp3jY72S3p2RxHaMo8gZ4IzlCoxqF2fQbBdbOLrMGxTtomXJsz4CdER+Q68ENwChmhKva9rchUqgBZwzRJrjQ1yaV/dIP+if/WEZmUCs3zcN1vJ1OIy6tCd2OYjbW1+EXKo4CxuQi39XxjGWhaHgzHRGI7VsJNRB8UtYMI+Qr+wKJEYRXYs2HwldTpvJrkPSwgMLzzU0H6WEByEj6WX7+yM50qMPHJ9GEiYudetlWnFrYi0WLDwbBo3MGgKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rHODdgIR5I/SOY9DdOiYeG1CvWbhuCfsyH94qiMV+g0=; b=0qiwN0d3oKMS0ZFlW7RI7K3dQFf6Uc0Cx3GBxpmB+u/CU40jTlORH/hvW+q0DNDZVAl2tB3jMp9R9+5eQp39KdEZbHuR+QvtQU7Jc0eLXEnyvA+0TUvnh0FPEnWcRIkJI5YSzYF1gLbkWi2y6oCSdAzDWXqm7XI70r6YYwdehnArv98nQs0ex4eS4n/1yLN9u0b1kMgA+NlpOsq514mzx6BXbLUz8g6+nGB4tz5OcbY/iAeNyooOhpec6aJtNOeBmOOGuM7Ik4gTByd5bvoerGEa03vrXcLmK6b2wnY6Wuey1DGkNnvavAtj4X1F5HsZ1ExzDFM6eyJMK+ISZEJUEA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8139.eurprd04.prod.outlook.com (2603:10a6:10:248::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Mon, 22 May 2023 14:47:00 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c%5]) with mapi id 15.20.6411.027; Mon, 22 May 2023 14:47:00 +0000 Message-ID: Date: Mon, 22 May 2023 16:46:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v3] Support Intel FRED LKGS Content-Language: en-US To: "Zhang, Jun" Cc: hjl.tools@gmail.com, binutils@sourceware.org References: <20230522142036.199490-1-jun.zhang@intel.com> From: Jan Beulich In-Reply-To: <20230522142036.199490-1-jun.zhang@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0227.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b2::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8139:EE_ X-MS-Office365-Filtering-Correlation-Id: af84f229-8850-4c16-2b5e-08db5ad36616 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C5JsYKrSi4FASruBeJx1ZkNlAegVMRtK6OsKP5HXBm+2BoctmD7FtoDbGXMQpPlgRwfM2hJ187RXoFjScjf6o/uAX92rpJkjOnMR7iSqIhqjGdqstUR0KjRQxJ4NFinyMxqwKD4smS0Zotb+xV+iF6sRKhVC/q3bdlCnPu80ESqen+91utSOVXdLeViOPbsSt0TKsHyBjVF6f3Nn6ma8q20mVx4+WVAiEzQM2SA2x3u+Qh70ZZs2BqOICe8LcducyfV8ejcPNXa8uPWZxdpbr5ydSIpXxw2aaZKh/So37+p49eZ886SDox8kCnKrHO/GIh/jmdu0oiL6tTMT9L0qWN6Hec2JYgmM2mH8Dc+BU3G9oI1Gr8/SpF9F3A7ht9qEzaBdkyk/NxWO6HgYsEyz6a+LNIX9HudnkOqaZckClXO3D8PF3ORwRXoTydEYUhEGCmuHtfVgZA6QE03U3riqj/gc4HudZWdKwWEIcN0IvJG1dZlqU+KrDq4CLU1Pw2wMT5YHjvBWTEsuwlSHYQPJuZqvatPvy5c0Og3KNhiJVRb9F+uE/sUsE+4cLCBIaQm3Is4AiCqFo8U1X3kOpmqJStGo4RawUd3aKW8ANuYXtq7Tcs8IV2Mtq9zhfG2P4PJbqTav80pc1fKg61vv2snhOg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(396003)(366004)(136003)(346002)(376002)(451199021)(66899021)(38100700002)(31696002)(86362001)(36756003)(53546011)(6512007)(6506007)(8936002)(8676002)(2616005)(2906002)(186003)(31686004)(478600001)(41300700001)(316002)(4326008)(6916009)(26005)(5660300002)(6486002)(66476007)(66556008)(66946007)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0hDY0N2MkJtOTJVU2RNWC9oaU55Kzd5b3IzRkRCb2lyek5YUU8zZW55Tnd4?= =?utf-8?B?TEI1ODNybXRXYTlLYmhRclM0Vkk1a1NyaHBiWGJsTWd0b3NPemFNNTI1eVg0?= =?utf-8?B?VHJsYVRWellPemhJS0NyNDFGU0Q3cGF0bFZTYThpdWNlUE93TjB1RUI2a0V2?= =?utf-8?B?RUJaajRMYk1Ba2ZscUV2YWFGai9NODdGbFpibiswdDBQeUwxMStNM01mMzRS?= =?utf-8?B?UEErRnlteXQ3RE9uZkR2THN6WWNGbUZWV1lrSC93bGRQU0czVWFoNTNPRkdo?= =?utf-8?B?dTZkb2M0ZlBiQmNZY2JrWEN3ZnZZblROdEJNTW0xcFprRXpzbm54aTV0ZlpS?= =?utf-8?B?Q2hvOGw3ZTVIVkgvZFFBQWhkd2hvbGNsVTFKWHplZVFVRnl1enpFMHVDQ00y?= =?utf-8?B?OEF4WlhwNGpoRWc0VzFvdDNrajR6d2dUd3h3cUxZR2s0a204YlM3QlNCYVZB?= =?utf-8?B?YmNqb2F6bHRhZ281Rjlyb3BiendISVF2OXF3cllldjl1dE9USjlKY1FaSnpx?= =?utf-8?B?cERyenpKTE9hQVFTUW9NQWpXSWxqUGl3NzBXRFFRbGVjY0lyZmFDUi80UURH?= =?utf-8?B?aFZkQkVKN1lxU3JTRDRNUDFWNGVHOHgyNjJDbUxZKzFWWVJUNXg4OGtUUzR0?= =?utf-8?B?Nm9QNjBOMWo3T3V5WU1LcUd6ckowcUN4NW5WdUd2TFlKbG5CQUcwTzRhQUc2?= =?utf-8?B?am9wQUdCeEFTRXJueGlJYWMrUDVsVExnWW9pMkh5Qld6Rml0c1VMQnNYcjdE?= =?utf-8?B?L01kU0pPdlBpdDczMWRESkUwVHFsZDlWVGlSaW44eWcybzkzWGc3RUFEV01H?= =?utf-8?B?WHBHVWtUS0V3SlllaUY0cnFNbWJPWGZBYlZqUjkrQi9FR3gwZ09hd2xCZGxp?= =?utf-8?B?TFAzbVNRa25RL2JjcGkxUDM3L3F3RUgyMnJPWEZwa0JrU1dUejJaRjh2U1BZ?= =?utf-8?B?RWtxR3NaNHN1aVNZZFdRTjdCdDVmZ1ZnQTltQmRoRjF4NkNYQ1dNYzBzcGgr?= =?utf-8?B?T2lqcHhwWFgzMUszdVkrNGxnbzlBVENKcmt5eWdEemVuNk15d2VWUU1wVWg4?= =?utf-8?B?VEVJL1hwb2pKYnhaNWZSR0pUemMyc01FNG16emFSWXRKWk95TXlxTnlvM1Bi?= =?utf-8?B?bnlqZ0NhMTlGd3ZqbWc5S1I0bEw4cjh5MHA4UDVObTZXenE1MTJseHg4bEpE?= =?utf-8?B?eEg1OXJuSmhzeHJXU2FjZkoxMWlTTjlFOTZQRERvZDgzZnZGanhUdk5qQzMx?= =?utf-8?B?cWpXM2Z6T0U2bUxvd0ZXSUxFVnZ3TW5pcE5yVExPNEhnYUkyZEVBUE9XcnY4?= =?utf-8?B?Y1RZZ0pTTUdWODZmZFYxcWNLN1V5ZE00a2sxMDhmZjVzOGJGd2lSVDZNOVg1?= =?utf-8?B?cS9hSkJFYWtRUCtKMDBPaWpLcXp6QjhPZWlWQzE2ZVdwUUp5RXZNWEg3RDVW?= =?utf-8?B?UFN0QTNlaTlQaEd1UUhYSWZYZzJsK1BXNmpFOE50OFhZZEFNV1AvRkhack5x?= =?utf-8?B?bmNEOEVvT2c3ZTlnYVp0OTJuOWpFT2xSYm03RFBMeU1lbnRpU2VpWEZvd2pW?= =?utf-8?B?MWNHRklyRURIVnFwRW93Mml3Znd4ZXM2UjFSK3Q0VVV3bVhsa3J2R3Zoekc5?= =?utf-8?B?L1BtWmNRUWh5Y0VESVkreWhUT3U4dXgrMEJ5VXFldStHdkFIWVVKaVVaL1Bh?= =?utf-8?B?aEIxV292VFdlWVdIeEhkKzIxZFNtQ2YwWVJWaUk3aDIyZG94M1ZZM1lMMnRx?= =?utf-8?B?Uk1BMDNQV2VhcVB0STUrZDlRc0ZLdE91TVdXUElPZEtSdmZKMkgvaG93Z2N4?= =?utf-8?B?M0pTaE81Ynh0QVpEWmdPaUFWUHBHbnZlUlNCVEMvK1hqdDVOMVBvTUFsbHJH?= =?utf-8?B?NHhjWlhFN25VcDllS3ZTMGlydEsycTNTYUlkYjZ3VW9iRVpEVFZlS2VOMmVY?= =?utf-8?B?WW0yM1BQYzU4R1BZcWVWZzhkelJlRTRzV2lDSFl6SXZSTXp6dHRiK0IzS0w0?= =?utf-8?B?dDBRVFU4SnVpYmo5VFNqRDVBcUFSbXFhWExGa1c4akRCdzM4VEFiVmY1MGhx?= =?utf-8?B?Z0Z5Q24rckpFSDhTMnJESE5RQlRyMFRMdEZYRTd0YVBwNzg5UnlnSHZNbEJl?= =?utf-8?Q?P3Hf/dWsHtM7TqWcoVccXSeJ0?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: af84f229-8850-4c16-2b5e-08db5ad36616 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2023 14:47:00.1582 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Bi5KY1pt5q5L3Cholsn7X8b7zdRGhztTo/aruaB+YhHNszNJ+F0xrEC051GB+KUPv1o3d70PVzNdhHdt4XG+rg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8139 X-Spam-Status: No, score=-3027.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 22.05.2023 16:20, Zhang, Jun wrote: > This patch is the third version about Intel FRED and LKGS instructions. > please help to review. > > Jan,I am new comer, this is my first patch for binutils. > Maybe we need senior engineer to fix Ew. Well, okay, I'll try to deal with that myself then. What I'm puzzled by though is what this v3 is intended to change / correct comparing to v2. The one small request about ... > --- a/opcodes/i386-opc.tbl > +++ b/opcodes/i386-opc.tbl > @@ -3351,3 +3351,17 @@ aor, 0xf20f38fc, RAO_INT, Modrm|IgnoreSize|CheckOperandSize|NoSuf, { Reg32|Reg64 > axor, 0xf30f38fc, RAO_INT, Modrm|IgnoreSize|CheckOperandSize|NoSuf, { Reg32|Reg64, Dword|Qword|Unspecified|BaseIndex } > > // RAO-INT instructions end. > + > +// LKGS instructions. ... using singular here and ... > +lkgs, 0xf20f00/6, LKGS|x64, Modrm|IgnoreSize|No_bSuf|No_sSuf|NoRex64, { Reg16|Reg32|Reg64 } > +lkgs, 0xf20f00/6, LKGS|x64, Modrm|IgnoreSize|No_bSuf|No_lSuf|No_sSuf|No_qSuf, { Word|Unspecified|BaseIndex } > + > +// LKGS instructions end. ... here was not fulfilled, in any event. Plus that wouldn't require re-posting, but simply correcting before/while committing. In case you don't have commit access (you didn't say so, though) I'm sure H.J. or I could make this small adjustment while committing for you. But you'd need to let us know ... Jan