From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id D347E385DDCC for ; Fri, 12 Jul 2024 15:03:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D347E385DDCC Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D347E385DDCC Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1720796637; cv=pass; b=fq8aeF974rB+dfccfApxsDV1KEXm+mwZFNv0+rbOUCBbN0yHmsdq3DFyOnOc5unNBO5bk8eorbYZ/7Kgv+zDkyfifgNtWpVX9HFV+bFc0R3Cr3qUXHEpvlVsTZOY8Y+eHAZniq1H2FcGpc5roaipRuCdwmTFnXpx0ggDrczNAJY= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1720796637; c=relaxed/simple; bh=sFnGOE4HYcPC60uMOjXJHk/ho5899ItNqkeZADvwWao=; h=DKIM-Signature:DKIM-Signature:Subject:To:From:Message-ID:Date: MIME-Version; b=enq5yuUUlSEBYRpJufqMWoq2Br9x29tJevufssRH4qsWTZUnXlvxNgRJhT+Us1y6dLMOxcPKa/gJbpqkcnoLJ4ZNDuvB3wGkCh0RrnQZMAerYY4L/nfqJC2ZwmEmf1qxxSZnYVasoK51uys1JnwTxME75DwRDFrmWi9cIjeHUtk= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 46CDJ9dj021855 for ; Fri, 12 Jul 2024 15:03:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= subject:to:references:from:message-id:date:in-reply-to :content-type:content-transfer-encoding:mime-version; s= corp-2023-11-20; bh=ed6Wk2R8knxi8sDXxEV5ZUznqXLmschG5LgjP7nvIWA=; b= F/xoyONIpwFwSTg+HjChAbBNnPfr11owKaY35MmJQE/+YVpNrRz0R6DDfvzHNyhV h/uX27mLjOqcy1UgG9Tvupf7mlwgqA0UfwYcYLHoZ3Fd7ZsY1hCX0iRG8aqdl3sZ oeko4qmkXy0+2ltpitIBir5n3kLUNOsWUNj+f0m38etLmMsHNJ27XnNVE0MV1ZU5 k/RcbY9W99UiFw2Z2z4JJkuUy1rX0/Z7N6t78nmGxIXW1j8TDo+kQ6Zudy1OqqMU jN6TWt3Qe/+fPljG7jJfD8Pcmk2460K4MhYJCgjclNWNPdLH0CtikEKdhOJUxypK +gM2yE6huM176ZAt1YDKpQ== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 406wt8m1wt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 12 Jul 2024 15:03:53 +0000 (GMT) Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 46CDi19T008987 for ; Fri, 12 Jul 2024 15:03:53 GMT Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04lp2041.outbound.protection.outlook.com [104.47.73.41]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 409vv62tft-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 12 Jul 2024 15:03:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HoUyjipnuQVfPiKZ5INCp+PNXZiwI0EK2N1R/JcnhIWAbKjatvi4MkGrFEpsQTkSf/UitYRq8nNtthROY1lhpPNR9PraPtv7Kf62CPNw3zMO3UJm1rh7jEAXJJrvw7xUYxaXZO+VpU4Uxwj1ello/Iq/W6S2wdRyWO5lJbOtzl4rXeqqDgTFu3StTkXm5mtupkiKTi/ByZ17myyCnbmAxx1y4qkAjlrfpET+5ctj87agtb4Z7QKqng4WV9O1KeUzXMEW1qnCV02cPaN3c+w9hWJJP8LSs38YpRlOpBqpz/6NaqXOZNyVDo57IjNPT7rAqbK3NLuv8JBTyxjmUPFmpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ed6Wk2R8knxi8sDXxEV5ZUznqXLmschG5LgjP7nvIWA=; b=ZeFinbV3lW07lYP3OKmXXSz3DylBcqe7s0AIgxHKXlDUt4Jr+j7aaPoWu6ArlnnPoVSABhN/SQ1OuG/6jj+fyaQPZyobu4sCFmKhhDv/4oLTOzERP+jUO8mnxe0iy6Ts8Exqr9cdsLh07Wqbjfov1IVpbAY8RINInWCGOPw8wm3m2qUyo7bOeq4hMFeNSWeGjoqFqTL+dsIyIoqjKrzh0kmhxdZwZj4P/c+M8eg8a7Yx2b6K0C1h9p9PoRyvnpwVS99ZM4BgXBRg0pA3RGxTI7+uyRMrtJmdR8ekeEI0dnf4SpEhbhlhXjkKU5qoTNJzQwXhNSnZBdZTBD47mM5oqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ed6Wk2R8knxi8sDXxEV5ZUznqXLmschG5LgjP7nvIWA=; b=JzO5w6hqdkLmurJZxs8CC8iLmHCpNB47vNKeEneQeGZS+jot0I8Y/oR6rUYXefd9G60m//u61hyu7fBnEr03EBa3PYZIDnep955FfCl25B6TnqG6z3msPWuaYDV0VOP5o9exblPGk4W916mh7XMO01OGG42n8PTQsdflG3KmoL0= Received: from BN6PR1001MB2180.namprd10.prod.outlook.com (2603:10b6:405:32::23) by BY5PR10MB4114.namprd10.prod.outlook.com (2603:10b6:a03:211::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.22; Fri, 12 Jul 2024 15:03:50 +0000 Received: from BN6PR1001MB2180.namprd10.prod.outlook.com ([fe80::34e:408e:c7a1:2446]) by BN6PR1001MB2180.namprd10.prod.outlook.com ([fe80::34e:408e:c7a1:2446%4]) with mapi id 15.20.7762.020; Fri, 12 Jul 2024 15:03:50 +0000 Subject: Re: [PATCH, V4 1/8] gas: scfi: make scfi_state_restore_reg function more precise To: binutils@sourceware.org References: <20240701025404.3361349-1-indu.bhagat@oracle.com> <20240701025404.3361349-2-indu.bhagat@oracle.com> From: Indu Bhagat Message-ID: Date: Fri, 12 Jul 2024 08:03:47 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 In-Reply-To: <20240701025404.3361349-2-indu.bhagat@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW2PR2101CA0017.namprd21.prod.outlook.com (2603:10b6:302:1::30) To BN6PR1001MB2180.namprd10.prod.outlook.com (2603:10b6:405:32::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR1001MB2180:EE_|BY5PR10MB4114:EE_ X-MS-Office365-Filtering-Correlation-Id: d3ee7b71-13f4-4da5-73ba-08dca283d67e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Vy9xejVkZWRqQlVqdTV4ZWYzMVpQM25pbjJ6Vk5hYlMrUzl0RnJIQ3grQ21B?= =?utf-8?B?bDVkbEkrbklyUkZTblBodlFJb01RVmZKdXR2dVRvWGxIM0xRMWVtWDlFNjRF?= =?utf-8?B?dGxLOWcvRUplM0VjWFVSTEZyam1id0JjK0g0WEhaclhUTDQvTEVMUGFqbEZ3?= =?utf-8?B?TVZQYlpLeERrU29QUVN6Zmw4TU5UTmwxYVJxTEVPUHBrRnJ0NEdXQVdRZEV6?= =?utf-8?B?RHlqbmwveUF4WjQ0d1QvNHVpcW5TZDI5dEQ2SnRreTJPcnprUDlBd0ZVbi9n?= =?utf-8?B?R2h2Z0cwUi9iMTJvZS9XTFliRWlMZjgyR1BBZys2anpXNUthUHpjMDZOUXFE?= =?utf-8?B?T3hTRUQ4UkNOM2kwTkdNTGFJa3E5KzRub0tMZ1cvaTJnOVlCQWdiVjhzM0hS?= =?utf-8?B?MS9PREMvUThEVkJLMEhHS2pMVzBTL0Raa1AxTXZRUUxLZ2RQc1g0MklXNGVv?= =?utf-8?B?ZWVSZmNaZGNETjQwTWh0M2ZMMWRlL2QvVDFNRWVWS1QxcXhzSGhyQjhYQnJZ?= =?utf-8?B?aURva1hYMk5td01zdUpiZW5KY3BQZEhXWnRwRWlqMHpUTEdNM2FNcVpaVWhQ?= =?utf-8?B?UFA0bFVxVnpHTGcrbTE4SHo2eDJQZDRPdzZoblF3OXBzV0VJRmU1YWx4ajNx?= =?utf-8?B?TC9uSDk2MDNiM3RESzFzc1NLWE0xNGtVaVVtR3gyQnd1THhPdEhET0doZmdN?= =?utf-8?B?T0RPSWZpS0JrWFpQL1NMaGtEdkFRNnZobW9VcnVXWW9PSi9CVGlFL0tqeTFn?= =?utf-8?B?WTBmVXVOcTludlQzNkhCUjN6YmZYWXErUkZ4ZkJrQ2JESFpUVWxWclJadEZZ?= =?utf-8?B?d3RjQ2RjMm91ZjdKM1plTFNBQm0xVzY0Sm5SVy9kU3NtOThvWmJVQVRCbHNh?= =?utf-8?B?b1lzNjNON01vUTAvdlJlWFVzQWpOQTNLbXl3RGw3VWVaYk5tK3dOQUhkdlVa?= =?utf-8?B?WldkZnNOMFVMcm1sbEduVmJZZyt5aE8zREgxN3FkK3M4MXQwMTN6UlJaSlYr?= =?utf-8?B?RXo1dEw2N21DTmVFaWh0MGt5Z0NOSXhoL3k5OXNGMFpGUWFyM1BnV0o0Zkcz?= =?utf-8?B?ZkNtSnBpc1RkT0ppNHJ2aThPa0xTMzhTL3oybVpwNWJrVVlKbUR2MzNLaG95?= =?utf-8?B?Y3B2eXNNRFZoTVZyMlA4Y1lsUmVTdERWWUpjUFhUeEI4c21XQmdvaEE0WjNO?= =?utf-8?B?VlBCZVJ6UHllRFBaMlMvU2xRTjFrWk1ldmorSzByVi9nRXJjeXNnQmw0TjAv?= =?utf-8?B?ZDRKK0VsUityUGZBUkNEcm5VdDdwQjVKSDJCMDBqeTJqOURnZm5kUkY4Rmdo?= =?utf-8?B?R2pwaFZPbjdqZ1c0TmlUNitpbFhpMWZROHZKc3I2NjZsSG8wdHpWaUxFWkJJ?= =?utf-8?B?aWR1bVhQNlBjNkVRUVpHaEJhQkpnQ3Q2TjZvQzNXV2Vvejh4SWtxc1A5WGp3?= =?utf-8?B?aFljODhDdEpveG15SjFid0FXQVgybHdTM2hNTDIvcHNTS2E0TU5objI5b0Fl?= =?utf-8?B?VXdwMTArV2tEUTNjODViNmkzMjllZUkxZ0FxM0oxaXcyeFl0Rml0K2gzR1RO?= =?utf-8?B?SlpIdk9wYVdRQnFHQzZyNHNXbnRWUzVXN3NhMjAraW5xQlI0UGE0d09UaStZ?= =?utf-8?B?ZXEyWVV5anVVbU9OZTBZR0dvVXYvWUlPUFByU3JockZxUmpOOFFadDg4UmdZ?= =?utf-8?B?SllCMDZiSzJaSkZscTFwK2J3UHAwK1hIUFRSWHRCcGg3VzBNUnVyVjNFSVI1?= =?utf-8?B?bzdVVW5nOE5IdzI5T1R2bm5yZVVzelh4Z0F0cjRBZ3FVYnd6Y1F0Mm5Gb0cy?= =?utf-8?B?UUFGUXVVMUVaRFdZNUVsQT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR1001MB2180.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmtuWVhyZ2pIMTRiMW1xU0QzQjhISVk2S2F5UllTTTRrRTIvUzJaYklHT01a?= =?utf-8?B?Y1B3Wk05dFF1L0d3VnNnWkx1N21yK1ZHTWRPcDBobUd6aEUxNFllYzBXd3VS?= =?utf-8?B?Z3ZMWHBJRnhFSnptU3NqRWxlNElRdDBPMGdjTGJnaFBuYVB5SjgrNUR2bmNS?= =?utf-8?B?elA5b3Q2Qy9Qc09nbFJOR1g3UjlDWXVrY2xRY3J6V2czd05CV0hTeW5GNkV0?= =?utf-8?B?ZVpET0U5VXJOVnpHS3dLRXdaWVhOSzg4aVpOMWRmTGVrMDhnYzUxWU1lNjlT?= =?utf-8?B?bmFRSXliRXFCdmlIazR4OE80ZjBGSHppTHhEQzZXTjRUUEhWdnZZa0dBUmt3?= =?utf-8?B?TVROWUxNRDVSRy9BV2ZTWWU4YmhSSmF4S2RjRDFLcW0razNNWEJtNE53OGIx?= =?utf-8?B?bGxlVzJPS1ZiMkhFeFczZlVvcUxRdUhQK2IwSG5vc2FPM1dkcHVTREwvdjVP?= =?utf-8?B?V3c5MzlOdnNzdWxIQnMxUTRramlhZXNTWFAzTk1jUG9xVDVaL0hiWTlndzRa?= =?utf-8?B?YzNYaXN6bzd4c0thQmtFTkRBMFNicUMyL2Vua1g0ZlBPbjFEQ2E5ekx3Wko5?= =?utf-8?B?MWR3OVRhLzFDckFmWjZOWjFveU5LSGJDMjdPM0ZnQjBreHFOUGFKZWFFOFl4?= =?utf-8?B?Z2M1WXJKbUdPOXcyRzNZbkhwWHpMd0hNRmVLNWZYK3JWR2FjSFpDOGEycXlZ?= =?utf-8?B?VVVmU1VYNldHZ2VweGRIR0VHL1Yxd1liS1RlaHNMV3Jwd0Zyd1VXS0svVFF1?= =?utf-8?B?eUladUQrejVQOCs5RndOd21Cc241b0k1TkpJaW1PSEJyNmp2M0g4a0J0Z3RK?= =?utf-8?B?ZGdLOWtCd1hyUkVhVnllN3Y5ZUVoSVRYVHkwSUhPQW4ycTZyMzFHRXdudlRh?= =?utf-8?B?TUpqMXl1SE5NK3YzR0VDekRQWjI3T08wZSsvUXBEdHBXZGJtbG0yOVdRSk1a?= =?utf-8?B?N3JObTVXeE10RTlWVzNHYnloYzh1MmxkWXZnZnJucmppdUFadzZKdUFhWU0x?= =?utf-8?B?ZTJ6Mnlsa3Q4Qi9ucmxUc2hCSWs1QkQ4bnIxOGNwaDFaRk5BN3JBbmoyV1J0?= =?utf-8?B?NFphcXgydW9zbEx0ZzdGb2ErdklERGY0OU55bDRLY0ZUQjVEQS9weklBSUxS?= =?utf-8?B?MExreGQrYmRUR01KbEJraTNlM2F3YTl2SC9XbmFZNCtpejY2MnVtaDh5Z2dC?= =?utf-8?B?THRyQVFoMWEwc1Z6WEFZeGJ3bjFaS1FKaERTSDVnbGNZZjdwb0FhQ1ExYXF1?= =?utf-8?B?NVNROHZJTUNMWEFzb3hUREEzelJLK2p4WjkxWkR0N05TOFFGeEtRMmx1alZO?= =?utf-8?B?L2Y4cjY3cGVZcVFKWFpFSTNnTUQxVUo4MFh6eW03Z1drMlVmak1EcU8wQlky?= =?utf-8?B?NWxlSE8zMnFzZDhTWElGMnE3WmxJbVlTVFJzbGpMYkJSQU1jV2pZcmdEcVFS?= =?utf-8?B?MFpkZ2lzNlFhK0FwS3J5Z3lUZHFCMW5JbTEyUXFNN2FOWExLOFlSOW55TmlC?= =?utf-8?B?OFRUOXNqbW1YbVNJT1VmVDZRN1pGYldSWXhIRXRBZVgyZ1Q4RndqS2FiUlY1?= =?utf-8?B?SWRCSkc2ZlFoMFhBcGRvaCtYRHpocVlHYXJkUkNwODgwUmYxZzVjS3FmL2tz?= =?utf-8?B?QWNsOC9DN0l0bnZsbmZvVFBmWHpIblExYmoxdW14UHVxVXZPemUxSUZxdUFX?= =?utf-8?B?WmhacGgvSUZjT2U0Tll2bllTclJjMkRnemgvb1RydUZWUUJlQ3FlalhtZUQw?= =?utf-8?B?RmVWNytwRHZ6djVRVVhMZmFhdHJsZkRtcnNVVi9rRk1ha1FmbHh5M1I4aTRB?= =?utf-8?B?cCtrMUR3Y1JUemlhNlM0MnBUTzVtSWVMT3pEQnRHbk9HUW80NmxFWi94N0Ft?= =?utf-8?B?K1Z3ZXNwcnlnYVRiRG1POHVPWVZqYS84TUdEaUJlRXVHVEhPK3RuRFVLY2tX?= =?utf-8?B?Nk1HL1ErT1A3ZDczdUdXdUtHNU80RzhHejd3S0tIOTZySjM3RUdZM2FZaTgw?= =?utf-8?B?U1orSnNSdU9ONUpqcDh3bU9lWmsvZkYxazI2L2ZXdFlyZk1XOFVpS1ZNekZJ?= =?utf-8?B?Ym93M3dMUldZbFBMYXhla3RPemFpdUh0Y0cvbWFpc1NqMnpIR1RyV1JVRWlK?= =?utf-8?B?MGVRUWRyOC9LN0pHZThQZVRGRHZwejg5aUFrNWNHd0NKM2g0ZVZrSUVSNXlF?= =?utf-8?Q?Oh6+KPIFIluy6FzgDsP642E=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: QxvsOkbh3GtLXw6wlRCWta7O1RlUpwwEdlX7DdZuf3XoutRMspkfPwCakBGey6rqm9bZyxGUTu6RmnoawC7fRXBzfBKiHa6wAPuTKEL7JKwWmiuk74RocyFDC9BTCQZ5m7OWVaMGx8cCioD9v49gEyWujy3x6dx1FZjQ3v7T1pBuLtAAxIp72LNz4mnJZC0wH4pDInD7Sqo4g0/wPyEh5Y81olYbzz6eNZOCvoes1KmOciaKJyQ1DVsJX0LnRWqRfQrCaD4UJrQg46ZMvjbBI76utt+s0vCjz37U8Maymzj5+3i/yxictFEvFoug0qDkTB6XqecGoWmxj1zvlBc1+9Sqn0FLQRK2rq2hr5jJaHQrefu2watET7x7GilO+E6Jh82ILPMJgedq8nP8ObyFlauPXPl7X9fnv11AX1HTWZD0SiVRo9mP7/6RKYw9gyC+HVecxKJZLfXwr6QaB+60wczJS2bQtgEx4T7DeuxSDEgwvMuf/rlApfgyQSLncn46rWv1loBkMUExsJuByja+GYT/ozAFQfLgiXx+vD5o0cVd/bL2ijWky2tnyXNxycw5ugFEqPbp3xVhEZXoDfei/U6Kyg25r5m/H2qHzhBBO+k= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3ee7b71-13f4-4da5-73ba-08dca283d67e X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2180.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2024 15:03:50.4128 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hn4hC11jYglnEGTzqDkYkPvFxgarWfsPXrJFZCeJi9dCDnpfR2RoqNF57H0gdXeHtE+rwDdP1+1xIv/zV9nLjw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4114 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-12_11,2024-07-11_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=730 bulkscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2406180000 definitions=main-2407120102 X-Proofpoint-GUID: I7jcdW3TOo6lJ2dOzCjiA58iwQf3rrfd X-Proofpoint-ORIG-GUID: I7jcdW3TOo6lJ2dOzCjiA58iwQf3rrfd X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: [PING] On 6/30/24 7:53 PM, Indu Bhagat wrote: > [No changes in V3, V4] > PS: This patch needs a global maintainer review/approval. > > [New in V2] > - This patch is orthogonal to aarch64 support. It is included here > because the testcase added for it is aarch64 specific. It is a > bugfix really. > [End of New in V2] > > When the SCFI machinery detects that a register has been restored from > stack, it makes some state changes in the SCFI state object. > > Prior to the patch, scfi_state_restore_reg () was setting a value of > (reg, CFI_IN_REG) for (base, state) respectively. This was causing > issues in the cmp_scfi_state () function: > - The default state of all (callee-saved) regs at the beginning of > function is set to (0, CFI_UNDEFINED). > - If a register is saved and restored on some control path, the state > of reg is (reg, CFI_IN_REG) on that path. > - On another control path where the register was perhaps not > used (or saved/restored on stack) remains (0, CFI_UNDEFINED). > - The two states should be treated equal, however, at the point in > program after the register has been restored. > > Fix this by resetting the state to (0, CFI_UNDEFINED) in > scfi_state_restore_reg (). > > A testcase (scfi-cfg-4.s) for this is added in a subsequent commit. > > gas/ > * scfi.c (scfi_state_restore_reg): Reset to 0, CFI_UNDEFINED > for base, state. > --- > gas/scfi.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/gas/scfi.c b/gas/scfi.c > index 744822d8102..5898a57b330 100644 > --- a/gas/scfi.c > +++ b/gas/scfi.c > @@ -223,11 +223,12 @@ scfi_state_restore_reg (scfi_stateS *state, unsigned int reg) > gas_assert (state->regs[reg].state == CFI_ON_STACK); > gas_assert (state->regs[reg].base == REG_CFA); > > - state->regs[reg].base = reg; > + /* PS: the register may still be on stack much after the restore. Reset the > + SCFI state to CFI_UNDEFINED, however, to indicate that the most updated > + source of value is register itself from here onwards. */ > + state->regs[reg].base = 0; > state->regs[reg].offset = 0; > - /* PS: the register may still be on stack much after the restore, but the > - SCFI state keeps the state as 'in register'. */ > - state->regs[reg].state = CFI_IN_REG; > + state->regs[reg].state = CFI_UNDEFINED; > } > > /* Identify if the given GAS instruction GINSN saves a register >