From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2060.outbound.protection.outlook.com [40.107.104.60]) by sourceware.org (Postfix) with ESMTPS id D90D63858413 for ; Tue, 29 Nov 2022 10:38:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D90D63858413 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kwELd8aTxM524GLaAU1efs/Y0NfMhaF/W7P+fjbf4bgmQ4NoUy/KXF/Ct6HfQSFav6tI4iUVy27TtLrzjVuPT3a/ccHFnXQOFAmerXPpymmFP74aGbt3JQMftCx7UmSLJlJYdPTVCvBB4hH159wXv+y+2qjZIxFVgBnJKQSGprgodsJaBnbIf2Xydf2qaGvikAyKVHWC7EFnNFk/+C/Re+Jd8kZ3Lw1iOchrIISngXxJ1PCwYXKQoM+ouGWAilY+UNM9NHKw7YRXNMdAaojhYpOLT09dsaZq6EkJCZT47fyjKnyek3ExD2n94jUURt3Uiv1FaSWYYy0cgyzAK2JWhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nzzFLhs+MA/7tszi9W44piEEKFO0StqsG1rWw1vfmrY=; b=F0dwjs56H3+xetFCztJsihV3Z0swJJz7mgYlJQHMUEXiEGTxeMquihX+S6tDgB+b1XPcFMgVLjW0bPhhyaxF3GSFdKOeY/NuS4kbMQZlbHqGfoQ2xLSdwYlq+e+k3e2RayMI1Uxtom1hiENDrjAt0sqpMzP+J6JPwMFf995oT2UDnD8hxfVUTVJz1Ar0meIZotBDoPtErcAaXpL1oOaFvQJ5a0E4pb4m1t83I/rncsPy8KKzeSw11fOc6BG64256EfCqq1L19nBqTU+kpI9bXnS/qUI0q+TCHq1pWrHffcc/CvlQoc1JQA0BO0mu8nWwp7/H2kUoPPyHho+LX1mcvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nzzFLhs+MA/7tszi9W44piEEKFO0StqsG1rWw1vfmrY=; b=pefwQttGbneGnAWxK8pA6FQaitY7WkqP1pLEnS5IMctLtfc2fBE8B3j1LW3niQ3j13b2ElcZT6kG8kkJ2kZpwPrxGuzox1Mi/x4j0jq14GDpT3riY+OSMhrX96q/yicS6q7BmcWfe04wTwheNat8sM+W8W447DRKYJTpljcTERKtighQGdLTrwIAgAcjWY/h4SMi64k5Qrr65I9NF1jwwE3Jm2ZbDWyKc+X+SSgTUH5dkc3uwxCL/zJUVaO9tZ0CLcPtQsw82WGHT/CyHeluxPArbjk0bL+Uyd40/iWoQYT2UC6Ic278MqqnZV3FJ3jY3/ZEPzprxg0qB7uvIL68Xw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7336.eurprd04.prod.outlook.com (2603:10a6:10:1a9::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Tue, 29 Nov 2022 10:38:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 10:38:54 +0000 Message-ID: Date: Tue, 29 Nov 2022 11:38:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: [PATCH 4/5] Arm: avoid unhelpful use of .macro in testsuite Content-Language: en-US To: Binutils References: <9afdf9c8-323b-78c1-d75b-8964e00cdec5@suse.com> Cc: Nick Clifton , "ramana.radhakrishnan@arm.com" , Richard Earnshaw From: Jan Beulich In-Reply-To: <9afdf9c8-323b-78c1-d75b-8964e00cdec5@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0075.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7336:EE_ X-MS-Office365-Filtering-Correlation-Id: 9e50c3dd-fee1-41e8-f9b3-08dad1f5e976 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h9xYimTk90VPT72hUJnS6Jc+HfqbxbZWYoEU4t2L4SF/Wf3OkdgD4bXHCn7w/2A6ho9giEsFHXUdo/cSFDcp0huHx0L1f/+Wj7nE5oLVMlMOYWaBOcC1LUQph2crgFvdx7ZrDurnC7SQQdcV/LM+6kjEi4BQkzzBCvdxLymENhlyhP33kylRC+eZ6w1vfL8rKILNvZ72AwhAhhzP0qkqcgMZB86OLn57yYGrR7bbPK6Ugni0CcKidn+sOHM+4cwSFTc5iAicoiTVfTiElTPEXZFHzENTupJcTpI2cK10CxwfLZIOE4X28oPly5+HjFfa3hMyoX7ROnbmfx/ywig00qKK/PlaTe/LbOeyKzdCunGPYWpNgxEgCkS2eFIKi/M9CCTQXEpYoPaFrdz9ZVQxJY26tkog3Jrpz5Mb8NiwlVlgXJpJzRu8kVqgJXOgz1d2eAREZsVLEO2p22w5HuU4V1bclae+kS0mvydj8iiC0Hnqn28cM4oeVeZ2MrMNeObTApmYCHUy8e5uZ2zZq589buC1hExSDgyKhFhXUn9jpuIw1QcpyutqrKI8+MVEAVvz/4MNpAZhtbjxWStOB2t1mzCR32JfD7B7LWzZdAAFFRuO5SL3ywZXisfFX74MV1jMxhLxK8PFQaM6QTnLo/Yi7efvwOuOMkHnuO5rjwEWsJjAZkZJjLRuvGN8jQYYgpMk5egw1YmQ7NiA84WBwWX7WHqnaPTP3HiwaxoufMbgmQWK/+KL3PpBFdc96PN2g+7/gJ4xjYTpdrftVoB9cUmUJg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(136003)(396003)(366004)(376002)(451199015)(31686004)(41300700001)(66946007)(83380400001)(86362001)(2906002)(31696002)(38100700002)(54906003)(316002)(6486002)(6916009)(8676002)(66556008)(2616005)(478600001)(66476007)(36756003)(186003)(4326008)(8936002)(5660300002)(6512007)(26005)(6506007)(142923001)(43740500002)(45980500001)(357404004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2cvaUZ3Rk1tVENJMFN1QnBOMUY1N2VmTUFoZCtCODZGWGRJcHpRUkgxVmZC?= =?utf-8?B?bkZCUG5BQTVjTTY5M2lLZ2s3RTJkVnRTU3dUN09PeXpnTWE3RzdxL0dBZE9P?= =?utf-8?B?VlJwcGlDRzBzbm9xZkFqejZVcEpFUWthY2ZncE1aN2JjdDk1MVhORTdiTVVr?= =?utf-8?B?eVVjcTFNQ2hWSmRDbGlWbW8yOXcvSGl5L2hSZUFXcWNWR081eEZXS2hOVnp4?= =?utf-8?B?TE5EMmtwSGs4MzNDeE1CTTNMeGJzSndHM0RiZHYyMXY3U0RlNlNtTFZoWFll?= =?utf-8?B?VVBad1c4eHR2aTQ4N1NaTWlhczhwb2hYaTRCVDd6WGdwUDM0SU0zMVQxZHpE?= =?utf-8?B?bWo4bjVaWXVuZVA2azR0cDJkcy9IWUtPSDBHMVJlL05yTVJqbElEQ2plUTFV?= =?utf-8?B?ckh4V0ZaNHhGajJwemRjRC95ZW53NlpIMnNIT0lXT2hjVHQ3Vk1HdzRNQ0k2?= =?utf-8?B?WUY3WEdHa2g0ZXNWSXlCMWwzYytSYUt4SEFvTFR0SUVLNU5xSGFvS3F1VzhC?= =?utf-8?B?Q2h5ZmZ1MDlUUndtWW9NQTFUbHdKK2YvaTc5R05YUVpFNk1zZjdrQ0t1R0FW?= =?utf-8?B?WkRVSFVRRXhoT0FVQTVrTDBQd1I5eFpINC9xU1pZY25jdGtRVWVoRFU5ZFlh?= =?utf-8?B?c2pUV2szdkpNRzJEM1BFekJkeERlbmVLUElxT2dGVU5TZ0haNzB3R0FFRTQ0?= =?utf-8?B?ejFCOVo5Tzd2a1lzZmdyWktuM0VYV0J6NVVqOFErWk9jQWxQM3k3eHUzWFRF?= =?utf-8?B?MzZBdzBQcDNlMXlhS1IzVEZ0SjBWalNOUjMrcDdIaTVvRCtJRjVkc0wxWWNh?= =?utf-8?B?UjVLY2ZJWHJXcDFLdmdrY0FyVDF5WUw2cFNYdEpQcEdQdXp0M3JSWWMzcjlo?= =?utf-8?B?RTVhNS9iT0R1RitqaTM1d1V5SDRsdlljbXIwb1h5UkdSNFI1enVIRWRvcVdC?= =?utf-8?B?eFNuejFLU2RaMWpsREpnUzA4ZkhXUVMyOUl2RXNKbFRjQ0RZb0lLT2h6WTRm?= =?utf-8?B?eVZzWHN6Wlo5TVlndkVUWFFLdmdqS2lySDVKUGNoUTdYUXpNMjhuWEswOEhB?= =?utf-8?B?Y2poNFRqaDZ6d0YxdGtCbGJQTEsxa1pPRWJERzhqM3VrSDJBOVZsL1B2V1Ri?= =?utf-8?B?YUpJRVppU25yd1JKb1pEVGR5eG1xRi9UMm5MMkRPVHBONFZ5aGlsUURPOEV0?= =?utf-8?B?cnhidnY3c1BGdS9wWEtGYUpDTGwwZ3VBK0o5anRkWUFnVk5tcGRlS2NNaUNv?= =?utf-8?B?cFVSS3VtN3JPMEJyekJGSVpwM2RhUGhyWXJ0L1hsc0M2aFh1MDRHbWdHMVF3?= =?utf-8?B?WkxldDQva2lNNm16bkZLSjdIdnpzUVhObXkxSC9ReDhZcFRXblo5TWFKT3Jk?= =?utf-8?B?M2lqcUdrVnpHRkIrRVBsWHcxaWx6QkNFc0syYnBlQlg3VXBYdENMWTlEQWd2?= =?utf-8?B?eU1zdXJHeG4wd0crV2I1ZGxwWkhBNnNHcG1mbnBnaWROLzBYbnV4TkZMOTdI?= =?utf-8?B?WmE4ZDVWc05wNXQ2ZnZCSnJ3TldqZFdRSjNrZ1RwYVN4ejB5SDhCQ3pxUG5L?= =?utf-8?B?QitkRlQ0c0pQbXJLVXZMSDYvSzJtR2p6ZkNyYWxuR0NIQktDYlFqZVc2OFJh?= =?utf-8?B?eTFiWWYxTGdEL2FIRWNrQ2l1ZnJrcXVpUWw1VWRhblBVcnoxSVcvNXd5RFZG?= =?utf-8?B?MmJIWC9tUHg3RWtMU0l3ZEhNbStMWUNPZU1NRW9QVGRQYWg3NEpHdFhHSVlX?= =?utf-8?B?N0Uvckc0SmJGTC9lcHhyb1RWTFpOcHJEamZyaS9lOHh3VG9nUnlTTUFMQUZo?= =?utf-8?B?UlhjcWRKN1R2ZnIxOHlIN3lsaXNOZlB2bzcxNCtMM0p1S3gvakUvUTQvOEJV?= =?utf-8?B?RHoraW5EN2pQV2xhWmhoeENCcHZXN25wc2ZNMUQ0NFBFTmVwUTdOaEpwKzhF?= =?utf-8?B?eXloOVVHVE9ZUElXQVVkblVvQXQrT2dIQjY0SkJ6YnlTc3BSVXZzRjRLMldH?= =?utf-8?B?SzNHUldZOTEzeGpTRGNJYjFYN2p1Y0UzQ0dwbWluWnd0Vkg0aWJYNEtzUWgz?= =?utf-8?B?VnVjdC94TlI0UGFZWTFHRGdRQ1hWSFQxbVBUaU5FL0cvNTZGaW14SW90ZEY2?= =?utf-8?Q?jFX/xPZyzDl5K6gSNN9U0nVgV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e50c3dd-fee1-41e8-f9b3-08dad1f5e976 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 10:38:54.1365 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: u4BvDbZgeCUTUqncyT2uqrrND/yiI9WRc6qZiL6LY+izUOAezDQAOigt5kFJN5jB+jXWS/THmDDGJP1jqTXeZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7336 X-Spam-Status: No, score=-3029.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Macros with just a single use site are a little pointless to have. Expand sp-usage-thumb2-relax'es inline, avoiding the need to touch the testcase when diagnostics for code inside macros are changed. While there also make what was "iter_mla" cover smlatt as well, rather than testing smlabt twice. --- If this removal of the use of .macro is deemed acceptable, I'd like to extend it to some of the "[Bb]ad MVE ..." testcases as well (see also the subsequent patch). --- a/gas/testsuite/gas/arm/sp-usage-thumb2-relax-on-v7.l +++ b/gas/testsuite/gas/arm/sp-usage-thumb2-relax-on-v7.l @@ -1,17 +1,17 @@ [^:]*: Assembler messages: -[^:]*:25: Error: r13 not allowed here -- `add.w sp,r7,#1' -[^:]*:25: Error: r13 not allowed here -- `sub.w sp,r7,#1' -[^:]*:25: Error: r13 not allowed here -- `addw sp,r7,#1' -[^:]*:25: Error: r13 not allowed here -- `subw sp,r7,#1' -[^:]*:26: Error: r13 not allowed here -- `bic r7,sp,r2' -[^:]*:26: Error: r13 not allowed here -- `sbcs r7,sp,r2' -[^:]*:26: Error: r13 not allowed here -- `and r7,sp,r2' -[^:]*:26: Error: r13 not allowed here -- `eor r7,sp,r2' -[^:]*:27: Error: r13 not allowed here -- `smlabb sp,sp,sp,sp' -[^:]*:27: Error: r13 not allowed here -- `smlabb r0,sp,r3,r11' -[^:]*:27: Error: r13 not allowed here -- `smlatb sp,sp,sp,sp' -[^:]*:27: Error: r13 not allowed here -- `smlatb r0,sp,r3,r11' -[^:]*:27: Error: r13 not allowed here -- `smlabt sp,sp,sp,sp' -[^:]*:27: Error: r13 not allowed here -- `smlabt r0,sp,r3,r11' -[^:]*:27: Error: r13 not allowed here -- `smlabt sp,sp,sp,sp' -[^:]*:27: Error: r13 not allowed here -- `smlabt r0,sp,r3,r11' +[^:]*:7: Error: r13 not allowed here -- `add.w sp,r7,#1' +[^:]*:7: Error: r13 not allowed here -- `sub.w sp,r7,#1' +[^:]*:7: Error: r13 not allowed here -- `addw sp,r7,#1' +[^:]*:7: Error: r13 not allowed here -- `subw sp,r7,#1' +[^:]*:11: Error: r13 not allowed here -- `bic r7,sp,r2' +[^:]*:11: Error: r13 not allowed here -- `sbcs r7,sp,r2' +[^:]*:11: Error: r13 not allowed here -- `and r7,sp,r2' +[^:]*:11: Error: r13 not allowed here -- `eor r7,sp,r2' +[^:]*:15: Error: r13 not allowed here -- `smlabb sp,sp,sp,sp' +[^:]*:16: Error: r13 not allowed here -- `smlabb r0,sp,r3,r11' +[^:]*:15: Error: r13 not allowed here -- `smlatb sp,sp,sp,sp' +[^:]*:16: Error: r13 not allowed here -- `smlatb r0,sp,r3,r11' +[^:]*:15: Error: r13 not allowed here -- `smlabt sp,sp,sp,sp' +[^:]*:16: Error: r13 not allowed here -- `smlabt r0,sp,r3,r11' +[^:]*:15: Error: r13 not allowed here -- `smlatt sp,sp,sp,sp' +[^:]*:16: Error: r13 not allowed here -- `smlatt r0,sp,r3,r11' --- a/gas/testsuite/gas/arm/sp-usage-thumb2-relax-on-v8.d +++ b/gas/testsuite/gas/arm/sp-usage-thumb2-relax-on-v8.d @@ -21,5 +21,5 @@ Disassembly of section \.text: .*: fb1d b023 smlatb r0, sp, r3, fp .*: fb1d dd1d smlabt sp, sp, sp, sp .*: fb1d b013 smlabt r0, sp, r3, fp -.*: fb1d dd1d smlabt sp, sp, sp, sp -.*: fb1d b013 smlabt r0, sp, r3, fp +.*: fb1d dd3d smlatt sp, sp, sp, sp +.*: fb1d b033 smlatt r0, sp, r3, fp --- a/gas/testsuite/gas/arm/sp-usage-thumb2-relax.s +++ b/gas/testsuite/gas/arm/sp-usage-thumb2-relax.s @@ -1,27 +1,17 @@ - .macro iter_addsub + .syntax unified + .text + .thumb + .global foo +foo: .irp m, add.w, sub.w, addw, subw \m sp, r7, #1 .endr - .endm - .macro iter_arith3 .irp m, bic, sbcs, and, eor \m r7, sp, r2 .endr - .endm - .macro iter_mla - .irp m, smlabb, smlatb, smlabt, smlabt + .irp m, smlabb, smlatb, smlabt, smlatt \m sp, sp, sp, sp \m r0, sp, r3, r11 .endr - .endm - - .syntax unified - .text - .thumb - .global foo -foo: - iter_addsub - iter_arith3 - iter_mla