From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-sender-0.a4lg.com (mail-sender.a4lg.com [153.120.152.154]) by sourceware.org (Postfix) with ESMTPS id 4B0E4385703F for ; Tue, 13 Sep 2022 15:29:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4B0E4385703F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=irq.a4lg.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=irq.a4lg.com Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 1793A300089; Tue, 13 Sep 2022 15:29:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irq.a4lg.com; s=2017s01; t=1663082961; bh=au7fNJO36gqu619bSiLiTtL3pmQiaobc+qWBQ5uOqJg=; h=Message-ID:Date:Mime-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=S/QeWeyq74nyhrp1zUuX+V+FdulK+90ONsG8c9ova8psaSRKm6NNb8G0mwFAcEv36 3EMtqo9glQU8ydvBzSWtgnDGSQs/XdLhHkcJy0WQrG93Ikx9Qle+aO6IjRFgRIVRhD SO1KYJcfYVaDCOMYtY8DXiI4laBVfx3D/qT19Pwk= Message-ID: Date: Wed, 14 Sep 2022 00:29:20 +0900 Mime-Version: 1.0 Subject: Re: [PATCH 1/1] bfd: Stop using -Wstack-usage=262144 when built with Clang Content-Language: en-US To: Jan Beulich Cc: binutils@sourceware.org, Nick Clifton References: <9edb72a280d3be93753afd29cfc2084d8a27fc14.1663073944.git.research_trasio@irq.a4lg.com> <077641fe-f70d-2f25-d539-50198eb97284@suse.com> From: Tsukasa OI In-Reply-To: <077641fe-f70d-2f25-d539-50198eb97284@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022/09/13 22:44, Jan Beulich wrote: > On 13.09.2022 14:59, Tsukasa OI wrote: >> Some components of GNU Binutils will pass "-Wstack-usage=262144" when >> "GCC >= 5.0" is detected. However, Clang does not support "-Wstack-usage", >> despite that related configuration part in bfd/warning.m4 handles the latest >> Clang (15.0.0 as of this writing) as "GCC >= 5.0". >> >> The option "-Wstack-usage" was ignored when the first version of Clang is >> released but even this "ignoring" behavior is removed before Clang 4.0.0. >> So, if we give Clang "-Wstack-usage=262144", it generates a warning, making >> the build failure. > > While not exactly the same, how about passing -Wframe-larger-than= when > it's (new enough) Clang, instead of not passing any such option? That's a good idea. But if I do that, that would make another patchset on top of this (not PATCH v2 of this). We need to know a good value of -Wframe-larger-than= for Clang and meanwhile, just removing the -Wstack-usage looks acceptable for me. For now, that would be nice to have an approval to apply this patch as is. > > Jan >