From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id A3D23385801B for ; Fri, 15 Apr 2022 07:24:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A3D23385801B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from [10.20.4.152] (unknown [10.20.4.152]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9DxXxOcHVliAyYkAA--.44856S3; Fri, 15 Apr 2022 15:24:12 +0800 (CST) Subject: Re: [PATCH] objcopy: Add elf header e_flags option in objcopy. To: Alan Modra Cc: binutils@sourceware.org References: <20220414112906.2684102-1-liuzhensong@loongson.cn> From: liuzhensong Message-ID: Date: Fri, 15 Apr 2022 15:24:12 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CM-TRANSID: AQAAf9DxXxOcHVliAyYkAA--.44856S3 X-Coremail-Antispam: 1UD129KBjvdXoWrKFWkKr4kArWkuFW7XF1rtFb_yoWkArcEkr ZF9rs8AFW7WrWSy345Crs8JrW5GF13ZwsrJ340g3ZFyry5Xr9rJr4vkF9Yk347ZFySyryj 9ryav3WSkFnxJjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbx8YjsxI4VWkKwAYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I 6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM2 8CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW5JVW7JwA2z4x0Y4vE2Ix0 cI8IcVCY1x0267AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv67AKxVWxJr0_GcWl84ACjcxK6I 8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21lYx0E2Ix0cI8I cVAFwI0_JrI_JrylYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjc xG0xvEwIxGrwCjr7xvwVCIw2I0I7xG6c02F41lc7I2V7IY0VAS07AlzVAYIcxG8wCY02Av z4vE-syl42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67 AKxVWUGVWUWwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1Y6r17MIIY rxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14 v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWrJr0_WFyUJwCI42IY6I8E87Iv67AKxVWU JVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07b8GQ DUUUUU= X-CM-SenderInfo: holx6xphqv003j6o00pqjv00gofq/ X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00, HTML_MESSAGE, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Apr 2022 07:24:17 -0000 On 2022/4/15 上午10:03, Alan Modra wrote: > On Thu, Apr 14, 2022 at 07:29:06PM +0800, liuzhensong wrote: >> @@ -660,6 +666,7 @@ copy_usage (FILE *stream, int exit_status) >> --weaken-symbols -W for all symbols listed in \n\ >> --add-symbol =[
:][,] Add a symbol\n\ >> --alt-machine-code Use the target's 'th alternative machine\n\ >> + --alt-elf-eflags= Use the alternative elf header e_flags\n\ > Don't use tabs in help messages. > >> --writable-text Mark the output text as writable\n\ >> --readonly-text Make the output text write protected\n\ >> --pure Mark the output file as demand paged\n\ >> @@ -3496,6 +3503,11 @@ copy_object (bfd *ibfd, bfd *obfd, const bfd_arch_info_type *input_arch) >> } >> } >> >> + if (alt_elf_eflags_set) >> + { >> + elf_elfheader (obfd)->e_flags = alt_elf_eflags; >> + } >> + > Needs a check bfd_get_flavour (obfd) == bfd_target_elf_flavour before > writing a field only in ELF bfd, and no need for braces. > > Also, please update binutils/doc.texi with the new objcopy option. > I will send a v2 with the requested changes. Thanks for the review. -- liuzhensong