From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by sourceware.org (Postfix) with ESMTPS id 3435E3858D20 for ; Wed, 9 Feb 2022 07:20:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3435E3858D20 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2108.outbound.protection.outlook.com [104.47.18.108]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-10-BNOyEBe5Ot2sRFLEbuXsyA-1; Wed, 09 Feb 2022 08:20:29 +0100 X-MC-Unique: BNOyEBe5Ot2sRFLEbuXsyA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=irHybQvCn0kzJxbVIM7luzkV8XD409THYZGAI0B+Go8OUx0bhKlzIx4TTxroQ85fB9k4E8geXqLi3ZmRt//MPmWvMR/54kdjSLAgmJ3qVDbzXFsBK1cNGSh4XhpFDyGVd0yE1knHWJ3otWtzBNfQRR9GrIFkiZ6T5xND8pERNH1jUWYyjebiteEWgH5vDQil2uRQ0OhueBGm2d1slvVhzp9OaYuZ9NC4MvKLMQW53abfr9OBWmgWNXtwrqqXivRovjOSt/s98tRciMkYThmy1wM+KqfrE8NuDL3S6zpJVf2aRS4qJZIuvxf30yl18uRdxFvCDAjRDNIMzN0/DJw/dA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=02Ea3RW62cAU0LO5Ndzeh8F3RROOWVFiyIkcs6WAa4E=; b=mhOl/JM2nK3d0fbpOqhneg0imXOokHHi2AbY2E8Ml58EBVNQvXDSHEEX/2JdXy7XpWZaOinZNBW0kM7/OopStSpFrxfBMRiL4rjkYs8orh99QXRpPxiBTcvjSG945I7KBxD/o85jcJNEs/0lgWdFWGOX6+J/LEEvc7hCDV/ckmx5zlQAuumOAVDNvAfy7doeXDZ6pqRnN/uY8jyXVjKNbJQhejGHk0+Nfm4xgWEzOrQvc8xasvjS07SCrLrdY+7qE1CyNfXT9k+4Ay/xg/+45h3f1k6AqzP7MdoiyqUh8RL9f0yZvN5MwMU20/jjElmXeblB1TgbhheAcpkyeKkrLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by DBAPR04MB7239.eurprd04.prod.outlook.com (2603:10a6:10:1a8::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Wed, 9 Feb 2022 07:20:27 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Wed, 9 Feb 2022 07:20:27 +0000 Message-ID: Date: Wed, 9 Feb 2022 08:20:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] Fix the disassembly of the AArch64 SVE DECP/INCP/SQDECP/SQINCP instruction. Content-Language: en-US To: Shaokun Zhang Cc: Jingtao Cai , Bo Dong , binutils@sourceware.org References: <20220207093441.55725-1-zhangshaokun@hisilicon.com> <8b5990b6-a9c0-8365-17b0-fcb99b22a3f0@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0012.eurprd06.prod.outlook.com (2603:10a6:20b:462::34) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0dc3d50d-1c04-4989-2d47-08d9eb9ca582 X-MS-TrafficTypeDiagnostic: DBAPR04MB7239:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:22; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /pkfSjP+aFSpLKWkUxZMKJuHOuirIjovigWKxvXEXYqjNGS/f6mFK2bKpjBAeZ152bRys/gsBLozuB4a3XgHftGMhttJ+n9i07mDXXK6YHC1wGTLXjamZlwUKXR0zuoR0VPxR1IZseUS4OevrOoL43+ZA8mW31hYUvMvkoF1AUcZeAf9a9SKN0Jgf2x353NXR1a+d0QQ1V5tNOgQjRa2HjIrxl9IJV3vMgFSlS4mvP/A/X10nalfAaOjTqT6UJreeYWhcFgSO+J+4NQW6GlPg9OUIrcWUbqZez26EceLbbgwMeXUIbs1uBtTALAHlXOoNBL8L+J+AiAnEeHbRzO+C2OiKadyK9h/9TrEKVZhIe9rX8kOkWnj7rq/5qcEjD2mc4t9wIO34UTSAP0Q+6/Rtoh8B2Qd/HTobMCb8xk/q817fIzixtRshhZdcBMqd7UoKFjsOREtGTEtsmiwj2T00TbSyrJrp/q8Jg8ovSCts5SlupUWel5Nsq2W4eSmG8uMFf1hW6M3gwqv4F1DAZzLIu7S8fHDb8h6VbMLAyGhtzDDXu3hofSNXrMoUVEHYOF1p9brllQu3Wisf7ftIpuJM3wgrka8a2CRYXTJs1fnk0JJN2AsZpajkJCptdC8VDa8hoqz27KaUPFR8NjJcJ0vg7eWw4CAPTkHlUcSC5BTQhGsc50DMH3KvRt3x5IeNursTvyxEo5qOdjMxtfItG1Ha+j5YwmEGuXWYtVKSROHQGKeXLKV8HtPUW26c5cAH3V0UBJWBumM9u4/a+B5xOb6xmMOXS0EysUSmY9VDKbnHEnmLziQYNHp9aKlRrk/AaQ8 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5600.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(26005)(186003)(2616005)(31696002)(6506007)(31686004)(53546011)(36756003)(6512007)(83380400001)(8676002)(8936002)(86362001)(5660300002)(966005)(508600001)(54906003)(66476007)(66556008)(66946007)(4326008)(316002)(6916009)(6486002)(38100700002)(2906002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWpDYnJQRHozS1E0eUxkbXhZLzhVU0FRVUczenZldlc5bjlxWSthSXBGNEhG?= =?utf-8?B?STU5dXF6L2J4RkpZVG1nMXdneGlBYXFVWFluc2lBRXJkZVhjcmpONmt6Tncw?= =?utf-8?B?SVY2V21Sd1FhYTBzdDJhVEc2TitkZW1sMTZuV0doa3dJUWY2K3psTUQ5ME9D?= =?utf-8?B?RWpsVkU5WXhIOWxueHFTQWt1MWhZajRwYWg0eHhuTEROcmhzYVlYVWFrNVI2?= =?utf-8?B?MVlEWU1lWHZtQlYyQUpEdDhCbU9wVTNrWTdIMEpCcit5eWd3Yys3NlJBWVhO?= =?utf-8?B?eEZpWDlRL0prMDkzTjI2ZWdCU3FmUVhibDg0VHFNRUliNEttQkpMWDRRVDJz?= =?utf-8?B?Zm5LRS9hdzV0R2g5TC9OdVp6UFFnRzlVSkxuY3E2cEQvcDJ5WUVtcCthRW1X?= =?utf-8?B?M3VuYzRlQURZRXlTU2lUYm1LQ01WK0l4SDNCRlZzbk0vZ2RuOGs0TDR2b1dm?= =?utf-8?B?UW5uN0MxRDNDMDI4L2ZtSWFlNGpMak1sUUhmbGxtMWsvVE9zS1c3LzdaR1gx?= =?utf-8?B?TFlwQksvSWpjVlhMUDZBeHVkUGpKRzN4NVU5dHAyazN3OVlDMWlXb20vMTRU?= =?utf-8?B?clBNV0hPbWhIUTIyWEZQSGFyNHFDNDlEeFNpVllST0lyOTd3ZWNnRUNUMHg1?= =?utf-8?B?NXJpTjJJS2dkLzNYQVFWSDRTVUdIUStobnlaejF0S1JzM1FQUUp5UHdGOGV4?= =?utf-8?B?RlN2THpiQmNxMDBNU0VQSmRWRG4rZ2xuRGRUWldZUEYzZ0xwTi9hUUdSL0Ft?= =?utf-8?B?TU9QS0RvcnVYRXc5aWNsSlVzckFFU1NqZFV6eS80NElibzR3eXBTMS9KRE1s?= =?utf-8?B?UEg2eWNWRi95UkF2OG5XalBRYU41ZS9hbHFENkJ0OFh0QnJsV1FVMGxxN3o4?= =?utf-8?B?ci9VZW16WDdVL0luMEhocnZZQ3J5V0Y2ZU9URnRyR0JPaElIaWliN25mbVZW?= =?utf-8?B?ZDF0RlRxZFpTaVNvRVZZMm9WaG1UbGVKa2RvWmlwL3ZCcjFRRytXd3VzR1do?= =?utf-8?B?VFYwTHFJYVppdktLa05rUGRKSGV4YVdlbEZyVFhQeVVSL3FNK2IreEhaVlFO?= =?utf-8?B?ZC8yYUx2UVFvMzhtSCszcHZOSVNheEFjYWpjWUpEOVBzbHkrV0UrS1EwNUx5?= =?utf-8?B?UkZaYUl2bkZrdENVSkZCMER4WGU5TkVRdFBMOXJKUUdBT2x5Qm9hWm43VDE3?= =?utf-8?B?YXBzWHZweUw0VTFNOWJkTFA2UTg0bWYzb0NWVE93VkJqZ051VjlpQmxMcGdB?= =?utf-8?B?eGxidEVtc1IvZ2VFTVc3QTU1alJHTHZleklVWm83bjBrek53K2o3aVBCV3Vn?= =?utf-8?B?eTJBTE9zcnZPOHVtMXRRQmtOWkIyTDA5TzBaZGRadEF3OUFUd0xqNWxsQkxS?= =?utf-8?B?aWhmZjhVOVZXM09NaGRSYm8zMVNMQ2xkTjFQa0VDSkpMV2tqNDJHbkx2SVF3?= =?utf-8?B?NjNjdVJ2dmFNdzVIdERlNFlLZ3dtN0NVenZEUjF6YjRDbG9UVklLczRpd3JY?= =?utf-8?B?WVRpalpkZXRta1ZxblRaN1ErWWtzVHNnMUNHMHEwdWNJb0hMeVRSV2J0dUlT?= =?utf-8?B?bXZ0NmkybGZyR2V3MGtSSjVKc1dqTEFCVHRlV001cHM4WDB2dDBERlRUVEV2?= =?utf-8?B?cm5mazRuSGNJLzNnRHlEUVpxbks5czZtTGg0aHR5Z05vcDFDazU2TFBTeWQr?= =?utf-8?B?VG1WcGw4TWNTVkFYOTBDU3NZZWRaYmp6TTNzU0RqaXB2cEZ6ak1ZVUJ2VGsr?= =?utf-8?B?dW1xOW9BQVBjV3lmc2RRTW1hNnVYSzZyUm9Ib05FdGZjdXJGZ3F5MVlMemNq?= =?utf-8?B?eUdMWjhFYlJLUzVvRkNBbFZxelB2UVhIN01YWXlqMFVhTXdldEJkcWhoWWFO?= =?utf-8?B?b0x6L3Z0OWtOc3d4c1BzTTBXTnV2NEt0cFV5aXZyRko4U3d4U1RWb0VxVjky?= =?utf-8?B?ZWpQN09Hdk9tWDRtTTFDTDc3a09DNFlHcmNQSDZmTEt0ak0ySzJHS3U0Qm4x?= =?utf-8?B?ZjRKdThIRDltTWg4dGRmVXVJRHNpdDB5YUdQOTZOMDU1cGZRMWJRQ2RHWXlz?= =?utf-8?B?UzR4eFAxWHRPNmZMNHNsd2VFNHZEcW5xc1hGcnVLK2pCNXRFU0VuMUEzdEhE?= =?utf-8?B?VFA2aTVxUmJZSjZPaHNERlNQa2F6Ykw2eDRzaG92aUJ0V3IyTjJLZ2c2NEw2?= =?utf-8?Q?85sfoNYMwHH08Bjr8xtm1P8=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0dc3d50d-1c04-4989-2d47-08d9eb9ca582 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 07:20:27.5239 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xQ4MXfe8LeusRyz9y7MviaxZou2J9K4LRgpqndA1jiZfU59zfdVcY0alMIWM7e9VaXmNwFr6BxVReYZ0CnCVyg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7239 X-Spam-Status: No, score=-3033.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Feb 2022 07:20:33 -0000 On 09.02.2022 01:56, Shaokun Zhang wrote: > On 2022/2/7 17:44, Jan Beulich wrote: >> On 07.02.2022 10:34, Shaokun Zhang via Binutils wrote: >>> From: Jingtao Cai >>> >>> This patch fix qualifier for the AArch64 SVE DECP/INCP/SQDECP/SQINCP instruction, which take the predicate size specifier: >>> DECP ., . >>> INCP ., . >>> SQINCP ., . >>> SQDECP ., . >>> >>> Omitted predicate size specifier will be prohibited in a future release of the architecture, please refer to Arm A64 Instruction set documentation for Armv8-A >>> architecture profile, see document[0]. >>> >>> [0]: https://developer.arm.com/documentation/ddi0596/2021-12/SVE-Instructions/DECP--vector---Decrement-vector-by-count-of-true-predicate-elements- >>> >>> E.g. : >>> >>> DECP Z1.H, P0.H >>> >>> This patch adds support for this kind of operand. >>> >>> DECP Z1.H, P0 >>> >>> This instruction leads to messages: >>> Assembler messages: >>> Error: operand mismatch -- `decp Z1.h,P0' >> >> IOW unlike the title suggests you change not only the disassembly > > Correct, current title is not quite accurate and how about `aarch64: > allow explicit size specifier for predicate operand of decp/incp`? If, as you say below, the diagnostic becomes a warning, then "allow" reads fine to me. If it was to remain an error, "require" would seem more appropriate. Jan >> logic. Wouldn't it be better to make this a warning initially, and >> convert to an error only a few releases later? That way people >> don't need to immediately fix their code. >> > > Agree, we can make both `decp z1.h, p0` and `decp z1.h, p0.h` get > assembled successfully and emit an warning for `decp z1.h, p0`, > then everyone will be happy for now. > >>> did you mean this? >>> decp z1.h, p0.h >>> other valid variant(s): >>> decp z1.s, p0 >>> decp z1.d, p0 >> >> Isn't this misleading? Should these "other valid variant(s)" also >> be output with suffixes? >> > > Oops, apologies for the stupid typo, it does output with suffixes actually. > > Thanks,