From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2080.outbound.protection.outlook.com [40.107.104.80]) by sourceware.org (Postfix) with ESMTPS id 21C55384B81F for ; Thu, 6 Oct 2022 08:43:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 21C55384B81F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DodtqIVoWMjhTpclKkI7ksBBRfUebHSBsp5DU47HyD9MOteGqUrEZ7wc7tYqgpvr+7OT+G1kJ0JYMLG/GC3L69XlGz0uGHMIgPXnXhdkx7cEdVdqxi5rORfiLWJRkyBkEtQ7p8yKJ95SJuE6gTYnw65d0r0/QBu17ilLL5BDGcMQQtGw09rA9xopWyF/hTdNnv8fJQVeBa2Zf2dY4GbGbykg4jhfS0iYhI7r+V4y5TLw1tjbXi+WSsbrSlXpRd+LPEhWagP47n5mrYmdgwVG9e/GwUfU/LG/24tAvG50XtEbwooEm3tNYJHiBJtLT9NNaU3LPeQrqQ4tsSwYW4i2KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bpRyCjXU5KEw+4m3AE70BmUDiUN9EOGlCRk9NtqD7bI=; b=exsSsNnHj24kGROYx4zJTgSym9cbH1e9oKDxHPzEQshy7qlqJ4slKTYNTlBOvu6yoIYj/eLn8HJbI25iAf7NL3Ltsz8Dq0Ub2Dvrl6VF7KDprS149QE1ntYZ7j8jHUiiD1sgJbmlKt7+dfXsFcwK6rQbxhb08C+YZfyXcMUN27KagxGDTANHYL8a6hg70L23qdV/SIwNA4mddGnSDjzkXrTQ/rOFnEpnTIJgxGp/N5LaRLdlxdgAlSgnZZBlWuZgtxeLE0DzE34GkvMlOoBuv58QMxqO8pz8YmuJAn1gLvIQxXUzEIsqOwCEgpQR8eCffI4KUF/hrAiZ9UZJG4wfUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bpRyCjXU5KEw+4m3AE70BmUDiUN9EOGlCRk9NtqD7bI=; b=34t4qkS0npfwAp7E/zYTb50DLdUovJvPzw6lM5/Jqc5Uu6Lsr/5Hz8KdXkTQ+SHYLN/qjjYiijeK89vxXlgo3h1VjYmoG1zA8FvTrrjxBtzdkqwnB4Zv1oQU/GQJO98rUSNp73QJaRHQamirN+c27JePHaYckhTFCpz1Vy7pNjj6FkapIfQslzD9JJGXVStY4EXB9lclkqelPWh0uds1EygoX85gZ4sLVnBFrZGh0li5Fyr5BktW/nJTvsn3sFtHrABrqZbwn/aZ3pcb7mvysDWGcpNqFuZB4gXGc+78W+nzBBN5KL/pFjdAGRrw5bXqNpfPiUINox/8prweLLCLPg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7429.eurprd04.prod.outlook.com (2603:10a6:10:1a2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.34; Thu, 6 Oct 2022 08:43:38 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Thu, 6 Oct 2022 08:43:38 +0000 Message-ID: Date: Thu, 6 Oct 2022 10:43:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2 2/2] RISC-V: Improve "bits undefined" diagnostics Content-Language: en-US To: Tsukasa OI Cc: Binutils References: <65f01021-9da7-a895-3cfb-95b959e930c7@irq.a4lg.com> From: Jan Beulich In-Reply-To: <65f01021-9da7-a895-3cfb-95b959e930c7@irq.a4lg.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0102.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7429:EE_ X-MS-Office365-Filtering-Correlation-Id: ec279ba0-1ac0-4c2b-ae42-08daa776dcc6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5aJ+I61x0+ybGbbb28agPKvc7ZYAeFSTljKV+YaincAtR1eyhcX3Abge3MDWB6BvZmRTqjQg1iZWgiLaFnRIv04B+YkAiI17GBFXv7it/Ncbk1pNvqLKzm6x33P1DD1KAzEBOHUH/XRcl7SIHU2IJx7gZoTKrJ/c7jzCmyXbZj2541yaKgpWiajCEKM3nEvfFqADTbgwdQH8xw/dssmCOIVdqLGtVA8vKiQvw2twShUVoXm5iR/8Qx19yV53Ex6LTONJedhZqUg6ibPwK2SndGxX8lidlRm9f1ylDl43eUlUFeV91V/0/Av3fhTOc4eA1Jau6+JNPZMBw1UgHjDVM+rsRfIUkroCbVy5Z69DW4V4fOh0zssY7XShiWaiNZLWpjOsWrCYXQnssD07ZoTme4Q5uSGfmMMcMhUqAc3+UKY3GKXsyz8GdvF7hoKiopk0+Qa6PLx53sDKMCFSGQuDrW5qkJb1YWYHmpUM43fLfJ8DhKplJ72sLchKxYwC0guP/x5GB2QnAA7L5LNYvhVo4i6CeF7gmUj+1ao3Q1gVprIXuAxLxA2irqiZRnU1D0WtEyanb0kxtKHf+FOkSMkaD9Ln36mApZ49ZZPH+myLrbxicCtmd0C1aVsfUilfz4zUM9ZAG1tEvOE6n6Oxf6yGBfT9GHDQZH47rDIVXI2QR4R6SzaG1CrmOZU21w0IRI+DT0rsId6hmg1chrED4yVHckfsTLG970n8jc6LV+ADOeFM5iWVnoHORv4Hk4JlDy26ce9rZtsuYUG8Ht+t0cDre6cAlMSPcqHqbJBFobe9T3I= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39850400004)(136003)(346002)(396003)(376002)(451199015)(2616005)(83380400001)(38100700002)(31696002)(36756003)(186003)(86362001)(5660300002)(8936002)(6512007)(66946007)(66556008)(66476007)(41300700001)(2906002)(26005)(53546011)(478600001)(6486002)(31686004)(6506007)(316002)(4326008)(8676002)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aTJpVGd0UUtRYnRscnpGSWtZby9tU25hL3NQalVaZjdjZFMxYUpZNFQxMG01?= =?utf-8?B?SjBtZDNzRHFQNkxKUGZaNjR4cndaYlloK1M3RGU5NWNUblR6MldTa2l0S3hj?= =?utf-8?B?WVo2dDJsRTRiRmlaZGhIZk5LbTZsVmRLWCtDUFNOVkJGT3UxNitZSVF2Z1ZK?= =?utf-8?B?QlRrR3lhVG1PZG9KcnlEdWZLOW9CUkhUZDhtRVlCci9yczVkcjRjQ3NKc0pX?= =?utf-8?B?eVVES0FveWZ5RVF1TWVPR3h1UVlxeUVtem5KaGZUUHVPZGJ1VG90MnRTcEJx?= =?utf-8?B?blBiSGRXUWY4U05sMmk2WDJkN00xaDRkajQ4QnIxbWdaMms4SGVtbUtEc1Ba?= =?utf-8?B?eXpOSHFVUmR5NUtuU2ZibFJJNTQ0M21HMjA2cGI2VzNwd1ZkUVFGQk5rMVVG?= =?utf-8?B?dVpvN1E5akxncUNoWEhnZjNwN1VzZEhsbkt0NEtpYktZZmRzSlgyV1RlbEpU?= =?utf-8?B?d0F0RDVaRFFpRlVZZFRHclRnRjI3c0tWelNBb01ScmI0QmpnYklzZzFUUmZI?= =?utf-8?B?YTJCK3NPOFZ3U3ZrNWR2ZVFpWDY5dTNVQ1RXTTVabXIrWCs3aDFrdGtIVUU0?= =?utf-8?B?bWpZaXFjUDJsWlpRRjBvelNXSm5NOXpTUTZOc3BmcDd6M1hpT0FIN3lYNGhj?= =?utf-8?B?bEFuOUIrSGNqOG9JMEMrajRrRE5qaTFRZ0hLaHI2K2t6TVhJaFVQSGVubjVa?= =?utf-8?B?ZWZlVFhZR1JMV1lIRFl1SEg0T2lJd3kvN3QvVkJ3clJJTzRPQ0hndEEwWnVn?= =?utf-8?B?VGw3dmJYUHhXdmlrbUJsSk83eURuTkRjaU9xQnJjMlNUT2FHSEdZZFdmRFhF?= =?utf-8?B?bE4zN0h5ZXh5V1ZZakcxTVNXdEc4VVViZ09aWFFnanFQcnAxM0hwM05mVUJu?= =?utf-8?B?Yyt0M3BISVhQdGtVOGplM3BsSG0rWE9jdWxVT0ZCQVBXQWd0aU9NUkl4ZjNt?= =?utf-8?B?NmRENFZCYk1rWHp0RXhIMFVDMkw5MVp2cGNCdVNUbVlPSkVoalNPS245UVBI?= =?utf-8?B?MFBSQXY2TnhWdHN2RWZTZnJZcnZWRlBNT25hTjdGc3hnTkpud2UwRS9Kelp0?= =?utf-8?B?SUp3RjhKbzhIOHphWVZwclFmS3pCWWliTXhYbEhkZHJYTUpicTFWMXJDZnVz?= =?utf-8?B?UjhCNUs2K0EySDc5NW9jZndxYTVzenBVQ2hpR2ZsS3Z0ZlI0OE0wMmxBTXZP?= =?utf-8?B?RjZTQzVCQTB6TGoxNnQ4RWdPbGo0YlBYTjh5Yk94aWhGcFRQV2lIdDR1TXJH?= =?utf-8?B?UmFTY2s0TXFTSnJET0dxUE00ZkNwWmQ4MWFkZVhLQm5rTS9PYi9CaS9VVEF5?= =?utf-8?B?RndCazlONTNGd0FsaFkxNWNBOHJZaENvaHBDUEJkMGg3MWFuZUJseUI3TEsy?= =?utf-8?B?OWN6UTJ5aGwvNXU0ZFJWSUt3NVA0WTg1WXROWmhwNU1mK21uckxkbkpkeHdv?= =?utf-8?B?elJoYmtJYnprV1paV2twQm1mcURyMXU2dVU3UzR5aFY5cTN3TlZlcmhFQnR0?= =?utf-8?B?bG5ZMHJBLzl1MWVCMWJrSWI2TStUTFBTcnpZNTZzQzdWdmM4dklKU2IyTFNt?= =?utf-8?B?Z3V2OTU0cFdkTStYMlJ1bVVZaURzYm96K3lNYmpRSng2MDQzREpCSEJONThk?= =?utf-8?B?bzVwZnVZTHBLckdzSW1hN0h0WWRDd21HTkw5Q0FQaDFtTys2RnpqeHJXWUlE?= =?utf-8?B?KzdEd1NRRUVQWTgzZGFpMXlXMFlQazdSQjg3WjVPVlA5a1d5elpFWXluNVpZ?= =?utf-8?B?WTc4ZmVINWxFSndpQVVLWXB0cDZVYmpGcmRlSFNaMXo3SXRxOVRUVGFDbWJL?= =?utf-8?B?K1lwbFV5SEFGMXJhMTlyUmttZmFMcDliNFQ0UHI1cmh1ZndKbGxFaEtHSFZN?= =?utf-8?B?NVZrSFIxRmZ2OWtzVTh2dS9EWlcrL1oyQm40S1hacFhRZlo5bHBmVi95aVVT?= =?utf-8?B?SSsrYm1ER2lQUVZkL0x1czRQUldHazlOQnFFSmdRd0c4bnNBUzdLSGxvSnc1?= =?utf-8?B?R1p5aWZPWUtqcllXU2tGQTZRMEVOcnFCWGI0TUFaOVBpMVd2dGFpVnllVnJ1?= =?utf-8?B?TkdSQ1pNaTRFZHcyc3k0VU02bXExMmdtazlzd0pUSzFQdFllOVp4VFlBVWhi?= =?utf-8?Q?DZ0TAKeqKHzOZE/mJ3To7HnmO?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ec279ba0-1ac0-4c2b-ae42-08daa776dcc6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2022 08:43:37.9896 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bLU9Ars5OdfwaCfQJny7/dst80i6KJY1hNI5rkQ5wrj9H7MW/3w4ArKt/b19+5WWJnt3bKo9QcR9II715oxVdA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7429 X-Spam-Status: No, score=-3030.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 06.10.2022 10:34, Tsukasa OI wrote: > On 2022/10/06 17:26, Jan Beulich wrote: >> On 06.10.2022 06:40, Tsukasa OI via Binutils wrote: >>> --- a/gas/config/tc-riscv.c >>> +++ b/gas/config/tc-riscv.c >>> @@ -1312,8 +1312,8 @@ validate_riscv_insn (const struct riscv_opcode *opc, int length) >>> if (used_bits != required_bits) >>> { >>> as_bad (_("internal: bad RISC-V opcode " >>> - "(bits 0x%lx undefined): %s %s"), >>> - ~(unsigned long)(used_bits & required_bits), >>> + "(bits 0x%llx undefined or invalid): %s %s"), >>> + (unsigned long long)(used_bits ^ required_bits), >> >> May I encourage the use of the # format modifier in cases like this >> one (i.e. %#llx here), for producing a one character shorter string >> literal? Iirc a respective adjustment was done pretty recently to >> some other parts of binutils. > > I would disagree if it was a part of the core disassembling portion > but... Sure - typically in disassembly you want to output leading zeros, and in that case using # isn't desirable. (I've observed RISC-V disassembly to omit leading zeros in certain cases though, which personally I find confusing.) Jan > seems okay here (as exact formatting is not important). It would > have changed the behavior if (used_bits ^ required_bits) is not zero > (e.g. with "%#x": "0" (0), "0x1" (1)...) but here, (used_bits ^ > required_bits) cannot be zero. So, the behavior won't change either. > > Thanks, > Tsukasa