From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2078.outbound.protection.outlook.com [40.107.13.78]) by sourceware.org (Postfix) with ESMTPS id 62F653858CDB for ; Mon, 18 Sep 2023 13:28:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 62F653858CDB Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KIBo6PI28JblG+4K9gdtWB2LHF1JzhOkprI9bUWpryeBsur/OnGm0mU9u/cLjNarghyP7Mk7gQiZNeWKSBw87RYXfVP7c7wMAdahyfMUjYQdT34N+h++hrWFfJ7lwYTSFPvdwIk3/flrW6Tg5ZNAy27askejaL7GH4KVN5/wAsdyqrRvELUqDcDqM4yusicTkAJtr3ZWYyYfcehpq+4vgH1vWc32du2Tpdy/ePunhyyhvSa9GoAjffTspApJnxtR9RDK7usj46WcJG/d5Jtylx4Aa2UuunCgmrjN2wmG7meskBmNg/lkSS1nD14AIgy1cflqxMU5mEEeSWBRNDgE5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=syQ6Pc4jI+stO40wL07fgZFNAmvwdrDjB92PiLHAh5E=; b=QOgCy3Z6RgAIAATVgLjGQQKtm9s67tTtmJAJohGY8T8DCnTLahrMtZHw7kUvVQoaBWPYJModKrIOLCf8OjoeiD76JIkYLI/4taXuMEMdFrLAav13+rfaFicbhJCHYXU3iqGLh8G70FpY3cSZ1Wxlv5/r7PXMFQxcaOmGoIbiVGUK60guEAFr+z+KIG85pkXWjr+ya+fZBGBlZ6f7+e1KxXCgsXfwqZfSSwew4RPc12rwOIWA9SgWYQxhPt306Yao7aJeR43yFXhFnuO845PqcG5tdvZhtP8QwsZcTt08VD8zn4vvZioOUuDph02Lc99dblsan9p1cL9xMZhSbW69pA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=syQ6Pc4jI+stO40wL07fgZFNAmvwdrDjB92PiLHAh5E=; b=0oq7GzCgtY8skNqzzIAgDbyfjSFXFlatSkoC9cDRfhRpdfwuZZCHSAmxKSaaxrfzkBDQhNHHRJqokmofVTcOZiJ8fCmGoDcfSK59l+/rLgVt+syZQRgqx02vMGd+ugjVNKrmtOoAdZRr2MbG1vNGm2lCb8H5bPirvnHpCbpAhENm47s39LTdfoW9Ze39dmpd5QptScaJM9Zxe6bdYEs7U6cCC6g1eewXqUJznASXeWDi+CAyn72NsR7nZkzmYrRPLnHGxsg0OhgRpozaiC+fUUB5P7BS19JYEnAzMeSFy1o+AGWKHtLRaaEEFQglzF2XujUgdE/Kp01Z27bBMazFWA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DBBPR04MB7995.eurprd04.prod.outlook.com (2603:10a6:10:1e5::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.26; Mon, 18 Sep 2023 13:28:52 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::f749:b27f:2187:6654]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::f749:b27f:2187:6654%6]) with mapi id 15.20.6792.026; Mon, 18 Sep 2023 13:28:51 +0000 Message-ID: Date: Mon, 18 Sep 2023 15:28:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2 1/2] ld: write resolved path to included file to dependency-file Content-Language: en-US To: =?UTF-8?Q?Thomas_Wei=c3=9fschuh?= Cc: Alan Modra , binutils@sourceware.org References: <20230916103619.819791-1-thomas@t-8ch.de> <20230916103619.819791-2-thomas@t-8ch.de> From: Jan Beulich In-Reply-To: <20230916103619.819791-2-thomas@t-8ch.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0101.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::7) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DBBPR04MB7995:EE_ X-MS-Office365-Filtering-Correlation-Id: 449af375-66cb-4414-9488-08dbb84b32a4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c2vOdq0bFlHWDec88hqq98JcVQdF0PhY9nL3Sro8OEFkCbEQoIDGUZS/ncz02hYAe/vfCjHvwst7apZDQBcHD4RktiRTVCy66jDbEeqX7tGJtvKd4IM+ZHRwQVso8QpRioGHXOJujXNGp/SuHTdOe8BauqHDs+XkWX+X946COspar6AiTXwvUN8uhkKFDEOjUlgIY7zHkoG3DmbLOgnrO/B3fzm5JUahvbE1uCg0SRPiitw2XunPKjTawKyQMM742aZzrvsekN1bpjyAFvzpOuoO2pyBw4Us02NiSAjJjMCdfslzY2Mux0agimUhMGZr7ngbqxIX128T0Pjh0ichwwgVn8L0zzHwRJe3rq31XgZ8hQZ6SVJHtnl/9nO04KuHmrKeCvfDUuBuMJmTkp8pP0prqV/CIOeG6ZUp+NO0IaC5mbc6B4UuRgdOiO5VVJTI9wwTp0InJODopOE1sC37z7S9gWkBdWy6D2xhX8ydTlFVOlgn0ncNfh3F7GVb66N2KUxwFKk2MxLTR0DsMe5Df1DgFB6EJxgsCeu29LmMKO0x5xRsb72GW8Cw1w3CrDBfMGuoMzfYK/nT0zWIn0hdceDPVdpW196NHroayNMO8QIcbL0KUMzSWLPAeqcBck1Sg10oCjZVvze0ebs8XsXDsw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(136003)(376002)(396003)(39860400002)(346002)(451199024)(1800799009)(186009)(2906002)(5660300002)(26005)(41300700001)(316002)(6916009)(66476007)(66946007)(4744005)(66556008)(478600001)(8936002)(4326008)(8676002)(31686004)(6506007)(6486002)(53546011)(6512007)(36756003)(2616005)(66574015)(38100700002)(31696002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TlVBTXNvbS9aanNqYnBVU1BVdE1pbWhhWFNyUWRNcVdZNTJXZHVHSEw3dXJ0?= =?utf-8?B?RWJ0RmRJQTFVRkp5bEozeTdpRXBENG56WklRR2srMFZSQ1IwaXZMVENrb1A0?= =?utf-8?B?bEZQdDIvdU5ZcUtnQTd0MzRCTTVqQm5Xa2lZaURkU002ZlNySGZoSW5RS1Mz?= =?utf-8?B?TVV1cStTK1F3cmd3RHlEelp0S2pvNEN3QXBkUldJWHVWYUltQzFId29RUnFv?= =?utf-8?B?UkRaUU0vK2RXRlVPdXNZc2IzVzgzMXlwVisyS0R2T2l3WG1vM3FFczhWVEdu?= =?utf-8?B?N3hhSllQU0JPaGVvNnhlSWw3Y0NvRlJ2WGw1QnBRWm1vSGxhemZHOHJobmN0?= =?utf-8?B?NTNXYUdhbmc3d0tJeW1uNXRJb1pUejVzUlk5Njd6amVjRjgrSTIvVktGUmFp?= =?utf-8?B?cFpJTmlTbU9DcUQrUmlMZCsxRjZVWVA4V0lWODBGODBZUlZSeG5LSDVkZ0lu?= =?utf-8?B?NTJES0NrRjNWZUZjZnNzdjBOeUM2dkFRM3hBNXh4Y0ZJQWdxeUNEdFlhaC80?= =?utf-8?B?R2xoR2ZUeDhWNjVaeEV0UUlqRFVPN1Nic3Z0YlRiUVloeVNuRzZQTlZFQXZ3?= =?utf-8?B?TzJKR2daVmJIRTFnSTFpdXU4MXl1YVhzMUpheVZiUmRwUFdlK2ZMNWRzcDVp?= =?utf-8?B?UlYxV1pWZGNIZ0srUnJ2WGwwYS9KRTRDODNIelpxTGRka3hkNlBKeUF2YVdl?= =?utf-8?B?VGp0aS8rNHFabUJmbjhXS0xsSzhzdXFjU3NpUzkwalBtWHRjdnNQeHBuRjdV?= =?utf-8?B?ZVhidW1hTjZVYUJqZGRtMkN5RlVydHEvMkFOMUt4TzRMaTNvV25DYnZxaXcz?= =?utf-8?B?RnBUUFo5MTFQZmFPdEkvRjM0dWVGOHgydTdkRW96Q0xEMGtBTFA3VlFYQkxn?= =?utf-8?B?dy9KNWpDQnVTNUtkWXV4SlZ3c0RPMWlJSkg5cDhheVZiU3MwazZ4eE9ZT0g3?= =?utf-8?B?ZFU0QUdPOWljSlFzdFpwbHVGaUlJdjV0NVhuNDloanlQdHFtMVMyaldYY1FF?= =?utf-8?B?c0hSMWZNd2U2UXlrRkxHZ1Z5RUJuN08zZldSdllBK3hxMEY4aVlTRlJ6cGhN?= =?utf-8?B?MDRPVk1oOTAxeHZtOGlwWEdrS2VaTy9ZL2x2Unh2d3E5cUY2Rmg3cVc1dGNC?= =?utf-8?B?blZ6SzRreG9KR09DaWF3S0JlTXdZSDN0alptZTVQV1NNaFRQWUx3dElFVCtm?= =?utf-8?B?UEUyS0lwVi9VRGlud2hNTXVsMzJpcFRwZm1kbVgrNVFOVkh5MTFYUTYwUktV?= =?utf-8?B?d21KTjgxa2lkcFB2c1NQNVlISzIzRm53R2dYWmZMOGJrUEtkVVE1cG9lOVg3?= =?utf-8?B?TzgrTlV4ZkhnVy9kVlFTc2pZOWduWnpFWGVDam1pTnJRTllLMkRtZVkxUm5w?= =?utf-8?B?T1o0OTFQMXBSTkorY09tS2hjME9mdDFXS3ZDR3Y0WlFoTklNd3BDOG5RMUZZ?= =?utf-8?B?WkZTekRHVWVJQmpwWjBob282OWRtcWtQalZRZ0lKYzExcDQ0MDNjUE5OaWF6?= =?utf-8?B?V0JSOWgxams4c2M2bU1DSndCODY1ZGp2QjB2aVlQUmNVdjdwTlFXR3FlSDh2?= =?utf-8?B?NjMrbHAydHd5eGJXaTY2QVc2NW5LUkRGb3JsZ2dzMERkUmpFeTA0OVRTUzQx?= =?utf-8?B?TFZNY3Zjelo1MmNIaTlkNjh4ajJOQ1k0MjB1c0hWOHJyR1JPSU40RjFpZW5O?= =?utf-8?B?V1NLZm43cHh1by9qQTRkVEx2YnU3ZUk2ckYxM3VDaEtjdzBBREJkSzVEeUFE?= =?utf-8?B?MG8zVTBpQkIzNE1tWHZiMGpyZ29IVlBWRXdoSWRwWGdMaTFMWi80QkZvM3pj?= =?utf-8?B?RWc5R2wzYm1hV3hGT29tK2w0b0h6cEoxczJiL0Zuc1FxUUFBNG5WN2JVUStn?= =?utf-8?B?NzZxMzJrb1lCSkw1eVEvK0pWOXFkVXhXUktwT2xyMlN6K3RoVzVweVBvaE94?= =?utf-8?B?TThjYmovYUUwaDJtNlA4K0Z2Z05GajBxVk1VOVdYQVhDMFpZek1peUpUN3FZ?= =?utf-8?B?d1FPa2xZckdFS0RKWjg5UWdEbzJCbGE3NFg2M0U5bkVVM3B6OHlicnNyQUt6?= =?utf-8?B?ZTEvcTdCTFRaTEQzcXpWazZ1MXVBK2RRWXJWa0grNUkzSGlucTkrRzAzVkcr?= =?utf-8?Q?Cs6oes5QBfs0rSy+QwLq2nW1d?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 449af375-66cb-4414-9488-08dbb84b32a4 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2023 13:28:51.6310 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PRK084sWUowjXvjZcoF5z774oaWq+3JI1RLnRHcEe7HO+94x9dAW+p50FnuuhDUHiU5HBeHn7V4ygX6TQQ10oQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7995 X-Spam-Status: No, score=-3027.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 16.09.2023 12:36, Thomas Weißschuh wrote: > In ldfile_open_command_file_1() name written to the dependency files is > the name as specified passed to the "INCLUDE" directive. > This is before include-path processing so the tracked dependency > location is most likely wrong. > > Instead track the opened file at the point where the resolved path is > actually available, in try_open(). > > Signed-off-by: Thomas Weißschuh Looks okay to me, with (nit) ... > --- a/ld/ldfile.c > +++ b/ld/ldfile.c > @@ -528,8 +528,10 @@ try_open (const char *name, bool *sysrooted) > > result = fopen (name, "r"); > > - if (result != NULL) > + if (result != NULL) { ... style corrected here: if (result != NULL) { *sysrooted = is_sysrooted_pathname (name); track_dependency_files (name); } Jan