From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailbox.box.xen0n.name (mail.xen0n.name [115.28.160.31]) by sourceware.org (Postfix) with ESMTPS id C294C3858C53 for ; Fri, 5 Aug 2022 10:22:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C294C3858C53 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=xen0n.name Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xen0n.name DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xen0n.name; s=mail; t=1659694922; bh=lLB7lSqRQxikrYCo6V6rcxhIdusnhxKym4dkhM1gi1w=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Kyin695ZEZV32S+i4Fk0zJqsUpnGLa0QL5aMfKAEkFqzAW3Ny1S79kjSjMsFUwMxd sBudHgmTtFWMgD1tLQZACcK21xvP8QekewWiEVQpfOh0r8+T/DO0rdrdJt0+BrTlUB SWzx7nGxpAMpyJ2wt4LnG5n9M1WTIp4morDUzyiw= Received: from [100.100.57.219] (unknown [220.248.53.61]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailbox.box.xen0n.name (Postfix) with ESMTPSA id 0A5CB60074; Fri, 5 Aug 2022 18:22:02 +0800 (CST) Message-ID: Date: Fri, 5 Aug 2022 18:22:01 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:105.0) Gecko/20100101 Thunderbird/105.0a1 Subject: Re: [PATCH] bfd: Add support for LoongArch64 EFI (efi-*-loongarch64). Content-Language: en-US To: Youling Tang , WANG Xuerui Cc: binutils@sourceware.org, Chenghua Xu , Zhensong Liu References: <1659666386-5500-1-git-send-email-tangyouling@loongson.cn> <24a9300d-24f9-d4cf-4b71-198d5f4da511@xen0n.name> From: WANG Xuerui In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Aug 2022 10:22:06 -0000 On 2022/8/5 18:07, Youling Tang wrote: > Hi, Xuerui > > On 08/05/2022 05:41 PM, WANG Xuerui wrote: >> >> >> +#define COFF_IMAGE_WITH_PE >> +/* Rename the above into.. */ >> I know this is copied from bfd/pei-aarch64.c, but you could reformat it >> a little by adding an additional period and space, for style >> consistency. > In the previous macro definition, I used tab alignment. Do you want to > use space alignment? Sorry I meant only the comment line directly above. I can't check tab/space usage on Thunderbird because whitespaces can't be made visible like with VSCode/Vim AFAIK. > >>> diff --git a/binutils/NEWS b/binutils/NEWS >>> index 4fdf1c3b4e8..3b5a96b9819 100644 >>> --- a/binutils/NEWS >>> +++ b/binutils/NEWS >>> @@ -14,6 +14,9 @@ Changes in 2.39: >>>     architectures.  Use the --disassembler-color=MODE command line >>> flag, with >>>     mode being either off, color, or extended-color. >>>   +* Support for pei-loongarch64 has been added to objcopy in order to >>> enable >>> +   UEFI development using binutils. >>> + >> Isn't binutils 2.39 already frozen? > I will add to the next version. Okay. (I don't know if just adding a "Changes in 2.40:" heading would suffice, or if something else has to be done, though.)