From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by sourceware.org (Postfix) with ESMTPS id C9A283858CDA for ; Tue, 6 Feb 2024 08:30:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C9A283858CDA Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C9A283858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::132 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707208211; cv=none; b=UYMnzJyvQcItS4VwBu9oKwdvofHWW9B/3ri17cgX2Bj402e/Av32ddHXpIs1M+CzFEikpoCyRnDsVc5yFUgW5Evj3mj3h/6EuwoQYrCTOivxgiQYCRkBgXqcRxGTgDtbBS0Cdu2QZcG4ne6rH5keJhdOr+n2VuIsunyoOHca5OI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707208211; c=relaxed/simple; bh=3tqiTbV4Y4LmR3SeUDknKoxpxk51DJgoyQXjs47Sic4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=JKzO8qqc7wTemgZ+fwuJ0B65P0zW/5PTIJly/lkpfUq7u+Nrp0VSqV0ZOyhsowSxjSF6hgbEFeI8b/giw4gNPhodyHfl7wHQtQ4Z0OAke7s0Cldk9DHW0Sts9MME1DFVUeZJTa+rHm+zYx/WJVCU5wNAHU0YNTMVcKqg9p+M1g4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-5114cd44fdbso3933948e87.2 for ; Tue, 06 Feb 2024 00:30:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1707208202; x=1707813002; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=K16EfeGSobnJ/O4rQL9jpv1kUOr0YirlRroZQnqXTQI=; b=RlcEa/UUIsSaq5I0P8p25rv8DlFTeIGUyNJFm6k2wrPgzEQ9eaJ+h8VAWGCsdJ0YSL 0ikf2tPqXYesxkmLmTb94ypC6cqvs9i+pQX9eAi9VkbsU7WepYQZ+0FMyQy8odCbN68P Z/p/3P7kH3fyIHutuomEhb58r+T4cSZbVJXnxjPeFa9jlWJT8QBkg0QywvMU0VDcgrXo +hCENj6H3IYJg1VkI4j4vKbyQkdEyXXVMsx0evr9jtaFwKBL6dXEgpwrkbm0jbGKvchy 0mmmDwfYeHQFXl8EDsJ1GUbsC5iOafnCrEh39t5zKVtox9iv+c0G9f9qeX8mr06EuA0k ANzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707208202; x=1707813002; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K16EfeGSobnJ/O4rQL9jpv1kUOr0YirlRroZQnqXTQI=; b=h+W14Hech3rXskICbW/V/Pq4GRKhw/jVba3yp1LQpQbqsF7wGAf4ebyoA3SI95ks2E RGtfahSVU5k0dYkn3G3VLnoR6yPZr/hZ0mXhebFLFqln8DA9UYl/x1IndFbAOVR63JWR WCnR0Eqj7yFw7FSNIAgArrG2zBTsVIdIrMRl4tR8jWr3ZndXowVUvVvk2XdDLkXvHl0V G4ECFisBtG7FwOWP7hNPMEFbwuAfwYDEEYnV+CFvx/hwYgpOHgBHplPfqbd/WlJ1PUcC xVlZ0eZ5OZgAx5yZX50cqfUzZl6Qb0ZVAXz9NnQrFJwq+oivxGPvXR/l714fQNng9ix7 pgiQ== X-Gm-Message-State: AOJu0YwjgJ+XCfXb2bWM5d9KemFcaseWUqSWEMaao6/G4zIkJx6GMRS6 WnAROtt/ovQKHmMiEjg6vKvPnpv5WnOfsNdKA+ndq3hSDVMBiG41BKhiOrCiFA== X-Google-Smtp-Source: AGHT+IGv+8cp2jIFSVCQTZL0HOvSe0U7S8621qb1lHAxIMH8XP9CwwHEayUSNExrQBrNRgGfwbuVgQ== X-Received: by 2002:ac2:46f6:0:b0:511:437c:9646 with SMTP id q22-20020ac246f6000000b00511437c9646mr1219826lfo.6.1707208202024; Tue, 06 Feb 2024 00:30:02 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id s9-20020a05600c45c900b0040fb44a9288sm1184202wmo.48.2024.02.06.00.30.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Feb 2024 00:30:01 -0800 (PST) Message-ID: Date: Tue, 6 Feb 2024 09:30:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gas: scfi: fix failing test on Solaris2 Content-Language: en-US To: Indu Bhagat Cc: binutils@sourceware.org References: <20240202232542.2282432-1-indu.bhagat@oracle.com> <4227b81e-5a62-49fd-a811-0515ea6000e8@suse.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 05.02.2024 23:39, Indu Bhagat wrote: > On 2/4/24 23:32, Jan Beulich wrote: >> On 03.02.2024 00:25, Indu Bhagat wrote: >>> It has been observed that the run of scfi-unsupported-1 test with --x32 >>> arg on a Solaris2 x86_64 system fails: >>> >>> Executing on host: sh -c {../as-new --x32 --scfi=experimental <...>/scfi-unsupported-1.s 2>&1} /dev/null dump.out (timeout = 300) >>> spawn [open ...] >>> Assembler messages: >>> Fatal error: no compiled in support for 32bit x86_64 >>> regexp_diff match failure >>> regexp "^Fatal error: SCFI is not supported for this ABI$" >>> line "Fatal error: no compiled in support for 32bit x86_64" >>> FAIL: x86_64 scfi-unsupported-1 >>> >>> Fix the above by adding a check for --x32 support before running the >>> test. >> >> While okay as-is for the purpose at hand, I still have two questions: >> >>> --- a/gas/testsuite/gas/scfi/x86_64/scfi-x86-64.exp >>> +++ b/gas/testsuite/gas/scfi/x86_64/scfi-x86-64.exp >>> @@ -14,6 +14,14 @@ >>> # along with this program; if not, write to the Free Software >>> # Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA. >>> >>> +proc gas_x32_check { } { >>> + global NM >>> + global NMFLAGS >>> + >>> + set status [gas_host_run "$NM $NMFLAGS --help" ""] >>> + return [regexp "targets:.*elf32-x86-64" [lindex $status 1]]; >>> +} >>> + >>> if { ![is_elf_format] } then { >>> return >>> } >>> @@ -40,8 +48,11 @@ if { ([istarget "x86_64-*-*"] && ![istarget "x86_64-*-linux*-gnux32"]) } then { >>> run_list_test "scfi-fp-diag-2" "--scfi=experimental" >>> run_list_test "scfi-diag-2" "--scfi=experimental" >>> >>> + if { [gas_x32_check] } then { >>> + run_list_test "scfi-unsupported-1" "--x32 --scfi=experimental" >>> + } >>> run_list_test "scfi-unsupported-1" "--32 --scfi=experimental" >> >> Did it occur to you that this would better also be wrapped in a similar >> check, seeing that gas/i386/x86-64.exp also uses such a conditional? > > I saw that, but I couldn't see why gas_32_check would fail if [istarget > "x86_64-*-*"] is true. > > IIUC, BFD64 must be defined for the case when "if [istarget > "x86_64-*-*"] is true". So seeing the stubs in gas/config/tc-i386.c, I > concluded that --32 should be supported at this point in the > scfi-x86-64.exp. Looks like I am missing something ? While BFD64 is a prereq to building 64-bit code, it says nothing about the supported object formats in a particular build. Conceivably there might be builds which support only 64-bit ELF, at which point use of --32 would fail just like what was observed with --x32. Jan