From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 9EF63394BE17 for ; Fri, 29 Apr 2022 13:43:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9EF63394BE17 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-231-AX5e9kZPM6SXTJclC8OMZA-1; Fri, 29 Apr 2022 09:43:01 -0400 X-MC-Unique: AX5e9kZPM6SXTJclC8OMZA-1 Received: by mail-wr1-f71.google.com with SMTP id e21-20020adfa455000000b0020ae075cf35so3099258wra.11 for ; Fri, 29 Apr 2022 06:43:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=NeDXltONnhC2Fma+tIseCywuJbR60POT0qAAnlmuzt4=; b=ibkxRV8RU1RX64KQ9GmhsujfvUvcnJKrewVgZ0WSQSdlr21rKPjx8SGhXWvWyzET1h nk30kg8t5xqzhWQdyVh4Fdt0KWs4bThNmhHoiuvt2nVfn4it3UM9MIB/OpTjLSUqNSMk 3xn0n0lRS4WH5+YJOsiSleqPymiylw/TXtkPopaZwj/P4OepflA98U3wPqMTzYJl/4VH 1tMflCfRL9XaF4qM+u2KJoAuTTJqBafTIabaFHuryI8UAi7mXd/fQhF1xKUXwDwRXVTg tKUjj4blFV4ZL9BzX7J7VHBSHoYWWiSlLebMI3j/56tfycCbtcJEoU2W09BycxZtBcfG dedQ== X-Gm-Message-State: AOAM5336+Q3E85253PAplklS/x+bZUyjyh0IIKwnnEqeE94IAs53+6O2 YijP2QoDBlgoPVdy4p6tCt85s2az5L27HIexoWkXeGY7WTqW++rLUivR6kU57njazcjELI8cXoG CrN6L7cQZzGCbC5JqrhlWxchoDDiiCD/Q6aPJrt/ia8tiKBF8Rf1rDTEU+DruzzV6/x34Uw== X-Received: by 2002:a05:600c:4f50:b0:393:f258:46ed with SMTP id m16-20020a05600c4f5000b00393f25846edmr3342515wmq.35.1651239779555; Fri, 29 Apr 2022 06:42:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzdJnvgsQG6XS5Wxww6jimz7HbmScwWTupd06ZrTPeAxXXYTnada6J3dlE3uzaaMp/m0PPVfg== X-Received: by 2002:a05:600c:4f50:b0:393:f258:46ed with SMTP id m16-20020a05600c4f5000b00393f25846edmr3342496wmq.35.1651239779256; Fri, 29 Apr 2022 06:42:59 -0700 (PDT) Received: from localhost (host81-136-113-48.range81-136.btcentralplus.com. [81.136.113.48]) by smtp.gmail.com with ESMTPSA id e4-20020a5d6d04000000b0020aef6046bcsm2782406wrq.84.2022.04.29.06.42.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Apr 2022 06:42:58 -0700 (PDT) From: Andrew Burgess To: binutils@sourceware.org Cc: Andrew Burgess Subject: [PATCH 0/2] Disassembler styling for i386-dis.c Date: Fri, 29 Apr 2022 14:42:54 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Apr 2022 13:43:05 -0000 This series builds on commit: commit 60a3da00bd5407f07d64dff82a4dae98230dfaac Date: Sat Jan 22 11:38:18 2022 +0000 objdump/opcodes: add syntax highlighting to disassembler output which introduced a framework for disassembler styling. In this series I extend the minimal styling that currently exists in the i386 disassembler to add full styling for all instruction operands. The i386 disassembler is pretty complex, so it is quite possible that I've missed some corners of it, however, this should not cause any major problems, worst case some output would (when styling is on) end up with the wrong style, or no style at all. That said, in the testing I've done, I'm not seeing anything that's not styled any more, and the styling I do see looks reasonable - though I don't claim to have manually checked every single i386 instruction. If anyone spots any output that is not styling correctly, then please just let me know, and I'm happy to get it sorted. Thanks, Andrew --- Andrew Burgess (2): objdump: fix styled printing of addresses libopcodes: extend the styling within the i386 disassembler binutils/objdump.c | 9 +- opcodes/i386-dis.c | 571 ++++++++++++++++++++++++++------------------- 2 files changed, 337 insertions(+), 243 deletions(-) -- 2.25.4