From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-sender-0.a4lg.com (mail-sender.a4lg.com [153.120.152.154]) by sourceware.org (Postfix) with ESMTPS id 0B4383858295 for ; Sun, 7 Aug 2022 07:40:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0B4383858295 Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 8D476300089; Sun, 7 Aug 2022 07:40:53 +0000 (UTC) From: Tsukasa OI To: Tsukasa OI , Nick Clifton , Jan Beulich , Tristan Gingold Cc: binutils@sourceware.org Subject: [RESEND PATCH 0/1] gas: Minor strings fix on June 2022 (Mach-O part) Date: Sun, 7 Aug 2022 16:40:41 +0900 Message-Id: In-Reply-To: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Aug 2022 07:40:59 -0000 This is a ping. Previous: This patchset contains some minor string improvements I discovered while I'm investigating/translating GAS. Original PATCH 2/2 was merged independently so I will resend PATCH 1/2 only. It seems this is okay to Tristan (Mach-O maintainer) so I request for merge. PATCH 1 : gas/config/obj-macho.c (i18n enablement) On collect_16char_name on this file, there's a formatted error message: > as_bad (_("the %s name '%s' is too long (maximum 16 characters)"), > msg, namstart); collect_16char_name is called by obj_mach_o_get_section_names but it does not wrap input `msg' parameter. Quoting from the function: > if (collect_16char_name (seg, "segment", 1)) > collect_16char_name (sec, "section", 0); The words "segment" and "section" should be wrapped with _(). This is not a problem on French but it IS on Spanish. I quote some Spanish translation from gas/po/es.po: > #: config/obj-macho.c:119 > #, c-format > msgid "the %s name '%s' is too long (maximum 16 characters)" > msgstr "el nombre %s «%s» es demasiado largo (máximo 16 caracteres)" > #: config/tc-aarch64.c:607 config/tc-arm.c:1072 config/tc-i860.c:1003 > #: config/tc-sparc.c:3440 > msgid "bad segment" > msgstr "segmento equivocado" > #: config/tc-alpha.c:4274 > #, c-format > msgid "unknown section attribute %s" > msgstr "atributo seccional %s desconocido" It will have following mappings in French (fr): segment --> segment section --> section On the other hand, it will have following mappings in Spanish (es): segment --> segmento section --> seccional In Japanese (the language I am trying to translate some GAS strings), it will be visiblly significant: Sample message in English: the section name 'ABC...' is too long (maximum 16 characters) Possible Japanese translation without this patch: section 名 'ABC...' が長すぎます (最大 16 文字) Possible Japanese translation with this patch: セクション名 'ABC...' が長すぎます (最大 16 文字) In here, an English word "section" stands out too much in otherwise Japanese message. If we can translate the word "section" (technically, transliterate) to "セクション" (Hepburn: sekushon), the whole sentense gets more natural. It will have following mappings in Japanese: segment --> セグメント section --> セクション I completely understand that the most of Binutils users understand what "section" and "segment" is. However, we usually translate the text containing "section" and "segment" (or at least make them translatable) and we don't want messages with mixed languages. Thanks, Tsukasa Tsukasa OI (1): Mach-O: i18n enablement on some error messages gas/config/obj-macho.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) base-commit: 9663a947c09f63f75491dd4ad2f38fb448142240 -- 2.34.1