From: Andrew Burgess <aburgess@redhat.com>
To: binutils@sourceware.org
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: [PATCHv2 0/2] Disassembler styling for ARM
Date: Sun, 2 Oct 2022 11:47:50 +0100 [thread overview]
Message-ID: <cover.1664707612.git.aburgess@redhat.com> (raw)
In-Reply-To: <cover.1663334366.git.aburgess@redhat.com>
This series adds disassembler styling for ARM.
Changes since v1:
- Patch #1 is now much bigger! The ARM disassembler now uses '@'
consistently for its comment character. This is a minor change in
the disassembler, but a huge change in the expected test results.
I believe I've fixed all the tests; I'm not seeing any failures,
but as always, I suspect I will have missed something. I
apologies in advance, and hopefully, it should be pretty easy to
update any tests I've missed.
- Patch #2 is largely unchanged. The only difference is that we now
look for '@' to indicate the start of a comment instead of ';'.
All feedback welcome.
Thanks,
Andrew
---
Andrew Burgess (2):
opcodes/arm: use '@' consistently for the comment character
opcodes/arm: add disassembler styling for arm
.../testsuite/binutils-all/arm/objdump.exp | 4 +-
gas/testsuite/gas/arm/adr.d | 2 +-
gas/testsuite/gas/arm/adrl.d | 20 +-
gas/testsuite/gas/arm/arch4t-eabi.d | 8 +-
gas/testsuite/gas/arm/arch4t.d | 8 +-
gas/testsuite/gas/arm/arch7.d | 4 +-
gas/testsuite/gas/arm/arch7a-mp.d | 6 +-
gas/testsuite/gas/arm/arch7r-mp.d | 6 +-
gas/testsuite/gas/arm/archv6t2.d | 10 +-
gas/testsuite/gas/arm/archv8m-base.d | 12 +-
gas/testsuite/gas/arm/archv8m-main-dsp-1.d | 12 +-
gas/testsuite/gas/arm/archv8m-main.d | 12 +-
gas/testsuite/gas/arm/arm3.d | 2 +-
gas/testsuite/gas/arm/arm6.d | 4 +-
gas/testsuite/gas/arm/arm7dm.d | 6 +-
gas/testsuite/gas/arm/arm7t.d | 26 +-
gas/testsuite/gas/arm/armv1.d | 8 +-
gas/testsuite/gas/arm/armv7-a+virt.d | 4 +-
.../gas/arm/armv8-2-fp16-scalar-ext.d | 8 +-
.../gas/arm/armv8-2-fp16-scalar-thumb-ext.d | 8 +-
.../gas/arm/armv8-2-fp16-scalar-thumb.d | 8 +-
gas/testsuite/gas/arm/armv8-2-fp16-scalar.d | 8 +-
gas/testsuite/gas/arm/armv8.1-m.main-fp.d | 70 +-
gas/testsuite/gas/arm/armv8.1-m.main-hp.d | 8 +-
gas/testsuite/gas/arm/bl-local-2.d | 10 +-
gas/testsuite/gas/arm/bl-local-v4t.d | 10 +-
gas/testsuite/gas/arm/blx-bad.d | 14 +-
gas/testsuite/gas/arm/blx-local-thumb.d | 10 +-
gas/testsuite/gas/arm/blx-local.d | 12 +-
gas/testsuite/gas/arm/branch-reloc.d | 10 +-
gas/testsuite/gas/arm/ccs.d | 2 +-
.../gas/arm/copro-arm_v2plus-arm_v2.d | 8 +-
.../gas/arm/copro-arm_v5plus-arm_v5.d | 4 +-
.../arm/copro-thumb_v6t2plus-thumb_v6t2-1.d | 4 +-
.../arm/copro-thumb_v6t2plus-thumb_v6t2-2.d | 4 +-
gas/testsuite/gas/arm/crc32-armv8-a-bad.d | 24 +-
gas/testsuite/gas/arm/crc32-armv8-r-bad.d | 24 +-
gas/testsuite/gas/arm/dis-data3.d | 2 +-
gas/testsuite/gas/arm/el_segundo.d | 2 +-
gas/testsuite/gas/arm/float.d | 2 +-
gas/testsuite/gas/arm/group-reloc-alu.d | 160 +-
gas/testsuite/gas/arm/group-reloc-ldrs.d | 240 +-
gas/testsuite/gas/arm/immed.d | 10 +-
gas/testsuite/gas/arm/immed2.d | 2 +-
gas/testsuite/gas/arm/inst.d | 36 +-
gas/testsuite/gas/arm/iwmmxt.d | 2 +-
gas/testsuite/gas/arm/ldconst.d | 42 +-
gas/testsuite/gas/arm/ldr-global.d | 14 +-
gas/testsuite/gas/arm/ldr-t.d | 16 +-
gas/testsuite/gas/arm/ldr.d | 10 +-
gas/testsuite/gas/arm/ldst-offset0.d | 6 +-
gas/testsuite/gas/arm/ldst-pc.d | 8 +-
gas/testsuite/gas/arm/m0-load-pseudo.d | 4 +-
gas/testsuite/gas/arm/m23-load-pseudo.d | 4 +-
gas/testsuite/gas/arm/m33-load-pseudo.d | 4 +-
gas/testsuite/gas/arm/macro1.d | 6 +-
gas/testsuite/gas/arm/mapdir.d | 4 +-
gas/testsuite/gas/arm/mapmisc.d | 38 +-
gas/testsuite/gas/arm/mapsecs.d | 10 +-
gas/testsuite/gas/arm/mapshort-eabi.d | 10 +-
gas/testsuite/gas/arm/mapshort-elf.d | 10 +-
gas/testsuite/gas/arm/mask_1-armv8-a.d | 32 +-
gas/testsuite/gas/arm/mask_1-armv8-r.d | 32 +-
gas/testsuite/gas/arm/mrs-msr-arm-v6.d | 6 +-
gas/testsuite/gas/arm/mrs-msr-arm-v7-a.d | 6 +-
gas/testsuite/gas/arm/msr-imm.d | 268 +-
gas/testsuite/gas/arm/mve-vand.d | 94 +-
gas/testsuite/gas/arm/mve-vbic.d | 20 +-
gas/testsuite/gas/arm/mve-vcvt-3.d | 80 +-
gas/testsuite/gas/arm/mve-vmov-1.d | 20 +-
gas/testsuite/gas/arm/mve-vmov-2.d | 34 +-
.../gas/arm/mve-vmov-vmvn-vorr-vbic.d | 64 +-
gas/testsuite/gas/arm/mve-vmvn.d | 114 +-
gas/testsuite/gas/arm/mve-vorn.d | 22 +-
gas/testsuite/gas/arm/mve-vorr.d | 20 +-
gas/testsuite/gas/arm/neon-cond-bad_t2.d | 4 +-
gas/testsuite/gas/arm/neon-const.d | 516 ++--
gas/testsuite/gas/arm/neon-cov.d | 564 ++--
gas/testsuite/gas/arm/neon-ldst-rm.d | 4 +-
gas/testsuite/gas/arm/neon-logic.d | 8 +-
gas/testsuite/gas/arm/nops.d | 2 +-
gas/testsuite/gas/arm/offset-1.d | 8 +-
gas/testsuite/gas/arm/offset.d | 8 +-
gas/testsuite/gas/arm/pr21458.d | 14 +-
gas/testsuite/gas/arm/pr24907.d | 6 +-
gas/testsuite/gas/arm/pr25235.d | 14 +-
gas/testsuite/gas/arm/push-pop.d | 8 +-
gas/testsuite/gas/arm/reg-alias.d | 6 +-
gas/testsuite/gas/arm/relax_branch_align.d | 8 +-
gas/testsuite/gas/arm/relax_load_align.d | 6 +-
gas/testsuite/gas/arm/sp-pc-usage-t.d | 8 +-
gas/testsuite/gas/arm/tcompat.d | 6 +-
gas/testsuite/gas/arm/tcompat2.d | 8 +-
gas/testsuite/gas/arm/thumb-eabi.d | 42 +-
gas/testsuite/gas/arm/thumb-nop.d | 4 +-
gas/testsuite/gas/arm/thumb.d | 42 +-
gas/testsuite/gas/arm/thumb1_unified.d | 4 +-
gas/testsuite/gas/arm/thumb2_add.d | 38 +-
gas/testsuite/gas/arm/thumb2_invert.d | 24 +-
gas/testsuite/gas/arm/thumb2_pool.d | 32 +-
gas/testsuite/gas/arm/thumb2_relax.d | 52 +-
gas/testsuite/gas/arm/thumb2_vpool.d | 158 +-
gas/testsuite/gas/arm/thumb2_vpool_be.d | 158 +-
gas/testsuite/gas/arm/thumb32.d | 186 +-
gas/testsuite/gas/arm/thumbv6.d | 8 +-
gas/testsuite/gas/arm/thumbv6k.d | 8 +-
gas/testsuite/gas/arm/tls.d | 14 +-
gas/testsuite/gas/arm/tls_vxworks.d | 6 +-
gas/testsuite/gas/arm/udf.d | 24 +-
gas/testsuite/gas/arm/unpredictable.d | 2 +-
gas/testsuite/gas/arm/vfp-mov-enc.d | 18 +-
gas/testsuite/gas/arm/vfp-neon-overlap.d | 8 +-
gas/testsuite/gas/arm/vfp1.d | 6 +-
gas/testsuite/gas/arm/vfp1xD.d | 76 +-
gas/testsuite/gas/arm/vfp1xD_t2.d | 70 +-
gas/testsuite/gas/arm/vfpv3-32drs.d | 6 +-
gas/testsuite/gas/arm/vldconst.d | 246 +-
gas/testsuite/gas/arm/vldconst_be.d | 246 +-
gas/testsuite/gas/arm/vldr.d | 4 +-
gas/testsuite/gas/arm/wince.d | 12 +-
gas/testsuite/gas/arm/wince_inst.d | 36 +-
gas/testsuite/gas/arm/xscale.d | 4 +-
ld/testsuite/ld-arm/arm-app-abs32.d | 8 +-
ld/testsuite/ld-arm/arm-app.d | 6 +-
ld/testsuite/ld-arm/arm-be8.d | 2 +-
ld/testsuite/ld-arm/arm-call.d | 8 +-
ld/testsuite/ld-arm/arm-lib-plt32.d | 6 +-
ld/testsuite/ld-arm/arm-lib.d | 6 +-
ld/testsuite/ld-arm/arm-movwt.d | 40 +-
ld/testsuite/ld-arm/arm-pic-veneer.d | 4 +-
ld/testsuite/ld-arm/armthumb-lib.d | 16 +-
ld/testsuite/ld-arm/attr-merge-wchar-24.d | 2 +-
ld/testsuite/ld-arm/attr-merge-wchar-42.d | 2 +-
ld/testsuite/ld-arm/callweak.d | 2 +-
ld/testsuite/ld-arm/cortex-a8-far.d | 6 +-
ld/testsuite/ld-arm/cortex-a8-fix-b-plt.d | 8 +-
ld/testsuite/ld-arm/cortex-a8-fix-bcc-plt.d | 8 +-
ld/testsuite/ld-arm/cortex-a8-fix-bl-plt.d | 8 +-
.../ld-arm/cortex-a8-fix-bl-rel-plt.d | 8 +-
ld/testsuite/ld-arm/cortex-a8-fix-blx-plt.d | 8 +-
.../ld-arm/farcall-arm-arm-pic-veneer.d | 2 +-
ld/testsuite/ld-arm/farcall-arm-arm.d | 2 +-
ld/testsuite/ld-arm/farcall-arm-nacl-pic.d | 4 +-
ld/testsuite/ld-arm/farcall-arm-nacl.d | 4 +-
.../ld-arm/farcall-arm-thumb-blx-pic-veneer.d | 2 +-
ld/testsuite/ld-arm/farcall-arm-thumb-blx.d | 2 +-
.../ld-arm/farcall-arm-thumb-pic-veneer.d | 2 +-
ld/testsuite/ld-arm/farcall-arm-thumb.d | 2 +-
ld/testsuite/ld-arm/farcall-data-nacl.d | 4 +-
ld/testsuite/ld-arm/farcall-data.d | 2 +-
ld/testsuite/ld-arm/farcall-group-limit.d | 2 +-
ld/testsuite/ld-arm/farcall-group-size2.d | 10 +-
ld/testsuite/ld-arm/farcall-group.d | 10 +-
ld/testsuite/ld-arm/farcall-mix.d | 10 +-
ld/testsuite/ld-arm/farcall-mix2.d | 10 +-
ld/testsuite/ld-arm/farcall-mixed-app-v5.d | 26 +-
ld/testsuite/ld-arm/farcall-mixed-app.d | 26 +-
ld/testsuite/ld-arm/farcall-mixed-app2.d | 28 +-
ld/testsuite/ld-arm/farcall-mixed-lib-v4t.d | 36 +-
ld/testsuite/ld-arm/farcall-mixed-lib.d | 24 +-
.../ld-arm/farcall-thumb-arm-blx-pic-veneer.d | 2 +-
ld/testsuite/ld-arm/farcall-thumb-arm-blx.d | 2 +-
.../ld-arm/farcall-thumb-arm-pic-veneer.d | 2 +-
ld/testsuite/ld-arm/farcall-thumb-arm.d | 2 +-
.../farcall-thumb-thumb-blx-pic-veneer.d | 2 +-
ld/testsuite/ld-arm/farcall-thumb-thumb-blx.d | 2 +-
.../ld-arm/farcall-thumb-thumb-m-no-profile.d | 2 +-
.../ld-arm/farcall-thumb-thumb-m-pic-veneer.d | 2 +-
ld/testsuite/ld-arm/farcall-thumb-thumb-m.d | 2 +-
.../ld-arm/farcall-thumb-thumb-pic-veneer.d | 2 +-
ld/testsuite/ld-arm/farcall-thumb-thumb.d | 2 +-
ld/testsuite/ld-arm/farcall-thumb2-purecode.d | 2 +-
ld/testsuite/ld-arm/farcall-thumb2-thumb2-m.d | 2 +-
ld/testsuite/ld-arm/fdpic-main-m.d | 16 +-
ld/testsuite/ld-arm/fdpic-main.d | 16 +-
ld/testsuite/ld-arm/fdpic-shared-m.d | 4 +-
ld/testsuite/ld-arm/fdpic-shared.d | 4 +-
ld/testsuite/ld-arm/fix-arm1176-off.d | 2 +-
ld/testsuite/ld-arm/fix-arm1176-on.d | 2 +-
ld/testsuite/ld-arm/gc-hidden-1.d | 2 +-
ld/testsuite/ld-arm/group-relocs.d | 58 +-
ld/testsuite/ld-arm/ifunc-1.dd | 50 +-
ld/testsuite/ld-arm/ifunc-10.dd | 236 +-
ld/testsuite/ld-arm/ifunc-11.dd | 28 +-
ld/testsuite/ld-arm/ifunc-12.dd | 28 +-
ld/testsuite/ld-arm/ifunc-13.dd | 28 +-
ld/testsuite/ld-arm/ifunc-14.dd | 42 +-
ld/testsuite/ld-arm/ifunc-15.dd | 42 +-
ld/testsuite/ld-arm/ifunc-16.dd | 36 +-
ld/testsuite/ld-arm/ifunc-17.dd | 2 +-
ld/testsuite/ld-arm/ifunc-2.dd | 146 +-
ld/testsuite/ld-arm/ifunc-3.dd | 40 +-
ld/testsuite/ld-arm/ifunc-4.dd | 236 +-
ld/testsuite/ld-arm/ifunc-5.dd | 26 +-
ld/testsuite/ld-arm/ifunc-6.dd | 38 +-
ld/testsuite/ld-arm/ifunc-7.dd | 18 +-
ld/testsuite/ld-arm/ifunc-8.dd | 118 +-
ld/testsuite/ld-arm/ifunc-9.dd | 56 +-
.../jump-reloc-veneers-cond-long-backward.d | 2 +-
.../ld-arm/jump-reloc-veneers-cond-long.d | 2 +-
ld/testsuite/ld-arm/jump-reloc-veneers-long.d | 2 +-
ld/testsuite/ld-arm/long-plt-format.d | 4 +-
ld/testsuite/ld-arm/mixed-app-v5.d | 26 +-
ld/testsuite/ld-arm/mixed-app.d | 26 +-
ld/testsuite/ld-arm/mixed-lib.d | 12 +-
ld/testsuite/ld-arm/movw-merge.d | 4 +-
ld/testsuite/ld-arm/non-contiguous-arm2.d | 10 +-
ld/testsuite/ld-arm/non-contiguous-arm3.d | 12 +-
ld/testsuite/ld-arm/non-contiguous-arm5.d | 10 +-
ld/testsuite/ld-arm/non-contiguous-arm6.d | 12 +-
.../ld-arm/stm32l4xx-cannot-fix-far-ldm.d | 2 +-
ld/testsuite/ld-arm/stm32l4xx-fix-ldm.d | 8 +-
ld/testsuite/ld-arm/stm32l4xx-fix-vldm-dp.d | 2 +-
ld/testsuite/ld-arm/stm32l4xx-fix-vldm.d | 2 +-
ld/testsuite/ld-arm/thumb-plt.d | 4 +-
ld/testsuite/ld-arm/thumb1-adds.d | 12 +-
ld/testsuite/ld-arm/thumb1-movs.d | 10 +-
ld/testsuite/ld-arm/thumb2-bl-as-thumb1-bad.d | 2 +-
ld/testsuite/ld-arm/thumb2-bl-bad.d | 2 +-
ld/testsuite/ld-arm/tls-app.d | 4 +-
ld/testsuite/ld-arm/tls-descrelax-be32.d | 112 +-
ld/testsuite/ld-arm/tls-descrelax-be8.d | 78 +-
ld/testsuite/ld-arm/tls-descrelax-v7.d | 78 +-
ld/testsuite/ld-arm/tls-descrelax.d | 112 +-
ld/testsuite/ld-arm/tls-descseq.d | 20 +-
ld/testsuite/ld-arm/tls-gdesc-neg.d | 14 +-
ld/testsuite/ld-arm/tls-gdesc.d | 22 +-
ld/testsuite/ld-arm/tls-gdierelax.d | 8 +-
ld/testsuite/ld-arm/tls-gdierelax2.d | 10 +-
ld/testsuite/ld-arm/tls-gdlerelax.d | 4 +-
ld/testsuite/ld-arm/tls-lib-loc.d | 14 +-
ld/testsuite/ld-arm/tls-lib.d | 4 +-
ld/testsuite/ld-arm/tls-longplt-lib.d | 28 +-
ld/testsuite/ld-arm/tls-longplt.d | 30 +-
ld/testsuite/ld-arm/tls-thumb1.d | 36 +-
ld/testsuite/ld-arm/vxworks1-lib.dd | 12 +-
ld/testsuite/ld-arm/vxworks1.dd | 10 +-
opcodes/arm-dis.c | 2660 ++++++++++-------
238 files changed, 5146 insertions(+), 4518 deletions(-)
--
2.25.4
next prev parent reply other threads:[~2022-10-02 10:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 13:21 [PATCH " Andrew Burgess
2022-09-16 13:21 ` [PATCH 1/2] opcodes/arm: add missing ';' characters Andrew Burgess
2022-09-20 15:13 ` Richard Earnshaw
2022-09-22 9:08 ` Andrew Burgess
2022-09-22 12:39 ` Richard Earnshaw
2022-09-22 18:20 ` Andrew Burgess
2022-09-16 13:21 ` [PATCH 2/2] opcodes/arm: add disassembler styling for arm Andrew Burgess
2022-10-02 10:47 ` Andrew Burgess [this message]
2022-10-02 10:47 ` [PATCHv2 1/2] opcodes/arm: use '@' consistently for the comment character Andrew Burgess
2022-10-03 16:37 ` Andrew Burgess
2022-10-02 10:47 ` [PATCHv2 2/2] opcodes/arm: add disassembler styling for arm Andrew Burgess
2022-10-12 12:42 ` Andrew Burgess
2022-10-19 10:10 ` [PATCHv2 0/2] Disassembler styling for ARM Andrew Burgess
2022-10-31 14:59 ` Nick Clifton
2022-11-01 9:37 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1664707612.git.aburgess@redhat.com \
--to=aburgess@redhat.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).