From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-sender-0.a4lg.com (mail-sender.a4lg.com [153.120.152.154]) by sourceware.org (Postfix) with ESMTPS id A4AE33858D1E; Tue, 4 Oct 2022 08:59:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A4AE33858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=irq.a4lg.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=irq.a4lg.com Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 2614C300089; Tue, 4 Oct 2022 08:59:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irq.a4lg.com; s=2017s01; t=1664873961; bh=7a9khYzESloqUwrTs6DUVdrJxTfZxefCXY+CSaeY0Qs=; h=From:To:Cc:Subject:Date:Message-Id:Mime-Version: Content-Transfer-Encoding; b=j3zzwkfhs96QTuZAzyApeYYkb1NGRJZvvml3u45VlGQmaITOFIexx+QxTuq/8zDtU O4tuwZtw+lktEStarRwp9VKHaoiRAlXP9dqnazBznbtjyA8NXSn6kZbJZtXh/W47Ih E8dueb9MUcHvy56WNjQUzkfO2BK3ZQdA/SQZxpCc= From: Tsukasa OI To: Tsukasa OI , Nelson Chu , Kito Cheng , Palmer Dabbelt , Andrew Burgess , Jan Beulich Cc: binutils@sourceware.org, gdb-patches@sourceware.org Subject: [PATCH 0/2] RISC-V: Fix buffer overflow after long instruction support Date: Tue, 4 Oct 2022 08:59:06 +0000 Message-Id: Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KAM_MANYTO,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, After commit bb996692bd9 "RISC-V/gas: allow generating up to 176-bit instructions with .insn", I started to see some crashes while running "make check-gas". The cause was simple. Some functions depended on the fact that maximum length returned by riscv_insn_length is 8. But since the commit above increased that upper limit from 64-bits (8 bytes) to 176-bits (22 bytes), we need to increase two buffer sizes to avoid crashes. But note that this change doesn't really support over 64-bit instructions. It can be said on riscv_insn::fetch_instruction because it now may return only a part of instruction. Instead of merging this, reverting that commit (for now) might be an option. PATCH 1: Binutils PATCH 2: GDB Thanks, Tsukasa Tsukasa OI (2): RISC-V: Fix buffer overflow on print_insn_riscv gdb/riscv: Fix buffer overflow on riscv_insn::fetch_instruction gdb/riscv-tdep.c | 2 +- opcodes/riscv-dis.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) base-commit: 034235cebd790d4f9a1728043a175d7d7d9338b1 -- 2.34.1