public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Tsukasa OI <research_trasio@irq.a4lg.com>
To: Tsukasa OI <research_trasio@irq.a4lg.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Andrew Waterman <andrew@sifive.com>,
	Jim Wilson <jim.wilson.gcc@gmail.com>,
	Nelson Chu <nelson@rivosinc.com>,
	Kito Cheng <kito.cheng@sifive.com>,
	Jeff Law <jlaw@ventanamicro.com>,
	Greg Favor <gfavor@ventanamicro.com>
Cc: binutils@sourceware.org
Subject: [PATCH 0/1] RISC-V: Make XVentanaCondOps RV64 only
Date: Wed, 30 Aug 2023 01:38:33 +0000	[thread overview]
Message-ID: <cover.1693359513.git.research_trasio@irq.a4lg.com> (raw)

Hello,

I noticed that two instructions in the XVentanaCondOps vendor extension --
"vt.maskc" and "vt.maskcn" -- are defined for all XLEN values.

This is against the manual and LLVM.


1. The instruction manual

<https://github.com/ventanamicro/ventana-custom-extensions/releases/download/v1.0.0/ventana-custom-extensions-v1.0.0.pdf>

Currently defines the instructions only for RV64.

> All current cores by Ventana Micro implement RV64 and are designed as
> 64-bit only, the RV32-column is marked "n/a".

But it also says it's (in theory) XLEN-agonistic.

> The instructions in the XVentanaCondOps extension are defined to operate
> on XLEN and would thus be directly applicable to RV32.


2. LLVM (llvm/lib/Target/RISCV/RISCVInstrInfoXVentana.td)

> let Predicates = [IsRV64, HasVendorXVentanaCondOps]

It indicates that XVentanaCondOps instructions are only enabled on RV64.



Unless Ventana is working on some RV32 processors (and soon to be released
), I think disabling XVentanaCondOps instructions on RV32 would be safer
(to prevent possible misuses).  I would like to hear thoughts especially
from Ventana employees since I am just a volunteer.

I also chose not to reject XVentanaCondOps + RV32 because it is not stated
that is illegal (unlike Zcf + RV64).  This patch set makes XVentanaCondOps
+ RV32 empty (yet legal).


Sincerely,
Tsukasa




Tsukasa OI (1):
  RISC-V: Make XVentanaCondOps RV64 only

 gas/testsuite/gas/riscv/x-ventana-condops-32.d | 3 +++
 gas/testsuite/gas/riscv/x-ventana-condops-32.l | 3 +++
 opcodes/riscv-opc.c                            | 4 ++--
 3 files changed, 8 insertions(+), 2 deletions(-)
 create mode 100644 gas/testsuite/gas/riscv/x-ventana-condops-32.d
 create mode 100644 gas/testsuite/gas/riscv/x-ventana-condops-32.l


base-commit: 0637da3c7325b28a2c05f016d7f290513b1cd19b
-- 
2.42.0


             reply	other threads:[~2023-08-30  1:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-30  1:38 Tsukasa OI [this message]
2023-08-30  1:38 ` [PATCH 1/1] " Tsukasa OI
2023-08-30  2:45   ` Nelson Chu
2023-08-30  2:48     ` Tsukasa OI
2023-08-30  3:21 ` [PATCH 0/1] " Greg Favor
2023-08-30  3:59   ` Tsukasa OI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1693359513.git.research_trasio@irq.a4lg.com \
    --to=research_trasio@irq.a4lg.com \
    --cc=andrew@sifive.com \
    --cc=binutils@sourceware.org \
    --cc=gfavor@ventanamicro.com \
    --cc=jim.wilson.gcc@gmail.com \
    --cc=jlaw@ventanamicro.com \
    --cc=kito.cheng@sifive.com \
    --cc=nelson@rivosinc.com \
    --cc=palmer@dabbelt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).