From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 63B9D3858C54 for ; Mon, 9 May 2022 05:44:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 63B9D3858C54 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2491BGqN009854 for ; Mon, 9 May 2022 05:44:21 GMT Received: from ppma01fra.de.ibm.com (46.49.7a9f.ip4.static.sl-reverse.com [159.122.73.70]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3fx2ph2bpv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 09 May 2022 05:44:21 +0000 Received: from pps.filterd (ppma01fra.de.ibm.com [127.0.0.1]) by ppma01fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2495iJGY016950 for ; Mon, 9 May 2022 05:44:19 GMT Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by ppma01fra.de.ibm.com with ESMTP id 3fwgd8hh8j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 09 May 2022 05:44:18 +0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2495iFVg59113778 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 9 May 2022 05:44:15 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 978CFAE045; Mon, 9 May 2022 05:44:15 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6A118AE053; Mon, 9 May 2022 05:44:15 +0000 (GMT) Received: from [9.171.4.36] (unknown [9.171.4.36]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 9 May 2022 05:44:15 +0000 (GMT) Message-ID: Date: Mon, 9 May 2022 07:44:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v2] IBM zSystems: Accept (. - 0x100000000) PCRel32 operands Content-Language: en-US To: Ilya Leoshkevich Cc: binutils@sourceware.org References: <20220504103648.1724970-1-iii@linux.ibm.com> From: Andreas Krebbel In-Reply-To: <20220504103648.1724970-1-iii@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: qOWMXhZMbuuykkITWblPKd_65ahMqGp_ X-Proofpoint-ORIG-GUID: qOWMXhZMbuuykkITWblPKd_65ahMqGp_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-09_01,2022-05-06_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 mlxlogscore=852 priorityscore=1501 lowpriorityscore=0 malwarescore=0 spamscore=0 phishscore=0 impostorscore=0 mlxscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205090032 X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 May 2022 05:44:23 -0000 On 5/4/22 12:36, Ilya Leoshkevich wrote: > as does not accept instructions like brasl %r0,.-0x100000000, because > of two problems with the generic overflow check: > > 1. PCRel32 operands are signed, but are treated as unsigned. > > 2. The allowed range for these operands is [-(1 << 32), (1 << 32) - 1], > and not [-(1 << 31), (1 << 31) - 1]. > > Fix both by disabling the generic overflow check - it's not needed, > because s390_insert_operand () performs its own. > > gas/ChangeLog: > > * config/tc-s390.c (md_gather_operands): Set fx_no_overflow. > * testsuite/gas/s390/s390.exp: Add zarch-z900-err. > * testsuite/gas/s390/esa-z900.d: New test. > * testsuite/gas/s390/esa-z900.s: New test. > * testsuite/gas/s390/zarch-z900-err.l: New test. > * testsuite/gas/s390/zarch-z900-err.s: New test. Ok. Thanks! Andreas