From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 1C7E9385803D for ; Fri, 26 Jan 2024 09:01:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1C7E9385803D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1C7E9385803D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706259701; cv=none; b=OnlXFqUWTvtdSkG6RzzpBx1QABKRKBOYuhWm6rR/Va3dsYOvXtgJcIorWEdFcGAxhbIAocH42mrWFNAtGK9obtE9+0Bk5mIm/u+3K/5OxwJnOQE1CtoiQhDAjZtWjDTin/TfmNGByHY8BncZyF6LYXe3H/X9qRaUaW7nQITiEvo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706259701; c=relaxed/simple; bh=sAfbZGN/Fi3bvB10uhu/0l6ylEuIZkXuC6emsRMIZlg=; h=Subject:To:From:Message-ID:Date:MIME-Version; b=UP0q2y8xnihj7nAswF4L2Anw63XTfSwpM6b57umpDb/Z/tR2PWa14GHxa/5flNteNW7mGh4KVMocrxL/PtXrx2y8u0GhkBKYYX0hJNjZYvykw3hCaVSdzxsu9WwDSTjZWqW/j3RzQXN5m+H6nH2OT99xYzNCaPqgiC4jIfjjsuA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from loongson.cn (unknown [10.20.4.171]) by gateway (Coremail) with SMTP id _____8AxjuvpdLNlJDAGAA--.21520S3; Fri, 26 Jan 2024 17:01:30 +0800 (CST) Received: from [10.20.4.171] (unknown [10.20.4.171]) by localhost.localdomain (Coremail) with SMTP id AQAAf8BxVMzodLNlx8IbAA--.59190S3; Fri, 26 Jan 2024 17:01:28 +0800 (CST) Subject: Re: [PATCH] LoongArch: Fix a bug of getting relocation type To: Nick Clifton References: <20240126033932.3577932-1-mengqinggang@loongson.cn> Cc: binutils@sourceware.org From: mengqinggang Message-ID: Date: Fri, 26 Jan 2024 17:01:28 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20240126033932.3577932-1-mengqinggang@loongson.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8BxVMzodLNlx8IbAA--.59190S3 X-CM-SenderInfo: 5phqw15lqjwttqj6z05rqj20fqof0/ X-Coremail-Antispam: 1Uk129KBj9xXoWrZry3Ww4xtF4UXF13JF45twc_yoWkWFb_KF Wftr1UursrtrWFyr1Yqw1fuFyrXF4rWFs2yFyqvr1xGw17XFnYyrnI934SkF1YgFWfXwn8 urWqqr13Aw43ZosvyTuYvTs0mTUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUj1kv1TuYvT s0mT0YCTnIWjqI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUI cSsGvfJTRUUUbIxYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20x vaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxS w2x7M28EF7xvwVC0I7IYx2IY67AKxVW8JVW5JwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxV W8JVWxJwA2z4x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v2 6r4UJVWxJr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27w Aqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_JrI_JrylYx0Ex4A2jsIE 14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1c AE67vIY487MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8C rVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUXVWUAw CIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x02 67AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Gr 0_Cr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU1wL 05UUUUU== X-Spam-Status: No, score=-14.3 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Nick, This patch and 969f5c0e1        LoongArch: gas: Add support for s9 register a0aa6f4ab        LoongArch: ld: Add support for TLS LE symbol with addend need to apply to 2.42 branch. 在 2024/1/26 上午11:39, mengqinggang 写道: > The old code works because R_LARCH_RELAX has no symbol index. It causes > '(rel + 1)->r_info == R_LARCH_RELAX' is 1 and ELFNN_R_TYPE (1) is 1. > --- > bfd/elfnn-loongarch.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c > index b2caa5fc3e1..0cc6273726c 100644 > --- a/bfd/elfnn-loongarch.c > +++ b/bfd/elfnn-loongarch.c > @@ -4166,7 +4166,7 @@ loongarch_relax_tls_le (bfd *abfd, asection *sec, > static uint32_t insn_rj,insn_rd; > symval = symval - elf_hash_table (link_info)->tls_sec->vma; > /* Whether the symbol offset is in the interval (offset < 0x800). */ > - if (ELFNN_R_TYPE ((rel + 1)->r_info == R_LARCH_RELAX) && (symval < 0x800)) > + if (ELFNN_R_TYPE ((rel + 1)->r_info) == R_LARCH_RELAX && (symval < 0x800)) > { > switch (ELFNN_R_TYPE (rel->r_info)) > {