From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4C304385829E for ; Mon, 15 Aug 2022 11:07:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4C304385829E Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-322-rUYzdvYwOH6eyD_HGSlKvQ-1; Mon, 15 Aug 2022 07:07:50 -0400 X-MC-Unique: rUYzdvYwOH6eyD_HGSlKvQ-1 Received: by mail-wr1-f72.google.com with SMTP id v20-20020adf8b54000000b002216d3e3d5dso1077996wra.12 for ; Mon, 15 Aug 2022 04:07:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=ipTYCqR1VTQgRuGAiKrMlz6Ekrtk/wYz1tp4WiHR8kM=; b=NTPESkWaP4kdYdU993AEXhTB2MFV8MUCLfIfZQiUkArz/cfxZhvBE7QgKTWA79/Udm 0/GmEPPE4gbMNLLtDxwcyJ94kcWgtHqfYw6coPIQ6Ev/ylq3xISrmsUYAKhhJ983ftkx OC/qY/U4EFrV0pmEhOd8NOq5oTxh1enK8tHE8q8kIPNlub9mvRq7pVhYJglMPmDAgWTJ I7BpBEzU2BGVlyTi0rod3LNaQeCHbstRXJ9Aney0CtF+3yu475HKGT7eY846WWDToBNN oyePUvZI0yKOJOXbwuiFzLNSJkaHMEYOTm6hBOlah5mZFGxGqx+QK11Jd2LdpHsBv9E4 A2gA== X-Gm-Message-State: ACgBeo063oNCc+MA1o14ByH2B3g3qKq0058HT6h4IR0RN8V+oZfWUc7b b1Gdb7YMWJqv1ocEHZarRvPv+B2T0xh+ijZECEYBP4Xn6nDkVJYiLeqA0z1gym9YckhaJkt+Raf KYrTP0llDmAdAjQx2qQ== X-Received: by 2002:a5d:5964:0:b0:222:ed7f:4418 with SMTP id e36-20020a5d5964000000b00222ed7f4418mr8360385wri.133.1660561669802; Mon, 15 Aug 2022 04:07:49 -0700 (PDT) X-Google-Smtp-Source: AA6agR67VDeXO6PX12oSsQekchO0qmWp213zL2EF2uvOaXjghvOQD+Rq8I437mx/dp6K3lyz6fVRwg== X-Received: by 2002:a5d:5964:0:b0:222:ed7f:4418 with SMTP id e36-20020a5d5964000000b00222ed7f4418mr8360373wri.133.1660561669645; Mon, 15 Aug 2022 04:07:49 -0700 (PDT) Received: from [192.168.1.6] (adsl-2-solo-236-177.claranet.co.uk. [80.168.236.177]) by smtp.gmail.com with ESMTPSA id q25-20020a1ce919000000b003a601707174sm528945wmc.33.2022.08.15.04.07.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Aug 2022 04:07:49 -0700 (PDT) Message-ID: Date: Mon, 15 Aug 2022 12:07:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] bfd: handle codepage when opening files on MinGW To: Luis Machado , =?UTF-8?Q?Cl=c3=a9ment_Chigot?= , binutils@sourceware.org Cc: Torbjorn SVENSSON References: <2fe3fe60-4039-b9e8-4212-4d9f62e270cc@arm.com> From: Nick Clifton In-Reply-To: <2fe3fe60-4039-b9e8-4212-4d9f62e270cc@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Aug 2022 11:07:53 -0000 Hi Luis, > In fact, trying to build master binutils-gdb with Ubuntu 22.04's mingw-w64 8.0 or Ubuntu 20.04's mingw-w64 7.0.0 runs > into the following: > > bfd/bfdio.c: In function ‘_bfd_real_fopen’: > bfd/bfdio.c:125:28: error: implicit declaration of function ‘___lc_codepage_func’ [-Werror=implicit-function-declaration] >   125 |    const unsigned int cp = ___lc_codepage_func(); So that would imply a missing #include of a system header, yes ? Do you know which header provides the required prototype ? The code is currently conditional upon __MINGW32__ being defined. Perhaps that check needs to be extended/changed to reference a different preprocessor symbol ? Cheers Nick