From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by sourceware.org (Postfix) with ESMTPS id 18D893858431 for ; Tue, 21 May 2024 12:24:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 18D893858431 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 18D893858431 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::52b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716294290; cv=none; b=J5VWlQ+nUwgnEdLpSvN1oCz8mc0PEkGOzBixFmklmS4thULlbPG8Zv5Zu/ND+MJTNlSL0bFQtx8v3awA5xMFw+Ag5L9bHQzf++XLhL6En1Jim9lo8xCR/5mgwvZJK0yYs7wuUYvE8Ub2Kgc5HYN8g9g+FvdHRIw/azomE/1s1A4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716294290; c=relaxed/simple; bh=mIezb8HlZ7kuYREDdnCw6TGjzEaF80O0pM+htUaOrFI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=iECJ+GT+DL1W5J3BS0ONAhXlSbnwWs+OOnhp7R/oQAGGzZVg8/C7Cl9d+gwzMTQRCs5/r/7/l3kJumiwN2VfPwUaZBMW41dKuuJkmsP0z5hoq/GHtq52NLSbzrA6AcviAOG1UlURgVUzTbdK7ITV/ZIoge4Toa2DmT/srhNU1tc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-572af0b12b8so8362169a12.2 for ; Tue, 21 May 2024 05:24:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1716294286; x=1716899086; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MTSiuCivQfgXx/RITifHeDOILjJqdYnLFyF13FB9fSw=; b=edLUO5GRDfCFZhuTlh2j7x7tdvY+rrMgYUqLbZfWxHE/EhdwwsKWoR67bmhCKTBk5Y iSMFssrb0KaBQVzFh7HmEGyeS8u1sTVJc/+0+orNSelwesFJ13nnJ8O3RptAXFPPlOOh aGx++BZ54p8XM9uLign5YdXsqmdH1Ho5ZdzcPZVSQmL8aS+CiS5uD3cagwq9CaOVSlDb wEymqN+8CDgfjKywN7BEJ1Pa3bg0k94mqTXjEhwB0C2g1YFcSaukTYb4MfPW3W5Nb59d DXSGSoDFbhqCPSQ3WC3PRsbVdlNozkZp/6pnF6mJRpJ/jK5Z6rCV2ZaXRjAtknrg3u9e vwiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716294286; x=1716899086; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MTSiuCivQfgXx/RITifHeDOILjJqdYnLFyF13FB9fSw=; b=YPQO6swsYn0bjDUA8HtrKfZPQAjumLch7pk3Ki0L6dMpxVAJAK1Jx7eEqs4XVrfRmi 29omaWVUM0LMAIkoWJpb7F+HoIxdbl/1zxz7DYbSly64q01fe5ex1zjp4DqWadqO1biB Z3jW1Q7cHn8rSBWlGAZTl6P6L3+hBrQwCBtIxMW3NIKy0W1aHJHgZaLDbbRVx5vKTpTa i6TZ/gF7RTEbb2AzD3SqHQgeZIVlqHzuPNivEE9wmLzOJTy6qXnnjkH2VC+//o4Owgj+ GhDGdjvEGl1x86Q7b4tJb/2toyFIJtI/4e0a6LOYSR1wRBKV8r5k9GnOT5Z0xc8+TDxi qdTg== X-Forwarded-Encrypted: i=1; AJvYcCXNQVhhlIvrIsBr/bXbwk0uz5WZcnx95YnVD06dL4cPdJ87X+MmqRW+Kml4+NAYfDIyxeHSIeifHtzThWAcu+A+CWFjUqCsCg== X-Gm-Message-State: AOJu0Yzo5pYHo7b8mWVLxjZMu0e5FaAbAvn5evEwn3Qi44xgg51y7El7 oKNbANspBCj2qGSbdG+Rluu+rEYR4ZIwehFW8jxxs+suboCO5pJRND+BPGxE3Q== X-Google-Smtp-Source: AGHT+IH6tI3vZ7kpyHgNd8cPwswnaI4vF5R8Ac879GVdCySN0Cyu8mk24S8bpb6d/bJr00p2eO3afQ== X-Received: by 2002:a17:906:ae48:b0:a61:a5be:c8ea with SMTP id a640c23a62f3a-a61a5bec981mr337356266b.36.1716294286440; Tue, 21 May 2024 05:24:46 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a5a17b18110sm1603879066b.225.2024.05.21.05.24.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 May 2024 05:24:46 -0700 (PDT) Message-ID: Date: Tue, 21 May 2024 14:24:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] Add check for 8-bit old registers in EVEX format Content-Language: en-US To: "Cui, Lili" Cc: hjl.tools@gmail.com, binutils@sourceware.org References: <20240520062202.1297234-1-lili.cui@intel.com> <20240520062202.1297234-3-lili.cui@intel.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20240520062202.1297234-3-lili.cui@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3024.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 20.05.2024 08:22, Cui, Lili wrote: > --- a/gas/config/tc-i386.c > +++ b/gas/config/tc-i386.c > @@ -4311,10 +4311,10 @@ static void establish_rex (void) > && !is_apx_rex2_encoding () && !is_any_vex_encoding (&i.tm) && !i.rex) > i.rex |= REX_OPCODE; > > - /* For REX/REX2 prefix instructions, we need to convert old registers > + /* For REX/REX2/EVEX prefix instructions, we need to convert old registers > (AL, CL, DL and BL) to new ones (AXL, CXL, DXL and BXL) and report bad > for AH, CH, DH and BH. */ > - if (i.rex || i.rex2) > + if (i.rex || i.rex2 || i.tm.opcode_modifier.evex) > { > for (unsigned int x = first; x <= last; x++) > { > @@ -4326,7 +4326,7 @@ static void establish_rex (void) > /* In case it is "hi" register, give up. */ > if (i.op[x].regs->reg_num > 3) > as_bad (_("can't encode register '%s%s' in an " > - "instruction requiring REX/REX2 prefix"), > + "instruction requiring REX/REX2/EVEX prefix"), > register_prefix, i.op[x].regs->reg_name); > > /* Otherwise it is equivalent to the extended register. > --- a/gas/testsuite/gas/i386/rex-bad.l > +++ b/gas/testsuite/gas/i386/rex-bad.l > @@ -3,8 +3,8 @@ > .*:5: Error: same .* > .*:6: Error: same .* > .*:7: Error: same .* > -.*:9: Error: .* REX/REX2 .* > -.*:10: Error: .* REX/REX2 .* > -.*:12: Error: .* REX/REX2 .* > -.*:13: Error: .* REX/REX2 .* > +.*:9: Error: .* REX/REX2/EVEX .* > +.*:10: Error: .* REX/REX2/EVEX .* > +.*:12: Error: .* REX/REX2/EVEX .* > +.*:13: Error: .* REX/REX2/EVEX .* To avoid these diagnostics getting yet more diffuse, can you please switch to as_bad (_("can't encode register '%s%s' in an " "instruction requiring %s prefix"), register_prefix, i.op[x].regs->reg_name, i.tm.opcode_modifier.evex ? "EVEX" : "REX/REX2"); Okay with that (or a substantially similar; I didn't test the above, after all) adjustment. Jan