From: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
To: Sam James <sam@gentoo.org>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] gprofng: 30894 bison should be no hard dependency
Date: Thu, 5 Oct 2023 07:57:09 -0700 [thread overview]
Message-ID: <d1139616-1ce9-d45c-5864-6c64fcd3c805@oracle.com> (raw)
In-Reply-To: <87jzs1o39c.fsf@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 485 bytes --]
On 10/5/23 01:57, Sam James wrote:
>> -QLParser.tab.cc QLParser.tab.hh: QLParser.yy
>> +# bison generates two files QLParser.tab.cc, QLParser.tab.hh.
>> +# we don't know which file will be newer.
>> +# Make QLParser.tab.cc always newer than QLParser.tab.hh.
>> +QLParser.tab.hh: QLParser.yy
>> + if test "$(BISON)" == ":"; then \
> Please use =, not ==, as == is a Bashism and configure scripts (etc)
> must work with POSIX shell.
>
I will fix this.
Thank you for review.
-Vladimir
prev parent reply other threads:[~2023-10-05 14:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 1:42 vladimir.mezentsev
2023-10-05 8:57 ` Sam James
2023-10-05 14:57 ` Vladimir Mezentsev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1139616-1ce9-d45c-5864-6c64fcd3c805@oracle.com \
--to=vladimir.mezentsev@oracle.com \
--cc=binutils@sourceware.org \
--cc=sam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).