From: Andreas Krebbel <krebbel@linux.ibm.com>
To: Alan Modra <amodra@gmail.com>
Cc: Nick Clifton <nickc@redhat.com>, binutils@sourceware.org
Subject: Re: [PATCH] Align linkerscript symbols according to ABI
Date: Fri, 7 Jul 2023 11:38:38 +0200 [thread overview]
Message-ID: <d113cf4b-57dc-958d-ad26-de92555e66bc@linux.ibm.com> (raw)
In-Reply-To: <ZKeAh/eHJHGzDs8G@squeak.grove.modra.org>
On 7/7/23 05:03, Alan Modra wrote:
> On Wed, Jul 05, 2023 at 11:53:35AM +0200, Andreas Krebbel via Binutils wrote:
>>>> Apply ABI specific alignment to symbols generated in the default
>>>> linker script.
>
> I think this change is potentially wrong for symbols defined inside an
> output section. Do you really want symbols marking the start and end
> of a section to disagree with the actual section, if the section
> itself is wrongly aligned?
Hopefully all our output sections are at least aligned to our symbol ABI alignment otherwise that's
what I would fix I guess. You are right that having a gap there would be bad.
Andreas
next prev parent reply other threads:[~2023-07-07 9:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 9:16 [PATCH] ld - Add SYMBOL_ABI_ALIGNMENT variable and apply to __bss_start Andreas Krebbel
2023-06-27 14:14 ` Nick Clifton
2023-06-28 6:23 ` Andreas Krebbel
2023-07-04 12:18 ` [PATCH] Align linkerscript symbols according to ABI Andreas Krebbel
2023-07-05 9:44 ` Nick Clifton
2023-07-05 9:53 ` Andreas Krebbel
2023-07-07 3:03 ` Alan Modra
2023-07-07 9:38 ` Andreas Krebbel [this message]
2023-07-12 1:36 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d113cf4b-57dc-958d-ad26-de92555e66bc@linux.ibm.com \
--to=krebbel@linux.ibm.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).