From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hpa@zytor.com>
Received: from mail.zytor.com (terminus.zytor.com [198.137.202.136])
 by sourceware.org (Postfix) with ESMTPS id B04A7385703C
 for <binutils@sourceware.org>; Mon,  8 Aug 2022 18:31:32 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B04A7385703C
Received: from [IPV6:2601:646:8600:40c0:425:cd56:6750:e1bf]
 ([IPv6:2601:646:8600:40c0:425:cd56:6750:e1bf]) (authenticated bits=0)
 by mail.zytor.com (8.17.1/8.15.2) with ESMTPSA id 278IVNVP007849
 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NO);
 Mon, 8 Aug 2022 11:31:24 -0700
DKIM-Filter: OpenDKIM Filter v2.11.0 mail.zytor.com 278IVNVP007849
Message-ID: <d1725378-7cce-60ce-ad9c-48459853f01a@zytor.com>
Date: Mon, 8 Aug 2022 11:31:18 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v3 0/3] RISC-V: Fix address printer on the disassembler
Content-Language: en-US
To: Tsukasa OI <research_trasio@irq.a4lg.com>,
 Nelson Chu <nelson.chu@sifive.com>, Kito Cheng <kito.cheng@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>
Cc: binutils@sourceware.org
References: <cover.1659419591.git.research_trasio@irq.a4lg.com>
 <cover.1659587739.git.research_trasio@irq.a4lg.com>
From: "H. Peter Anvin" <hpa@zytor.com>
In-Reply-To: <cover.1659587739.git.research_trasio@irq.a4lg.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_PASS,
 SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: binutils@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Binutils mailing list <binutils.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>,
 <mailto:binutils-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>,
 <mailto:binutils-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Aug 2022 18:31:34 -0000

Hi,

I tried out this patch, but I noticed that it still gets jalr with a 
(zero) register base wrong:

40003764:       454000e7                jalr    1108(zero) # 0 <_NULL>

The address here is obviously 1108 (0x454), not 0; there is a symbol at 
address 0x454:

00000454 T memcpy

	-hpa