From: "Martin Liška" <mliska@suse.cz>
To: binutils@sourceware.org
Cc: Ian Lance Taylor <iant@golang.org>
Subject: Re: [PATCH] gold: fix crash for empty file
Date: Wed, 5 Jan 2022 11:15:06 +0100 [thread overview]
Message-ID: <d193b761-c527-fff3-3b71-68433fccc68d@suse.cz> (raw)
In-Reply-To: <68116639-4565-14f5-ce21-6427487b24c1@suse.cz>
PING^2
On 11/29/21 10:00, Martin Liška wrote:
> PING^1
>
> On 11/19/21 15:01, Martin Liška wrote:
>> Hi.
>>
>> The patch fixes a crash I noticed and explained in the linked PR.
>>
>> Patch survives regression tests.
>>
>> Ready to be installed?
>> Thanks,
>> Martin
>>
>> gold/ChangeLog:
>>
>> PR 28585
>> * symtab.cc (Symbol_table::lookup): Return NULL for NULL
>> argument.
>> ---
>> gold/symtab.cc | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/gold/symtab.cc b/gold/symtab.cc
>> index 5a21ddc8cc2..ed6b5434592 100644
>> --- a/gold/symtab.cc
>> +++ b/gold/symtab.cc
>> @@ -701,6 +701,8 @@ Symbol_table::resolve_forwards(const Symbol* from) const
>> Symbol*
>> Symbol_table::lookup(const char* name, const char* version) const
>> {
>> + if (name == NULL)
>> + return NULL;
>> Stringpool::Key name_key;
>> name = this->namepool_.find(name, &name_key);
>> if (name == NULL)
>
next prev parent reply other threads:[~2022-01-05 10:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 14:01 Martin Liška
2021-11-29 9:00 ` Martin Liška
2022-01-05 10:15 ` Martin Liška [this message]
2022-01-05 17:35 ` Cary Coutant
2022-01-06 8:35 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d193b761-c527-fff3-3b71-68433fccc68d@suse.cz \
--to=mliska@suse.cz \
--cc=binutils@sourceware.org \
--cc=iant@golang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).