From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2080.outbound.protection.outlook.com [40.107.20.80]) by sourceware.org (Postfix) with ESMTPS id 781BE3858C54 for ; Mon, 7 Nov 2022 09:24:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 781BE3858C54 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eH3X2tz9BAKKSTLovPcGFEpkcJgcqpif9khny8wTCMnAnk1AgfuPYeTAWBjdZhyy4KIldcJM20cnJSa6VGT/qoaZ83o1GmdSfw/hzZqVxYutQB82e86voqhO0AxTxBinseaAc9rEi/DgciYKXydhQ3Q29JgNUYgfV2epIYDmorICkj1HE85tyD49jHH+ewuFkrsmQURoRxqs73aG4d3SHOZ1Qq0S7hhdIt6oveGyemO85E/0qAEnxpJpildCflMVQ6RjodO6pQ1rVfYn6vO+pTg1xaQC3MWIVrDNt7Ql0DXVuTOT9gF3Rs4q+/H2t17Qmhm0o3x1nCjgGtLG5dAfNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xvJKhITqLQUkwtx8QnrV/RRcpf8s8dSmtwi252zPaWA=; b=LcMwk1Sz4yZJkQWg+0rr65ctp/rZOVlxBOU2is61TnyPu/Dpa6BRkVHVHBWECNMfa4ml4YibRQ5VEZ98D46yOtI6QFdQ+3uryA7eacu5F7yuqGWG9BiCd4bl0hqNQ64EJ2Fh+bfP4xmR1zrKkKkvhdjC9lcrH9n2AHKaFUy6XGlR25DEnIRVJfZVo2+EDbqgU9rUA2Xwtn8keWrKJixgLmD69euIAJtVyiEccXDurgIiSlN6eHYM0Rhj+y9Otj9GLk57lC2IUAewWLY25FdFmjryYd3EnYS4yjMAL78kNKn89hds6l4kt8t1TxmMj/bDZEJ+FE2r/sIUqc29JaqnPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xvJKhITqLQUkwtx8QnrV/RRcpf8s8dSmtwi252zPaWA=; b=Ja62akn4/CfkPGnqw6C87PD/tC7huR5us4RWCigjXDakTzzwNu/9nd9DIh8zUaM/dcAHSZO+63Dha9hEAnTt9r9N+COLibPPHlnt8wS4yVkr6HtlRWlLEH1Nq9vrxnpyEMYhnBFiwdwvHDbTivPCzE7l25TzzA81ovMc2Xkd6n0Zgj6hn4VnrlwEq5G8VxneEz9UbBMrYqspcM0gGujqCd1bZ3j/exF+pQW0yAsLxFgOoo+BYxkb1ohLfnRo4IiGPJb/JO9xBP/vhoJEh34CcjLlrb1Wixk2aNyGxmn8SZ35Q9Z8fwxJ1CQaZxryxrpV9Zubi5uCI2IjvB1hxTAE6w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7964.eurprd04.prod.outlook.com (2603:10a6:10:1e9::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Mon, 7 Nov 2022 09:24:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.026; Mon, 7 Nov 2022 09:24:04 +0000 Message-ID: Date: Mon, 7 Nov 2022 10:24:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 06/10] Support Intel RAO-INT Content-Language: en-US To: "Kong, Lingling" , "Jiang, Haochen" Cc: "hjl.tools@gmail.com" , "binutils@sourceware.org" References: <20221014091248.4920-1-haochen.jiang@intel.com> <20221014091248.4920-7-haochen.jiang@intel.com> <1e6a7d9c-4b14-821e-cc46-453adbe6f183@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0180.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7964:EE_ X-MS-Office365-Filtering-Correlation-Id: d0ccffa4-050e-43f4-254e-08dac0a1d04c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: D8BysxVikwL/gJeeAAQhasNVEHjTNemsXMXnuwd9DR5bJAmm75wim+zIotyprQznYbwR3RTQs+67l7rI+tXSHD4bytfOPZTjRXWBb5G9zECxY4PoxyZbuVpwBQKHfjCcs8PF40dShm1Axs789QCrbyZ5VDXbqcKsR2KVPNN3StwEo7N8jP99qpDXGgyQHv/lC3jz7IVxVySuS2fQGZ0zSAQHJ6WWerY4TXly+3YSMcIMtaI75RWiiYd+L8WyfVSc/dl2NaVeX4bHNAgcuBGa01MwNOqeIhbL0rnMHGJRkc8PgCPetDX2o1jh/lMPg1LHawxCDQmbWsXNAr8jmoaEd2/m9kDRS2rcxmxZ+IvV7oy2ou91wvnM8hfrG/xonZjDSw2w4cWSshYbkruUM4B7a/4SH2IFWEKG+ZORTjSlWH2OiBfxqD6fQgCAagVEqb9K210DiFquHG1P8tV2TLCtXw63E2mDhH6mQYOLWcAt7XxsywJGem/PPS2pdQBWSg0Gm+9tNMK2LFUGQ8cC08HejklGoMvnTRFREHrMSOtugj+D40tQXI+ftrVF0b/ir9e7vKuSRrwD3tFGVZ7SmuIt11DiUlgz7V+iz0LrMlDBAh2Kfi77ow5S5El61hs9G91e0xss2ZvI19Y2iz5Z6p5n8JgSVXOzwlVU8srk+dTqeSAjZ4hOQP74MbRVGuUqT4f6+lHHcvnrDg1mHOahAp7Ava7LjKHHtGBFpXe9Y3swSeugBVo0KuSokJAQ0icvBNQuq7cQ6j1VohhLG50IuYEfIg2+PQ1hojiyEMHr6NaRfhs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(376002)(39860400002)(396003)(136003)(451199015)(6512007)(26005)(41300700001)(83380400001)(38100700002)(36756003)(5660300002)(2616005)(8936002)(2906002)(186003)(31686004)(478600001)(6486002)(316002)(66556008)(66476007)(54906003)(66946007)(6506007)(53546011)(4326008)(110136005)(8676002)(31696002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVlyN0F0R3dBVmtyK0tBUWdBQ0dzRENhU3RXS0lUL0NSL09NYm5WNzJ2R3k0?= =?utf-8?B?ME0zVjV2V1pGODJra2pZTW9hOGFGeHVtSWZQMmRrYXRWWWdUMDlwdUNGNStn?= =?utf-8?B?bDJLUzFQUGFYK1YzZTVTVzBOWmUyV01sNXozMDVuRURFMUs4cURMRmM5RmVZ?= =?utf-8?B?dGY5MjFhR0hwZmJReXdEYllPc1VDYmRvY0hldWFIeG42SlpPUWJTck8xSk1T?= =?utf-8?B?cHlRWjcxY2Zpd2R0d2JwSWVsZFloRUdJemRXak02cjFTMEsrUnNWcUNuYnJ1?= =?utf-8?B?VTNRMkcxd2lKVGVhTk4wc3VJRGtDN0ZUMnh6VmExUWREb0pla0NveUc4UmM1?= =?utf-8?B?aldLaWEzeTJGeGNqUCtBVFQ3ZmM5Tmg0VUUrN0piS1RnT2k0ZFlhR0NTd1B2?= =?utf-8?B?bHpOZVBmRENHQ002Z1Q4Mk5hNlRDQktEaTNRMC9hd3RUeVhiLysvajRjQTE1?= =?utf-8?B?eFJUSjlBN1JDRTlzQXR0WHErd2NsSG9tOStoZzZ6Rm1GTXhmMkE2RllIeE8x?= =?utf-8?B?MFY5RFM0WEZOTXc0QlZ3N3NSblFpdGJEVjEvVkJBT3ZVV252MjNpVmowSTl0?= =?utf-8?B?VndHeDUyZUpXZ0FGVk1vWlBiN0NndEJlcW5wbWVGYnM3anAzQm9xZ0ZKZEV1?= =?utf-8?B?YkZlK201Ni9lQW1jenBQKzRZNTFEUDRjbTUrOEZRaFJqeU45WlZkR3hRaGZs?= =?utf-8?B?Vnc5RldSWHY1OHIrZjZFcjZjdkROUGVWdEZwQ1hGbHhGSmtlR1pDdEVKUXh3?= =?utf-8?B?OFd3RjlqZ3JHa25yQzRLd3ptUXdjeURHZzJxbWwvczEzY1JOd3BhMXZiMUQ2?= =?utf-8?B?aW1hRXVwZXpGMS9HOUlNbEdReEFmSDZ0akIxcXlsMWxuTStLMzcrclFSL2JK?= =?utf-8?B?WkNuMjN5M0dIQXN4aGp1ZWF2TTZqZGhObTdRdGRRZ2JNQlZNR1MvdE55R0li?= =?utf-8?B?QmdDZ2hKeFlxeC9wSkJmVzdmckNOU1hiOXozV0VabUlmNUxyM0toTjRWanhU?= =?utf-8?B?dEZJaFVTWUMrMnZhT2YvOVQwUVg2Rk8rQW45UU95U3UvTERXQU5Nb0c0aENN?= =?utf-8?B?UWVhdVNpYUFLM3FWZzR5VHhsUkJwUkgxMVFXVHR4QVNnMnNnandhUlJoMllU?= =?utf-8?B?b2p2Z0xZTmlrLzNWd1VNVFBOaVlXWVVubTltNDBVS05DWm1xZjFJekVpazVl?= =?utf-8?B?OEptbkJWdHNYZURhWXFhSmRCL3k3ckZtV2dLU09Yam9mTkVYclZKRTN6UDBR?= =?utf-8?B?Z3FWMWtvbXV3L211T0dIMzRYT3FxTnVtUWEvMzgzVS9YOVI0SUIvNDNQTSsv?= =?utf-8?B?a0NBOE5JMGx5L01YTUpadEcvOVlzTURRaUpkNGU5eE96OUhxbVJmY0xNWlMw?= =?utf-8?B?SUViV2tyVy81S2NGNlE2ZEExRXlBNnhDamZpUXFFWU51cDBlTXFidGZkT1RL?= =?utf-8?B?YS9XMTBJaG83eFN0WDBaV3BvaFJob3FpNVEwbk9ZN3BGd1dQUS9rZHlsTXla?= =?utf-8?B?M2RNcytkRkRyd2RISjlQRDUyT2kxTEErZHA4bEdha2V4bjBqMDR1Y2pweXNa?= =?utf-8?B?QTdMdk5qTERabDhxWCswdkpmeFVQVUNuVXNCbFF1WVlML3BiR1dnWHo2eXVh?= =?utf-8?B?dm02dHhPTjljYWVDVVFDS3FwMHZ2V2RvY2FhOERuZE16NWNWeGpaQm5jSDlC?= =?utf-8?B?bTMwNWpjYnVQUVdBUkFlVnE5dCtCUnIweGhOZVI4S20raGV1VUpLdlVuTEdB?= =?utf-8?B?ZTBsZjB4N1dCQVdBNitteThEMk16KzBEQjBuQW90RFVucTdZRXZxRzl4cUdZ?= =?utf-8?B?K0hkVDNIWDRuRlRPZ1YvaGd4aU9SRHU2c2VCQ0d6UXM5TkxVMW5LRU0wdzJN?= =?utf-8?B?VTVvVU9YR3BXR1UvTmY5Z2VwdXovQXVTWDhYaGszM0hYRE1zWm8zQ0lKUUNB?= =?utf-8?B?U2xKNlpVUnRGMXNTaFRCcHo1OXFkcUFwYW5iSHBxT09oNXJHdkxQaVhJVTBZ?= =?utf-8?B?ck1xVlVqQW5JVjZSUmRlT2F2dDZkazhpN3NLNGJtM21UbjhHTGdZT3JLTno1?= =?utf-8?B?bHpTcGFLb1B6QUwxMmpNOUM4UzZmVWR4SlV3S2xsOUhsNXo1RFBUeDVvYTRU?= =?utf-8?Q?l6KRZOMN+7BoJ9sSH7TNOeWjE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0ccffa4-050e-43f4-254e-08dac0a1d04c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 09:24:04.4984 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r+2jzTGabZBapDMTeSKBM0Sh+TAxnz50ZyUZCyAFXENKhdunAiYTkPeCS6yS+H5HOf5xP5h9xXPfFIytS5rK3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7964 X-Spam-Status: No, score=-3029.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 06.11.2022 13:50, Kong, Lingling wrote: >>>>> +aadd, 0xf38fc, None, CpuRAOINT, >>>>> +Modrm|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|No_ldSuf,{ Reg32|Reg64, >>>>> +Dword|Qword|Unspecified|BaseIndex} >>>>> +aand, 0x660f38fc, None, CpuRAOINT, >>>>> +Modrm|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|No_ldSuf,{ Reg32|Reg64, >>>>> +Dword|Qword|Unspecified|BaseIndex} >>>>> +aor, 0xf20f38fc, None, CpuRAOINT, >>>>> +Modrm|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|No_ldSuf,{ Reg32|Reg64, >>>>> +Dword|Qword|Unspecified|BaseIndex} >>>>> +axor, 0xf30f38fc, None, CpuRAOINT, >>>>> +Modrm|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|No_ldSuf,{ Reg32|Reg64, >>>>> +Dword|Qword|Unspecified|BaseIndex} >>>> >>>> Why IgnoreSize? Instead I think you need CheckRegSize (assuming it >>>> does enough for Intel syntax memory operands - please double check; >>>> if not this will need fixing). >>>> > Yes, now it changed to CheckRegSize. For one I'm pretty sure I said I was wrong about IgnoreSize. And as to CheckRegSize - did you actually double check as indicated? While I think the attribute should be there, I've also observed recently that it missing on e.g. MOVBE does not currently make any difference (there are the same bogus diagnostics with and without it). So while I don't mind it being put there, H.J. may view this differently as long as the attribute doesn't really have any effect. > --- a/opcodes/i386-opc.h > +++ b/opcodes/i386-opc.h > @@ -223,6 +223,8 @@ enum > CpuMSRLIST, > /* Intel AVX NE CONVERT Instructions support required. */ > CpuAVX_NE_CONVERT, > + /* Intel RAO INT Instructions support required. */ CpuRAO_INT, > /* mwaitx instruction required */ > CpuMWAITX, > /* Clzero instruction required */ This and ... > --- a/opcodes/i386-opc.tbl > +++ b/opcodes/i386-opc.tbl > @@ -3321,3 +3321,12 @@ rdmsrlist, 0xf20f01c6, None, CpuMSRLIST|Cpu64, No_bSuf|No_wSuf|No_lSuf|No_sSuf|N wrmsrlist, 0xf30f01c6, None, CpuMSRLIST|Cpu64, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf, {} > > // MSRLIST instructions end. > + > +// RAO-INT instructions. > + > +aadd, 0xf38fc, None, CpuRAO_INT, > +Modrm|CheckRegSize|No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf,{ > +Reg32|Reg64, Dword|Qword|Unspecified|BaseIndex } aand, 0x660f38fc, > +None, CpuRAO_INT, > +Modrm|CheckRegSize|No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf,{ > +Reg32|Reg64, Dword|Qword|Unspecified|BaseIndex } aor, 0xf20f38fc, None, > +CpuRAO_INT, > +Modrm|CheckRegSize|No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf,{ > +Reg32|Reg64, Dword|Qword|Unspecified|BaseIndex } axor, 0xf30f38fc, > +None, CpuRAO_INT, > +Modrm|CheckRegSize|No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf,{ > +Reg32|Reg64, Dword|Qword|Unspecified|BaseIndex } > + > +// RAO-INT instructions end. ... this doesn't look like valid changes - line breaks are at the wrong spots. Jan