From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60083.outbound.protection.outlook.com [40.107.6.83]) by sourceware.org (Postfix) with ESMTPS id 277023858D38 for ; Wed, 2 Nov 2022 07:47:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 277023858D38 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jeMCFdRB5Uovqe2y7eiYGh1smKEOcFs6UB5wViHilEW/Y3myNbi8oFBAfbLFv1QXLEYvfAjzhXE0uUAnFlwCXh0dFCnRVSUFmkhAGnlo6NPa37D2XWBWjaSapvI/ImCqGsQAWEEE9tvtz/uDo8B+mrYG0kvj8bxwh4++HRnXOCTUz5AzDTz/qBem/jJzIOAdoJVFqzLRgz4mblNv45pVGCRwQoAD5DyjXlCYmy8bSdy5z7iWzvDh0sRLOBbDU77cnoe6Mwan26a+3sp318nnTv5DlIjOqGu56/o9Up1v/GE8mygHhdZOGjZ5v5ud8VnDQWOr0bJtdD2YvSIK+StE8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VRjWWWt4GaG8XIq7H/cwRoH1t7xd/VLOxuLgbV7DFZg=; b=YRf6g07K7Fav780Mo6XboQvxbBE2z7pCU3+ib7d4JkvFxPoVCU6c5tb4sbrtTyBj7J7KFLt5kiKP2qf+OOs22BOEeUWblj1FY5hCnl0ggKbpBcnqBAMyYb4qj5nMz3jU7d8UbPVJu11XcASrvgQYfYEWtygjfVbT0NoMieh6cdinjXFJlOy3LX0aM3NFNEZLuu2/xFkDLm+uFGLiAjaOMxKtHg6ODTUk+7YltAotvzx4TYkqLw5gXNQa+nAtIyGmCxc8N0rh2hZnrZmB5IgQNpk0B2txZ6y9GeUNWEyr9Z4k11ikAxdhQqdoYnNr45Ug1CavFyfZ+QoVAbzlY+Y7Tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VRjWWWt4GaG8XIq7H/cwRoH1t7xd/VLOxuLgbV7DFZg=; b=O8abJzH2yAPFi5Q3eVj2rTEXk215/JcBFaQuvAo2tlc1Uodg4On1JjmKJB5RqUd7aJGSk0MK0L9U0vNwbl+hSwE6vJ+5L17KhOD3gz27bznrlBW1Gvl1zBlPnU7AR6h4yuo0TpZlwkKYkWJLXtBNufrCP8q4KEUr0LEJjEtNQ633I+euGh45YgbT9EkvTy4iMGSQdy546Ur8q0x00wfUEvFNt3Mp4Csix2xyXJsmvIdmGiRnUx/KT/jxQvin1tNAor8CQeYwmtgCBmdjVV0EgUf/qtPBsLhFhqa7JirlRdFSsUvNoGhL40kgs26s5xSZhL2ogYhbrhQbm0agmN3/hA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9399.eurprd04.prod.outlook.com (2603:10a6:102:2b3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.21; Wed, 2 Nov 2022 07:47:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5769.021; Wed, 2 Nov 2022 07:47:21 +0000 Message-ID: Date: Wed, 2 Nov 2022 08:47:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 2/2] Support Intel AVX-NE-CONVERT Content-Language: en-US To: "Kong, Lingling" , "Jiang, Haochen" Cc: "hjl.tools@gmail.com" , "binutils@sourceware.org" References: <20221031060601.38460-1-haochen.jiang@intel.com> <20221031060601.38460-3-haochen.jiang@intel.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8P189CA0056.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:458::33) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9399:EE_ X-MS-Office365-Filtering-Correlation-Id: 56edf12a-bfd7-4c13-39e5-08dabca67972 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HEoXoyn06tMg1qZHWd2MWzw3mOWYG2bP7Sdp2r/yYOX9iY6jLUzA/M+QUdKc2QTzCf7Il/nyrX0j2RIOSW1yG0VhKK433zTcsuMo/3Tmavde/H3GIWXv41AmDMjk8m+53nyWScsoqmjqvaCU8zHI5ZNzy0E+q55epEQYg/0eBgFy5teOYX4pSr0T9bTQmsmpHuL5HjZPb8cO0rGA9eWgn7wZhbW0eY7DUSXtcSfSoOcYZYuNRFyTvSx2Xlz560PYlbJIxodxR1TEr+y8ZZFkVQNA5rkK7DyI+LOjM/bZddb5Bls1suQXmx9Od09kEwBkKTPL2Beqvs4RghBIOXvNSzY4DeOrKXz659KePGJWYHLq+URJ5Ir+doSrCYluTMvdcg9nae//1dvk5XciFn6GOCOk4E+/Ce6PUMXPWMRIE9WKQOB3EFdhDYFVFUA2RS2SMj6LQAVnt2MJFYjRp7W91wNx8s4ujjsc/cLO/tM8zOUq7DSCKP1vFeVRY5w3INnxGecvz6NVOBqMxIfEIhQOtSCjGJax72sn6SFkez2r/cc5CyYDGlxIJKsaTHuX/4T+3y8d7qO+PzBQM+Pn5/0eAlyaYmJKBkxm+gtSW6Y9VomsVnnu5oMRORKK624ECKOsiRpWjVhKq+kJzHEBUJ6emKcKmaM3NrqUKDOKgWkzXHSaWJ+N/oaWnIHvTFQK6pDYNTK/nNb+0kf9vM7DmC+gSpytiF8TlrVMs6IqIPO2PkxeAlDSlwHUQyMpp1V8LFb3t6pMKObcyX/QWw5Uf7SSUr7HEQSwmZC5N3bKtVnsr3k= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(346002)(136003)(376002)(366004)(451199015)(8936002)(5660300002)(4326008)(8676002)(41300700001)(31696002)(186003)(2906002)(86362001)(6486002)(66556008)(53546011)(2616005)(6506007)(38100700002)(26005)(6512007)(478600001)(66476007)(66946007)(316002)(54906003)(110136005)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?THd5b2lJWGs2WkRVay9aWUo1Zk85VjJSNUZpNkgvdnBiT1l6ZFRZL1pTQ0dQ?= =?utf-8?B?TVlmcVg0dm8yWldhZ0IvR3BpZ1ZCYUMyN2pIayt2bEpPeEZzeHhsRDcxVE1Q?= =?utf-8?B?bVhvUnpzOGdWTmdMTE5ld0ZhckZNU241bXE1RWQzVURQeTlIKzRZT3JvR3VF?= =?utf-8?B?bkhSNEpRZXQzbm8vcENQU1Z5MmtVQ0svYW5MOXZIbWovSEVyYWpLZ3RMZndP?= =?utf-8?B?ZndmcHZtUjJmYUhQVzZRcXpOQzFkdWV1bkNWblRrZDdwVjZtcGR2NEY1WUt6?= =?utf-8?B?bjdxWGVPN3JzdWJzZHoyMkcvTzVhVEVUYUZYQUY2ZjF6V2lnbWFtcUNkc0VR?= =?utf-8?B?bkw0UUJtUXl1L3drMkY3bHgwNGVuUEc4Qmt3NklBQkU4TWRFOVNuVkE3Yk9R?= =?utf-8?B?MFpyMXRxdzQzcDc3eVUzWWhTRFpHMjNSZFVlKy9QaWYrU3NUdVlNeGEwTS92?= =?utf-8?B?ajExQ0JySzREYVFDQ3h4cmlCc0Z1aTVQbG9JYVE0QVVRZDQxR3ExaFptUWNN?= =?utf-8?B?aWhYVTdaL2JyMTIvZEtpMjN1Sm80cmFocG9VcWpFcjM0MHNCSkZrSks0WVd5?= =?utf-8?B?c1pabFRKSllYakJKUGJGeHF4ZjBDd3FhNnB4U2dPZEcrZDR0NGFqQ3VONWUy?= =?utf-8?B?M2xaNWZ6SEFFd0Ric2NCYVZsSU0zNXRLU1ExMXg3bDRsaEkyYlBBTWFSMFFk?= =?utf-8?B?MEFlVFlKY0JQNHBXMktrRE52aEthcjFidWt6YlR1Y2hoeU1BL3doeDJobUEz?= =?utf-8?B?dllSaWRhRkYzRVp6UEk2bW42TGx4d2EzMGV2emI5ZlV0YVJBOGh6RjYvdTNn?= =?utf-8?B?cldoQm5HdGhJVHNKeFRVYi85MW5YNVVEVTNCWGNYU1NpcElMa244eS9oNlJo?= =?utf-8?B?dFNaODdHamIrQlkzOWRTcS9jeENoQndvK2hzL2dNbWFCRVc1czI1TDNsWEcw?= =?utf-8?B?dy9kRVdlMGlHeUV1YjdBNENCbk5YRE5rWjQ2TCtBVkd3YVZJRUE1SmNVYkUw?= =?utf-8?B?RHlpZkZhWk5yNDUxY2RYV2twRG9UR0p2S3ZmdjZnZWVxM1hCN1Y2ZWpjbzly?= =?utf-8?B?Q2Y2T3VxZ3FFSkpjQUpTa2ZLTWdrSU9RZldFVGw0TUpuV0pFVm85QzN0NlFk?= =?utf-8?B?RWFFeWMyQzNrVzFpSkJzaVdwc0dDNHY0VkthaW41SGsvS1dVcllhTkNrSkVF?= =?utf-8?B?WGtRL25ycTdsWW51Sm8vL3IyWHpKYkMveHZsaGxobDBMbmZKTSt3d0ExM0hp?= =?utf-8?B?S21nMWZjTjl3MmlITCtnWXpoZmRXaFpKQXhKNmFWRHRtT2pDbS9jWUlzV29G?= =?utf-8?B?Rm1pMGFMS2VUdm1PRC8vQTU2M1dqTThNUUF6K2tOZTdhSEFMaXhhRUxUOE5K?= =?utf-8?B?RktaUmVsL0QxOE5zMmdJL0dRWE5ZVXAzd2NpcDdjZlF1T2RUMjZKRXlmWlFs?= =?utf-8?B?Y3VYS3IxbWwzdXJWSTJDVmdwdkltM2RpZXdQdWRTTWhDbzhhbXVtbGpCK0N6?= =?utf-8?B?eDR1YkdtZlhjaUxQWVpETmVjeVdVNUJGaEhIOXJDTDRDbUhUWWlWTmpXdkJF?= =?utf-8?B?RXkybWRKYnJ5UFJqTzAzRjNXdWRVVVZwcDVUMmFSelU4N0xJSGNFU1hlNk1X?= =?utf-8?B?M1ZvNkRVUWFRRkxmdmw5Y0xGRlYwcmRUckttK0NkdFpqczRMVHJ6bFpVVkth?= =?utf-8?B?MnVIUGRNYk16TjZHRThoMmk2MUp3dHNFY3VBMk13dldPcXIvUENnb0lxN0hP?= =?utf-8?B?a1hyUU1wR1FLWmhWV21UT1lkQS84bkVmSWoycEc4aHQyaEYyZENueUFPeWpX?= =?utf-8?B?bU1qMU5RK3g5ZlI2Z29wOUMrYW1wdHNJTERNVG5CdE9Mbm1Ka3p4L3FwcGYw?= =?utf-8?B?cG9ZbmpXbmNQcWR4NmsveDhTd3NwcTN0ZkNZWTdzcXExSXZIRjAzQThoM2R6?= =?utf-8?B?NGVGTnpCS2ZEM1hmZ3FRWE43SU5qMUhBTmcvaEpXeXRRT3NXYnhzOFFWUWVm?= =?utf-8?B?eHRvdlV5SVRvZnVFUHR6eUF1SWxObVZ1WUhKbDNDRVQ4ZDgrV2I1SjdIMkpz?= =?utf-8?B?NExPQ3Ftd3dFYmV6cVV4d3liZXI1ZzRUTHJSY283cUZETjZQaXBBajFqVHFN?= =?utf-8?Q?TnjDAVT3e02ChmqH7TgwdKwKP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 56edf12a-bfd7-4c13-39e5-08dabca67972 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 07:47:21.5874 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Jq/VusAkcnhYSNDrpys1IlZ3MC2c7IfySJ07lE4z99KeeJnA9v5zwcipJItVRzjjfKnn9dCFQpUHmp8ibc4M2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9399 X-Spam-Status: No, score=-3029.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 01.11.2022 10:04, Kong, Lingling wrote: > --- a/opcodes/i386-dis.c > +++ b/opcodes/i386-dis.c > @@ -942,6 +942,8 @@ enum > MOD_VEX_0F385E_X86_64_P_3_W_0, > MOD_VEX_0F388C, > MOD_VEX_0F388E, > + MOD_VEX_0F38B0, > + MOD_VEX_0F38B1, > MOD_VEX_0F3A30_L_0, > MOD_VEX_0F3A31_L_0, > MOD_VEX_0F3A32_L_0, > @@ -1140,6 +1142,9 @@ enum > PREFIX_VEX_0F3851_W_0, > PREFIX_VEX_0F385C_X86_64, > PREFIX_VEX_0F385E_X86_64, > + PREFIX_VEX_0F3872, > + PREFIX_VEX_0F38B0_M_0_W_0, > + PREFIX_VEX_0F38B1_M_0_W_0, > PREFIX_VEX_0F38F5_L_0, > PREFIX_VEX_0F38F6_L_0, > PREFIX_VEX_0F38F7_L_0, > @@ -1556,8 +1561,11 @@ enum > VEX_W_0F385E_X86_64_P_1, > VEX_W_0F385E_X86_64_P_2, > VEX_W_0F385E_X86_64_P_3, > + VEX_W_0F3872_P_1, > VEX_W_0F3878, > VEX_W_0F3879, > + VEX_W_0F38B0_M_0, > + VEX_W_0F38B1_M_0, > VEX_W_0F38B4, > VEX_W_0F38B5, > VEX_W_0F38CF, > @@ -4093,6 +4101,27 @@ static const struct dis386 prefix_table[][4] = { > { VEX_W_TABLE (VEX_W_0F385E_X86_64_P_3) }, > }, > > + /* PREFIX_VEX_0F3872 */ > + { > + { Bad_Opcode }, > + { VEX_W_TABLE (VEX_W_0F3872_P_1) }, > + }, > + > + /* PREFIX_VEX_0F38B0_M_0_W_0 */ > + { > + { "vcvtneoph2ps", { XM, Mx }, 0 }, > + { "vcvtneebf162ps", { XM, Mx }, 0 }, > + { "vcvtneeph2ps", { XM, Mx }, 0 }, > + { "vcvtneobf162ps", { XM, Mx }, 0 }, > + }, With the use of Mx here I see no reason to have decode go through mod_table[]. And then ... > + /* PREFIX_VEX_0F38B1_M_0_W_0 */ > + { > + { Bad_Opcode }, > + { "vbcstnebf162ps", { XM, Ew }, 0 }, > + { "vbcstnesh2ps", { XM, Ew }, 0 }, > + }, ... this should also engage OP_M() rather than OP_E(), removing the mod_table[] decode step here as well. Obviously you'll need to add Mw for that to work. Jan