From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 100883858C78 for ; Thu, 18 Apr 2024 07:40:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 100883858C78 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 100883858C78 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713426029; cv=pass; b=flaCmcClCw936htwlPuTMX1ccceVxMby3s3JTSfh0/CVgkkZwQlq9O9Z/zBzH/wa1obhXl+BIIAAcY0h9HN2u2aNtDKN5U0Ct+sulijq1gsxpVzQViCLpG5QlU24E4CRcpBWvl5dAtIcJBg0ugvM3YhUOxCGB9LxtGEIXi8FNkU= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713426029; c=relaxed/simple; bh=/uXhFWU7FqhGrNvFE9yZ5zPUPJmME1BR4Qjl4dPqG3s=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:From:Subject:To: MIME-Version; b=ZlzSjT5YSsmrit/n6gtxF2LKPpXn1IZOqKUhWHOT3niEnJfvKaPJLaUHZ+WGETC1zY7r65W2dBO2glkBYtWn2VQZ7C0IPSxA4e7f9DpcBDm0SzHG9lt+llvRT3dE71EhpBa5OeKwyAlusozQ6sr6nLxIFxaXVnsOalUXSdcDh+U= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43I3wl1G010035; Thu, 18 Apr 2024 07:40:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : from : subject : to : cc : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=79r1lyWp/dmdo8vOshmv+Jh+Wv5vQbdIkTeFmD5VYYk=; b=N9ZxDMJXRaxeDWn4iUbPQgmI+2v56jdKgrgRdDgF/iYd5QaSuVUdvit17DrqAqkoCHcZ 2dQNCguxJyiWae41DwZpWHVXt0YVspabvutl3Ji2Cds6nbHHledsRa3dgVm0kmDLPn1b HxeDdpjQ0BIGJX0HyubwCN1ygjyfKmS/DRL+57IR2MvxFecfxLayeiH69IcFD7XQNlff vPsyaQtIdgd/SlnqkU5nnjSHQnt8XHP6iORoQm8/rvnfgPWpFjwzUOqVrj1OKhZoq67e JVTk4pTBwv65udxwbYB+fBTfPOhOd78kWe9sZ7YsbNdPe9ZUOWV+6h78Tbwsz2iCm+0X WQ== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xfj3e9v93-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Apr 2024 07:40:25 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 43I7Bd7T022408; Thu, 18 Apr 2024 07:40:25 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2101.outbound.protection.outlook.com [104.47.70.101]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3xfggga3ng-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Apr 2024 07:40:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bg+2b80A8jtj2kyvpUCXo5fplXF2+nkJXjH1rOVknQ3n+FGF9kAGDpbkmFg66dCoSQckNy/1/70tGgi/yJ1tRTrWSaqnVWJObxBd1C1XoObQQNBBCF0y9QaYjW2HTuJHrgui1LI3b7UZ2aUA+K/Fe1Sb1/VgYtOxfq7FtVQkaDOlxxSPpA+MyAvH6SKDlB9F/rJ46cE/KhTE5nQWK7x6aNQdqbnPX8ALDZHvKNbZj2aFypy7ZittcfCTin3hk6FSt7LbKRobWZs9CCqLrao4ODIlC4KVnfKx9OoozqLf81aITZscdn/lKBDim4PtAIu+pTxGiQp56wqnKjBWNfP+/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=79r1lyWp/dmdo8vOshmv+Jh+Wv5vQbdIkTeFmD5VYYk=; b=PaX9tA54EZasY76IjlPo+pY09/V9KER1Jor8D599OGDK/p8XB1bnLLtq50RA+3chZmyNzEfmoIOULE27tjfAzXSnxUAs8/057GuK2DjWyy7BJq5IX4Ahr9nk5skq5f7Mr+B61AAjRe1YuE7IfLKB+2j/iutMSOeNQkii5IBxM1JueIyIKEQKIt6T9tZPUe2lZTg8Gp8IA2w+IBZwaFDr9369rASiw6k2CdqeaAMMUO7G1yTbf4sHIwabhz+uUk169/jebT0aU3vgMn2zFJsYs1JVuiUuYbDYg3GNYTax4QO7N2JgQJNb79zVNn6IIYbm3VsFeSAy/rdBat2O1AlYHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=79r1lyWp/dmdo8vOshmv+Jh+Wv5vQbdIkTeFmD5VYYk=; b=YBWwj8jTus0aESL3AVr+qXCt6vYxIE7ZHdpTziqJfr4RJXQkCyhVU2R51GJNvPZku0QnGnuDORuhWd69CFJgRr7ECA68RCHF0Z+JWR/NH9yb9BfeX64kqDeEUk9uv0DAw4NDRXz3uqJ6XCKFr5iXFlkVGYtHhiaeNM+LdVpRYXc= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by SJ0PR10MB5694.namprd10.prod.outlook.com (2603:10b6:a03:3ed::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.50; Thu, 18 Apr 2024 07:40:22 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::6f0e:742a:270:889]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::6f0e:742a:270:889%5]) with mapi id 15.20.7452.049; Thu, 18 Apr 2024 07:40:22 +0000 Message-ID: Date: Thu, 18 Apr 2024 00:40:22 -0700 User-Agent: Mozilla Thunderbird From: Indu Bhagat Subject: Re: [PATCH v3 05/15] gas: Print DWARF call frame insn name in SFrame warning message To: Jens Remus , binutils@sourceware.org Cc: Andreas Krebbel References: <20240412144718.4191286-1-jremus@linux.ibm.com> <20240412144718.4191286-6-jremus@linux.ibm.com> Content-Language: en-US In-Reply-To: <20240412144718.4191286-6-jremus@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4P220CA0004.NAMP220.PROD.OUTLOOK.COM (2603:10b6:303:115::9) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|SJ0PR10MB5694:EE_ X-MS-Office365-Filtering-Correlation-Id: b942366e-708b-413b-1ef0-08dc5f7acdd2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MU/0Pad5TNBz64gmjzE8Dm+JPNqSv8Iyx4YLMqmek5WObD7y1qoP2XxbOAFURxpgK4lRHP8+N/Pt2mGuwh+GI7DX9oO2TZgLxbxa4uITz/SAT+0LJrKdglq7s3e2bDbTQYKxGhGWvYbMm5vfd6psNMAgfHcczlg1cbc9DAHoIoRXvWBW7zgVYm7lsFdDu3+NL/HJZkFK7dq1AUHJlFS5kzYhF877vULhCSgYyLinpsP/XwRmmWJM3DuEEuAwlm04puvcJjyUAzC+CXpVJ9V4piRb0KdTwgLiAy1vkXhkY4EpNG5yRum3cki6IDgYefTlKecPFWBhGaadJZJ5+dGLPq9rkHlikVKOlgERd5eHfxDYQ3qm0y+4giQN8UFPoEXQwQ3rD74aPE6517z1LAzDZ4hnPw64lwIdtZ4Jci5pJZkNAldf12ObWo09VuLE+Npnys/byq+efjhKt397naR7sCU14t+2qMTb2VhJR6S4nPuBfCY6sPynvVuRZOpKnSKDmEK68hiCDHzv5WTOkbbVQn7AD9J7ydbBD2DpFY0XtnIzp2VG9xoDZ78PhWTsaa97ij9KGvA9YRl0tCezsagqmmiyeJq9JvZ0upSTokqNPYZF3EY/eTD+V87d83G8jzQSb9/BM3rFMlWWiSCgW6a4eZdlFCiABMHidG2NCVX1k/w= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(1800799015)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0kxd1BndHRKNmRTTE8zc21MdmoxSWlJNjZVZkNocC92bm1PekF5d1dzdkx5?= =?utf-8?B?NXNRa0VqK1VHWDgyL0dxQkVDdFl4Q3ZvVEZ5K2JjTGlKdy93aHI0KzYyY09l?= =?utf-8?B?ZTdYMUtPYTZtNnM3a3B4bEVrV0x3ZWxqK3IxSy8yd2JoMXFCRU5WVDBoWjh5?= =?utf-8?B?TGowTysrNEEzR1JsSFVuR2Y1QlBYQ1VQVUpLdXFiV1A3eDZERFFRRnk5d1dX?= =?utf-8?B?czM2U0lyYlQrdUFYTFVFMFdUUTIvSG9CT0VVNjJMZEo0WHM2VElZQU5lR2ZM?= =?utf-8?B?bmNWdjVxaVZTSTA2NHkweXdScE5SQ2p0WmhhaHVTc1hLRmgremxzSExHQTNp?= =?utf-8?B?Q0ZkUGUrSUFUMDR2K1hsRTZhRXJqRUg3WGc3eUcxeDlEZTdUMlNNaVZ6aEtq?= =?utf-8?B?L2NtbFRMSng0eXhsdjNXdnA2UGdKYjFNNnduOUxXc3NjQW9rYm4xZ042ajB4?= =?utf-8?B?cGNDcTZSSDY4bE9FMG9CcXR2RnJZbVNNU0RHc1RlcDdLajI1Ni9waXQxUGJ0?= =?utf-8?B?cDNzMFBiRFBDd0J6Ujh2L29TZnE0QWpxYmZxTUxMa0R6ZXI5VEh4NVBZZmFG?= =?utf-8?B?WUU4dEFJQ0g5Q3FZVXN0ZHc0VmVjRUZJVWRLZjIxaEdYeHhSck1Sem9VK1VH?= =?utf-8?B?REZpSi9TL2pnWmhsWDVwbkJlS0VhdWVKNDM5a0pnY3k2UCtFdjFNQmlqcmhp?= =?utf-8?B?d2VZNDVBMjRQM1RYYTAwTTJnTkZjb0ZKM1I3cCtFblFHUGNEOGltRTVZeHcw?= =?utf-8?B?dVFuUGJPVG9EZlpqTGxSNXFpSkFVNjFLUmZLNFo0aldmZ2h5eUorQTk2Ykda?= =?utf-8?B?a2Y4cjI4Z0lLbTVYRWJ5bHFjcnZudy9mVjUvSnVUcVRaNE9LQnVZcjhHcTJP?= =?utf-8?B?TDkwYkl1Q3pRNTg2cDI4Vk5HblJ2cWFJMld0Ty85bk9sTGV1emlmRVliNW1a?= =?utf-8?B?ODMxVllwc1RnVE5mZk1yZmF4UzVIa0oydEdyQS9zUVJsRm0zVUR4RFJEMmZJ?= =?utf-8?B?ZlYycWhMNzBLeFNhNDNwWWlTM1B2dER0NkJrajZVYXE0SGJwU2ZvbURhK3Mv?= =?utf-8?B?SmZPZm1Yc2lmTUR4VUE0amRTYkhRamlXUXBsRU1LKy84N3pJWG4vUDQyOFBQ?= =?utf-8?B?bitMZXRmdnJpRFk5MnlLSjhBS0xZNzhzTXlmMHpyRGV4U24xM2R1cVEzNEFD?= =?utf-8?B?eHhiV2Vja2oxd2Z0cTRGdGhBNTRJakRkQytteUl5YVFleWltU3ZObHhPSUNP?= =?utf-8?B?U0hzSThTZGhDSDUzVlNvUmQ4K1cybFB5amxMR0xML2xodS9QdTJBZzlxWkNy?= =?utf-8?B?YjVSNGRuL3BCa01IaGMycUlOUEZuNytBdW9vakM1ZUtxS3U1NzdMUVhHQXdW?= =?utf-8?B?UmNINmRzRVNtT1dvZE53VmhZSVg5OUFhcFNUK3RhZzMyWS9lOVZza1JoZjFu?= =?utf-8?B?YUcySUZrOE1VTktjeHYxaGZncG1IUnpEWkx5WHlSWmVVRzAwNUJNUmErWHFo?= =?utf-8?B?UjI1cW1ZUHVXS3RvTFE1M1RLRDE1MUExSUhDS2UydWNSWHZXbCsyaUdOM1Za?= =?utf-8?B?aXJCb3U4V24vcmJtcE5ibkFLQlp4RHBrRVVSczRhaFQ2bGthZE90RDBCV2RO?= =?utf-8?B?YTFTSlVDRko3Sm9qUXRKVEZSTE9Xb0t3bGg0MEpsRlpvckJEV2g5Ulp0SHk5?= =?utf-8?B?anc2QVBaYkxqekZISUM1UlhBNmFFVEZ2aU5EWTdZYmZYN216U0M3ZW52Mm4x?= =?utf-8?B?MWk0VjNwN2c1alQ3YmUzc2hiSnBLNmUrV3hzaWVqdjl5K0U1RjN5bmRoeVZ3?= =?utf-8?B?MWtsMGhJYjJwZWI3TDVqZEhSQnJxRzdRYVQzeG5PRDFMRVFhMzNsek42dTU4?= =?utf-8?B?ZStmN0YzNTJiekNkOUdtYXdzWUtFV1EyOW9Tb2Y1OWg4L1gyNHVqd3Z0Rith?= =?utf-8?B?NTVhSlRwczVNbWlqN2hpd1pxYmVXVGZHZTFNMG42STlwMkRXZVBkSzRIYytw?= =?utf-8?B?TUlKaVFGTzRjS2xXQVpoYit1RlNFRVBGSzhyQ01BaU5qQW0zdDNNbXNHV2VC?= =?utf-8?B?bk00RkVuS0Z5TFZHb2hNa0U0RGtzQllsNjFvdk5UaWFKTlcrT3p5WVJiSFp5?= =?utf-8?B?Qjk4dzFNL2lKaDZzSHYwaWhJNVlvMXk2N0hMekM3TnNPdVBQSEhpc2sxcXdT?= =?utf-8?Q?Dw/w84TCWayDigdXBodd3mM=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: N2FGXV8i6/gEZxhaofPWmBh09nWAgVsP5mnDXsapOb1Ju94xWhyZPme0AIcTe5krnSBFDeaiSwSexbJIN+THzBsOmbRBEIoR36XI1ieBMyP8rq8YhkF3Q2S7wHOJ7jmAj7dT4T2IQFQMAFSjalVb1iTOdIqCE7H7njhLwsM64QkFhLIIizs7gWX+hAJgLoEN17m1kEBfiwzBFk7vSj1uSAyOJJW66ooqU2hFBpFEXATIXSWcN+UeNeP0R2vfwF7CPghJLRonH4di601QG4K5gaLR8iCtLIgP6BdQoI6QW7K8/vzPh2q+0KQ0ytBzXZw2cSAWt5bve7LhoKfazyR3BPnTNuns+S1Frj2Z4AlPr1ZzYJXtvTXIeYGiowfcZEz4KNwYDmW/SXJ+LacZjCI1+0dy0UgfI0NS9qz3CdZ68ZLsOF25RoXiVh8rfDdnbvCXigTT11BeuDZcHm3vp4KrbzbAL7I6dLVRssOxyOC5n5hFZ7RUxA5k7LNB/JtCBK1yI6C5di2QQpUxvzVkuW3YDsoPi19edXD3f6eI8+MuEvlfuwwPsx5EgYwC8vJkhlBnCgYoAMc7zVR5iQb+jlWCaqbQGBvEFL15HE8ldIKarhQ= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: b942366e-708b-413b-1ef0-08dc5f7acdd2 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2024 07:40:22.4176 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BXPmoB7M0ahdfgCLF7ofLtkYFk1MRI1Smp7L0nr44UY7m63Qyr9Fw/ihtNJqlHPl8fyE1cnYbbKfTWn0QJK49w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5694 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-18_06,2024-04-17_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0 adultscore=0 phishscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404180053 X-Proofpoint-GUID: LLzwedMeU_70uWPFpsysNsOf9LimDu6r X-Proofpoint-ORIG-GUID: LLzwedMeU_70uWPFpsysNsOf9LimDu6r X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/12/24 07:47, Jens Remus wrote: > SFrame generation prints the DWARF call frame instruction opcode in > hexadecimal. Leverage get_DW_CFA_name to additionally print the > DWARF call frame instruction name in human readable form, while also > respecting fake CFI types. Use "(unknown)", if the DWARF call frame > instruction name is not known. > > This changes the following assembler SFrame generation warning message > as follows: > > Old: > Warning: skipping SFrame FDE due to DWARF CFI op 0x > > New: > Warning: skipping SFrame FDE due to DWARF CFI op (0x) > > gas/ > * gen-sframe.c (sframe_get_cfi_name): New function to get the > DWARF call frame instruction name for a DWARF call frame > instruction opcode. > (sframe_do_cfi_insn): Use sframe_get_cfi_name to print the > DWARF call frame instruction name for the DWARF call frame > instruction opcode in the warning message. > > gas/testsuite/ > * gas/cfi-sframe/common-empty-1.d: Update expected SFrame > warning message text for DWARF call frame insn name. > * gas/cfi-sframe/common-empty-2.d: Likewise. > > Reviewed-by: Andreas Krebbel > Reviewed-by: Indu Bhagat > Signed-off-by: Jens Remus > --- > > Notes (jremus): > Changes v2 -> v3: > - Removed stale ChangeLog entries from commit message. > - Corrected formatting of ChangeLog in commit message. > > gas/gen-sframe.c | 49 ++++++++++++++++++- > gas/testsuite/gas/cfi-sframe/common-empty-1.d | 2 +- > gas/testsuite/gas/cfi-sframe/common-empty-2.d | 2 +- > 3 files changed, 50 insertions(+), 3 deletions(-) > > diff --git a/gas/gen-sframe.c b/gas/gen-sframe.c > index 75781fc8ccbd..d35baaac54b2 100644 > --- a/gas/gen-sframe.c > +++ b/gas/gen-sframe.c > @@ -1197,6 +1197,46 @@ sframe_xlate_do_gnu_window_save (struct sframe_xlate_ctx *xlate_ctx, > return SFRAME_XLATE_OK; > } > > +/* Returns the DWARF call frame instruction name or fake CFI name for the > + specified CFI opcode, or NULL if the value is not recognized. */ > + > +static const char * > +sframe_get_cfi_name (int cfi_opc) > +{ > + const char *cfi_name; > + > + switch (cfi_opc) > + { > + /* Fake CFI type; outside the byte range of any real CFI insn. */ > + /* See gas/dw2gencfi.h. */ > + case CFI_adjust_cfa_offset: > + cfi_name = "CFI_adjust_cfa_offset"; > + break; > + case CFI_return_column: > + cfi_name = "CFI_return_column"; > + break; > + case CFI_rel_offset: > + cfi_name = "CFI_rel_offset"; > + break; > + case CFI_escape: > + cfi_name = "CFI_escape"; > + break; > + case CFI_signal_frame: > + cfi_name = "CFI_signal_frame"; > + break; > + case CFI_val_encoded_addr: > + cfi_name = "CFI_val_encoded_addr"; > + break; > + case CFI_label: > + cfi_name = "CFI_label"; > + break; > + default: > + cfi_name = get_DW_CFA_name (cfi_opc); > + } > + > + return cfi_name; > +} > + > /* Process CFI_INSN and update the translation context with the FRE > information. > > @@ -1272,7 +1312,14 @@ sframe_do_cfi_insn (struct sframe_xlate_ctx *xlate_ctx, > /* An error here will cause no SFrame FDE later. Warn the user because this > will affect the overall coverage and hence, asynchronicity. */ > if (err) > - as_warn (_("skipping SFrame FDE due to DWARF CFI op %#x"), op); > + { > + const char *cfi_name = sframe_get_cfi_name (op); > + > + if (!cfi_name) > + cfi_name = _("(unknown)"); > + as_warn (_("skipping SFrame FDE due to DWARF CFI op %s (%#x)"), > + cfi_name, op); Nit again: I realized when looking at this patch again that DWARF standard uses the terminology of "instruction" for these DW_CFA_*. I looked in the existing codebase and there is precedent to using "CFI instruction" in error messages. How about we change this to "due to CFI insn" ? OK with that change. Thanks for the patch. > + } > > return err; > } > diff --git a/gas/testsuite/gas/cfi-sframe/common-empty-1.d b/gas/testsuite/gas/cfi-sframe/common-empty-1.d > index 125612ff841f..d7756302b559 100644 > --- a/gas/testsuite/gas/cfi-sframe/common-empty-1.d > +++ b/gas/testsuite/gas/cfi-sframe/common-empty-1.d > @@ -1,5 +1,5 @@ > #as: --gsframe > -#warning: skipping SFrame FDE due to DWARF CFI op 0xa > +#warning: skipping SFrame FDE due to DWARF CFI op DW_CFA_remember_state \(0xa\) > #objdump: --sframe=.sframe > #name: Uninteresting cfi directives generate an empty SFrame section > #... > diff --git a/gas/testsuite/gas/cfi-sframe/common-empty-2.d b/gas/testsuite/gas/cfi-sframe/common-empty-2.d > index 59328fc1033f..20282c7854e8 100644 > --- a/gas/testsuite/gas/cfi-sframe/common-empty-2.d > +++ b/gas/testsuite/gas/cfi-sframe/common-empty-2.d > @@ -1,5 +1,5 @@ > #as: --gsframe > -#warning: skipping SFrame FDE due to DWARF CFI op 0xe > +#warning: skipping SFrame FDE due to DWARF CFI op DW_CFA_def_cfa_offset \(0xe\) > #objdump: --sframe=.sframe > #name: SFrame supports only FP/SP based CFA > #...