From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 2D0503858D3C for ; Thu, 18 Apr 2024 20:35:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2D0503858D3C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2D0503858D3C Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713472514; cv=pass; b=EciBpho47NqVpHW/ZlCLnmupDmmMWOOYZvR3nkh/L7Ab+GSg8CUw9jWOrcZKZo7yN/e1ysRFlL9fUKEdnd2bO/CT9WYU8VXgI9RnpRRHTgqtWXuMVH9143suV/PjyoyV2DyTCB8FXLpp62LImfBFsXSNmYkZ7Rr/9MDFO1ZU7A8= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713472514; c=relaxed/simple; bh=mKqJ+/1hV8jKgmMDuqlhFTJIL6ZNmMP85GH0jBtEHLo=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=rqmXkzcD3YtYmOPQZ3OWfwSjU1IDSdB1RI5/eYV6xfJ3xPdVYKDOx9XP/U3/+Mo7H56nTWuUIn7sNuTfRFjI/8cid7aN8xIawEtBAOrKchu/pvXip8bx6G9xKxRwwA3BluIlNcDhtdewywQoan1YADjgBk/sU17VZtsvnb/csDs= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43IJi9Oa020534; Thu, 18 Apr 2024 20:35:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=OZQfurNTfsDw7F2KA5YXU2H8Ky0q9FSp/GP1wVbVkKg=; b=dmQ4mvE08msCgzsZt2TfQGoV4LZ60CMvwarkYmDAJWI+dhYwsO5BgknQ3qzZ2C7CC3ps ucXTPZkxcpkjU7XMlD+rJ+8LyYgMOXVOyvioAu/8QDuq2z5LTBjq1Tq5aMlH+TpWaUhI KdPE5ebYQoqElWJ5qzIoIUWVjWUSYCaTgbWPbkjxwBja219DhI0xk2g8+o2XlTi5BWwE PnIH/II4NOskvJcXv9JfyevUaRfoB8tOeyjx5EFum6qN6O+/KcAXmXdqL6wvRl1QhIPB tDgvoR1ppgwcRgBwBw3poaZVOwSM2ps+jqeAe5uZWNcAT+WoahySlooAaJVVof5v3PuL tg== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xfgujupha-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Apr 2024 20:35:09 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 43IJTOVn014252; Thu, 18 Apr 2024 20:35:09 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2169.outbound.protection.outlook.com [104.47.56.169]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3xfggh8f9f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Apr 2024 20:35:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y0Q/G42Adshji0x2YrT9SzSfhcrlauKUgx55a7+lHYBVuLVH9cmNCi/SCFht8WOkEZ/6VOlt9Xxh0f3wDnHpGiFg26e3QwFe7hqi192G7Pf+ojOfjP2VXWVJyX5ri2fri5f2kbz3XZ9qg72IcSCtdq04D6LtZ9tbUq/N7IJTEyC+119OqnPYUl5xrmcxlLzy4O6grr2pxdcww+dDDXP0+a13n1YDKQOuExNrszXKcr1LHQF0zJrL/8pUTlFFKB/4f0edCtCv24AJ1EaR1wvoPbx6kGHLBEonK//+R58DzHw9p2OpObQPxJlaxJojWLdIk1RGxbem4ld7hjpjF7lXgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OZQfurNTfsDw7F2KA5YXU2H8Ky0q9FSp/GP1wVbVkKg=; b=lOXrgTZtqlvFI+oeR3DrdSIHhZQpd5lMIa3bo68ob6XeQE7NzZcC1S0wnfSdlYjDi6k9S3dlkKsi6gOl8cF/B/eSYXtwUrXNFu0gql6jA3H7PMj3TZs52TmqCT0L4hy/ojW/Dhy6AGFGCD8AI2hPP77qUHGlUbKDqFfGjbRMDy/+FWcgDncFaoS9z7DDrAuJaZgJy+knCDpUya0c78X8ZD/iPgF71zCFSwrOXxYg4j8cwH7St3Llhkn/HEOzQDVjHLhLC4crNGnyy3JmHR6tjCORCmNvd2SeNBQeShRgiRWdmwdE+Tqftfscrzhsl/VqYdOLsJV4qZsvsW79HNTjOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OZQfurNTfsDw7F2KA5YXU2H8Ky0q9FSp/GP1wVbVkKg=; b=H5Xs4+x7p0wOFQEuNVI5HH6g/sWchvDJYOvQCDupPVH7PxzuFcM4S1O3ebdRDYYg8uKUTleRa7ln1U36Sb28BXyuvspy1fXhhIM0AyFLjIC5PnodJC8K3aR6e9FYMQuPKjfd1S8rFDh5vC1SfwEFnZlEFH2TSTX38z/hvStnLR0= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by PH0PR10MB4455.namprd10.prod.outlook.com (2603:10b6:510:36::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.50; Thu, 18 Apr 2024 20:35:07 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::6f0e:742a:270:889]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::6f0e:742a:270:889%5]) with mapi id 15.20.7472.037; Thu, 18 Apr 2024 20:35:07 +0000 Message-ID: Date: Thu, 18 Apr 2024 13:35:06 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 10/15] gas: Skip SFrame FDE if FP without RA on stack Content-Language: en-US To: Jens Remus , binutils@sourceware.org Cc: Andreas Krebbel References: <20240412144718.4191286-1-jremus@linux.ibm.com> <20240412144718.4191286-11-jremus@linux.ibm.com> From: Indu Bhagat In-Reply-To: <20240412144718.4191286-11-jremus@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR03CA0162.namprd03.prod.outlook.com (2603:10b6:303:8d::17) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|PH0PR10MB4455:EE_ X-MS-Office365-Filtering-Correlation-Id: 731e471f-bd0a-4865-474b-08dc5fe708d7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F0eOz8GEgfz8swDIDKwr8CCBGa7k18siS/YfUA0RksB/zqf7fA+JJkSmQGbVU41B2nBSWY39f/TSdVLeE9VC6zKlRNcnGuw/QUGLOX77jf81LNcMxOtyir5XhOCfkmKRTqkTWz5iAxmR8Gnm661vVf/4f9iRnpOO4oXf6VlGTBi+jPG6Uvy2wKlZdaZZZnV/wIMQn41nbozy2Gd79v/Xv0Rr9q7FUOeCRsbRE3gjKN+fPYuKzWcPeV2HaZGTim98mWiNyRWDaadoMYYcUbq1upqsOF8X+ArjPuJxivfqUFRN2MOdZErNFz+yn999awyYpArxlReSXDEyierq2XgRr1lUccpTwJvM1oB7k+mBVXFCfKl12ppDmF4Q3guj715ypY6RINDjJuthqui8rFb0U19K2SKvtkqTtcSA++bFTuRlI/1wTZR7c8YaVd6Q3YdDhxLYL9R9jV2TW4MFHy9VTf/4FsTPf7HdrnoyvlqpLL7RYEWvUGo6yTy82u1gZsnOKhj9bqtYuufhlrzFau5h1miIeSEMhAEHj0AvxhKDVbPcsL4nyR2uAD0vdrLiWAUi8jCu6SDAKCFspeO4D5mcZl8EcC8GTP+3zxxTvNZLhja5ESdURWrJkhBji39IU/+BWqln3OyjhkPZXiJQj9ge05vSOcpPTc6slEJAhp/3ldk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(366007)(1800799015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QkN1eVJzcFVtd2ZaUTRkaUxjMTI0RjhnVW9xMHFucDZmVU9sS0pGUUc3VHdl?= =?utf-8?B?ZnRIZ1l6enJESzlGemU1NUdvTld6QWxvUDkzcmxzYlJpOG0zc1pyOW8rbzlT?= =?utf-8?B?S1VQNWs1RmVJNFFPYnJHaEJJYlAvV1BlTjMrY1FkZk14V21ZSUl0cnBWamRq?= =?utf-8?B?ZW1EVlJKMm4zSWM0NWMwaEw2YnBJVEE2bWtlRzFEVHF1WVFNZDJtMkh4MERM?= =?utf-8?B?ZEJqbVp3WXJySTFHRVpFaXNoMG9KOVVaU0k1eXVKMUk0aG56RFhsbGw2QjMy?= =?utf-8?B?QmZHSFgvdGRkVjlObjBVZFFvM09jaWlPTXlVZ0xFeHZleWFpOHJ2V1duSVVi?= =?utf-8?B?TVBCN0QxVmFRMlFidnhRUjYzZlVjbWgwOVNTMncwdkh1SmVjS3NFdU8zMHow?= =?utf-8?B?YUU3RGFRS3BEVEt4TzZGdHk1aG90WVArdXVsQWZWL0Z0NEZWNWllNGZIUXU4?= =?utf-8?B?TlpNWTlaelhOaElxUyt3QmNTTWhpb2VtMXE4ejFSTzRlOEp4ZXYvajNIU2Qy?= =?utf-8?B?NTNlQXU2TmdHaUJWTzRHbVlIblI3dWwwaUtHcU1yb0k1UVFpSmNxaHpLbDcr?= =?utf-8?B?dWhqZFhPOVhJa09TYmh3YmpQaGJFdDFIallJbFVRRE1sTU1IV1FabFE1THh1?= =?utf-8?B?MWNzbzMveDNxMjVwUzBwQUltVnJJNUd2V0RuUEdYUGFGSmpQcU02TzBaUm85?= =?utf-8?B?eXJXY0YrZlYxQUVTQ2t1dkgrVHpBNmNPRXM5MS9OTmp5c0pnMkU0dXkrcytw?= =?utf-8?B?TXBzQUMwWUw4NnN2VjFEb0RmM2o3QUFhcktaOGQxU3pGWElKSkRrZUxhV0Qr?= =?utf-8?B?Wk5DUHJVQW9jQ1FJeVNNZHJOTWpieWt4ODZyU20xK0s3L3h3ZkZmVStha3Z1?= =?utf-8?B?dWwwUDJuNnhJQjhZV3FxdkwvLzNDUXZ2QmFPYUZVWS9Zd0tMMVlFUXMrVWdh?= =?utf-8?B?N2IzSFJQY25VQktudS9SYUNGWjc4bUgrT1VNRmkreGdTTGJjWWhGYWJKMHJy?= =?utf-8?B?dkFJSmZJOHlDbGhnRVI5UE00OHFMb2g2M1JaNm52WkFYS2RNNnVoV0g5VzJa?= =?utf-8?B?QURKczI1TzE1WldqdzJuQ05XR1lQai9rcjRiYU1EMVZ6VWpOZDBtb2dOdHJM?= =?utf-8?B?ZjNJb1N1S0ExREZTNnBNcmg0dzdNeEVjbllUZWtSdDZIQVA2dnRVTTJ0K1NS?= =?utf-8?B?bEUzSmhFQ1JkU1QwV3VMcUM3SDFJaFFuYVowTVpUTjAvSWorbDc1R2ZJV3VB?= =?utf-8?B?YTQ1TTJmb0lyR1dhYm42UFNDY2EyeHNUUUFTcGRKZ3h4WlhwbDlGa3JXN245?= =?utf-8?B?N3hiRjl3WEZRc0ZnbDJiMFozdVlrY3oxVE9EZStWendFS3h4amNKUFhPVExB?= =?utf-8?B?M0JKQ2V3Z1cyY1FQQmZDZG1vQzBBSmFrMi9OVmpEKzlTbDZxQzJ1U2FkdlZO?= =?utf-8?B?eG55QlhraHdQd0xQcC9IK201V3VpSXJrYk1wcXh5T2hSQlNEcGRrWlFiVTRy?= =?utf-8?B?ZzcyM2taMnc5d2JtOXgrRkpJV014ZCt1b1o4R3RMZDZkYndIb2tSWTh4cFp4?= =?utf-8?B?M21vdlJ4WDRFS21GQUpMbVZqMElFZHBwMVBaSW9sVUsxYTQ3R2cwcldyNVk4?= =?utf-8?B?d1BIcWpzYVJyRmk3SHc0Tkp0UGZtMGpqZFphRXVLY2RTcGs2UXlqRFhjK1VW?= =?utf-8?B?Z2RnQVZZaFZ6dEQ1ZXZkL1BEdmk3S0xiOG5ja3l1QnJVNURUUGR3cnNsd0hD?= =?utf-8?B?dml5N1pMT0wrOHNESWlyOXdtNWJXT0wvNHhhSnhwcDFFQ2JBcTZJRnBNMFFi?= =?utf-8?B?MVlCMzNLSHNjNkt2cDd1UkpLYm5VU2JjY0FtR1BhWHNhVldTL1pEZS9wMmdN?= =?utf-8?B?UzYwaVJycjdkbkZoSHNOdEJqMmxYNS9YSTJickgyMlMxZDdFejQrWE94ZkMw?= =?utf-8?B?UExsckxDSXczYVlsam45cnlHNFR2bmNDeHdGMVFVd1Z3YjFBTGYwS1ZrQW15?= =?utf-8?B?b1puZWNsUUNtNC9sN1hTTCtNRXJhV1lpTTJ2bWc1UkhodjlCd2ptd3lLRENl?= =?utf-8?B?S2hkQk1OOERGMFpGa1gwS2FKZ3Z4RHlCY2JEVkVrc0h0RVhiOFA4V0VhNTUy?= =?utf-8?B?OUtaS3c2UStIKytsYjVoaDd5OGRwbVE2VXBrbmpKYzliajVIdHNMSnJOeVcz?= =?utf-8?Q?8KV7ifq8WDL6f5si2/bKG7k=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: CitzrMY1CG6SkA3m+T9neeRxFstTD2LU0zgNlzEpfyXW+fCk8xR58xnYmfGebuPuWMmTyr+YTynnxmgd9GsMr7JrQFYjUnCtk6V1i2GfZxndnb+mx5HS+dd/F8vXNskR1eLdcUlQ45Fcy26V61oiVIdD1oZ4kmpTTns6allkIMwWIIVUia8XxauLISYm0m3qDVt45l3Ri2Y4PkW3du1WjoK46KQBI/j2wXGfXiEq3ZEDy1rZSHTv+vpQ+S4A6ZgIKh/UPvID1+zTgHYEUxPLzaaFFIrF+0ya9fv5rFBhfdQNKBRhO1xbQoC9MtE74IkwK1nNWI+xjNpMdqmnZl+7CtdoRTQgIvcUtpFCkzy78YQlqSAy3+BtOd07ob8OtbEmtAnGt/SuQxNIqleLeTVXEBqsQZ+9/zQzIAkl+aF2rtli0DYnyTdqGtgH/9IEu5WQMOLJQ2/+ls3KSwSYs9AXPquKMjGv3lyZ2ZSesXKKFKsrDjX2FldBd6rRrIvBUddd5mjLgYcfSzdUsyMQTtfzsIsfC7K/JeskW+QdJESAqWuNCqcWTP5X9gBW+o6xk28boXG2RTyNrtHqwJw21920PqSKPt/ejvp8oPkjN/AvexM= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 731e471f-bd0a-4865-474b-08dc5fe708d7 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2024 20:35:07.0785 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FfLcgT2MhFLD/zJvrqoveA4ngXthz3imGHo85IvR5PKktqY0h/yEgOMdCp50tYyGW+SbszwuUwpdh0XyoG4a+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4455 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-18_18,2024-04-17_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 phishscore=0 bulkscore=0 spamscore=0 malwarescore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404180149 X-Proofpoint-ORIG-GUID: aBW3tYExnHcDT84lIq9BG5jnSU-7-OZ0 X-Proofpoint-GUID: aBW3tYExnHcDT84lIq9BG5jnSU-7-OZ0 X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/12/24 07:47, Jens Remus wrote: > The SFrame format cannot represent the frame pointer (FP) being saved > on the stack without the return address (RA) also being saved on the > stack, if RA tracking is used. > > A SFrame FDE is followed by 1-3 offsets with the following information: > > Without RA tracking: > 1. Offset from base pointer (SP or FP) to locate the CFA > 2. Optional: Offset to CFA to restore the frame pointer (FP) > > With RA tracking: > 1. Offset from base pointer (SP or FP) to locate the CFA > 2. Optional: Offset to CFA to restore the return address (RA) > 3. Optional: Offset to CFA to restore the frame pointer (FP) > > When RA tracking is used and a FDE is followed by two offsets the > SFrame format does not provide any information to distinguish whether > the second offset is the RA or FP offset. SFrame assumes the offset to > be the RA offset, which may be wrong. > > Therefore skip generation of SFrame FDE information and print the > following warning, if RA tracking is used and the FP is saved on the > stack without the RA being saved as well: > > skipping SFrame FDE due to FP without RA on stack > OK. One comment below, otherwise LGTM. Thanks > gas/ > * gen-sframe.c (sframe_do_fde): Skip SFrame FDE if FP without RA > on stack, as the SFrame format cannot represent this case. > > Signed-off-by: Jens Remus > --- > > Notes (jremus): > Changes v2 -> v3: > - New patch. > > Without this patch the assembler would generate incorrect SFrame > information without warning for the s390-specific SFrame error test > case 5, that gets introduced by patch "s390: Initial support to > generate .sframe from CFI directives in assembler". The FRE would > be followed by two offsets for the CFA and FP. SFrame would > erroneously interpret them as CFA and RA offsets, as it cannot > represent FP without RA on stack. > > gas/gen-sframe.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/gas/gen-sframe.c b/gas/gen-sframe.c > index a3b6f75cfe85..87be3eb05ad2 100644 > --- a/gas/gen-sframe.c > +++ b/gas/gen-sframe.c > @@ -1439,6 +1439,25 @@ sframe_do_fde (struct sframe_xlate_ctx *xlate_ctx, > = get_dw_fde_end_addrS (xlate_ctx->dw_fde); > } > > +#ifdef SFRAME_FRE_RA_TRACKING > + if (sframe_ra_tracking_p ()) > + { > + struct sframe_row_entry *fre; > + > + /* Iterate over the scratchpad FREs and validate them. */ > + for (fre = xlate_ctx->first_fre; fre; fre = fre->next) > + { > + /* SFrame format cannot represent FP on stack without RA on stack. */ > + if (fre->ra_loc != SFRAME_FRE_ELEM_LOC_STACK > + && fre->bp_loc == SFRAME_FRE_ELEM_LOC_STACK) > + { > + as_warn (_("skipping SFrame FDE due to FP without RA on stack")); > + return SFRAME_XLATE_ERR_NOTREPRESENTED; > + } > + } > + } > +#endif /* SFRAME_FRE_RA_TRACKING */ > + There is a comment "/* No errors encountered. */" at line 1452 (few lines above the proposed diff after applying). I suggest we also remove / move that comment too. > return SFRAME_XLATE_OK; > } >