From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150044.outbound.protection.outlook.com [40.107.15.44]) by sourceware.org (Postfix) with ESMTPS id D25923858C50 for ; Mon, 15 Aug 2022 06:18:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D25923858C50 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=myuRbuUAos9f/CWEyEbIG0FBCYnEHFHyxcSXz6KUTZuVZgCIA8K8IkHFvmRsO09ZjPaTJK0XRy7SiO+vsmK+UGvFmY6JoaSRUyv3I2AnyhI9YmlWaXRCuUjqLO4ZBVIJ3u2LO5h9qahCTecMuiqoHXHlQKFOiBa6zmQHJMtBf/Rcp5vU59QaoQ8oEeflQ1z0aQcJCjh2UwUIyYfpVFjSPStGlSyCBpl1dnCH8TEQsO37LcAA+bZWXvcUvzKJwJ2A1ztw7znV8/pKyT3NKpmx6ETfT40t2R4fSnOjRXIclztetLF4GXBf0A8Cs+fwYl+EyU2sLkIgQ+pXhvsCIG4tkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CWga/3e8NsV9eABrKM9vBMu42tpX+nNbTXEQnuSkZ9A=; b=mgkAMYhNQYH3taYhXeDy4EfuqpeN/ogLu//pXO1NRmz+/k8JHLv1cZFfMCt51lsfs617txwwJWYslD1HhoWGdh/6eiRxnPUHPuqV7zKz/sBMvHZIwzmFaL3gK4PT6XOYHpOeFdI4LIQNzgHjqyN3DBdgcm7HqYo3h3Z4pTet8X0SBOSDczwCIY5WgNVr5JMIul8kZsA1vkYUwM6/L0tBWzVvJGsfBNGS5/lxWOJeHrxidbAkht6e2ZR5oa/7s+Ace1XiqEBAZVBGU0X8tc2PBLXaXNHrQFm6rXn949k+vc4zi7n+qDZjkKgXKPAp/DK7V0ZwEHQ97Nh62+i8+tzPYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB4495.eurprd04.prod.outlook.com (2603:10a6:803:67::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.10; Mon, 15 Aug 2022 06:18:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2d5d:bae0:430f:70ad]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2d5d:bae0:430f:70ad%4]) with mapi id 15.20.5525.010; Mon, 15 Aug 2022 06:18:38 +0000 Message-ID: Date: Mon, 15 Aug 2022 08:18:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v6 3/7] ppc/svp64: support setvl instructions Content-Language: en-US To: Dmitry Selyutin Cc: Luke Kenneth Casson Leighton , binutils@sourceware.org References: <20220626190005.7727-1-ghostmansd@gmail.com> <20220725131020.128550-1-ghostmansd@gmail.com> <20220725131020.128550-4-ghostmansd@gmail.com> From: Jan Beulich In-Reply-To: <20220725131020.128550-4-ghostmansd@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0007.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f6e6b281-d2d0-4a08-7d5c-08da7e85fe25 X-MS-TrafficTypeDiagnostic: VI1PR04MB4495:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dopG9hb3Wi6KrCGtlOi7G6S6Ev7YKVU2ZgA2EgeVifBTJs5kQc29Yb+QhRrF2/mY5wmsE+g8bbCSSmN+rUygm0kXeJY3CBAqzR50SxKqCb0akzlyBPAGH9fpxFYV1M6TwFr4fLExUvtRUudtD5f3ISb5SFcd3ojDh4NJs3LdRgiIo0QMMLFIVP+GvhoSOk5Segq6PoZ9FYu/F5wsy4VluE4Al8pY0V9D1BqGSbE+VzY01X50ULtvAflk1niC3nk/lIlxG7BjVpLRZ7UtJnfYU5vU/8RXn7Zgwd+dhOD3Aq75XXNRhu3u6YGUXUa6RvCKl3CPThj7nlWO8CLm58PPUvETQQjxAe+lhb767gEQbpFovR6rexjhryNLGyl5Ic9CDFStB36O46VCWqWD5MXlG6DzYYdrQyjRWWPjqVLfny2DAs6i99f5TYJBaZdAGBpZcm5d8ObJXLTJuTqFB09B+4jEY3wQseQyXkv/qwddKN14ES7HOFntpFd+lokIJ+LaiMUG2/SHzbup84Sl9n93B6qFMfPPcoAyo1PZeNtwkMoBb8gXkl99N88J8GqCtYKfsvNZ9tKKoAAdtr4GyP1TkntwrNVmZqQ+eClCGhXweUhPL0n06cYiRpEaCqcgYqyJ1kT6koBf6Y7ZDxyrM0x4IPVoMnCYgYcUZ4OB35dzlgBap/la3Mf7iPRgjBt0wO6ujO+G0/AjwRGq8/i0RtzUi+yUnFP/hyGms66nG/k5TmTW+MgbMBqXefdnjWexk0eP7MHcsian6B65djqMY9RJGydw8Adsd5lhHpHeCsfoohL5eYJFzFgXNdrIo6JbJva+iwJyGvK/IUYLkX8Z+HKDtg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(346002)(39850400004)(366004)(136003)(396003)(38100700002)(26005)(31696002)(53546011)(6512007)(5660300002)(478600001)(6506007)(8936002)(86362001)(6486002)(41300700001)(4326008)(8676002)(2906002)(66476007)(316002)(6916009)(66556008)(2616005)(31686004)(66946007)(186003)(36756003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bll0THhNbnA2U1BiRUFtdzZpWjJ4bDNVa1ZEM1Q0cW1abjU4SU1UZWlwb3Ey?= =?utf-8?B?T2Q1aGk4MWFtazNGK3o4U3pEMjRLTml2UnY1bjhDVmU4N1pkV2tmVTF2WSs5?= =?utf-8?B?ZTdheEVpMC9jOEJ6ODlINjd5RDNobklKU3E0SFFjODdwWWllL09VSUs0MWVZ?= =?utf-8?B?UzJRVkdBTHpJRTJ4VGtJQ0M0MXE2VnpMYXdLY1lVQllKNmxJaW9xY2RPeWd6?= =?utf-8?B?T3JXNDBENDZTTmFTSzg3b0ZibngrMUQwMkZ0TWRSLzJBL3lzMnM4dTFjTzhE?= =?utf-8?B?SlJDVXY5cXdlbTEwRm1qNE1MbU15RW9lRnZxQ0FkczlUUVBwOWdianNkcGg3?= =?utf-8?B?SFhlSUt5dzZvbkE1SStidWkrU2ZPUklQQ3hhWDJYVXc5R3doTHRxK2owTmpV?= =?utf-8?B?NU83V2ZZeE5QNEVJQ3ZMTXErTU1NUE9DMm5WYkFWTUs0enJoZ3VCK2xUc25W?= =?utf-8?B?ZXp2UUcxNENBWHkyYkYxOFJ2UUI5bDhtOWVEWGU5bFFxeTRMMVZXZmt2cFF5?= =?utf-8?B?UktPb1BOYkFac0VNYVpmZ3ptSmJBQVR4bjA4QzhGUzJnOHI1cjVVZVUyUkJj?= =?utf-8?B?RGZuc0s4M0VhSDFrZ1NqNmtFWEpWTzJQNXVZYU1SUGVzemJWck81TzZzb0RY?= =?utf-8?B?TGw3Mm1HbE4xRHBDdVovalBjeUVKQ2U1RnBMMTVyTzhHck9QN3JRMlhFdEVZ?= =?utf-8?B?WDJaUGZoRUZsb3ZHeEVlamNkVXN3dkxKTll2Z2Y1VWJIQitPOUFvR0k5bVQ1?= =?utf-8?B?VktPRnV4UnU0STd6bENTKzJyMGF6ZjdVelE4Y3RibWp1UmE2UEZuN2JMSG05?= =?utf-8?B?Z1hJa0tWMTlid3o4dEZmaWxhMTZ6czhXbWxZMXdycjZ5ems0QmJHMTI4WjNQ?= =?utf-8?B?NzlEUVdXTU9IdXVJbkNDMGhiNzJ0M2RwYzdsSXhSU2t5MGs1SVpZUFlqNG9N?= =?utf-8?B?RHczQ00wY3puSCt3NXd6TEdneXlITUdZbnNWeXRZVDhjRnkzOWp3RzlBY1Vo?= =?utf-8?B?RFNhbk56cDBUVjVjdHFnQVdOL2JhQWcvRW9JNkt3VFhlTlBDd0NhSUhkV2F6?= =?utf-8?B?dmdEdXhtUHR4NzNOS0pnK2Jmb0cyN2dlcWw1QU9UaXhtKzBVTi9GYVh3Yld3?= =?utf-8?B?UytVL29yNkNUZVNMR1VIZWlXU204ZFcxbmZCenRLVmVVajVaSFVuSWt4Nk1u?= =?utf-8?B?TXg3T0dVZmVkQ3BvMTVYbGY0NDV1emxHRFVtQjl2blNBSDE2blN5YVBVRXN1?= =?utf-8?B?VUcvMHhsZjIyTWluZDFMVExrL2U3dWt0MEtCZk1pazRLR1dOeDFZLzdSNUly?= =?utf-8?B?NHZpelVrbElJblBuWGNtaVFTM0RCK3JoNTVrSDkvOW5RVVcvNVltY0pEMjVk?= =?utf-8?B?SjVNNDN4S1l0bEhuQUxyYm13d09XU1JFcHgvSGZzQ1BUNjN6Y2k4dkFDUHUy?= =?utf-8?B?ZklYWmlhNVRYWFhYRWVnUzZmckJrRXoxSWxrL01yb0szL3ZhVnFQUk5WVjJI?= =?utf-8?B?ZDVzc0I0b25sMDNoRGlhaUFVd3l0MDlDV0Y4Qmdkb3pqOC9VcEU3QWY5aUto?= =?utf-8?B?QUhoS3BtZWtPTG9DOVhVM2JFSU5aWUV6bHZiajNjS01mQTltYWUwcW1HZEFr?= =?utf-8?B?c3dJUUFxWXZiRlFkUUN5c2pIR05HcnRZM2FFSEhSak5lL3ZhQ2ZmVHAvNjU1?= =?utf-8?B?cVZ6MlVaVUp0blFJVHZvUWZRRjJiN2lpZFp0L2p5MmE0NE53c3VnSE0xbXly?= =?utf-8?B?Rlp2elhFUTVodlB6Z1lnR282ajZwZG44b2lPOEJSK0xZYnByM0QwRWZvaThR?= =?utf-8?B?WmlNWURNQVVQdFFsU281WEIybkdXNkRPTUpSQWZXQ0FvNVZoT2E4OU80cWc0?= =?utf-8?B?Zk9XUEtETGZteSt3dFlCcUU0QVpFc3NuSW9vdTM0V3F2a0lUNWdoVGxldmYr?= =?utf-8?B?SGpqR2duNEhIMXdDNDg2a0tIVEJjMzAvRWxrL29GZ0Rpc1hWdG42QW5TSS9K?= =?utf-8?B?T0VzWnJmWXpXTVNKMDZud2EwaVlvYmJDK3VNR2szQllZdXdHVm9tZjkzNVM3?= =?utf-8?B?a3NUVEd1cWtIVjlIdEc5SjFueFpSdjlWWEpLa3lPSFVKZ0NEQlREMFRGMVJX?= =?utf-8?Q?E4UlBE6h7JOuYQPSMzTogDmfz?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6e6b281-d2d0-4a08-7d5c-08da7e85fe25 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Aug 2022 06:18:38.7841 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2oQWhLZsPX1ovnACEQH63Cy5dTHwB3E+q/55VOGiwbDFH8VhBzEkHfezWPke9ywjY7U/jW0/Zkxo/mSo1mV9sg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4495 X-Spam-Status: No, score=-3030.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Aug 2022 06:18:44 -0000 On 25.07.2022 15:10, Dmitry Selyutin via Binutils wrote: > --- /dev/null > +++ b/gas/testsuite/gas/ppc/setvl.d > @@ -0,0 +1,15 @@ > +#as: -mlibresoc > +#objdump: -dr -Mlibresoc > + > +.*: file format .* > + > + > +Disassembly of section \.text: > +0+ <\.text>: > +.*: (37 00 00 58|58 00 00 37) setvl. r0,r0,1,0,0,0 > +.*: (36 00 00 58|58 00 00 36) setvl r0,r0,1,0,0,0 > +.*: (36 00 e0 5b|5b e0 00 36) setvl r31,r0,1,0,0,0 > +.*: (36 00 1f 58|58 1f 00 36) setvl r0,r31,1,0,0,0 > +.*: (36 7e 00 58|58 00 7e 36) setvl r0,r0,64,0,0,0 > +.*: (76 00 00 58|58 00 00 76) setvl r0,r0,1,1,0,0 > +.*: (b6 00 00 58|58 00 00 b6) setvl r0,r0,1,0,1,0 Out of curiosity - was it intentional to omit a case with the last operand non-zero? > @@ -6769,6 +6789,9 @@ const struct powerpc_opcode powerpc_opcodes[] = { > {"rlmi", M(22,0), M_MASK, M601, PPCVLE, {RA, RS, RB, MBE, ME}}, > {"rlmi.", M(22,1), M_MASK, M601, PPCVLE, {RA, RS, RB, MBE, ME}}, > > +{"setvl", SVL(22,27,0), SVL_MASK, SVP64, PPCVLE, {RT, RA, SVi, vf, vs, ms}}, > +{"setvl.", SVL(22,27,1), SVL_MASK, SVP64, PPCVLE, {RT, RA, SVi, vf, vs, ms}}, > + > {"rotlw", MME(23,31,0), MMBME_MASK, PPCCOM, PPCVLE|EXT, {RA, RS, RB}}, > {"rlwnm", M(23,0), M_MASK, PPCCOM, PPCVLE, {RA, RS, RB, MBE, ME}}, > {"rlnm", M(23,0), M_MASK, PWRCOM, PPCVLE, {RA, RS, RB, MBE, ME}}, According to the web page SETVL has a number of pseudos. I guess you've omitted those for simplicity in the initial submission. I'd like to point out though that the web page isn't really crystal clear as to, in particular, the Rc field's applicability to every one of the pseudos. (There's also a typo or two which makes things a little ambiguous, but there it's reasonably clear what is actually meant.) Jan