From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailbox.box.xen0n.name (mail.xen0n.name [115.28.160.31]) by sourceware.org (Postfix) with ESMTPS id CEADB3856DDD for ; Tue, 2 Aug 2022 07:11:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CEADB3856DDD Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=xen0n.name Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xen0n.name DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xen0n.name; s=mail; t=1659424308; bh=IF5BMJg+8LFGvjsxhJJB7dRYZwdHPmrLfwOqPR0kNQ8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=MET4HP4xsvgAtV76BDEZ4GAluEelpu3mgtb/+4wV/gWKzs9xYXOdcVkhW6c6BDSzl M117Iw7tLMveSrFS5RzMfIamusYYCxfiKfV/dUe4FLaEVXWH51eo8ELqLDroy7FDtm 2J1YJdCHjbMtjS6Asm2XIKmroiGexj/Ks8X5VHqU= Received: from [100.100.57.219] (unknown [220.248.53.61]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailbox.box.xen0n.name (Postfix) with ESMTPSA id 256EE60103; Tue, 2 Aug 2022 15:11:48 +0800 (CST) Message-ID: Date: Tue, 2 Aug 2022 15:11:47 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:105.0) Gecko/20100101 Thunderbird/105.0a1 Subject: Re: [PATCH 1/2] opcodes/loongarch: Remove unused code To: liuzhensong , WANG Xuerui , binutils@sourceware.org Cc: Chenghua Xu , Xi Ruoyao , WANG Xuerui References: <20220719030345.1125329-1-i.swmail@xen0n.name> <014d24bd-7c1f-bb1d-2fca-152c9038a76b@xen0n.name> <84b313da-3783-9d2c-7518-86cf6ea7f7ea@loongson.cn> Content-Language: en-US From: WANG Xuerui In-Reply-To: <84b313da-3783-9d2c-7518-86cf6ea7f7ea@loongson.cn> X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Aug 2022 07:11:59 -0000 On 2022/8/2 15:02, liuzhensong wrote: > > > 在 2022/8/1 下午3:07, WANG Xuerui 写道: >> On 2022/7/19 11:03, WANG Xuerui wrote: >>> From: WANG Xuerui >>> >>> include/ChangeLog >>>     * opcode/loongarch.h (loongarch_parse_dis_options): Remove >>>     unused declarations. >>>     (loongarch_disassemble_one): Likewise. >>> >>> opcodes/ChangeLog >>>     * loongarch-dis.c (loongarch_parse_dis_options): Remove >>>     unused code. >>>     (my_print_address_func): Likewise. >>>     (loongarch_disassemble_one): Likewise. >>> >>> Signed-off-by: WANG Xuerui >>> --- >>>   include/ChangeLog          |  6 ++++++ >>>   include/opcode/loongarch.h |  5 ----- >>>   opcodes/ChangeLog          |  7 +++++++ >>>   opcodes/loongarch-dis.c    | 35 ----------------------------------- >>>   4 files changed, 13 insertions(+), 40 deletions(-) >> >> A gentle ping for this patchset. > > This patchsethas been verified that there is no problem but cannot be > directly patched. Do you mean I should rebase it by "cannot be directly patched"? Or is there any other places that I have missed (e.g. testsuite)?