From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 0582E388B3AF for ; Tue, 21 Feb 2023 12:53:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0582E388B3AF Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676983989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M9AvmRWIeK1ykVnNll6IKN9ihOSumxnmMrbQDvwnJcc=; b=YoQYb9+fG12lUgXDuS8/dnIJae8VaZXK+xHAOUF9GX9ft514mvymN8UMpjczYKRKtpv2rZ ydF0k7raCmu1n/iyA6WWGKUvC/4DPlgp47d+bQ+c7UF4qI+4oI7ouIrtFpfjJeeEpFtcve eDzjN/0V2IlDh7FymnDTqBt9VS0x3E4= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-149-kRF1_5WxN2CV-0JIDak0hA-1; Tue, 21 Feb 2023 07:53:08 -0500 X-MC-Unique: kRF1_5WxN2CV-0JIDak0hA-1 Received: by mail-wr1-f71.google.com with SMTP id y9-20020a056000168900b002c3d80ab568so675558wrd.18 for ; Tue, 21 Feb 2023 04:53:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:references:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=M9AvmRWIeK1ykVnNll6IKN9ihOSumxnmMrbQDvwnJcc=; b=VdovslJVx293QRAkzF+dnESqlMVIma06jq+0MNrlUZ4PfjRBTWbS21qmNlbkiGiXwA oeNzKQJpWokjuhyxT4p8RoXLF1TLhiXWxs+0jT8k2xma5t/0pNji1ovn9pQT809gf6OH QTjvucsZcg2EspsQvmv8vBznrTBwqX97y/gSm2s3qvI6/I2iw5TUbjWHT2wcyBTmhITT yPGut71YUcoxrPU1lXp+6n5yMIdfGLWnghXrht06lYXTbbOQyPpaF4OKqRm8wWDuge/N lP31PDOnHDzl3vMbPjnVa8u9lblb4cJR7O5DEk/novgSfrEeJSegiD6wxtIsvl4O3MVD BUaw== X-Gm-Message-State: AO0yUKVZgB69cxbVYh29EyHDyZstgClTYpgGKHJBgl7ho7pP24gBBRf3 J/QJsM1RkUHgtaGvhdn1yj1b/WnCy+dxAobukWSS5I4vgKq1yYjvY/JZeydWhBXDIHZUGdCYAcw 72pfQzESMjXUP5WNbBsCq8LM= X-Received: by 2002:a05:600c:a287:b0:3df:ea9a:21c9 with SMTP id hu7-20020a05600ca28700b003dfea9a21c9mr3996045wmb.27.1676983986967; Tue, 21 Feb 2023 04:53:06 -0800 (PST) X-Google-Smtp-Source: AK7set+re8Nlg+YGxnpLoT3empKRf4+KXecSuzwUcp6zX562XBEupfKY1iWu9Oi7jqcLKZfO5O8EmQ== X-Received: by 2002:a05:600c:a287:b0:3df:ea9a:21c9 with SMTP id hu7-20020a05600ca28700b003dfea9a21c9mr3996034wmb.27.1676983986656; Tue, 21 Feb 2023 04:53:06 -0800 (PST) Received: from [192.168.1.18] ([79.123.86.193]) by smtp.gmail.com with ESMTPSA id r5-20020a1c2b05000000b003ddf2865aeasm4759626wmr.41.2023.02.21.04.53.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Feb 2023 04:53:06 -0800 (PST) Message-ID: Date: Tue, 21 Feb 2023 12:53:05 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 To: binutils@emagii.com, binutils@sourceware.org References: <20230219194549.22554-1-binutils@emagii.com> <20230219194549.22554-2-binutils@emagii.com> From: Nick Clifton Subject: Re: [PATCH v4 1/5] CRC64 commands documentation In-Reply-To: <20230219194549.22554-2-binutils@emagii.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Ulf, > diff --git a/COPYING.CRC64 b/COPYING.CRC64 > new file mode 100755 > index 00000000000..618e1c63dae > --- /dev/null > +++ b/COPYING.CRC64 > @@ -0,0 +1,42 @@ > +The GNU linker contains CRC routines that are used to implement the > +CRC64 command in the output section. > + > +The CRC routines are extracted from LIBCRC available at > + > +They are used to > +* https://www.libcrc.org/ > +* https://github.com/lammertb/libcrc/tree/v2.0 Umm, why do you have the "They are used to" line here ? > +/* > + * Library: libcrc > + * File: src/crc64.c > + * Author: Lammert Bies > + * > + * This file is licensed under the MIT License as stated below > + * > + * Copyright (c) 2016 Lammert Bies > + * > + * Permission is hereby granted, free of charge, to any person obtaining a copy > + * of this software and associated documentation files (the "Software"), to deal > + * in the Software without restriction, including without limitation the rights > + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell > + * copies of the Software, and to permit persons to whom the Software is > + * furnished to do so, subject to the following conditions: > + * > + * The above copyright notice and this permission notice shall be included in all > + * copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE > + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, > + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE > + * SOFTWARE. > + * > + * Description > + * ----------- > + * The source file src/crc64.c contains the routines which are needed to > + * calculate a 64 bit CRC value of a sequence of bytes. > + */ Given that the library is not being incorporated as-is into the linker sources you should probably indicate the relocated location of the src/crc64.c code. > diff --git a/ld/ld.texi b/ld/ld.texi > index 7802f0661b0..2042fadb33e 100644 > +The CRC32 command defines some global symbols. > + > +* @code{___CRC32___} address of the CRC32 checksum > + > +* @code{___CRC32_START___} first address in the checked area. > + > +* @code{___CRC32_END___} first address past the checked area. I probably should have mentioned this in my comments for the [v4 0/5] email, but are these symbol definitions really necessary ? Given that the CRC functions have to be invoked from the linker script with symbol names in their parameters, why define extra symbols ? Cheers Nick