From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id 071C23858D28 for ; Tue, 27 Jun 2023 13:27:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 071C23858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-1b7f92b764dso12803745ad.2 for ; Tue, 27 Jun 2023 06:27:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687872448; x=1690464448; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dzkI3Lz7r1LlNANyI6Knp+cZiT8Bh0hDA9o+HNpok7g=; b=mHufQ6avkR2hDBGmYvWX4dN2i570xdtrxiCMPQFga5DtLXcNAMm2FcW+l0Ocm3VNzL SaCxNeseJVw92EGik23acecWF/31SHoPIfTimYlY6u6MZNXUiZBLVDy2SoQqTDdgNr1j EdiVKZVNqro13j2rcMWqKkBNplUdVCvMQaWtg3OiDqxABE0m0+5TpxWK6naqaeCtr1Hj PZF7EpQ32PluNNKjTg6l/e4eEq3wrqVXQanYf4Fkg4zgHUenPE3QxU1GNUDmn4hP6B7t Kti+MTX+25sct3COeqexbyp9MrcAGyfTndkFZFUFmMJsB1MK+E3xa/o6nhjNNBHArDXu KbPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687872448; x=1690464448; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dzkI3Lz7r1LlNANyI6Knp+cZiT8Bh0hDA9o+HNpok7g=; b=ViJvmx2cfgIanJH0hEw8mXSU3QjLkzSE1HVuTSgrE+Dpe0950qbwCVfT4moVKqNLrh AQdDIREouRcwPdy54039fwSZEL5brivN/ACAhEMjMgA+Sl03YRjHAz1RkCsRzCgirHnF MGVmyz/uD3SqEsqJT6KZR5ZMNIyeRN1RGsCIlS9EUAytS7Oxz0zq0anmkbJQ5rPVbnYy r8J9Sqf9mxqudTohNZ5HNCOXGExUwneWFgUbPFbM1hEzV4wwx5/Nog6qKQpKk7e0WEdH 5NZ8wHYJugLMX8MYfEszq72yAO/rQq7oLYaPzGd8XF3XVs4trIEb33rHqconiLpiQp3F CVtA== X-Gm-Message-State: AC+VfDzgxggYN8DZ8dQFSTqivefeOMQOjCXmXd/WYXoADcKiE4rZC3sY mL8UbDeDzf3MQ7ya0KWOLa0= X-Google-Smtp-Source: ACHHUZ7zR+zYWtAsfJ/wVBntFh8yriKjTq98fNwKSrE3y059Df5OBVTjg1RI2yjo+VCwWggz+15E/w== X-Received: by 2002:a17:902:aa09:b0:1b7:f649:f49a with SMTP id be9-20020a170902aa0900b001b7f649f49amr4394584plb.3.1687872447563; Tue, 27 Jun 2023 06:27:27 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id q9-20020a17090311c900b001ae59169f05sm6007350plh.182.2023.06.27.06.27.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jun 2023 06:27:26 -0700 (PDT) Message-ID: Date: Tue, 27 Jun 2023 07:27:25 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [RFC PATCH v1] RISC-V: Support Zicond extension Content-Language: en-US To: Palmer Dabbelt , binutils@sourceware.org Cc: philipp.tomsich@vrull.eu, kito.cheng@sifive.com, nelson@rivosinc.com, christoph.muellner@vrull.eu References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/20/23 22:38, Palmer Dabbelt wrote: > On Tue, 20 Jun 2023 21:25:12 PDT (-0700), binutils@sourceware.org wrote: >> >> >> On 6/19/23 08:21, Philipp Tomsich wrote: >>> Given that the 2.41 milestone is approaching and Zicond has passed the >>> FREEZE milestone (and is even out of public review already), I would >>> like to move this forward. >>> Is this OK for trunk?  Should I resubmit with an updated commit message? >> Given they were acked  with "this is fine to go forward with the spec >> freezes", I think they can go forward now.  I think you just need to >> fixup the ChangeLog a bit since it references >> INSN_CLASS_XVENTANACONDOPS ;-) > > Can whomever (IIRC Philipp?) sent the first version just send a v2 with > the various bits fixed up (ie, no RFC, no "don't merge this" header, and > the review comments addressed)?  That way there's a chance folks will > actually look at it. Seems a bit silly to keep deferring this. I went ahead and fixed up the ChangeLog entry to reference INSN_CLASS_ZICOND rather than INSN_CLASS_XVENTANACONDOPS as well as the spec URL and version number and pushed the result. Jeff