Re: [PATCH] LoongArch: Add support for b ".L1" and beq "$t0", "$t1", ".L1"

[Xi Ruoyao <xry111@xry111.site>]

On Wed, 2023-12-06 at 14:07 +0800, mengqinggang wrote:
> This is a question discovered during the porting of RSEQ system call, 
> and other architectures support this feature.

The other architectures support quoted symbols, but not quoted register
names.

On x86_64 if we write

   movq $1, "%rax"

It will be explained as "saving 1 into a symbol named %rax", instead of
"loading 1 into the register rax".  I. e. once it's quoted, it will be
treated as a symbol name instead of register name.

> 在 2023/12/6 上午11:28, WANG Xuerui 写道:
> > Hi,
> > 
> > On 12/6/23 11:17, mengqinggang wrote:
> > > Support register and symbol names enclosed in double quotation
> > > marks.
> > > ---
> > >   .../gas/loongarch/double_quotation_marks.d    | 11 +++++
> > >   .../gas/loongarch/double_quotation_marks.s    |  2 +
> > >   opcodes/loongarch-coder.c                     | 41
> > > ++++++++++++++++---
> > >   3 files changed, 48 insertions(+), 6 deletions(-)
> > >   create mode 100644 
> > > gas/testsuite/gas/loongarch/double_quotation_marks.d
> > >   create mode 100644 
> > > gas/testsuite/gas/loongarch/double_quotation_marks.s
> > > 
> > > [snip]
> > > 
> > > diff --git a/gas/testsuite/gas/loongarch/double_quotation_marks.s 
> > > b/gas/testsuite/gas/loongarch/double_quotation_marks.s
> > > new file mode 100644
> > > index 00000000000..bb8acb99a40
> > > --- /dev/null
> > > +++ b/gas/testsuite/gas/loongarch/double_quotation_marks.s
> > > @@ -0,0 +1,2 @@
> > > +# Before only support beq $t0, $t1, .L1
> > > +beq "$t0", "$t1", ".L1"
> > May you provide some explanation as to this feature's intended use 
> > case? Because it seems pointless otherwise without some kind of 
> > scenario that's both valuable to support and impossible to do so 
> > without this feature...
> 

-- 
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University