From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id 8C6BC3858CDA for ; Wed, 6 Dec 2023 06:16:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8C6BC3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8C6BC3858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=89.208.246.23 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701843371; cv=none; b=lh5xIaGjBVdzjOsZZipRXteGkQ1Q7EapzGyATXigiZHhTzyskroluW70wBK0luRHKWOCE8jKwwln6/f3Qafcy4pSr3VwIfAiYNyCRuqbGZpyx4xu6VO6u/os8GYUw4Ecry1dEUotZzalonnd4BPN6vZtCgQ803C8glo8MDesczk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701843371; c=relaxed/simple; bh=lTURF5HpxbEApxcEkkLJsrkW6fguHfZi0TpFIKBUNrE=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=OVSHsN4V/DRQx4OZtAuabJBn3pYO/oplNRkm5Ha3zVGJtx7m/+sTCTAU3rtfXufGxtsn1TFjkBP4DNVakPh0H/8/JKgCwMbC4+ITWTF4pA0GLmF9/fLCKf0SHHuKr9ZAK+YaAvPbT/qnyWFnm7p3M8YKkO9fcRImEysDrIWXN88= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1701843369; bh=lTURF5HpxbEApxcEkkLJsrkW6fguHfZi0TpFIKBUNrE=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=WEpTGXZaP50CE6W5u0EZI+mMK7Ku4ywZGIU24QeB/X0D/cfHMHdD1xbHo7Nex0L0c vtpH7Ex/N8W2XVpVdqxIaE5/p2LGvEyYJLmyLJfejb6nPeOWDbBe7GLYA2TVti+NaA E7xEEcjZUwANgiMOMuCfs3zP3Zy+u4CcytO9RScc= Received: from [127.0.0.1] (unknown [IPv6:2001:470:683e::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 8E4F966ECF; Wed, 6 Dec 2023 01:16:07 -0500 (EST) Message-ID: Subject: Re: [PATCH] LoongArch: Add support for b ".L1" and beq "$t0", "$t1", ".L1" From: Xi Ruoyao To: mengqinggang , WANG Xuerui , binutils@sourceware.org Cc: xuchenghua@loongson.cn, chenglulu@loongson.cn, liuzhensong@loongson.cn, cailulu@loongson.cn, maskray@google.com Date: Wed, 06 Dec 2023 14:16:05 +0800 In-Reply-To: References: <20231206031724.2330403-1-mengqinggang@loongson.cn> Autocrypt: addr=xry111@xry111.site; prefer-encrypt=mutual; keydata=mDMEYnkdPhYJKwYBBAHaRw8BAQdAsY+HvJs3EVKpwIu2gN89cQT/pnrbQtlvd6Yfq7egugi0HlhpIFJ1b3lhbyA8eHJ5MTExQHhyeTExMS5zaXRlPoiTBBMWCgA7FiEEkdD1djAfkk197dzorKrSDhnnEOMFAmJ5HT4CGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQrKrSDhnnEOPHFgD8D9vUToTd1MF5bng9uPJq5y3DfpcxDp+LD3joA3U2TmwA/jZtN9xLH7CGDHeClKZK/ZYELotWfJsqRcthOIGjsdAPuDgEYnkdPhIKKwYBBAGXVQEFAQEHQG+HnNiPZseiBkzYBHwq/nN638o0NPwgYwH70wlKMZhRAwEIB4h4BBgWCgAgFiEEkdD1djAfkk197dzorKrSDhnnEOMFAmJ5HT4CGwwACgkQrKrSDhnnEOPjXgD/euD64cxwqDIqckUaisT3VCst11RcnO5iRHm6meNIwj0BALLmWplyi7beKrOlqKfuZtCLbiAPywGfCNg8LOTt4iMD Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.2 MIME-Version: 1.0 X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 2023-12-06 at 14:07 +0800, mengqinggang wrote: > This is a question discovered during the porting of RSEQ system call,=20 > and other architectures support this feature. The other architectures support quoted symbols, but not quoted register names. On x86_64 if we write movq $1, "%rax" It will be explained as "saving 1 into a symbol named %rax", instead of "loading 1 into the register rax". I. e. once it's quoted, it will be treated as a symbol name instead of register name. > =E5=9C=A8 2023/12/6 =E4=B8=8A=E5=8D=8811:28, WANG Xuerui =E5=86=99=E9=81= =93: > > Hi, > >=20 > > On 12/6/23 11:17, mengqinggang wrote: > > > Support register and symbol names enclosed in double quotation > > > marks. > > > --- > > > =C2=A0 .../gas/loongarch/double_quotation_marks.d=C2=A0=C2=A0=C2=A0 |= 11 +++++ > > > =C2=A0 .../gas/loongarch/double_quotation_marks.s=C2=A0=C2=A0=C2=A0 |= =C2=A0 2 + > > > =C2=A0 opcodes/loongarch-coder.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 | 41 > > > ++++++++++++++++--- > > > =C2=A0 3 files changed, 48 insertions(+), 6 deletions(-) > > > =C2=A0 create mode 100644=20 > > > gas/testsuite/gas/loongarch/double_quotation_marks.d > > > =C2=A0 create mode 100644=20 > > > gas/testsuite/gas/loongarch/double_quotation_marks.s > > >=20 > > > [snip] > > >=20 > > > diff --git a/gas/testsuite/gas/loongarch/double_quotation_marks.s=20 > > > b/gas/testsuite/gas/loongarch/double_quotation_marks.s > > > new file mode 100644 > > > index 00000000000..bb8acb99a40 > > > --- /dev/null > > > +++ b/gas/testsuite/gas/loongarch/double_quotation_marks.s > > > @@ -0,0 +1,2 @@ > > > +# Before only support beq $t0, $t1, .L1 > > > +beq "$t0", "$t1", ".L1" > > May you provide some explanation as to this feature's intended use=20 > > case? Because it seems pointless otherwise without some kind of=20 > > scenario that's both valuable to support and impossible to do so=20 > > without this feature... >=20 --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University