From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 135AE395560A for ; Wed, 7 Jul 2021 14:40:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 135AE395560A Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-217-D61bA-MaOim77_XFn1tCFA-1; Wed, 07 Jul 2021 10:40:37 -0400 X-MC-Unique: D61bA-MaOim77_XFn1tCFA-1 Received: by mail-wr1-f69.google.com with SMTP id h15-20020adffd4f0000b0290137e68ed637so835380wrs.22 for ; Wed, 07 Jul 2021 07:40:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VBwuFKiYuyicNNIHRJ5wJOJFjVbadGU5NS06eHTYIrk=; b=ZvqOEswIn8/t/ToTaa1COs+ohOSSPdTvsJkyNjpOkTgphu+uicg4yHbYgVQSjS5kVQ rCpdk7cPvaV6VaA7+TPvAbvDRoE4PFYCeYeCL+HGwBdlJykE4BD1HzUm+zE5XYp/VClL DoR17ZaBCgtkmisQrGE+W+G1wf4763piAppHY+bqYaqQ1UVLXBYWRPrfZQiiWhWQ+Lk2 WsHFummo8kDRReDKotSdD97y1GlKXXOUCkWrTB/+7U8GXhDpKiQozjbKiSidj6nawgKg iATwu4BaEdzTCiyd7Anyi4GDxJefaHKSewkD+l68nb8fgJszhzmV3/e8nRgaYF2MWBeA ejfg== X-Gm-Message-State: AOAM530SEvOP8Zj26KqM+V5a4mO63YkIPG67CvXqrAxbhHFm7dRn73AX U6/43mTfqf+0emKfH6Yh0x1cN3TId9HRrJnMZUJ9IzKPI/yE/4mx2imvPbwCEo4W1LH7dlH3JeW TSmNGcBPY1WgPX6L+DAsbdywPOUzumazjxP3bUIu9JhZreThV7OZp+Z9dav1OSEfdsQ== X-Received: by 2002:a05:600c:4ba9:: with SMTP id e41mr7160595wmp.72.1625668836488; Wed, 07 Jul 2021 07:40:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzffWIEgQu3ySRTWQdBbFko0U+bkAdlAS4puJQjrOSYuj//3H5k+lOQKdMw2BfgaG6cXy8FAg== X-Received: by 2002:a05:600c:4ba9:: with SMTP id e41mr7160579wmp.72.1625668836304; Wed, 07 Jul 2021 07:40:36 -0700 (PDT) Received: from [192.168.1.5] ([80.168.238.114]) by smtp.gmail.com with ESMTPSA id a10sm934294wrm.12.2021.07.07.07.40.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jul 2021 07:40:35 -0700 (PDT) Subject: Re: [PATCH] ld: Check archive only for archive member To: "H.J. Lu" , binutils@sourceware.org References: <20210706133152.2201260-1-hjl.tools@gmail.com> From: Nick Clifton Message-ID: Date: Wed, 7 Jul 2021 15:40:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210706133152.2201260-1-hjl.tools@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jul 2021 14:40:40 -0000 Hi H.J. > bfd/ > > PR ld/18028 > * plugin.c (bfd_plugin_close_file_descriptor): Check archive > only of abfd != NULL. > (try_claim): Pass NULL to bfd_plugin_close_file_descriptor if > it isn't an archive member. > > ld/ > > PR ld/18028 > * plugin.c (plugin_input_file): Add comments for abfd and ibfd. > (plugin_object_p): Set input->ibfd to NULL if it isn't an > archive member. Approved - please apply to the branch and mainline. Cheers Nick