From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 739733858C83 for ; Wed, 2 Nov 2022 14:12:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 739733858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667398352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jD/qbF9gOm1a18DTSfjA8uZOMBra4xfwQwlTsgNrkNg=; b=IdwO7DzXgqZE/BKeUdztS3A9yxD0CBgz5NvWqrstAWYgID8lkZCg2DV3BNxYYd7eUZStpc PCWSBMFiL4IrDpL6//kIAlmiVw7T0UNrO/uJ0k4pICnknDbMuU50EQgD9fhiPOwa4F/qim 0kfUNwyJKm+cMuJuNkn98CbPGEpInrg= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-278-5cCu7_6HP_aEsYcvvDHnJg-1; Wed, 02 Nov 2022 10:12:31 -0400 X-MC-Unique: 5cCu7_6HP_aEsYcvvDHnJg-1 Received: by mail-qt1-f200.google.com with SMTP id g3-20020ac84b63000000b003a529c62a92so5629905qts.23 for ; Wed, 02 Nov 2022 07:12:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jD/qbF9gOm1a18DTSfjA8uZOMBra4xfwQwlTsgNrkNg=; b=2qWEp41TIzv8ddiSiqFU601YhiKNscTV9JZOPhxvFBCJ7OOUCYaZGe2FP3dMbzoTtB U+tYQYGnHRGwDuAu47u/enAtO8fX0DUoeEBhvfcE+PLTL1sjwo+d0jG1v+P5u6a2omRB VdTjkRuNLWQZRi1KNzqVLZ2488BYuukLFAcx4WwocpCYQLciEHJKPseaVVv8c23YG5bL G/qCCfFbiolzQTpUlX8Ge1ozI96r7zZs2g+gKdqDQ6iBAoPYznM1oc1sUr/cuTfKY61+ p2Qms/SWr07hqbYhE6Hgqy2AJ0//7W6D84q476dpVjlhPep9NnzFJt0athG1OBmHIULh 550Q== X-Gm-Message-State: ACrzQf2VEmPdQmARNQqm0TJi4H+lp+7HmLRvQE6Pt0al3z7IHc5AUlxs a5Y3fhsCjacIlCanT+sdwkgxPci0nA9DCUiORpu0Na09bu3TUSc4BGdd24+T+ftZR6cjgj3Q5lZ suhJZZz/HrcI7hVEr9A== X-Received: by 2002:a05:6214:2342:b0:473:e142:f758 with SMTP id hu2-20020a056214234200b00473e142f758mr21468053qvb.83.1667398350135; Wed, 02 Nov 2022 07:12:30 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4ihKAK2pkv11AJDWLMPKFFvwkXq4VVll43oZrIT6ooqud7I7H5/J/nemZCuiv0YSu9HqysLg== X-Received: by 2002:a05:6214:2342:b0:473:e142:f758 with SMTP id hu2-20020a056214234200b00473e142f758mr21468027qvb.83.1667398349909; Wed, 02 Nov 2022 07:12:29 -0700 (PDT) Received: from [192.168.1.18] (adsl-164-85.freeuk.com. [80.168.164.85]) by smtp.gmail.com with ESMTPSA id f11-20020a05620a280b00b006f8665f483fsm8541884qkp.85.2022.11.02.07.12.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 07:12:29 -0700 (PDT) Message-ID: Date: Wed, 2 Nov 2022 14:12:28 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH] ld: Add module information substream to PDB files To: Mark Harmstone , binutils@sourceware.org References: <20221102020752.24441-1-mark@harmstone.com> From: Nick Clifton In-Reply-To: <20221102020752.24441-1-mark@harmstone.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Mark, > + *data = xmalloc (*size); > + > + ptr = *data; > + > + for (bfd *in = coff_data (abfd)->link_info->input_bfds; in; > + in = in->link.next) > + { > + struct module_info *mod = (struct module_info *) ptr; > + uint16_t stream_num; > + bfd *stream; > + uint32_t sym_byte_size; > + uint8_t *start = ptr; > + > + stream = add_stream (pdb, NULL, &stream_num); > + > + if (!stream) > + { > + free (data); > + return false; > + } This fails to compile with: inlined from 'create_pdb_file' at /work/sources/binutils/upstream/current/ld/pdb.c:1097:8: /work/sources/binutils/upstream/current/ld/pdb.c:481:11: error: 'free' called on unallocated object 'mod_info' [-Werror=free-nonheap-object] 481 | free (data); | ^~~~~~~~~~~ /work/sources/binutils/upstream/current/ld/pdb.c: In function 'create_pdb_file': /work/sources/binutils/upstream/current/ld/pdb.c:604:9: note: declared here 604 | void *mod_info; Possibly you meant "free (*data)" ? Cheers Nick