From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 79B013858D20 for ; Tue, 20 Feb 2024 23:04:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 79B013858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 79B013858D20 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1708470259; cv=pass; b=fnTE7efPvfGulQXss0h9g+/iMXLdi7RQ6ce7356Qwk/l9MVZ4nbiqDJlQZBy7vABPOiYNBvxRsPPq0ur1aekY5RLRw8B2jI3BP9UIlTvFUNVF8sAYFr+gXT9SepS+i5sHFI+4Jxgizb4Tzx56kvfidP8yU6vgZ4AGlnbt9TzC6Y= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1708470259; c=relaxed/simple; bh=z1gddfvl+08Tt028LruAbFO1IOReaR0PQmEBNXtzvjE=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=H8XbwmJB4uLHgQilmE/yS42q3T4qbDXSEcvXkKEXFu2UUIpv0fhk/SpBF8x+/Q/rQXsohFLhlxx2Zw66Fo+1HwRUKiR9i9qrv50mBPzqYkyCu1kPd/W+TNPODBBZDN/VxkWp4XbWEM/Zpnu2jXgmrpwfOb9WcdBkEBzx0rssQlM= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41KL5qha001499; Tue, 20 Feb 2024 23:04:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=PhR3HXt5fVmGQn5tF7FJhBt88hdl0kaw2/AvcYFYazo=; b=kaM51KM3Q5ys2NnIm0UYHrsWexchw7aKeANqLfgBLXfdxRamaPyLhclelPckkL9BuV8B XdVYL+LI0XN/lGq1iPSSbtDEyWDoE+ci+cloP4dtvjRrZKrcXSxijPUolhb8fXYpEfEy wPv6aIBNvmCC+gm11ybutf4adKUW/LoJGMpk00lW2TFzHSJyCZQwd5uldzWh+dRp/hEe OrhVc7gFKfZtw22HqGabN2hSZ+FH3EJNMI3YZkHS1sTMbwBerdqWTDHBGLANWh18cqzb gJLHuNl0KCLXyAxf+4zq+GBmW3U1xpmVFeCITZWJp1ZtKyD0vPh2an6FhqKTGWxf/6uo 5g== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3wamdu08v5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 Feb 2024 23:04:15 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 41KLduum006741; Tue, 20 Feb 2024 23:04:14 GMT Received: from nam02-bn1-obe.outbound.protection.outlook.com (mail-bn1nam02lp2040.outbound.protection.outlook.com [104.47.51.40]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3wak88abjh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 Feb 2024 23:04:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HE/eTC8sEJOtxZU40qKmm2QzDJZJ/yS/tDhdnjGOe1X1Ymck2gYEEOK06LNLBcmu0z+gDXVnyMZBTMOtLna4oL2KiHpJl00TWxxOUQJqHd2Je7dS21igCa5xXbY1qfbNJCg4P0KMTax+/0Nx++0DPsWmyuHxMOAo1KKBda0MH44gptIrwSqCWnxEo3wavU0WhQ+GOfgu5Ov7o7XeUTAtr0iVmlfUg4fuot1tSiOdWFETeG4GiJQ2tYUI2Ci7hiJlQ3GHQQ+dxXeHfU/1g2vcwwwQgmpeyTdn9Z+64L5t/VopTmr0IEJLyHMEIMN1ym6R+HmVVsXWdxroe2FWBJfW7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PhR3HXt5fVmGQn5tF7FJhBt88hdl0kaw2/AvcYFYazo=; b=FJYivC+SVsxifLP8LbdCE2QSMmolnxWhN6UtZybiSEzZiiUQl9FT2VA7ImQ6rG3MFdwWE60wBtt751BD6D2i8ZXv3aRlFkzIa1fQEDkUeL2iaQC9S2GCpBv3qlgNAe3dPNQ0ttq5CQeoyMu7GfQWqToydPoM4JeXigaN+42bGkcl6xz7HKuo7wJlah+6EqDRONHRunFOw3lmF/qxe5D52YEGAbBa0HpO5Ui5N4Suzb9RuAyTE6ZO5zG/Neh0ZAAt9/0RHCsfaziUQaAMr9ADE895hbbuLJOdI+SZ0VXVRIzNtMTCEOAzp4uClsJPWRf9X3fjZRGvdAKvrcZhbm9lzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PhR3HXt5fVmGQn5tF7FJhBt88hdl0kaw2/AvcYFYazo=; b=a/rAnBXm0v8HDv/HfSswO/XAh6OaT+u6gPWC9yxi9JI6xNGkn5ndD6PS0Yr4tfsFf4mRhvHg64UXbCCUg0GuvWH24MDa7boAvqDwEUWoyty5zkzxJerE1KTzY7oDyKou7X8de5ObFxOs5gmVhmTeN4i5k3WMadmKiQrXsWgcPVA= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by PH0PR10MB4437.namprd10.prod.outlook.com (2603:10b6:510:3a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.39; Tue, 20 Feb 2024 23:04:13 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::a450:c423:d1fb:3f86]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::a450:c423:d1fb:3f86%5]) with mapi id 15.20.7292.036; Tue, 20 Feb 2024 23:04:12 +0000 Message-ID: Date: Tue, 20 Feb 2024 15:04:11 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86: adjust which Dwarf2 register numbers to use Content-Language: en-US To: Jan Beulich Cc: "H.J. Lu" , Binutils References: <262f296e-673b-47f0-a764-276939161d64@suse.com> <15c6acc7-21f8-44bb-bf0d-97392f2fcd37@oracle.com> From: Indu Bhagat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR04CA0243.namprd04.prod.outlook.com (2603:10b6:303:88::8) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|PH0PR10MB4437:EE_ X-MS-Office365-Filtering-Correlation-Id: e96b8184-1ca6-47ee-c8af-08dc326840df X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m4db7vAPt2Cl4jACM31E0To+5YrOme/vJmbGPs5uFc3M+FltgMVRR4vVBglUrhC6xoDiQ1y6Go+/NW557IfkfgbwffwVJSAY7kYzDVatEAtOM5lTSda5ePNAwEOonGv0ZG/s39OJHnXZc49VUNWVVMkLSPPGPfoh32b6QwN2qf+s95V68O9iQMPsa30TUY4R3eyj7FF0gyBQShh3J9rOvIcXsbLJkgnRFbKdTNpVZpoh9CW2DBuDHjHpVE9Xq3vax2ja+83xyopF0lJOU4H999oMyKN6vVTUmmyzF3P0vcHEA/TyihPHAlml9+37s7Zs+RgqtOp0L1aATwdVcwsGUKOAHM6s7sWoWiKu6wKlPRaML3Er9QxtUkQ53799YpilrHaF79x7rwnoNBluVykm+EO3x2nWECRBKTU4besZKVIOI1i4o8oa0z291ZfwqnrDpqFOhYvmlxkJabH6GUqhmqXWzownjS1C1GcL2plYcmaEOyQsEP8xBr8raJ6/9j7EJEsxJlWINXIK6M0Aj1E336f2xtpFxg+JY9mdTMoeL6E= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZmdkSHhOUXk3UVlHWGJXNDVFNXhnM1ZWK0h0ejF5dWFuTU1keUduOGZTdloy?= =?utf-8?B?ekU5UVFieXo3bUphb1cxMnpENFhhcUFWVk0vLzl1TG9Vdzh6cHNaZitaZkhZ?= =?utf-8?B?ejBCMlgzdjVsVDRtOStEUWxWWFc4TzVuTlZoQ1dOWXpwRlFhWXNMZ1pUN20x?= =?utf-8?B?QmxrSFpqblYyZmJxR0prSzZCNHhqb2IvbmpMQXhMc3htVXBIdk52WnlLczE0?= =?utf-8?B?dlVtWVRYWkY2M2llQzdMYndPSWJ3UXhHRWJUS05ycVA5RjJ0MWRlL0xEYy91?= =?utf-8?B?QkJUTCtCTVhQTkFXQ0tmRyt3aFlLUFR6SDhueG1SanNmdHNPUjZzV2ZpYkNL?= =?utf-8?B?WEdWTTBkQklieFZCNnBVY3ZnbFBQcEVwZ0cwRGlzOGNEbHhJQ3BUUmdxV1VV?= =?utf-8?B?Y012Q21PWitnUXQ2R1pFNXlrSkNHQkFsVTh4a1V0NGVDOWd2TnNOVlVMaEM5?= =?utf-8?B?d0hzSkZzL2t5dGZJcWduZThxUWltV3M5YkxFQnIxUzBSM0h6cU1PeDZjeE5B?= =?utf-8?B?NC93UkNTMGNNNzIzRHRMcEdsMFh0aE1NWFdvaHNZa2E5ZWx2M2wxYmlIcUhq?= =?utf-8?B?VHQ4NUJPVzh5MzBRL0hyd0s5bWFTUncxSWFtOVpOMzh1VE5YckJZN1pSK1Q2?= =?utf-8?B?aXJtQWdpSmlOZ0prR2tWOHVJbUUzMStaeldBK2dJNHdQc3hiQ0NhZGFxQk40?= =?utf-8?B?SWhSYTNaeWJ0WnJ2VHorMi90eStWV0xOdlV1WUU4TDRTL0oyeHQ5ZkFVRG1n?= =?utf-8?B?NlRhSXVKdVlZeXg4bWx6YW1ta0YyeE5ta1VNaG1sZlk4cDl6eGg3RTFibHNZ?= =?utf-8?B?dGVLMEdNMjY5Sm9UVytFRUlkaVAvYkRZM0VqWFNQV0F4S0ErVStEUHVFOVF0?= =?utf-8?B?SFVXNDRNa1lyd29uUEhxbUtLbGRUZ1N0Q3FEcTZGM0RHcU9wd1p3elI1NGNN?= =?utf-8?B?RmZxaU9FdTZORTRhVHVnQzVNcUkvOGh4Vk9zRDZFRjFLT0JsOXRFc2I1bzJu?= =?utf-8?B?K1dVOFBxM2lIWVZoWXVodkI3Tng1Ujg0bWFEeGNoOUo4dWU4bnRJakJ2UllG?= =?utf-8?B?eDJvdVh1cEhUNDhiNlBidkR4YTNPSU9DTmFrQjUzUTgyUDRsREFMd3c1Y29S?= =?utf-8?B?NC8wVTVwZisvYzE4UHNzR09US3J0YWZONnJGTCsrNkFtaFI5aG1MWDJRMkY0?= =?utf-8?B?Y3dKaHhjRTc0VzR0RW1tK0pEQVlWcWF5TTVUVXNhMlRoWkR4WmdtdVNQS2Rs?= =?utf-8?B?NXNXRFF2d1RMbk1Dd0tiT3V4aHFZVFRteVh5RnB1a2RGM0dQZmcvbjRaWU9j?= =?utf-8?B?bVl4b3FtcHVvcC9tSmFwRExNQjlidzZHVUVQajRJUU9zZjR0UDRZT0t4eDJv?= =?utf-8?B?TG9aa25hbzBvRGdhTElFLzk2MWw3cUFLVDJUSFpkcktaOHNDYThIb3F6RnlB?= =?utf-8?B?REg3L1lNamNDWXpCdmZ1NDZ6eE14MGk3RFNjNDlBdzBHOUNRamhHS1k0Q2pT?= =?utf-8?B?R0J3S2tlUEQxTStseFpucG9DcUtKNlgyN3ZZaFh2MjFHSFJKQXNHdmNGUlRo?= =?utf-8?B?ZjlRaWxuUS9rK0xIK2hqaFFrVW5jQUQ2cVJJd2FFcW81OFVycy9YTTVKaEhP?= =?utf-8?B?V3RnVkZMWGRFL0xaM1hncTBtOFlQaGZUT28vRjlkZnBsU3M1Sm4vN3pPYlI0?= =?utf-8?B?YnRqT2syTVZsOEY4WGdVczhPeUhhK3lOU2wweHBZRXJGQUN1dG0wRngyN3Vo?= =?utf-8?B?M09qQ3RialE0UEp3VVB3NDNoU0l3bTh6UVhzSDlnS1g4aWhvOUNrVlp6aEYz?= =?utf-8?B?aXd4UHhHcFYrNXFzQ3hOTm9UT25MRWJIYXB0cVdwbkI3SENwa2dRd28wQnNW?= =?utf-8?B?ZWtSQWdvRGR1RGF2YUMvQ2RHQ21mL0xMZjl4T0NzQmNZOW1DT0xwYzR0OUdZ?= =?utf-8?B?QU5pTkZONndyZXo1UElNVWhpaDkyaExyYjgxT1BNS3FqZEExUzk0NTRFK1VD?= =?utf-8?B?b3YwSWxoRFUwb0haUk9IcEdpd2I2WGFjR3hraU1SdWMvTS8rYm9BdldQV0J0?= =?utf-8?B?Mkd4QjFkcnBEK2dFanBhTkIxaUZsMzJ0YTJoR2N0OUd4dVVrcm9QVWwzRGhV?= =?utf-8?B?NmNOSVE0ZDRNa1RNNURTN3MySHNqRWlhWkZFWDZZOHF2blpNUE15WEdLSUQw?= =?utf-8?Q?pqgFcBnTctl1bzRU6/MDMjI=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: TiShmQv3QfIUZMHuLqk0ZXiJOgC5f/sq73zdec7VBY2OXWUFREojsbp7SY4L9ROf0yTWKAPPaQrS6zgzM0AIrfsV2ZOo5oJCjBdiJBomhD2PBKuwOC1jo80odIzI31CdhF+73G6MfY9cgcW/S7ZUtIlyJRlHYf76bdzEF6CHArHk9KAduX1bjd34XeBeD38FGqwFvEXoKtUTLOAbU/xNb4GxB3QmH144Y9XdGYf3QmLsb8kHZ4FodyPsIXemIa0xmJTIrDxRoQIF1+Mtt9nJvsqgIpx9t08W+rPu6Qbzk+2YaSC8vDzqix9t3g7gLVcCD8OQqIcTpfREYk7mL8SFZ90NR8jLneAluPk9nRojErlakznYsOb3ISVC6kGF/wLLRqLkJsN++tVaIkGzobn86BKF/vWXlFBkVHScLcAmfHFGF8ebAfTP6igAqOB73/M53Wf3exyqkLdnJB176HXUbWd5a6afAkFXnlOferETXsYQLvmn/0NjXgyj5tLykUN11muW80LRwJS6a8Os5u23fTks7RmYRtK4s54lfDrKvssS0IwPQBuyDNJOMmn6yFFfDFPJZpQWhpDpUv0m8xmsHilgz31B4we9RV5FSH/Wonw= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e96b8184-1ca6-47ee-c8af-08dc326840df X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 23:04:12.7170 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HSoH0w8FssK0XlWeJ5+prqso/yRD+YbUfkCVjfR4NeKpa3WLlBEWDAuVTSKyGF5v99aCvi0vKAOm488xET/K+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4437 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-20_06,2024-02-20_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402200165 X-Proofpoint-GUID: S8j2aB045z3EDoGX_4kKF9XDjpfdpFl_ X-Proofpoint-ORIG-GUID: S8j2aB045z3EDoGX_4kKF9XDjpfdpFl_ X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/15/24 23:26, Jan Beulich wrote: > On 15.02.2024 23:22, Indu Bhagat wrote: >> On 2/9/24 00:11, Jan Beulich wrote: >>> Consumers can't know which execution mode is in effect for a certain >>> piece of code; they can only go from object file properties. Hence which >>> register numbers to encode ought to depend solely on object file type. >>> >>> --- a/gas/config/tc-i386.c >>> +++ b/gas/config/tc-i386.c >>> @@ -5409,7 +5409,7 @@ ginsn_dw2_regnum (const reg_entry *ireg) >>> if (ireg->reg_num == RegIP || ireg->reg_num == RegIZ) >>> return GINSN_DW2_REGNUM_RSI_DUMMY; >>> >>> - dwarf_reg = ireg->dw2_regnum[flag_code >> 1]; >>> + dwarf_reg = ireg->dw2_regnum[object_64bit]; >>> >>> if (dwarf_reg == Dw2Inval) >>> { >>> @@ -17461,7 +17461,7 @@ tc_x86_parse_to_dw2regnum (expressionS * >>> if ((addressT) exp->X_add_number < i386_regtab_size) >>> { >>> exp->X_add_number = i386_regtab[exp->X_add_number] >>> - .dw2_regnum[flag_code >> 1]; >>> + .dw2_regnum[object_64bit]; >>> if (exp->X_add_number != Dw2Inval) >>> exp->X_op = O_constant; >>> } >> >> On one hand, I see that the suggested code changes are making things >> semantically clearer, I would like to understand: >> >> 1. If there is a scenario where flag_code is CODE16_BIT / CODE32_BIT and >> object_64bit equal to 1 is supported. gcc passes --32 when using -m16 >> or -m32. > > Well, gcc may never produce such input, but hand-written assembly can. > Then, should we also use sp[object_64bit] instead of sp[flag_code >> 1] in tc_x86_frame_initial_instructions? Otherwise the assert "gas_assert (exp.X_op == O_constant)" will trigger, e.g. with .code16 and --64. >> 2. Irrespective of #1, shouldn't we then also use "if (object_64bit == >> 1)" instead of "if (flag_code == CODE_64BIT)" in md_begin where we set >> the value of x86_dwarf2_return_column etc ? > > Good point, let me make a v2. > > Jan