From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rjiejie@linux.alibaba.com>
Received: from out30-57.freemail.mail.aliyun.com
 (out30-57.freemail.mail.aliyun.com [115.124.30.57])
 by sourceware.org (Postfix) with ESMTPS id 7A2843856DDC
 for <binutils@sourceware.org>; Tue,  2 Aug 2022 07:23:52 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7A2843856DDC
X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R151e4; CH=green; DM=||false|;
 DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=ay29a033018045168;
 MF=rjiejie@linux.alibaba.com; NM=1; PH=DS; RN=2; SR=0;
 TI=SMTPD_---0VLAZ44U_1659425028; 
Received: from 30.225.81.35(mailfrom:rjiejie@linux.alibaba.com
 fp:SMTPD_---0VLAZ44U_1659425028) by smtp.aliyun-inc.com;
 Tue, 02 Aug 2022 15:23:49 +0800
Message-ID: <d3a39e44-e9af-452e-8984-1a1eda7b825e@linux.alibaba.com>
Date: Tue, 2 Aug 2022 15:23:48 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.1.0
Subject: Re: [PATCH] Support multiple .eh_frame sections
To: Nick Clifton <nickc@redhat.com>, binutils@sourceware.org
References: <20220729074837.82957-1-rjiejie@linux.alibaba.com>
 <56cde846-f34f-72dc-7641-4bba6f544b06@redhat.com>
From: Jojo R <rjiejie@linux.alibaba.com>
In-Reply-To: <56cde846-f34f-72dc-7641-4bba6f544b06@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, BODY_8BITS,
 ENV_AND_HDR_SPF_MATCH, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP, UNPARSEABLE_RELAY,
 USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: binutils@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Binutils mailing list <binutils.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>,
 <mailto:binutils-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>,
 <mailto:binutils-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Aug 2022 07:23:54 -0000


在 2022/8/1 下午7:10, Nick Clifton 写道:
> Hi Jojo,
>
>>     This patch is based on MULTIPLE_FRAME_SECTIONS and 
>> EH_FRAME_LINKONCE, >     it allows backend to enable this feature and 
>> use '--gc-sections' simply.
> This patch looks good to me.  But there are two issues, one small, one 
> major:
>
> * The small issue is that you need to add an entry to the 
> gas/doc/internals.texi
> describing the new TARGET_MULTIPLE_EH_FRAME_SECTIONS macro.  (I know 
> that the
> name is basically self-describing, but it is nice to keep the 
> documentation
> accurate).
>
> * The bigger issue is that I could not find a FSF copyright assignment 
> under
> your name, or for Alibaba.  We would need such an assignment before we 
> could
> accept your patch.  (Note - I did find an assignment for Alibaba 
> contributions
> to gcc, so I would assume that obtaining a similar assignment for the 
> binutils
> should not be too difficult).
>
> Cheers
>   Nick

Hi Nick,

     Thanks for your review :)

     i will update documentation and check the FSF copyright assignment.