From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50043.outbound.protection.outlook.com [40.107.5.43]) by sourceware.org (Postfix) with ESMTPS id CD48F3858D28 for ; Thu, 29 Sep 2022 08:08:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CD48F3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BV/SQee2RULGbL5a+MnueqQFrBIBRZlcOFtm6v07oShTIY/Oyx8piCKsrQvvm9hbh/ShUcFsIDD0poQQThpJHUxsZ/djMNCSIUOS5jxf/KdB9o6xiHfIpLs2du+WFux2c2JPNfFvC+1tJOXnqTL6WbGEKf7t/IgjtgeeAdn9DMncsHBN3fYlHEmqPRSZ2+7slGIBQiVQNLgiyvGx8/cZB4L+2FTKyvwx+tH4A0n6J2MZEh/4R5I9R5sJxywhEo5h4BIK1n7MutwvThJi70Slu4Y68rs62UEiZ13CE/NvLUOFKrHIEn8yZKPkrPoUAfizHpG7QNllh0DLFtYjjF0BvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Go8UjZOB/OFR56BZaI4s9rr3cjhKSnr93qkhyh2h1zs=; b=NjupuAhf1CVincM1iN/KiAqt73GddgB1OHR0ljNYwFpbvldRzCl4D2ToPYEezuxd/vRcv0d6Ltjv8Fo40ewG6pJj0fL8dppYU4YAon/7SOfvBTyRp7ITDi3/8kvOkYjrKfDPOZvZGil5q6ApHw+aB/pMouQ6oKU+e4rkeGw3pFTsFAVyFOeivCkz+suK0XYqcO5Z9xNrJnsQTdBYS0PgYzubMw2qtOU/xwJP+qBglml1LcIWk8FiTe9xlWypKa7MS7gW/mja7PFXLB96S/oOlnl+xHnnvTkI+g45xU4XVkfsQo6+NyKMa7ofFFEQe6yZq1ZZzDvLkkHS+Nwrs6nOuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Go8UjZOB/OFR56BZaI4s9rr3cjhKSnr93qkhyh2h1zs=; b=T7GDk3MUuzzFRzovM7S/safz8J/j7sDs1wnpx0o9aHZHbz3NWXd0EiyRjti/bukYzL6DhRMBO5dRlkubhN10PG2BM8+vkobKklM9NcxWc3GhZPfZkG++xVEO2Lf1zqNkZMLIyd31ShprsdCYWGDog7IZ90kmJ1K3sht+B5IBgiFKkm0oOjSWqSCCUzEWTGE/SZQDVPCtP3GVmJWpQHSuS95lnpRpvM+uZtMhSpNF01yCiZ9C3UpRI8JsaLZz9rviAJuVsPMIdIKAD4T1I50jsgYcmOZ5SF7PVrauOYSLYgy6GWzpaTBHkNCkM5hiTEExK/v6XCWkjQfb6sTiwXOYJA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8793.eurprd04.prod.outlook.com (2603:10a6:20b:408::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20; Thu, 29 Sep 2022 08:08:44 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 08:08:44 +0000 Message-ID: Date: Thu, 29 Sep 2022 10:08:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 5/7] x86: re-work insn/suffix recognition Content-Language: en-US To: "H.J. Lu" Cc: Binutils References: <32216291-fd1f-4579-87de-d24cb7190894@suse.com> <995353db-27f3-ea60-8e69-32bcc44dfd49@suse.com> <162c053b-7c68-67b8-1443-926f2ebb321d@suse.com> <892afda8-0e6a-cc7c-df95-f5581e831fff@suse.com> <93622263-1a05-07e7-4a96-c33cffb0796b@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0391.eurprd06.prod.outlook.com (2603:10a6:20b:461::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8793:EE_ X-MS-Office365-Filtering-Correlation-Id: c6b8d39d-e38e-42e8-d27c-08daa1f1d422 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kzgYToC2pVWZG5Z84qzwNPFrlYFotdS94S38xqnAeOXPvM0Huaw8s2fbS7ffPiy7fB9SgBuenDjtIZLwKwUlCNRxKvfWqoZANcWcNMhITM3h4pucG8P2LC4vOQhLZvufiF76Gw4oZLOMF7TiP3r/Jd5X+PLB+pFaP1c5HQPqMnz0KNP3HEHbWSijpzaT85rbNWm9I/OU66FVw29IO8RjAbGCFgPpgHDyT9etgOhNYbyMwJjcu0+NVqOQlrg444YD21GxvS5zyXBa4Q9ps9BBMX937Slq/GPXtF23dec3ePUM+zgHdPnwZ3avXpcXn87eCaDP4ivkGykDs5oHpseWLQpae6U0AkYLe2xKo7Mtkgs1NDz5QsarrfOlV5aCIbufiprsclDxJeq6RWruc0BuFhHgih8lwEyeRMGYVuqCAFldU7a5HxX47ebAxNJdfAU0WCj4XWDIHBzr1bCgR2dJNcrGiptFwONoaG5WlD7PTRzUplstyJTX343WhgFZeo+y4H6K59RRHPTDRwJofUBmUPS5VCjZuUkDvHy4OlZ8aS2IAXgB4DDyGGA+M0+1SspgxX0TfhlHj3ewUToxp8cNGWji06LLJsn71NZYGmVTJ+R/S/TexZaCvw0K0f8yhrEzN+e/sx0CXlq4MGa86UpznauQb99XhZL3Zf7WQVmK2Hpchi83zckq79nq6hgzuG1TPmvNVAhHNpgk+vtM1dicJXRVmRFWaMf+wQD1O56zT7iJyMJRVKNo12lnrZoortKMIbHvqWsKKXbAVyCCPgL+FyDhez/dxdeWoibVwYNwyNQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(136003)(376002)(346002)(366004)(451199015)(31686004)(186003)(6486002)(478600001)(53546011)(316002)(6916009)(8936002)(6506007)(38100700002)(66476007)(36756003)(6512007)(66946007)(4326008)(8676002)(66556008)(41300700001)(26005)(5660300002)(2616005)(4744005)(83380400001)(2906002)(86362001)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VmVyU21aY2svbjNKaU0vV01iSUd3VTMyeFdEenVGcHdDZ3RrZ1lhdHpMSlRs?= =?utf-8?B?MmVmOWxHcFR2eUVOZDN2MkRtcVBOTE1ac2RzcW5RVDY4YUFRNldkQm9NQXkx?= =?utf-8?B?Z051MjhNWGkvVk55cDJBbGxkN1lPb2J4ek11Zkltem5NVktHdlhqRktQbTRF?= =?utf-8?B?aFdpdmFjQjc5WHpLbzQ3RnpNdHhxUFIwZFZXUEwyWFNGSkRxeHAzaDJVWDNs?= =?utf-8?B?QjllYmh3U2RqRGZ6US9wMW53RiswYzZYdHRabWdPK1Z1MnA5cnh6bzR3a2hO?= =?utf-8?B?Y1RSREZodXBHMGwwRWF0SFNCakU1U2w5UlliY3lqOU9EYWxuQnlWTThZVytl?= =?utf-8?B?RzZQcXBZUm5RTUVhOGxWNmNZRkNiaTRqMUVQN3pMejJFdWhENjNFQUJ6MzJw?= =?utf-8?B?U1h4RkI2eU94am5wMDR0R092V2ZDeGcrZzJJRStKR0UySU5qek5Jd2Rvemhi?= =?utf-8?B?ckU2bXRCMTJ4QjdndzhhSER1ci9ldTdmMGNLbWJXZGFCUFMvSEQrQ2FBb0gx?= =?utf-8?B?OW9FZ3RUNm5GWllrOWVkU2Rsd3h6RkZSVC95NUV1RzUrQ1N2ZnkxR3QwdURE?= =?utf-8?B?OXZTSmsrR0x5c2c5M0h5SkRaU1JkK0NIZktCV2FOZFc0RTZFRXJEeTdnbXBS?= =?utf-8?B?V2xZamp6b2tMTitQUHEvc1pqdnNneWIybHJhdzdHNTBlaGJzMGVVNm4vY0lk?= =?utf-8?B?Wlk4WVhnTDVSaTdkU1pyd3UrM3lBaUQ4ZEhLV3M2aitEZldIbTl2b1BlMDNK?= =?utf-8?B?dzcvZTBHaEVSWGQvbHdMMStOeDhENTgwZ3pWekxOc2cwMk9sQ3Fzc0VQbDJS?= =?utf-8?B?V3lSSkdmS2plTDlyQnV4WEliakh5NTdWdlR1K1VqQXI4cU1WTmpOT3JwQVo5?= =?utf-8?B?NmRIZnhkTDF3a3U1MDVGWnVRaWRlQmlJb2xuZkJSeEV5TnJJQ3RkeGwwK016?= =?utf-8?B?NjJxbmVTZzQ3bTdWYWl1SEt3Sm1MSmRBV2xUWWViKzdhWG5RRmhRRUdDUDkz?= =?utf-8?B?QUNsYkFWYS9zcUJpdG1yeWZ4VjEyRWFVdkNXNzdFTkRBdFJWWUgybEM2YTR0?= =?utf-8?B?YTVoQWt6UWNBS05PT3lSRXc5NEQ0S1FpWmw3WlZWZVpjbS9ucTlSOGE3dHov?= =?utf-8?B?UFl5eHFydThSOXJxNTNnenkwTFNvZWVWSmYzUk1OQXczcm1LTkVZMVZJUFZy?= =?utf-8?B?OTV4dDYweHp4bkJ5a0NsdTVkRlJTbjh6a3JsQTY4cThwbU4xQXQ2RkZNVVlX?= =?utf-8?B?SC85ZlBHQXlFTG9nS3ArTU82aUhENitKOU1kUnpveWRFc1hIdUxueFpyNXZ3?= =?utf-8?B?UjBNOWlLb2djL1FRbXJObWF6VkxxbnIvcW9GZUxLejRZVStyK2ZwcldudVRF?= =?utf-8?B?MkpITEVFNUIwUTVSYnNCRGgzM0lJdjVNWGxxSFJ1Ym1qQnlrMHdJcHFWQyto?= =?utf-8?B?dkgwQ0d0VXU2RmZGQmxLeGtvVUZCOFhJaFRRQWpvK3ByVVkyQjZXUlFLMytR?= =?utf-8?B?NmhGT01wUTRxOVJjVlVjS2RkSU9jSTQ2aDlGWW1RaGJhNjF2Z2xQMXBNZ0VH?= =?utf-8?B?VEpIRjgyTjZzUmlwQ0R6WGg3U3VnWHlYbEVKUURQMTdCd2FlLzlicHlOTzZy?= =?utf-8?B?MnNDaDd1SFY0cDFJNVQySFFLUnMvSVNLcDlOZGM3RU4xa3M2bm54MktUNjly?= =?utf-8?B?bHpxOEJTR0VvT0NHRDlOTGNWRlc2cUtJTTlyd1hmZnpva3RZL2Y5ejMvd0pq?= =?utf-8?B?RjZsckt6SVo1ZkJmTlpQQ3o0Ykx4MVpYL3hYYmZsM0ZBK0J3VGtlVzRWWGly?= =?utf-8?B?RXRaSXJLRXl3ODEvRUd0SS9zTjBKSVhYbWwrQlVNOFNYa0NOZTZEcUlPL3Vy?= =?utf-8?B?WmV6NTBkcWJBV2ppWWlHNkFCUVRQcXN6Zmw0c251WThrOWlVMUNGcWVYQnFj?= =?utf-8?B?K1N2NXR1Uiszc1JMc2c0QlcvL1VQdENXRjYrRjdzeWkveURodGppenRtUDFZ?= =?utf-8?B?U1NBZWxZdEVnYWJQYjdka1gzSkV0MmZuaFdFYkswckZ2Q0ZHcHM3TnRLd2RW?= =?utf-8?B?cU56QXN3OGIzS3czbHRDOGlxcnFscDNrSlp0RXFoTVNlWGtMaVJtNGM3OU9s?= =?utf-8?Q?c3Uah5SsRLEeaBmov5nSDr8Vz?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6b8d39d-e38e-42e8-d27c-08daa1f1d422 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 08:08:44.5838 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CcvE5f+HntTXwgrwRDOAHgn7zkaKrZzIBb3b7LAVEWOrsm3fDajSrcskz6Em2AsNpyfw0MWtX2Hz/5vUhipq1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8793 X-Spam-Status: No, score=-3032.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 28.09.2022 21:33, H.J. Lu wrote: > On Wed, Sep 28, 2022 at 5:49 AM Jan Beulich wrote: >> I guess to prove (and going forward guarantee) the apparent behavior of >> parse_insn() I'd like to constify its first parameter. This might >> involve adding a cast (to drop const-ness again after the call), which >> I generally would like to avoid, or some "interesting" pointer >> arithmetic. If you have any opinion here up front, please let me know. > > Can we avoid it by adding some new entries to the opcode table? > I don't think we need many such entries. I'm afraid I don't see the connection between the intended constification and what entries there are (or not) in the opcode table. I view it as a desirable property of the function in the first place to express its behavior (of not altering the input string) by a pointer-to-const parameter. In fact I guess I would make such an adjustment a standalone (prereq for the larger change) patch. Jan