From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by sourceware.org (Postfix) with ESMTPS id 5AEDA3858D35 for ; Fri, 17 Dec 2021 07:24:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5AEDA3858D35 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2050.outbound.protection.outlook.com [104.47.13.50]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-16-UIwXz4egMC6RPPLOwncxbA-1; Fri, 17 Dec 2021 08:24:33 +0100 X-MC-Unique: UIwXz4egMC6RPPLOwncxbA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a7YCYmegZ63e0EeFM03ypm0mggdJewxANnNLBgAoiPMvajECwAIxMlyIW7A+i+8KmBpAppW/NSjqSOK2i5tibVD10uIYHeY0caOhu+Qd3o+xktc9cMF74CDH9opN6SGg1MEadV9eLp5Wp/ynA43nE7zA5zgglBV1iXjZ2ba46kLYMV5YV3HGq4J2Bf1kVV8S1HGVsKDQ1epKKhz/Zrzbs30LTcPGYV0OqeEHj2aUMsZ7PXcVjdA/ix1T5h9Np08WnU47iEc0oSDN0+HzOThCl5E6vRRvGaBaLUnW34GfjssE7LhDiWjs77zCyFsrLkj8AxkCJsVneTuACPyD925TJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E0eZIo02S/Tl3MMM9EY9kPPI2Q9daKSVxQGPQZijsh0=; b=FwRpQcoBZTtOq5Yv5a0QYKyR8PUGHdru6VokHccgwo30rasrT5vGN6c7cp19SaNXCJqnKOQoJAWYGBJBYECD5AYkMPchDjOWKXeJf4kexSeSl596eT+CJKmMY7sfK5Lo5PXT+Ui2HzF6AFaV1mY2A5Ukaeh/NkYRNpDtycdZE2pv+CCWCgVZNfArsp5smD4jP7NfFQVhyHfeXBZwKh+35ESgfZxCIndsosfsHEU7lWWRcR05781PHFwLIrxlc8e1Iipjz/B7Wj+FKJ4X8ljBkWnTp99slg/hUvZDoqHMrUJUM0vTX3v+BPhVQNy8miZWd/7JHzdUrOylZjlHjaEUFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0402MB2702.eurprd04.prod.outlook.com (2603:10a6:800:b4::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Fri, 17 Dec 2021 07:24:30 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4801.016; Fri, 17 Dec 2021 07:24:30 +0000 Message-ID: Date: Fri, 17 Dec 2021 08:24:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH] opcodes/i386-dis.c is not thread-safe Content-Language: en-US To: vladimir.mezentsev@oracle.com References: <20211216222648.1014432-1-vladimir.mezentsev@oracle.com> Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: <20211216222648.1014432-1-vladimir.mezentsev@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR0202CA0054.eurprd02.prod.outlook.com (2603:10a6:20b:3a::31) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 33bbff8a-cecf-4c77-8770-08d9c12e443f X-MS-TrafficTypeDiagnostic: VI1PR0402MB2702:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zzMd+Bo/Kr6Bln+gu3voNpwBLTjsFOwvwPiwmo1qyi/CQNoWZh0shHWYVkDDXBr+K7z5qzYlmHIPApUAfDZ5+PFfioGVjPMRkvuenldvHUF2+S87JywYHk1hXOR3iWWUBhv5C1gxfiKOdVfS5yNmQzseuSdKMILFM+Kx7SRRPdIvvsBpHMePaZmW9xO/bGgoxFyF4LqMmxM5no8/sKNhgGrLPnr4M+3suBsTMEmSliCVBEjZKH2L24acu8TrojXWLVdQwTVB4qATd55CyS+2B3qYwZn6XoDPJhmuTz8HnwsV58k9ROq0nR4uA2kxkFGEZBoFOilzbHZo2RNq4iDGKOedjHmjM/Q7/IFE3+0dC3RkWgLSGEgH7oyTwm/JJAbhu51FAOboxyZaS9V7W4+urwP+0am1a2nsXDIXPpLYZ/lTc25euUILHdifZk09qKtYwfu+ujA0RxiApi4l1yXBsBx1EW9YPgnmO2qySJ7afHgLxoW1UHPNKptQXFAx86E9MFYH9Jg3t9VIFeJEd2DjgQrLd5MBEKaWLF/0659YPoKQOg++fu/qD+5/rZY+s+6YkSlsdMD/TqXDHehZ4CVeeRBL4SAC6Aqp9NS9WPE9dSmXNk1fHtJUtf8EZiaMn4BhoKn3bwY/nI9zmf2DhbDhCha/uAUi8vjnHTD+zlQMPFkIzUbv4nviGb1L9DoM/LB7WCa3ytWzbrTosATYfpcAQy6m0Otl0cbXzUBt7jPlZw8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5600.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(2906002)(4326008)(66476007)(66946007)(6506007)(8936002)(8676002)(6512007)(38100700002)(31686004)(66556008)(6486002)(316002)(4744005)(6916009)(26005)(5660300002)(508600001)(2616005)(86362001)(186003)(53546011)(36756003)(31696002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YXN5WUpRMzk1eEw3WkN5R1YvZ09heEVpRmhQNmYyekpGVExJQXYwR2FDaExy?= =?utf-8?B?TThpZXZ2SWFIb1ZwS2NYMW1MZkhrMFVTbG1qK3Q5YXZjd1dJSGZ4Qll5cFRo?= =?utf-8?B?U3ZQWjZjOUx2QldibDd6RDRFSE1VRHpqdDlqQnRudXJmeGRvZ3FYUEFOREpY?= =?utf-8?B?L2Zmc0dWTTV3V2NkZ3FhVmw3TWRZbndYZDZyTTJJeTJvc1hwK0xZMUxPdWZF?= =?utf-8?B?WVBYdnY0MklmMFVzQjM5ZEZkTFZkUTVSUWowQ2gxV2RlNlhaWENrR1lDbUh1?= =?utf-8?B?RkdETUdvNUdlL2hPbmp3am5rclNEaGJ0a1dZWU5FVU40VWV3OUpLbFhJN1c1?= =?utf-8?B?eXFuOElSRGp2MXdteDFFR0ExUFowcUFSS3J3RXBITjk0ZDNlNVo3RVRoeTZy?= =?utf-8?B?ZVlFYmRnajBrQlJ2d044Wk5EZ0ZkT1Azb2NCZ1pMaWFadWVGZDVpc092Mmpy?= =?utf-8?B?dFliak1CN09YMisxTGNNeWJ5S0lTT21SS1pHV09zSHdvTHhjR3NCZXNsRHdH?= =?utf-8?B?ekMwQ1RrMTE2Y1crdTlNTkhUalBVSWdlZU00UmF5elY4UVlMSGNqd0VsM2RD?= =?utf-8?B?eVpMa1d4QmsrTUhoZDlpb2x6SnREdlN5Qlh3cTRqaGJiZG03aEkrUGZiQU9J?= =?utf-8?B?WFpjMTlHVXlqdjdJMW95NHBacU5GSHAvV1hhQUxBRlZPWlQ4ZFRBNXBvS2Yr?= =?utf-8?B?eVQvWkxOODNxRER4c2ZYVkVvRXpnRFJ4ckpla3RuSXlSYXFpa0lIejB2NjY0?= =?utf-8?B?dk5xRDVQWDJpcVVOcWNDLysrdlIzZndKMzN4ZFFsSHpTb1d6MEU2QWdKVElo?= =?utf-8?B?cG0rNHRxb2NMMUhQT2J4ZFZTWER6aVI4OHVaTExvWDYrN1VqTUlvdm5jK1o2?= =?utf-8?B?NHE2NTVYUWhjZlltQUtBOS9WNUNhMmxPWUUzb1k4WFVIOG14WVJVRnJjQWZx?= =?utf-8?B?bFk4K1pkMXpHcDAyNWRQbXpBeG0yeDhOQ3orNTlSbngybDRjcGtia2ZlcmNn?= =?utf-8?B?TUZYVG5LbldZS216dWVOd3FOTjNFODhRTHJtby9JeWRZVFlmVVBOY2V5bFV5?= =?utf-8?B?RXZ6YlBGeWdTaVMzc2dzR2tVT1lwV3RxcEdwYTV3dzc1c0EwN3FONzRac285?= =?utf-8?B?OHZ5RHVhNGtFaDZGUi9yVGh3cjNCdXhiekMycFNVZXBYTkVIRWNXMERkaW9j?= =?utf-8?B?a3hoMTJrWUhwZlpDTFhqRFRvYWVTVEdWb2o5NmdKWnNJb2F6YUFFYmc3UG9F?= =?utf-8?B?QkNuV3M0ZllSSzZQUDh4Q1pEelFFM2VoTXBQcUZYOGxxUjZFUnBMaTdibzBR?= =?utf-8?B?dG4wY1dSeWdoS0Rva3ZSWnBNSFpZeXlDZnZVSUtZTGN2dzBXYkxqN0djRWZp?= =?utf-8?B?VEkxVWtBU1pqN3VSNHVPdklRNGVydlU2em9PUmlOa0U2eWlHaWN5WHppdGln?= =?utf-8?B?U1IvRTE5NGZhSUF3UHQ0S0NBRXROL3VZaTMycGJMZlFzbFpuWXB1TGdpaDU4?= =?utf-8?B?bTVNMENPZnRad1dnSm1pb0QwSHdYNzJGS0wySEVWRVBFV25ka0l3WEpvWkk3?= =?utf-8?B?UTJLVStHbTlzY2RIOGRMTmRFMTU4NU84dmpDSURIekd1ME5FbGFVeTEvMjNl?= =?utf-8?B?elFWbitaWk85Wm5jaG5YcFpoQUZDS1Ric0RhcTl0dVlGbnpZZUFpTDRaeG9a?= =?utf-8?B?QlVvNWNkQ3JLYzEzWDRvNFNUcWw4N2RTTnNua3lFMFlwMUFrN3Qvb3dLZDVS?= =?utf-8?B?dkJQRlZjYlJaM3VCcmVneHgybVQ1VUhZVTZiSTdobW5wYXN5Vm9tcWEwRXRr?= =?utf-8?B?R29rR0VYdU5VL0dWUGMxaWpmcVZUejc0dkhjRGxBZGxYTGFYZ2hmdEM2aU1K?= =?utf-8?B?V0Z0bDRYWWpBUklFODFPU21jU1REdThKaWgvNkNHRk1Xa1lRMzVXcTduaXQx?= =?utf-8?B?cVBtNHd3SkFaVWZhOXNwWUVyZFBhRkp0WHJnVWpqZFlrWjlSOHN3QTBONEFx?= =?utf-8?B?YXJOanlwSDJyd2I1V2FZVStHMWlWT200YUpGTU1tS0xDa1pkS2Nzbk5Genh0?= =?utf-8?B?TjkrWENtZ0N2S2U1WnpwdlF1QStOYk1yM0Rlc1E4VkxhM1BtSzBLRS9ydVZZ?= =?utf-8?B?Mzl0MzR4V0grMnRKM001K04wREJIK3Y2c2dUMHBZYUhBU0NCWFpBcEFYVGtN?= =?utf-8?Q?fUCtgE47U665jQVtteiRcLY=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33bbff8a-cecf-4c77-8770-08d9c12e443f X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2021 07:24:30.8835 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6GgbSOPidv+P8DxWF3mzzLcEpOigfdkq4hPp1PEcYP9rTOauhwBkvp/22llPdZGN8GaudQMGq2W554GpEwqXWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2702 X-Spam-Status: No, score=-3032.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Dec 2021 07:24:36 -0000 On 16.12.2021 23:26, Vladimir Mezentsev via Binutils wrote: > From: Vladimir Mezentsev > > We plan to use print_insn_i386_att, print_insn_i386_intel and > print_insn_i386 in a multithreaded application. > These functions are not thread safe due to the use of static variables. > > A disassembly output is changed due to fixes in swap_operand(). > The old swap_operand() did not cleanup mnemonicendp. > > Tested on x86_64-pc-linux-gnu. Looks plausible at the first glance, but it would be quite helpful if this was split up some. At the very least the fix to swap_operand() should be a separate prereq change, imo. Jan